rails_core_extensions 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 20b022eccf968998d9236870dd9255b5ca5eff46
-  data.tar.gz: a82a4adf1601c57035016df31d53d6a2fbc5e41e
+  metadata.gz: 66b12180b0871631d3aa748d769096169a861e1c
+  data.tar.gz: 35d1ef716439e10dd806131a99254cfd40f98765
 SHA512:
-  metadata.gz: 53bfc4fb4f56485453989c62428fb370748e6cda40bd082ce98e21a544518bc5354b70cc6b3294b59f897664e08b146e21bd6ce385a64880e10a3184649ad0bc
-  data.tar.gz: d1d3a4637dff550333f1eba6fb3ae7ca9d19bfa6aad31f8deb4344ab60a9e99ac519b139e356ee9e203f4aa9a2ec98a707774d4c6b1841780f74000574194c64
+  metadata.gz: ed049d5b08476af111e543f13771d91b96584b29732bfa8ea6376a1bfd4dd1a4e6c6b248a17c9d4761e37ca73fa053413d6c51d2d5174c8f59c27ace3b445720
+  data.tar.gz: b1ec8619fedbab171426d8fb4ec929cccd77bc6e1492a965da00b9905ac79b555cbc70522842a4a2c514300970043deab9e4e61db00d98fb21a8e8b652430a86

data/.gitignore

@@ -2,3 +2,5 @@ pkg
 coverage
 Gemfile.lock
 tmp
+vendor
+.bundle

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.3.0
+
+* Use coverage kit to enforce maximum coverage
+* [ROT-73] Always cache cacheable attributes
+* [RU-133] Replace alias_method_chain with alias_method
+
 ## 0.2.0
 
 * Extract and test translations

data/lib/rails_core_extensions/active_record_cache_all_attributes.rb

@@ -5,7 +5,7 @@ module ActiveRecordCacheAllAttributes
 
   module InstanceMethods
     def clear_attribute_cache
-      self.class.cache.delete("#{self.class.name}.attribute_cache") if self.class.should_cache?
+      self.class.cache.delete("#{self.class.name}.attribute_cache")
     end
   end
 
@@ -16,11 +16,7 @@ module ActiveRecordCacheAllAttributes
 
     def attribute_cache
       cache_key = "#{self.name}.attribute_cache"
-      if self.should_cache?
-        cache.read(cache_key) || self.generate_cache(cache_key)
-      else
-        self.generate_attributes_hash
-      end
+      cache.read(cache_key) || self.generate_cache(cache_key)
     end
 
     def generate_attributes_hash
@@ -35,9 +31,5 @@ module ActiveRecordCacheAllAttributes
       end
       cache_value
     end
-
-    def should_cache?
-      Rails.configuration.action_controller.perform_caching
-    end
   end
 end

data/lib/rails_core_extensions/concurrency.rb

@@ -46,8 +46,8 @@ module Concurrency
           end
           return_value
         end
-
-        alias_method_chain :#{method}, :concurrency_lock
+        alias_method :#{method}_without_concurrency_lock, :#{method}
+        alias_method :#{method}, :#{method}_with_concurrency_lock
       DEFINITION
       
       if method_type(method, options[:type]) == 'class'

data/lib/rails_core_extensions/version.rb

@@ -1,3 +1,3 @@
 module RailsCoreExtensions
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/rails_core_extensions.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'activerecord-nulldb-adapter'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'coverage-kit'
   spec.add_development_dependency 'simplecov-rcov'
   spec.add_development_dependency 'coveralls'
   spec.add_development_dependency 'sqlite3'

data/spec/support/coverage_loader.rb

@@ -1,27 +1,4 @@
-MINIMUM_COVERAGE = 81.1
-
-unless ENV['COVERAGE'] == 'off'
-  require 'simplecov'
-  require 'simplecov-rcov'
-  require 'coveralls'
-  Coveralls.wear!
-
-  SimpleCov.formatters = [
-    SimpleCov::Formatter::RcovFormatter,
-    Coveralls::SimpleCov::Formatter
-  ]
-  SimpleCov.start do
-    add_filter '/vendor/'
-    add_filter '/spec/'
-    add_group 'lib', 'lib'
-  end
-  SimpleCov.at_exit do
-    SimpleCov.result.format!
-    percent = SimpleCov.result.covered_percent
-    puts "Coverage is #{"%.2f" % percent}%"
-    unless percent >= MINIMUM_COVERAGE
-      puts "Coverage must be above #{MINIMUM_COVERAGE}%"
-      Kernel.exit(1)
-    end
-  end
-end
+require 'simplecov-rcov'
+require 'coveralls'
+require 'coverage/kit'
+Coverage::Kit.setup(minimum_coverage: 81)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_core_extensions
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Michael Noack
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-30 00:00:00.000000000 Z
+date: 2017-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -96,7 +96,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: coverage-kit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -272,7 +272,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Set of extensions to core rails libraries.