rails_conditional_params 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0147ea4dea489f5b3a34ca1dba8b955a1058d2ff
-  data.tar.gz: 06d56463e9de9be6b50ed8ac72dec291a01a4d0d
+  metadata.gz: cceaa82567b2886771f063721752211d3742b645
+  data.tar.gz: e3d518c542b164db67efed96a65673a5afca73a4
 SHA512:
-  metadata.gz: 242e25d5664b5002f3e1af4569be93e43851f6c1a9472a39bce4794d1aa5e47d2ac7b43beeef162a72761fcd87d447eaf3a588334100da05bad62fc7f9450195
-  data.tar.gz: 2478d1b6affaf4e801fbe77fea341b745597fd4e5ed8ef48d5d5cbd55e7cee23e587ac2b6794ee7d5fad66648f1567eeede61ce4931681b373d90c806221d8fd
+  metadata.gz: d376c355f226bdf3f6010f5c926193aa02485bf2258c0c9fb285c85343d31e32be3bc5d75aafc6754504aad33452687ca6aa5c9167bb69ab6b8fa8183247cf4a
+  data.tar.gz: ab6dae2701787461acf7cedc6b5236feaf176fade0cb0545d2a6b07bbe5d5a0bb772243d1efbfc9b89d351c54a0b4cfeb3e7070430b24ac8741f2f707070e8aa

data/lib/rails_conditional_params.rb

@@ -1,10 +1,15 @@
 require 'action_controller'
 
 require "rails_conditional_params/version"
-require "rails_conditional_params/patch"
+require "rails_conditional_params/alias_patch"
+require "rails_conditional_params/prepend_patch"
 
 module RailsConditionalParams
-  ActionController::Parameters.include Patch
+  if ActionController::Parameters.respond_to? :prepend
+    ActionController::Parameters.prepend PrependPatch
+  else
+    ActionController::Parameters.include AliasPatch
+  end
   
   def RailsConditionalParams.restructure_filters!(filters)
     filters.each do |filter|

data/lib/rails_conditional_params/{patch.rb → alias_patch.rb}

@@ -1,5 +1,5 @@
 module RailsConditionalParams
-  module Patch
+  module AliasPatch
     # Adds support for conditional params:
     # 
     #     params.permit(yes: true, no: false)
@@ -15,7 +15,7 @@ module RailsConditionalParams
       permit_without_conditional_params(*filters)
     end
   
-    def Patch.included(other)
+    def AliasPatch.included(other)
       other.alias_method_chain :permit, :conditional_params
     end
   end

data/lib/rails_conditional_params/prepend_patch.rb

@@ -0,0 +1,18 @@
+module RailsConditionalParams
+  module PrependPatch
+    # Adds support for conditional params:
+    # 
+    #     params.permit(yes: true, no: false)
+    #     # => { "yes" => "..." }
+    # 
+    # This is useful for parameters that should be permitted in some cases, 
+    # but not others:
+    # 
+    #     params.permit(:title, :body, published: admin?)
+    #     # Result only includes published if admin? is true.
+    def permit(*filters)
+      RailsConditionalParams.restructure_filters! filters
+      super(*filters)
+    end
+  end
+end

data/lib/rails_conditional_params/version.rb

@@ -1,3 +1,3 @@
 module RailsConditionalParams
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/params_spec.rb

@@ -17,4 +17,15 @@ describe ActionController::Parameters do
   it "should exclude conditionals when conditionals are false" do
     expect(@params.permit(:allowed, maybe: false).to_h).to eq("allowed" => "allowed")
   end
+  
+  it "should not carry over allowed-ness between separate calls" do
+    def filtered(maybe: false)
+      @params.permit(:allowed, maybe: maybe).to_h
+    end
+    
+    expect(filtered(maybe: false).to_h).to eq("allowed" => "allowed")
+    expect(filtered(maybe: true).to_h).to eq("allowed" => "allowed", "maybe" => "maybe")
+    expect(filtered(maybe: false).to_h).to eq("allowed" => "allowed")
+    expect(filtered(maybe: true).to_h).to eq("allowed" => "allowed", "maybe" => "maybe")
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_conditional_params
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Brent Royal-Gordon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-03 00:00:00.000000000 Z
+date: 2017-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -93,7 +93,8 @@ files:
 - README.md
 - Rakefile
 - lib/rails_conditional_params.rb
-- lib/rails_conditional_params/patch.rb
+- lib/rails_conditional_params/alias_patch.rb
+- lib/rails_conditional_params/prepend_patch.rb
 - lib/rails_conditional_params/version.rb
 - rails_conditional_params.gemspec
 - spec/params_spec.rb