rails_best_practices 1.9.1 → 1.10.0

data/spec/rails_best_practices/reviews/keep_finders_on_their_own_model_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe KeepFindersOnTheirOwnModelReview do
-      let(:runner) { Core::Runner.new(:reviews => KeepFindersOnTheirOwnModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: KeepFindersOnTheirOwnModelReview.new) }
 
       it "should keep finders on thier own model" do
         content = <<-EOF
@@ -11,8 +11,8 @@ module RailsBestPractices
           has_many :comments
 
           def find_valid_comments
-            self.comment.find(:all, :conditions => { :is_spam => false },
-                                    :limit => 10)
+            self.comment.find(:all, conditions: { is_spam: false },
+                                    limit: 10)
           end
         end
         EOF
@@ -27,8 +27,8 @@ module RailsBestPractices
           has_many :comments
 
           def find_valid_comments
-            self.comment.all(:conditions => { :is_spam => false },
-                             :limit => 10)
+            self.comment.all(conditions: { is_spam: false },
+                             limit: 10)
           end
         end
         EOF
@@ -43,8 +43,8 @@ module RailsBestPractices
           has_many :comments
 
           def find_valid_comments
-            self.find(:all, :conditions => { :is_spam => false },
-                                    :limit => 10)
+            self.find(:all, conditions: { is_spam: false },
+                                    limit: 10)
           end
         end
         EOF
@@ -58,8 +58,8 @@ module RailsBestPractices
           has_many :comments
 
           def find_valid_comments
-            Post.find(:all, :conditions => { :is_spam => false },
-                                    :limit => 10)
+            Post.find(:all, conditions: { is_spam: false },
+                                    limit: 10)
           end
         end
         EOF

data/spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe LawOfDemeterReview do
-      let(:runner) { Core::Runner.new(:prepares => [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], :reviews => LawOfDemeterReview.new) }
+      let(:runner) { Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], reviews: LawOfDemeterReview.new) }
 
       describe "belongs_to" do
         before(:each) do
@@ -15,7 +15,7 @@ module RailsBestPractices
           runner.prepare('app/models/invoice.rb', content)
 
           content = <<-EOF
-          ActiveRecord::Schema.define(:version => 20110216150853) do
+          ActiveRecord::Schema.define(version: 20110216150853) do
             create_table "users", force => true do |t|
               t.string :name
               t.string :address
@@ -80,7 +80,7 @@ module RailsBestPractices
           runner.prepare('app/models/invoice.rb', content)
 
           content = <<-EOF
-          ActiveRecord::Schema.define(:version => 20110216150853) do
+          ActiveRecord::Schema.define(version: 20110216150853) do
             create_table "prices", force => true do |t|
               t.string :currency
               t.integer :number
@@ -105,7 +105,7 @@ module RailsBestPractices
         before :each do
           content = <<-EOF
           class Comment < ActiveRecord::Base
-            belongs_to :commentable, :polymorphic => true
+            belongs_to :commentable, polymorphic: true
           end
           EOF
           runner.prepare('app/models/comment.rb', content)
@@ -118,7 +118,7 @@ module RailsBestPractices
           runner.prepare('app/models/comment.rb', content)
 
           content = <<-EOF
-          ActiveRecord::Schema.define(:version => 20110216150853) do
+          ActiveRecord::Schema.define(version: 20110216150853) do
             create_table "posts", force => true do |t|
               t.string :title
             end
@@ -140,13 +140,13 @@ module RailsBestPractices
       it "should no law of demeter with method call" do
         content = <<-EOF
         class Question < ActiveRecord::Base
-          has_many :answers, :dependent => :destroy
+          has_many :answers, dependent: :destroy
         end
         EOF
         runner.prepare('app/models/question.rb', content)
         content = <<-EOF
         class Answer < ActiveRecord::Base
-          belongs_to :question, :counter_cache => true, :touch => true
+          belongs_to :question, counter_cache: true, touch: true
         end
         EOF
         runner.prepare('app/models/answer.rb', content)

data/spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoControllerReview do
-      let(:runner) { Core::Runner.new(:reviews => MoveCodeIntoControllerReview.new) }
+      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoControllerReview.new) }
 
       it "should move code into controller for method call" do
         content = <<-EOF

data/spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoHelperReview do
-      let(:runner) { Core::Runner.new(:reviews => MoveCodeIntoHelperReview.new('array_count' => 2)) }
+      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoHelperReview.new('array_count' => 2)) }
 
       it "should move code into helper" do
         content = <<-EOF

data/spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoModelReview do
-      let(:runner) { Core::Runner.new(:reviews => MoveCodeIntoModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoModelReview.new) }
 
       it "should move code into model" do
         content =<<-EOF

data/spec/rails_best_practices/reviews/move_finder_to_named_scope_review_spec.rb

@@ -3,26 +3,26 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveFinderToNamedScopeReview do
-      let(:runner) { Core::Runner.new(:reviews => MoveFinderToNamedScopeReview.new) }
+      let(:runner) { Core::Runner.new(reviews: MoveFinderToNamedScopeReview.new) }
 
       it "should move finder to named_scope" do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
-            @public_posts = Post.find(:all, :conditions => { :state => 'public' },
-                                            :limit => 10,
-                                            :order => 'created_at desc')
+            @public_posts = Post.find(:all, conditions: { state: 'public' },
+                                            limit: 10,
+                                            order: 'created_at desc')
 
-            @draft_posts  = Post.find(:all, :conditions => { :state => 'draft' },
-                                            :limit => 10,
-                                            :order => 'created_at desc')
+            @draft_posts  = Post.find(:all, conditions: { state: 'draft' },
+                                            limit: 10,
+                                            order: 'created_at desc')
           end
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         runner.should have(2).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:4 - move finder to named_scope"
-        runner.errors[1].to_s.should == "app/controllers/posts_controller.rb:8 - move finder to named_scope"
+        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - move finder to named_scope"
+        runner.errors[1].to_s.should == "app/controllers/posts_controller.rb:7 - move finder to named_scope"
       end
 
       it "should not move simple finder" do
@@ -59,13 +59,13 @@ module RailsBestPractices
         content = <<-EOF
         class Post < ActiveRecord::Base
           def published
-            Post.find(:all, :conditions => { :state => 'public' },
-                            :limit => 10, :order => 'created_at desc')
+            Post.find(:all, conditions: { state: 'public' },
+                            limit: 10, order: 'created_at desc')
           end
 
           def published
-            Post.find(:all, :conditions => { :state => 'draft' },
-                            :limit => 10, :order => 'created_at desc')
+            Post.find(:all, conditions: { state: 'draft' },
+                            limit: 10, order: 'created_at desc')
           end
         end
         EOF

data/spec/rails_best_practices/reviews/move_model_logic_into_model_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveModelLogicIntoModelReview do
-      let(:runner) { Core::Runner.new(:reviews => MoveModelLogicIntoModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: MoveModelLogicIntoModelReview.new) }
 
       it "should move model logic into model" do
         content = <<-EOF
@@ -24,7 +24,7 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - move model logic into model (@post use_count > 4)"
+        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)"
       end
 
       it "should not move model logic into model with simple model calling" do

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NeedlessDeepNestingReview do
-      let(:runner) { Core::Runner.new(:reviews => NeedlessDeepNestingReview.new) }
+      let(:runner) { Core::Runner.new(reviews: NeedlessDeepNestingReview.new) }
 
       describe "rails2" do
         it "should needless deep nesting" do
@@ -21,7 +21,7 @@ module RailsBestPractices
 
         it "should not needless deep nesting for shallow" do
           content = <<-EOF
-          map.resources :posts, :shallow => true do |post|
+          map.resources :posts, shallow: true do |post|
             post.resources :comments do |comment|
               comment.resources :favorites
             end
@@ -100,7 +100,7 @@ module RailsBestPractices
 
         it "should not needless deep nesting for shallow" do
           content = <<-EOF
-          resources :posts, :shallow => true do
+          resources :posts, shallow: true do
             resources :comments do
               resources :favorites
             end

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -3,13 +3,13 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NotUseDefaultRouteReview do
-      let(:runner) { Core::Runner.new(:reviews => NotUseDefaultRouteReview.new) }
+      let(:runner) { Core::Runner.new(reviews: NotUseDefaultRouteReview.new) }
 
       describe "rails2" do
         it "should not use default route" do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, :member => { :push => :post }
+            map.resources :posts, member: { push: :post }
 
             map.connect ':controller/:action/:id'
             map.connect ':controller/:action/:id.:format'
@@ -24,7 +24,7 @@ module RailsBestPractices
         it "should no not use default route" do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, :member => { :push => :post }
+            map.resources :posts, member: { push: :post }
           end
           EOF
           runner.review('config/routes.rb', content)

data/spec/rails_best_practices/reviews/not_use_times_ago_in_words_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NotUseTimeAgoInWordsReview do
-      let(:runner) { Core::Runner.new(:reviews => NotUseTimeAgoInWordsReview.new) }
+      let(:runner) { Core::Runner.new(reviews: NotUseTimeAgoInWordsReview.new) }
 
       describe "time_ago_in_words" do
         it "should not use in views" do

data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb

@@ -3,16 +3,16 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe OveruseRouteCustomizationsReview do
-      let(:runner) { Core::Runner.new(:reviews => OveruseRouteCustomizationsReview.new) }
+      let(:runner) { Core::Runner.new(reviews: OveruseRouteCustomizationsReview.new) }
 
       describe "rails2" do
         it "should overuse route customizations" do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, :member => { :comments => :get,
-                                               :create_comment => :post,
-                                               :update_comment => :update,
-                                               :delete_comment => :delete }
+            map.resources :posts, member: { comments: :get,
+                                               create_comment: :post,
+                                               update_comment: :update,
+                                               delete_comment: :delete }
           end
           EOF
           runner.review('config/routes.rb', content)
@@ -23,10 +23,10 @@ module RailsBestPractices
         it "should overuse route customizations with member" do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, :member => { :create_comment => :post,
-                                               :update_comment => :update,
-                                               :delete_comment => :delete,
-                                               :disable_comment => :post }
+            map.resources :posts, member: { create_comment: :post,
+                                               update_comment: :update,
+                                               delete_comment: :delete,
+                                               disable_comment: :post }
           end
           EOF
           runner.review('config/routes.rb', content)
@@ -37,10 +37,10 @@ module RailsBestPractices
         it "should overuse route customizations with collection" do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, :collection => { :list_comments => :get,
-                                                   :update_comments => :get,
-                                                   :delete_comments => :get,
-                                                   :disable_comments  => :get }
+            map.resources :posts, collection: { list_comments: :get,
+                                                   update_comments: :get,
+                                                   delete_comments: :get,
+                                                   disable_comments: :get }
           end
           EOF
           runner.review('config/routes.rb', content)
@@ -52,10 +52,10 @@ module RailsBestPractices
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resources :categories do |category|
-              category.resources :posts, :member => { :create_comment => :post,
-                                                      :update_comment => :update,
-                                                      :delete_comment => :delete },
-                                         :collection => { :comments => :get }
+              category.resources :posts, member: { create_comment: :post,
+                                                      update_comment: :update,
+                                                      delete_comment: :delete },
+                                         collection: { comments: :get }
             end
           end
           EOF
@@ -68,8 +68,8 @@ module RailsBestPractices
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resources :categories do |category|
-              category.resources :posts, :member => [:create_comment, :update_comment, :delete_comment],
-                                         :collection => [:comments]
+              category.resources :posts, member: [:create_comment, :update_comment, :delete_comment],
+                                         collection: [:comments]
             end
           end
           EOF
@@ -91,7 +91,7 @@ module RailsBestPractices
         it "should not overuse route customizations when customize route is only one" do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, :member => { :vote => :post }
+            map.resources :posts, member: { vote: :post }
           end
           EOF
           runner.review('config/routes.rb', content)
@@ -102,8 +102,8 @@ module RailsBestPractices
           content =<<-EOF
           IP_PATTERN = /(((25[0-5]|2[0-4][0-9]|1[0-9]{2}|[0-9]{1,2})\.){3}(25[0-5]|2[0-4][0-9]|1[0-9]{2}|[0-9]{1,2}))|[\d]+/.freeze
           map.resources :vlans do |vlan|
-            vlan.resources :ip_ranges, :member => {:move => [:get, :post]} do |range|
-              range.resources :ips, :requirements => { :id => IP_PATTERN }
+            vlan.resources :ip_ranges, member: {move: [:get, :post]} do |range|
+              range.resources :ips, requirements: { id: IP_PATTERN }
             end
           end
           EOF
@@ -138,10 +138,10 @@ module RailsBestPractices
           content = <<-EOF
           RailsBestpracticesCom::Application.routes.draw do
             resources :posts do
-              post :create_comment, :on => :member
-              update :update_comment, :on => :member
-              delete :delete_comment, :on => :member
-              get :comments, :on => :collection
+              post :create_comment, on: :member
+              update :update_comment, on: :member
+              delete :delete_comment, on: :member
+              get :comments, on: :collection
             end
           end
           EOF

data/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe ProtectMassAssignmentReview do
-      let(:runner) { Core::Runner.new(:reviews => ProtectMassAssignmentReview.new) }
+      let(:runner) { Core::Runner.new(reviews: ProtectMassAssignmentReview.new) }
 
       it "should protect mass assignment" do
         content =<<-EOF
@@ -48,7 +48,7 @@ module RailsBestPractices
       it "should not protect mass assignment if using devise" do
         content =<<-EOF
         class User < ActiveRecord::Base
-          devise :database_authenticatable, :registerable, :confirmable, :recoverable, :stretches => 20
+          devise :database_authenticatable, :registerable, :confirmable, :recoverable, stretches: 20
         end
         EOF
         runner.review('app/models/user.rb', content)
@@ -93,6 +93,15 @@ module RailsBestPractices
         runner.review('app/models/user.rb', content)
         runner.should have(0).errors
       end
+
+      it "should not protect mass assignment if checking non ActiveRecord::Base inherited model" do
+          content =<<-EOF
+          class User < Person
+          end
+          EOF
+          runner.review('app/models/user.rb', content)
+          runner.should have(0).errors
+        end
     end
   end
 end

data/spec/rails_best_practices/reviews/remove_empty_helpers_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveEmptyHelpersReview do
-      let(:runner) { Core::Runner.new(:reviews => RemoveEmptyHelpersReview.new) }
+      let(:runner) { Core::Runner.new(reviews: RemoveEmptyHelpersReview.new) }
 
       it "should remove empty helpers" do
         content =<<-EOF

data/spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb

@@ -4,8 +4,8 @@ module RailsBestPractices
   module Reviews
     describe RemoveUnusedMethodsInControllersReview do
       let(:runner) { Core::Runner.new(
-        :prepares => [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
-        :reviews => RemoveUnusedMethodsInControllersReview.new({'except_methods' => ["ExceptableController#*"]})
+        prepares: [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
+        reviews: RemoveUnusedMethodsInControllersReview.new({'except_methods' => ["ExceptableController#*"]})
       ) }
 
       context "private/protected" do
@@ -127,7 +127,7 @@ module RailsBestPractices
         it "should not remove unused methods if all actions are used in route" do
           content =<<-EOF
           ActionController::Routing::Routes.draw do |map|
-            map.connect 'internal/:action/*whatever', :controller => "internal"
+            map.connect 'internal/:action/*whatever', controller: "internal"
           end
           EOF
           runner.prepare('config/routes.rb', content)
@@ -214,7 +214,7 @@ module RailsBestPractices
         end
       end
 
-      context "delegate :to => :controller" do
+      context "delegate to: :controller" do
         it "should remove unused methods if delegate method is not called" do
           content = <<-EOF
           class PostsController < ApplicationController
@@ -226,7 +226,7 @@ module RailsBestPractices
           runner.review('app/controllers/posts_controller.rb', content)
           content = <<-EOF
           module PostsHelper
-            delegate :helper_post, :to => :controller
+            delegate :helper_post, to: :controller
           end
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
@@ -246,7 +246,7 @@ module RailsBestPractices
           runner.review('app/controllers/posts_controller.rb', content)
           content = <<-EOF
           module PostsHelper
-            delegate :helper_post, :to => :controller
+            delegate :helper_post, to: :controller
           end
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
@@ -295,8 +295,8 @@ module RailsBestPractices
           content =<<-EOF
           class PostsCell < Cell::Rails
             def list
-              render :state => :show
-              render(:state => :display)
+              render state: :show
+              render(state: :display)
             end
 
             def show; end