rails_best_practices 1.4.0 → 1.5.0

data/spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe RailsBestPractices::Reviews::RemoveUnusedMethodsInControllersReview do
   let(:runner) { RailsBestPractices::Core::Runner.new(
     :prepares => [RailsBestPractices::Prepares::ControllerPrepare.new, RailsBestPractices::Prepares::RoutePrepare.new],
-    :reviews => RailsBestPractices::Reviews::RemoveUnusedMethodsInControllersReview.new({'except_methods' => []})
+    :reviews => RailsBestPractices::Reviews::RemoveUnusedMethodsInControllersReview.new({'except_methods' => ["ExceptableController#*"]})
   ) }
 
   context "private/protected" do
@@ -116,5 +116,72 @@ describe RailsBestPractices::Reviews::RemoveUnusedMethodsInControllersReview do
       runner.on_complete
       runner.should have(0).errors
     end
+
+    it "should not remove unused methods if they are except_methods" do
+      content =<<-EOF
+      class ExceptableController < ApplicationController
+        def list; end
+      end
+      EOF
+      runner.prepare('app/controllers/exceptable_controller.rb', content)
+      runner.review('app/controllers/exceptable_controller.rb', content)
+      runner.on_complete
+      runner.should have(0).errors
+    end
+  end
+
+  context "cells" do
+    it "should remove unused methods" do
+      content =<<-EOF
+      class PostsCell < Cell::Rails
+        def list; end
+      end
+      EOF
+      runner.prepare('app/cells/posts_cell.rb', content)
+      runner.review('app/cells/posts_cell.rb', content)
+      runner.on_complete
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/cells/posts_cell.rb:2 - remove unused methods (PostsCell#list)"
+    end
+
+    it "should not remove unused methods if render_cell" do
+      content =<<-EOF
+      class PostsCell < Cell::Rails
+        def list; end
+        def display; end
+      end
+      EOF
+      runner.prepare('app/cells/posts_cell.rb', content)
+      runner.review('app/cells/posts_cell.rb', content)
+      content =<<-EOF
+      <%= render_cell :posts, :list %>
+      <%= render_cell(:posts, :display) %>
+      EOF
+      runner.review('app/views/posts/index.html.erb', content)
+      runner.on_complete
+      runner.should have(0).errors
+    end
+
+    it "should not remove unused methods if render with state" do
+      content =<<-EOF
+      class PostsCell < Cell::Rails
+        def list
+          render :state => :show
+          render(:state => :display)
+        end
+
+        def show; end
+        def display; end
+      end
+      EOF
+      runner.prepare('app/cells/posts_cell.rb', content)
+      runner.review('app/cells/posts_cell.rb', content)
+      content =<<-EOF
+      <%= render_cell :posts, :list %>
+      EOF
+      runner.review('app/views/posts/index.html.erb', content)
+      runner.on_complete
+      runner.should have(0).errors
+    end
   end
 end

data/spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview do
   let(:runner) { RailsBestPractices::Core::Runner.new(
     :prepares => RailsBestPractices::Prepares::ModelPrepare.new,
-    :reviews => RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview.new({'except_methods' => ['set_cache']})
+    :reviews => RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview.new({'except_methods' => ["*#set_cache"]})
   ) }
 
   context "private" do

data/spec/spec_helper.rb

@@ -1,17 +1,26 @@
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
+require 'rubygems'
+require 'spork'
 
-require 'rspec/expectations'
-require 'rails_best_practices'
+Spork.prefork do
+  $LOAD_PATH.unshift(File.dirname(__FILE__))
+  $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
-RSpec.configure do |config|
-  config.after do
-    RailsBestPractices::Prepares.clear
+  require 'rspec'
+
+  RSpec.configure do |config|
+    config.after do
+      RailsBestPractices::Prepares.clear
+    end
+    config.filter_run :focus => true
+    config.run_all_when_everything_filtered = true
+  end
+
+  def parse_content(content)
+    Sexp.from_array(Ripper::SexpBuilder.new(content).parse)[1]
   end
-  config.filter_run :focus => true
-  config.run_all_when_everything_filtered = true
 end
 
-def parse_content(content)
-  Sexp.from_array(Ripper::SexpBuilder.new(content).parse)[1]
+Spork.each_run do
+  require 'rails_best_practices'
 end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-20 00:00:00.000000000Z
+date: 2011-11-26 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sexp_processor
-  requirement: &2152381700 !ruby/object:Gem::Requirement
+  requirement: &70247886541600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152381700
+  version_requirements: *70247886541600
 - !ruby/object:Gem::Dependency
   name: progressbar
-  requirement: &2152380940 !ruby/object:Gem::Requirement
+  requirement: &70247886540700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152380940
+  version_requirements: *70247886540700
 - !ruby/object:Gem::Dependency
   name: colored
-  requirement: &2152380200 !ruby/object:Gem::Requirement
+  requirement: &70247886540000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152380200
+  version_requirements: *70247886540000
 - !ruby/object:Gem::Dependency
   name: erubis
-  requirement: &2152379500 !ruby/object:Gem::Requirement
+  requirement: &70247886539360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152379500
+  version_requirements: *70247886539360
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &2152378620 !ruby/object:Gem::Requirement
+  requirement: &70247886538640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152378620
+  version_requirements: *70247886538640
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2152373900 !ruby/object:Gem::Requirement
+  requirement: &70247886537980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152373900
+  version_requirements: *70247886537980
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2152373120 !ruby/object:Gem::Requirement
+  requirement: &70247886537200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152373120
+  version_requirements: *70247886537200
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2152372280 !ruby/object:Gem::Requirement
+  requirement: &70247886536480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +98,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152372280
+  version_requirements: *70247886536480
 - !ruby/object:Gem::Dependency
-  name: watchr
-  requirement: &2152371480 !ruby/object:Gem::Requirement
+  name: haml
+  requirement: &70247886535760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,10 +109,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152371480
+  version_requirements: *70247886535760
 - !ruby/object:Gem::Dependency
-  name: haml
-  requirement: &2152370380 !ruby/object:Gem::Requirement
+  name: bundler
+  requirement: &70247886534860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -120,10 +120,43 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152370380
+  version_requirements: *70247886534860
 - !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: &2152369500 !ruby/object:Gem::Requirement
+  name: spork
+  requirement: &70247886533880 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - =
+      - !ruby/object:Gem::Version
+        version: 0.9.0.rc9
+  type: :development
+  prerelease: false
+  version_requirements: *70247886533880
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: &70247886532280 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70247886532280
+- !ruby/object:Gem::Dependency
+  name: guard-spork
+  requirement: &70247886531300 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70247886531300
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: &70247886530520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -131,7 +164,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152369500
+  version_requirements: *70247886530520
 description: a code metric tool for rails codes, written in Ruby.
 email:
 - flyerhzm@gmail.com
@@ -145,10 +178,10 @@ files:
 - .rspec.example
 - .rvmrc.example
 - .travis.yml
-- .watchr
 - .watchr.example
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - MIT_LICENSE
 - README.md
 - Rakefile
@@ -173,6 +206,7 @@ files:
 - lib/rails_best_practices/core/routes.rb
 - lib/rails_best_practices/core/runner.rb
 - lib/rails_best_practices/core_ext/enumerable.rb
+- lib/rails_best_practices/core_ext/erubis.rb
 - lib/rails_best_practices/core_ext/sexp.rb
 - lib/rails_best_practices/lexicals.rb
 - lib/rails_best_practices/lexicals/remove_tab_check.rb
@@ -233,6 +267,7 @@ files:
 - spec/rails_best_practices/core/routes_spec.rb
 - spec/rails_best_practices/core/runner_spec.rb
 - spec/rails_best_practices/core_ext/enumerable_spec.rb
+- spec/rails_best_practices/core_ext/erubis_spec.rb
 - spec/rails_best_practices/core_ext/sexp_spec.rb
 - spec/rails_best_practices/lexicals/remove_tab_check_spec.rb
 - spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb
@@ -289,7 +324,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1634590398891543727
+      hash: -3104358296029422528
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -318,6 +353,7 @@ test_files:
 - spec/rails_best_practices/core/routes_spec.rb
 - spec/rails_best_practices/core/runner_spec.rb
 - spec/rails_best_practices/core_ext/enumerable_spec.rb
+- spec/rails_best_practices/core_ext/erubis_spec.rb
 - spec/rails_best_practices/core_ext/sexp_spec.rb
 - spec/rails_best_practices/lexicals/remove_tab_check_spec.rb
 - spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb