rails_best_practices 1.23.1 → 1.23.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cdd81904314b75ffb168757035157e2e28627f890691ee869b567721485bb7ab
-  data.tar.gz: 98bd1b3d60c5a0218af2597f0ddf2a9d82f7375f2fe8466fc11d0f26f2f38e8b
+  metadata.gz: 45bd3e5bf9771d0f9c35424c5af13a11a0e0e05bfe571a1401f6f2e9f72e4ff0
+  data.tar.gz: e3f26d99ef59919f95bd125a96055bd99fea9042bb05fceebacc6a679d4ead67
 SHA512:
-  metadata.gz: e7bc62f7d7c9e69b69eadd2abc323aefd5e107135a29e6d91333f178c5f945621eb7b04d030745837335a706b0cd7a6628ec384d28ba407cbebb83e1f938cf1d
-  data.tar.gz: b6c9dfba7e08e08cad07fbc74fcc5c66f3ee24659e07376365afea89b9f6490b98b0c6c4925c74782788369cbdc9788fbb8764607464b16e1c97f34b2835276c
+  metadata.gz: b6164cb8d9f456dd5d3b99cfd824b721804ebd71d4b404d09767bbdb80e265a488bcc375606a6209d834a0292d428f62273268da37294efc7b97331f1feab138
+  data.tar.gz: d49f88f137c66a616758b06172f501e4f162730b4ee2665de8d19f06ae9ff0649c72dbacbc2054fd8fd469abb3ffc63a8827d73b584c7522fc594e56d1434db6

data/.github/workflows/main.yml

@@ -14,31 +14,14 @@ on:
     branches: [ master ]
 
 jobs:
-  test_ruby_2_6:
+  test:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.6']
-    env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
-      BUNDLE_GEMFILE: Gemfile.ruby-2.6
+        ruby-version: ['2.7', '3.0', '3.1', '3.2', '3.3']
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby-version }}
-        bundler-cache: true
-    - name: Run tests
-      run: bundle exec rspec spec
-  test_ruby_2_7_above:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        ruby-version: ['2.7', '3.0', '3.1']
-
-    steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

data/.ruby-version

@@ -1 +1 @@
-3.1.0
+3.4.7

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Next Release
 
+## 1.23.3 (2025-11-04)
+
+* Fix klass at the end_class
+* Fix links
+
+## 1.23.2 (2022-09-24)
+
+* require_ruby_version 2.3.0
+
 ## 1.23.1 (2022-02-12)
 
 * Do not strict activesupport dependency version

data/Gemfile

@@ -3,7 +3,7 @@
 source 'https://rubygems.org'
 gemspec
 
-gem 'coveralls', require: false
+gem 'coveralls_reborn', require: false
 
 gem 'guard'
 gem 'guard-rspec'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rails_best_practices (1.23.1)
+    rails_best_practices (1.23.3)
       activesupport
       code_analyzer (~> 0.5.5)
       erubis
@@ -13,7 +13,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.2.2)
+    activesupport (7.0.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -22,15 +22,14 @@ GEM
     code_analyzer (0.5.5)
       sexp_processor
     coderay (1.1.3)
-    concurrent-ruby (1.1.9)
-    coveralls (0.8.23)
-      json (>= 1.8, < 3)
-      simplecov (~> 0.16.1)
-      term-ansicolor (~> 1.3)
-      thor (>= 0.19.4, < 2.0)
-      tins (~> 1.6)
+    concurrent-ruby (1.1.10)
+    coveralls_reborn (0.24.0)
+      simplecov (>= 0.18.1, < 0.22.0)
+      term-ansicolor (~> 1.6)
+      thor (>= 0.20.3, < 2.0)
+      tins (~> 1.16)
     diff-lcs (1.4.4)
-    docile (1.3.2)
+    docile (1.4.0)
     erubis (2.7.0)
     ffi (1.15.4)
     formatador (0.3.0)
@@ -51,15 +50,15 @@ GEM
     haml (5.1.2)
       temple (>= 0.8.0)
       tilt
-    i18n (1.9.1)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    json (2.3.0)
+    json (2.6.2)
     listen (3.7.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
     method_source (1.0.0)
-    minitest (5.15.0)
+    minitest (5.16.3)
     nenv (0.3.0)
     notiffany (0.1.3)
       nenv (~> 0.1)
@@ -86,23 +85,26 @@ GEM
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
     ruby-progressbar (1.11.0)
-    sexp_processor (4.16.0)
+    sexp_processor (4.16.1)
     shellany (0.0.1)
-    simplecov (0.16.1)
+    simplecov (0.21.2)
       docile (~> 1.1)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.2)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     slim (4.0.1)
       temple (>= 0.7.6, < 0.9)
       tilt (>= 2.0.6, < 2.1)
+    sync (0.5.0)
     temple (0.8.2)
     term-ansicolor (1.7.1)
       tins (~> 1.0)
-    thor (1.1.0)
+    thor (1.2.1)
     tilt (2.0.10)
-    tins (1.22.2)
-    tzinfo (2.0.4)
+    tins (1.31.1)
+      sync
+    tzinfo (2.0.5)
       concurrent-ruby (~> 1.0)
 
 PLATFORMS
@@ -111,7 +113,7 @@ PLATFORMS
 DEPENDENCIES
   awesome_print
   bundler
-  coveralls
+  coveralls_reborn
   guard
   guard-rspec
   haml
@@ -122,4 +124,4 @@ DEPENDENCIES
   slim
 
 BUNDLED WITH
-   2.2.22
+   2.6.9

data/README.md

@@ -1,13 +1,10 @@
 # rails_best_practices
 
 [![Gem Version](https://badge.fury.io/rb/rails_best_practices.svg)](http://badge.fury.io/rb/rails_best_practices)
-[![Build Status](https://secure.travis-ci.org/flyerhzm/rails_best_practices.svg)](http://travis-ci.org/flyerhzm/rails_best_practices)
+[![CI](https://github.com/flyerhzm/rails_best_practices/actions/workflows/main.yml/badge.svg)](https://github.com/flyerhzm/rails_best_practices/actions/workflows/main.yml)
 [![Coverage Status](https://coveralls.io/repos/railsbp/rails_best_practices/badge.svg?branch=master)](https://coveralls.io/r/railsbp/rails_best_practices)
 [![AwesomeCode Status for flyerhzm/rails_best_practices](https://awesomecode.io/projects/d02ecd70-e068-4ad4-b61a-7003ac24b49a/status)](https://awesomecode.io/repos/flyerhzm/rails_best_practices)
 
-[![Coderwall Endorse](http://api.coderwall.com/flyerhzm/endorsecount.png)](http://coderwall.com/flyerhzm)
-[![Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !](https://pledgie.com/campaigns/12057.png?skin_name=chrome)](https://pledgie.com/campaigns/12057)
-
 rails_best_practices is a code metric tool to check the quality of Rails code.
 
 It supports the following ORM/ODMs:
@@ -90,15 +87,15 @@ To see the full list of command-line options, run:
 
 Homepage: <http://rails-bestpractices.com>
 
-GitHub: <http://github.com/railsbp/rails_best_practices>
+GitHub: <http://github.com/flyerhzm/rails_best_practices>
 
 Team Blog <http://rails-bestpractices.com>
 
 Google Group: <https://groups.google.com/group/rails_best_practices>
 
-Wiki: <http://github.com/railsbp/rails_best_practices/wiki>
+Wiki: <http://github.com/flyerhzm/rails_best_practices/wiki>
 
-Issue Tracker: <http://github.com/railsbp/rails_best_practices/issues>
+Issue Tracker: <http://github.com/flyerhzm/rails_best_practices/issues>
 
 ## Install
 
@@ -287,4 +284,4 @@ Send us email: <team@railsbp.com>
 Copyright © 2009 - 2022 Richard Huang (flyerhzm@gmail.com), released under the MIT license
 
 
-[1]: https://github.com/railsbp/rails_best_practices/wiki/How-to-write-your-own-check-list
+[1]: https://github.com/flyerhzm/rails_best_practices/wiki/How-to-write-your-own-check-list

data/lib/rails_best_practices/core/check.rb

@@ -138,7 +138,7 @@ module RailsBestPractices
             # end of the class
             add_callback :end_class do |_node|
               klasses.pop
-              @klass = nil
+              @klass = klasses.last
             end
           end
         end

data/lib/rails_best_practices/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsBestPractices
-  VERSION = '1.23.1'
+  VERSION = '1.23.3'
 end

data/rails_best_practices.gemspec

@@ -10,12 +10,16 @@ Gem::Specification.new do |spec|
   spec.platform    = Gem::Platform::RUBY
   spec.authors     = ['Richard Huang']
   spec.email       = ['flyerhzm@gmail.com']
-  spec.homepage    = 'http://rails-bestpractices.com'
+  spec.homepage    = 'https://github.com/flyerhzm/rails_best_practices'
   spec.summary     = 'a code metric tool for rails codes.'
   spec.description = 'a code metric tool for rails codes, written in Ruby.'
+  spec.metadata    = {
+    'changelog_uri' => 'https://github.com/flyerhzm/rails_best_practices/blob/main/CHANGELOG.md',
+    'source_code_uri' => 'https://github.com/flyerhzm/rails_best_practices'
+  }
   spec.license     = 'MIT'
 
-  spec.required_ruby_version = '>= 1.9.0'
+  spec.required_ruby_version = '>= 2.3.0'
   spec.required_rubygems_version = '>= 1.3.6'
 
   spec.add_runtime_dependency('activesupport')

data/spec/rails_best_practices/analyzer_spec.rb

@@ -77,10 +77,10 @@ module RailsBestPractices
       subject { described_class.new('.', 'format' => format) }
 
       before do
-        subject.stub(:output_terminal_errors)
-        subject.stub(:output_html_errors)
-        subject.stub(:output_yaml_errors)
-        subject.stub(:output_xml_errors)
+        allow(subject).to receive(:output_terminal_errors)
+        allow(subject).to receive(:output_html_errors)
+        allow(subject).to receive(:output_yaml_errors)
+        allow(subject).to receive(:output_xml_errors)
 
         subject.output
       end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.23.1
+  version: 1.23.3
 platform: ruby
 authors:
 - Richard Huang
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-12 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -207,8 +206,6 @@ files:
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
-- Gemfile.ruby-2.6
-- Gemfile.ruby-2.6.lock
 - Guardfile
 - MIT_LICENSE
 - README.md
@@ -373,10 +370,12 @@ files:
 - spec/rails_best_practices/reviews/use_scope_access_review_spec.rb
 - spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb
 - spec/spec_helper.rb
-homepage: http://rails-bestpractices.com
+homepage: https://github.com/flyerhzm/rails_best_practices
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/flyerhzm/rails_best_practices/blob/main/CHANGELOG.md
+  source_code_uri: https://github.com/flyerhzm/rails_best_practices
 post_install_message: |
   ********************************************************************************
 
@@ -399,15 +398,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.0
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.3.3
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: a code metric tool for rails codes.
 test_files:

data/Gemfile.ruby-2.6

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-source 'https://rubygems.org'
-gemspec
-
-gem 'activesupport', '~> 6.1.4'
-gem 'coveralls', require: false
-
-gem 'guard'
-gem 'guard-rspec'
-gem 'pry'

data/Gemfile.ruby-2.6.lock

@@ -1,130 +0,0 @@
-PATH
-  remote: .
-  specs:
-    rails_best_practices (1.23.1)
-      activesupport
-      code_analyzer (~> 0.5.5)
-      erubis
-      i18n
-      json
-      require_all (~> 3.0)
-      ruby-progressbar
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (6.1.4.6)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 1.6, < 2)
-      minitest (>= 5.1)
-      tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
-    awesome_print (1.9.2)
-    code_analyzer (0.5.5)
-      sexp_processor
-    coderay (1.1.3)
-    concurrent-ruby (1.1.9)
-    coveralls (0.8.23)
-      json (>= 1.8, < 3)
-      simplecov (~> 0.16.1)
-      term-ansicolor (~> 1.3)
-      thor (>= 0.19.4, < 2.0)
-      tins (~> 1.6)
-    diff-lcs (1.5.0)
-    docile (1.4.0)
-    erubis (2.7.0)
-    ffi (1.15.5)
-    formatador (1.1.0)
-    guard (2.18.0)
-      formatador (>= 0.2.4)
-      listen (>= 2.7, < 4.0)
-      lumberjack (>= 1.0.12, < 2.0)
-      nenv (~> 0.1)
-      notiffany (~> 0.0)
-      pry (>= 0.13.0)
-      shellany (~> 0.0)
-      thor (>= 0.18.1)
-    guard-compat (1.2.1)
-    guard-rspec (4.7.3)
-      guard (~> 2.1)
-      guard-compat (~> 1.1)
-      rspec (>= 2.99.0, < 4.0)
-    haml (5.2.2)
-      temple (>= 0.8.0)
-      tilt
-    i18n (1.9.1)
-      concurrent-ruby (~> 1.0)
-    json (2.6.1)
-    listen (3.7.1)
-      rb-fsevent (~> 0.10, >= 0.10.3)
-      rb-inotify (~> 0.9, >= 0.9.10)
-    lumberjack (1.2.8)
-    method_source (1.0.0)
-    minitest (5.15.0)
-    nenv (0.3.0)
-    notiffany (0.1.3)
-      nenv (~> 0.1)
-      shellany (~> 0.0)
-    pry (0.14.1)
-      coderay (~> 1.1)
-      method_source (~> 1.0)
-    rake (13.0.6)
-    rb-fsevent (0.11.1)
-    rb-inotify (0.10.1)
-      ffi (~> 1.0)
-    require_all (3.0.0)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
-    ruby-progressbar (1.11.0)
-    sexp_processor (4.16.0)
-    shellany (0.0.1)
-    simplecov (0.16.1)
-      docile (~> 1.1)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.2)
-    slim (4.1.0)
-      temple (>= 0.7.6, < 0.9)
-      tilt (>= 2.0.6, < 2.1)
-    sync (0.5.0)
-    temple (0.8.2)
-    term-ansicolor (1.7.1)
-      tins (~> 1.0)
-    thor (1.2.1)
-    tilt (2.0.10)
-    tins (1.31.0)
-      sync
-    tzinfo (2.0.4)
-      concurrent-ruby (~> 1.0)
-    zeitwerk (2.5.4)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (~> 6.1.4)
-  awesome_print
-  bundler
-  coveralls
-  guard
-  guard-rspec
-  haml
-  pry
-  rails_best_practices!
-  rake
-  rspec
-  slim
-
-BUNDLED WITH
-   1.17.3