rails_best_practices 1.22.1 → 1.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36bdd893273a363e797a90d58df2426f0429f94637171cdf803d4cfe3a3c0033
-  data.tar.gz: c2fc8eb82530d50615ecfd423da421c056fb309fd4edcdde91ea5cbe4c9ed2c2
+  metadata.gz: 6130c27d1f5ad49baeed9bd6595188a99f77e10260f709e7b2dc49bce191d06e
+  data.tar.gz: 856313c260d0e66d2625885bdb6f4f1614fa2184303a182d7fb016fb76dac304
 SHA512:
-  metadata.gz: 158478715edfea916abf0666e24665ac0da4aa5e6784df370a78f44654f2b817d415866ec363503bb7081011ace66edb0e32197d9d384c394f59cb429dc8d0ee
-  data.tar.gz: c785c39a4050af719e2513241dcff648dec9fe0d6c8bda3717e50da991fbc8d0d03cc1159fff946ad06d2c7378a5b9247146266e1e94d7d85178cbe50181e067
+  metadata.gz: 66c463631584235d020ea1ee12d748119827de1c9347660ccf5fde82191038ab75cd07f9266933c199a2fd6c722abf566eb75ec906f1c717a557c4e19e327278
+  data.tar.gz: 453991a40ccdf9f0549dbe6842e8823034a41e5b253efdccde0e4442a0ea17b654046747dea4de54ac4312eae89bd4ec946c45ded98c356d7f12465294b34d8d

data/.github/workflows/main.yml

@@ -0,0 +1,31 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.6', '2.7', '3.0', '3.1']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true
+    - name: Run tests
+      run: bundle exec rspec spec

data/.ruby-version

@@ -0,0 +1 @@
+3.1.0

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Next Release
 
+## 1.23.0 (2022-01-31)
+
+* Support hash short syntax
+
 ## 1.22.0 (2021-10-27)
 
 * Support atom editor

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    rails_best_practices (1.22.1)
-      activesupport
-      code_analyzer (>= 0.5.2)
+    rails_best_practices (1.23.0)
+      activesupport (~> 6.1.4)
+      code_analyzer (~> 0.5.5)
       erubis
       i18n
       json
@@ -13,14 +13,14 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.4.1)
+    activesupport (6.1.4.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
     awesome_print (1.8.0)
-    code_analyzer (0.5.2)
+    code_analyzer (0.5.5)
       sexp_processor
     coderay (1.1.3)
     concurrent-ruby (1.1.9)
@@ -52,7 +52,7 @@ GEM
     haml (5.1.2)
       temple (>= 0.8.0)
       tilt
-    i18n (1.8.10)
+    i18n (1.9.1)
       concurrent-ruby (~> 1.0)
     json (2.3.0)
     listen (3.7.0)
@@ -60,7 +60,7 @@ GEM
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
     method_source (1.0.0)
-    minitest (5.14.4)
+    minitest (5.15.0)
     nenv (0.3.0)
     notiffany (0.1.3)
       nenv (~> 0.1)
@@ -87,7 +87,7 @@ GEM
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
     ruby-progressbar (1.11.0)
-    sexp_processor (4.15.3)
+    sexp_processor (4.16.0)
     shellany (0.0.1)
     simplecov (0.16.1)
       docile (~> 1.1)
@@ -105,7 +105,7 @@ GEM
     tins (1.22.2)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
-    zeitwerk (2.5.1)
+    zeitwerk (2.5.4)
 
 PLATFORMS
   ruby

data/README.md

@@ -284,7 +284,7 @@ Follow us on twitter: <http://twitter.com/railsbp>
 Send us email: <team@railsbp.com>
 
 
-Copyright © 2009 - 2013 Richard Huang (flyerhzm@gmail.com), released under the MIT license
+Copyright © 2009 - 2022 Richard Huang (flyerhzm@gmail.com), released under the MIT license
 
 
 [1]: https://github.com/railsbp/rails_best_practices/wiki/How-to-write-your-own-check-list

data/lib/rails_best_practices/core/check.rb

@@ -204,7 +204,7 @@ module RailsBestPractices
                               :command_call,
                               :command,
                               :alias,
-                              :bare_assoc_hash,
+                              :assoc_new,
                               :method_add_arg
 
             # remembe the message of call node.
@@ -269,9 +269,12 @@ module RailsBestPractices
             #     def to_xml(options = {})
             #       super options.merge(exclude: :visible, methods: [:is_discussion_conversation])
             #     end
-            add_callback :start_bare_assoc_hash do |node|
-              if node.hash_keys.include? 'methods'
-                mark_used(node.hash_value('methods'))
+            add_callback :start_assoc_new do |node|
+              if node.key == 'methods'
+                mark_used(node.value)
+              end
+              if node.value.nil?
+                mark_used(node.key)
               end
             end
 
@@ -294,7 +297,9 @@ module RailsBestPractices
             def mark_used(method_node)
               return if method_node == :call
 
-              if method_node.sexp_type == :bare_assoc_hash
+              if method_node.is_a?(String)
+                method_name = method_node
+              elsif method_node.sexp_type == :bare_assoc_hash
                 method_node.hash_values.each { |value_node| mark_used(value_node) }
               elsif method_node.sexp_type == :array
                 method_node.array_values.each { |value_node| mark_used(value_node) }

data/lib/rails_best_practices/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsBestPractices
-  VERSION = '1.22.1'
+  VERSION = '1.23.0'
 end

data/rails_best_practices.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 1.9.0'
   spec.required_rubygems_version = '>= 1.3.6'
 
-  spec.add_runtime_dependency('activesupport')
-  spec.add_runtime_dependency('code_analyzer', '>= 0.5.2')
+  spec.add_runtime_dependency('activesupport', '~> 6.1.4')
+  spec.add_runtime_dependency('code_analyzer', '~> 0.5.5')
   spec.add_runtime_dependency('erubis')
   spec.add_runtime_dependency('i18n')
   spec.add_runtime_dependency('json')

data/spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb

@@ -556,6 +556,28 @@ module RailsBestPractices
         end
       end
 
+      if RUBY_VERSION.to_f > 3.0
+        context 'short syntax value' do
+          it 'does not remove unused method' do
+            content = <<-EOF
+            class Post < ActiveRecord::Base
+              def build
+                new(value:)
+              end
+
+              def value
+                'value'
+              end
+            end
+            EOF
+            runner.prepare('app/models/post.rb', content)
+            runner.review('app/models/post.rb', content)
+            runner.after_review
+            expect(runner.errors.size).to eq(1)
+          end
+        end
+      end
+
       context 'callbacks' do
         it 'does not remove unused method' do
           content = <<-EOF

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.22.1
+  version: 1.23.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-10-27 00:00:00.000000000 Z
+date: 2022-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 6.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 6.1.4
 - !ruby/object:Gem::Dependency
   name: code_analyzer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: 0.5.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: 0.5.5
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
@@ -200,9 +200,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -403,7 +404,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.3
 signing_key:
 specification_version: 4
 summary: a code metric tool for rails codes.

data/.travis.yml

@@ -1,4 +0,0 @@
-language: ruby
-rvm:
-  - 2.6.4
-script: bundle exec rspec spec