rails_best_practices 1.19.5 → 1.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ce639228ddc1497545e69b3ce97cd43b4832a5e9ebba9cf69e26c01c21831768
-  data.tar.gz: 9ea6a9454fbc1cd32c2b924066667e418448fea6c823c045bf7853bc0ea05c63
+  metadata.gz: 7b66ea6e0e742d6db68f867fed12f8242aa0d767b7b3fb4728043c97984f455a
+  data.tar.gz: 6f8ff9290459f8436908396fec8612d6050c7f5b278697475c4601e8931c0c19
 SHA512:
-  metadata.gz: e89e188603ede56c8f538f1415c352aa477fa8c3b591363380c1603dbbe301af6b0f5b29d834bd3b2e90525eb3418eda50508bdd7fc5a81a40aaf4c75f4e0cab
-  data.tar.gz: d318bb1faf3c574f8a88e59a54893af1ff1ffadd5e5542d1243b340bd07d72125214c8d4c9343c47ca32777fe8379ffb0f035093a51abe6a583ef3d80820ac97
+  metadata.gz: '03850b2873726ec5f3928bc1a846320927c56793c71221c715bbbc630cd1f10333b52ac9a713a78db3cbf1db6e2f25a34493d06bcce76d184f2447f5d888deb1'
+  data.tar.gz: 72586f6144df24dd9fd11861c443554f3903bc0cd8401bd08b1e6a89ff356d545b475b8e465b7e95e1803dd198517695fb91d81d6a746df9654e51525e638365

data/.travis.yml

@@ -1,3 +1,4 @@
 language: ruby
 rvm:
   - 2.6.4
+script: bundle exec rspec spec

data/CHANGELOG.md

@@ -1,30 +1,15 @@
 # Next Release
 
-## 1.19.5
+## 1.20.0 (2020-02-29)
 
+* Support ruby 2.7
 * Add the link format for vscode
-* Use code_analyzer 0.5.1
-
-## 1.19.4
-
 * Add cli class
-
-## 1.19.3
-
+* Add table_name and module_prefix to model ignored methods
 * Fix false positive remove unused method for around_action in
   controller
 * Fix current_class_name in end_class callback
 
-## 1.19.2
-
-* Integrate with awesomecode.io
-* Update to require_all 2.x
-
-## 1.19.1
-
-* Add table_name and module_prefix to model ignored methods
-* Forcing requrie_all version
-
 ## 1.19.0 (2017-07-26)
 
 * RestrictAutoGeneratedRoutesCheck is compatibale with rails api_only

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rails_best_practices (1.19.5)
+    rails_best_practices (1.20.0)
       activesupport
       code_analyzer (>= 0.5.1)
       erubis
@@ -66,7 +66,7 @@ GEM
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    rake (10.5.0)
+    rake (13.0.1)
     rb-fsevent (0.10.3)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
@@ -113,9 +113,9 @@ DEPENDENCIES
   haml
   pry
   rails_best_practices!
-  rake (< 11.0)
+  rake
   rspec (~> 2.14.0)
   slim
 
 BUNDLED WITH
-   2.1.2
+   2.1.4

data/Rakefile

@@ -1,18 +1 @@
-require 'bundler'
 require 'bundler/gem_tasks'
-
-Bundler.setup
-
-require 'rake'
-require 'rspec'
-require 'rspec/core/rake_task'
-
-$LOAD_PATH.unshift File.expand_path('lib', __dir__)
-require 'rails_best_practices/version'
-
-RSpec::Core::RakeTask.new(:spec) do |spec|
-  spec.pattern = 'spec/**/*_spec.rb'
-end
-
-task default: :spec
-task test: :spec

data/lib/rails_best_practices/reviews/always_add_db_index_review.rb

@@ -146,7 +146,7 @@ module RailsBestPractices
       def remove_table_not_exist_foreign_keys
         @foreign_keys.each do |table, foreign_keys|
           foreign_keys.delete_if do |key|
-            if key =~ /_id$/
+            if key.is_a?(String) && key =~ /_id$/
               class_name = Prepares.model_associations.get_association_class_name(table, key[0..-4])
               class_name ? !@table_nodes[class_name.gsub('::', '').tableize] : !@table_nodes[key[0..-4].pluralize]
             end
@@ -157,7 +157,7 @@ module RailsBestPractices
         # remove the non foreign keys with only _type column.
       def remove_only_type_foreign_keys
         @foreign_keys.each do |_table, foreign_keys|
-          foreign_keys.delete_if { |key| key =~ /_type$/ }
+          foreign_keys.delete_if { |key| key.is_a?(String) && key =~ /_type$/ }
         end
       end
 

data/lib/rails_best_practices/reviews/use_model_association_review.rb

@@ -46,7 +46,7 @@ module RailsBestPractices
         # check an attribute assignment node, if its message is xxx_id,
         # then remember the receiver of the attribute assignment in @assignments.
       def attribute_assignment(node)
-        if node.left_value.message.to_s =~ /_id$/
+        if node.left_value.message.is_a?(Sexp) && node.left_value.message.to_s =~ /_id$/
           receiver = node.left_value.receiver.to_s
           @assignments[receiver] = true
         end

data/lib/rails_best_practices/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsBestPractices
-  VERSION = '1.19.5'
+  VERSION = '1.20.0'
 end

data/rails_best_practices.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency('awesome_print')
   s.add_development_dependency('bundler')
   s.add_development_dependency('haml')
-  s.add_development_dependency('rake', '< 11.0')
+  s.add_development_dependency('rake')
   s.add_development_dependency('rspec')
   s.add_development_dependency('slim')
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.19.5
+  version: 1.20.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-28 00:00:00.000000000 Z
+date: 2020-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -154,16 +154,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -399,7 +399,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.0.pre1
 signing_key: 
 specification_version: 4
 summary: a code metric tool for rails codes.