rails_best_practices 1.19.3 → 1.21.0

data/spec/rails_best_practices/prepares/route_prepare_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Prepares
     describe RoutePrepare do
-      let(:runner) { Core::Runner.new(prepares: RoutePrepare.new) }
+      let(:runner) { Core::Runner.new(prepares: described_class.new) }
 
       context 'resources' do
-        it 'should add resources route' do
+        it 'adds resources route' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -17,10 +17,20 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(7)
-          expect(routes.map(&:to_s)).to eq(['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create', 'PostsController#edit', 'PostsController#update', 'PostsController#destroy'])
-        end
-
-        it 'should add multiple resources route' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'PostsController#index',
+              'PostsController#show',
+              'PostsController#new',
+              'PostsController#create',
+              'PostsController#edit',
+              'PostsController#update',
+              'PostsController#destroy'
+            ]
+          )
+        end
+
+        it 'adds multiple resources route' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, :users
@@ -31,7 +41,7 @@ module RailsBestPractices
           expect(routes.size).to eq(14)
         end
 
-        it 'should add resources route with explict controller' do
+        it 'adds resources route with explict controller' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, controller: :blog_posts
@@ -40,10 +50,20 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(7)
-          expect(routes.map(&:to_s)).to eq(['BlogPostsController#index', 'BlogPostsController#show', 'BlogPostsController#new', 'BlogPostsController#create', 'BlogPostsController#edit', 'BlogPostsController#update', 'BlogPostsController#destroy'])
-        end
-
-        it 'should add resources route with only option' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'BlogPostsController#index',
+              'BlogPostsController#show',
+              'BlogPostsController#new',
+              'BlogPostsController#create',
+              'BlogPostsController#edit',
+              'BlogPostsController#update',
+              'BlogPostsController#destroy'
+            ]
+          )
+        end
+
+        it 'adds resources route with only option' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:index, :show, :new, :create]
@@ -52,10 +72,12 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(4)
-          expect(routes.map(&:to_s)).to eq(['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create'])
+          expect(routes.map(&:to_s)).to eq(
+            ['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create']
+          )
         end
 
-        it 'should add resources route with except option' do
+        it 'adds resources route with except option' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, except: [:edit, :update, :destroy]
@@ -64,10 +86,12 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(4)
-          expect(routes.map(&:to_s)).to eq(['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create'])
+          expect(routes.map(&:to_s)).to eq(
+            ['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create']
+          )
         end
 
-        it 'should not add resources routes with only: :none' do
+        it 'does not add resources routes with only: :none' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: :none
@@ -78,7 +102,7 @@ module RailsBestPractices
           expect(routes.size).to eq(0)
         end
 
-        it 'should not add resources routes with except: :all' do
+        it 'does not add resources routes with except: :all' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, except: :all
@@ -89,7 +113,7 @@ module RailsBestPractices
           expect(routes.size).to eq(0)
         end
 
-        it 'should add resources routes with members' do
+        it 'adds resources routes with members' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
@@ -104,14 +128,17 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          expect(routes.map(&:to_s)).to eq([
-            'Admin::PostsController#edit',
-            'Admin::PostsController#update',
-            'Admin::PostsController#link_to_post',
-            'Admin::PostsController#extra_update'])
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'Admin::PostsController#edit',
+              'Admin::PostsController#update',
+              'Admin::PostsController#link_to_post',
+              'Admin::PostsController#extra_update'
+            ]
+          )
         end
 
-        it 'should add resources routes with members inline' do
+        it 'adds resources routes with members inline' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
@@ -123,15 +150,18 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          expect(routes.map(&:to_s)).to eq([
-            'Admin::PostsController#edit',
-            'Admin::PostsController#update',
-            'Admin::PostsController#link_to_post',
-            'Admin::PostsController#extra_update',
-            'Admin::PostsController#retrieve'])
-        end
-
-        it 'should add connect route' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'Admin::PostsController#edit',
+              'Admin::PostsController#update',
+              'Admin::PostsController#link_to_post',
+              'Admin::PostsController#extra_update',
+              'Admin::PostsController#retrieve'
+            ]
+          )
+        end
+
+        it 'adds connect route' do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.connect 'vote', controller: "votes", action: "create", method: :post
@@ -142,7 +172,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['VotesController#create'])
         end
 
-        it 'should add named route' do
+        it 'adds named route' do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.login '/player/login', controller: 'sessions', action: 'new', conditions: { method: :get }
@@ -155,7 +185,7 @@ module RailsBestPractices
       end
 
       context 'resource' do
-        it 'should add resource route' do
+        it 'adds resource route' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts
@@ -164,10 +194,19 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(6)
-          expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#new', 'PostsController#create', 'PostsController#edit', 'PostsController#update', 'PostsController#destroy'])
-        end
-
-        it 'should add multiple resource route' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'PostsController#show',
+              'PostsController#new',
+              'PostsController#create',
+              'PostsController#edit',
+              'PostsController#update',
+              'PostsController#destroy'
+            ]
+          )
+        end
+
+        it 'adds multiple resource route' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, :users
@@ -178,7 +217,7 @@ module RailsBestPractices
           expect(routes.size).to eq(12)
         end
 
-        it 'should add resource route with only option' do
+        it 'adds resource route with only option' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, only: [:show, :new, :create]
@@ -190,7 +229,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#new', 'PostsController#create'])
         end
 
-        it 'should add resource route with except option' do
+        it 'adds resource route with except option' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, except: [:edit, :update, :destroy]
@@ -202,7 +241,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#new', 'PostsController#create'])
         end
 
-        it 'should not add resource routes with only: :none' do
+        it 'does not add resource routes with only: :none' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, only: :none
@@ -213,7 +252,7 @@ module RailsBestPractices
           expect(routes.size).to eq(0)
         end
 
-        it 'should not add resource routes with except: :all' do
+        it 'does not add resource routes with except: :all' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, except: :all
@@ -224,7 +263,7 @@ module RailsBestPractices
           expect(routes.size).to eq(0)
         end
 
-        it 'should add resource routes with get/post/put/patch/delete routes' do
+        it 'adds resource routes with get/post/put/patch/delete routes' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:show] do
@@ -244,13 +283,25 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(7)
-          expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#list', 'PostsController#search', 'PostsController#available', 'PostsController#create', 'PostsController#update', 'PostsController#update'])
-        end
-
-        it 'should add custom resources routes with {}' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'PostsController#show',
+              'PostsController#list',
+              'PostsController#search',
+              'PostsController#available',
+              'PostsController#create',
+              'PostsController#update',
+              'PostsController#update'
+            ]
+          )
+        end
+
+        it 'adds custom resources routes with {}' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
-            resources :posts, only: [:show] { get :inactive, on: :collection }
+            resources :posts, only: [:show] do
+              get :inactive, on: :collection
+            end
           end
           EOF
           runner.prepare('config/routes.rb', content)
@@ -259,7 +310,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#inactive'])
         end
 
-        it 'should add resources routes with get %w() routes' do
+        it 'adds resources routes with get %w() routes' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:show] do
@@ -272,10 +323,12 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(3)
-          expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#latest', 'PostsController#popular'])
+          expect(routes.map(&:to_s)).to eq(
+            ['PostsController#show', 'PostsController#latest', 'PostsController#popular']
+          )
         end
 
-        it 'should add route with nested routes' do
+        it 'adds route with nested routes' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -288,7 +341,7 @@ module RailsBestPractices
           expect(routes.size).to eq(14)
         end
 
-        it 'should add route with namespace' do
+        it 'adds route with namespace' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
@@ -303,7 +356,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['Admin::Test::PostsController#index'])
         end
 
-        it 'should add route with namespace, but without resources' do
+        it 'adds route with namespace, but without resources' do
           content = <<-EOF
           RailsBestPracticesCom::Appllication.routes.draw do
             namespace :something do
@@ -314,10 +367,12 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          expect(routes.map(&:to_s)).to eq(['SomethingController#route_one', 'SomethingController#route_two', 'SomethingController#custom_action'])
+          expect(routes.map(&:to_s)).to eq(
+            ['SomethingController#route_one', 'SomethingController#route_two', 'SomethingController#custom_action']
+          )
         end
 
-        it 'should add route with scope' do
+        it 'adds route with scope' do
           content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               scope module: "admin" do
@@ -337,17 +392,19 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          expect(routes.map(&:to_s)).to eq([
-                                          'Admin::PostsController#index',
-                                          'Admin::DiscussionsController#index',
-                                          'CommentsController#index',
-                                          'UsersController#show',
-                                          'UsersController#preview'
-                                        ])
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'Admin::PostsController#index',
+              'Admin::DiscussionsController#index',
+              'CommentsController#index',
+              'UsersController#show',
+              'UsersController#preview'
+            ]
+          )
         end
       end
 
-      it 'should add route for direct get/post' do
+      it 'adds route for direct get/post' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           get 'posts/show'
@@ -360,10 +417,18 @@ module RailsBestPractices
         runner.prepare('config/routes.rb', content)
         routes = Prepares.routes
         expect(routes.size).to eq(5)
-        expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#create', 'PostsController#update', 'PostsController#destroy', 'HighVoltage::PagesController#show'])
+        expect(routes.map(&:to_s)).to eq(
+          [
+            'PostsController#show',
+            'PostsController#create',
+            'PostsController#update',
+            'PostsController#destroy',
+            'HighVoltage::PagesController#show'
+          ]
+        )
       end
 
-      it 'should add routes for another get/post' do
+      it 'adds routes for another get/post' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw
           get "/login", to: 'sessions#new', as: :login
@@ -375,7 +440,7 @@ module RailsBestPractices
         expect(routes.first.to_s).to eq('SessionsController#new')
       end
 
-      it 'should add match route' do
+      it 'adds match route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match '/auth/:provider/callback' => 'authentications#create'
@@ -386,7 +451,7 @@ module RailsBestPractices
         expect(routes.map(&:to_s)).to eq(['AuthenticationsController#create'])
       end
 
-      it 'should add match route with all actions' do
+      it 'adds match route with all actions' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match 'internal/:action/*whatever', controller: "internal"
@@ -397,7 +462,7 @@ module RailsBestPractices
         expect(routes.map(&:to_s)).to eq(['InternalController#*'])
       end
 
-      it 'should add root route' do
+      it 'adds root route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           root to: 'home#index'
@@ -408,7 +473,7 @@ module RailsBestPractices
         expect(routes.map(&:to_s)).to eq(['HomeController#index'])
       end
 
-      it 'should add root shortcut route' do
+      it 'adds root shortcut route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           root 'home#index'
@@ -419,7 +484,7 @@ module RailsBestPractices
         expect(routes.map(&:to_s)).to eq(['HomeController#index'])
       end
 
-      it 'should do nothing for default route' do
+      it 'does nothing for default route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match ':controller(/:action(/:id(.:format)))'
@@ -430,7 +495,7 @@ module RailsBestPractices
         expect(routes.size).to eq(0)
       end
 
-      it 'should do nothing for redirect' do
+      it 'does nothing for redirect' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match "/stories/:name" => redirect("/posts/%{name}")
@@ -442,7 +507,7 @@ module RailsBestPractices
         expect(routes.size).to eq(0)
       end
 
-      it 'should parse customize route in nested resources' do
+      it 'parses customize route in nested resources' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
@@ -456,7 +521,7 @@ module RailsBestPractices
         expect(routes.last.to_s).to eq('PostsController#stop')
       end
 
-      it 'should parse custom route for resource with explicit to and different action name' do
+      it 'parses custom route for resource with explicit to and different action name' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
@@ -469,7 +534,7 @@ module RailsBestPractices
         expect(routes.last.to_s).to eq('PostsController#stop')
       end
 
-      it 'should parse custom route for resource with symbol action name' do
+      it 'parses custom route for resource with symbol action name' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
@@ -482,7 +547,7 @@ module RailsBestPractices
         expect(routes.last.to_s).to eq('PostsController#stop')
       end
 
-      it 'should not take former resources for direct get/post' do
+      it 'does not take former resources for direct get/post' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts
@@ -494,7 +559,7 @@ module RailsBestPractices
         expect(routes.last.to_s).to eq('SprintsController#stop')
       end
 
-      it 'should not parse wrong route' do
+      it 'does not parse wrong route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match ':controller/:action' => '#index', as: :auto_complete