rails_best_practices 1.19.3 → 1.19.4

data/spec/rails_best_practices/reviews/hash_syntax_review_spec.rb

@@ -39,10 +39,10 @@ module RailsBestPractices
       end
 
       it 'should ignore haml_out' do
-        content = <<-EOF
-%div{ class: "foo1" }
-.div{ class: "foo2" }
-#div{ class: "foo3" }
+        content = <<~EOF
+          %div{ class: "foo1" }
+          .div{ class: "foo2" }
+          #div{ class: "foo3" }
         EOF
         runner.review('app/views/files/show.html.haml', content)
         expect(runner.errors.size).to eq(0)

data/spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb

@@ -40,10 +40,10 @@ module RailsBestPractices
         end
 
         it 'should law of demeter with haml' do
-          content = <<-EOF
-= @invoice.user.name
-= @invoice.user.address
-= @invoice.user.cellphone
+          content = <<~EOF
+            = @invoice.user.name
+            = @invoice.user.address
+            = @invoice.user.cellphone
           EOF
           runner.review('app/views/invoices/show.html.haml', content)
           expect(runner.errors.size).to eq(3)
@@ -51,10 +51,10 @@ module RailsBestPractices
         end
 
         it 'should law of demeter with slim' do
-          content = <<-EOF
-= @invoice.user.name
-= @invoice.user.address
-= @invoice.user.cellphone
+          content = <<~EOF
+            = @invoice.user.name
+            = @invoice.user.address
+            = @invoice.user.cellphone
           EOF
           runner.review('app/views/invoices/show.html.slim', content)
           expect(runner.errors.size).to eq(3)

data/spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb

@@ -19,9 +19,9 @@ module RailsBestPractices
       end
 
       it 'should move code into model with haml' do
-        content = <<-EOF
-- if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
-  = link_to 'Edit this post', edit_post_url(@post)
+        content = <<~EOF
+          - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
+            = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.haml', content)
         expect(runner.errors.size).to eq(1)
@@ -29,9 +29,9 @@ module RailsBestPractices
       end
 
       it 'should move code into model with slim' do
-        content = <<-EOF
-- if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
-  = link_to 'Edit this post', edit_post_url(@post)
+        content = <<~EOF
+          - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
+            = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.slim', content)
         expect(runner.errors.size).to eq(1)

data/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb

@@ -5,8 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe ProtectMassAssignmentReview do
-      let(:runner) { Core::Runner.new(prepares: [Prepares::GemfilePrepare.new, Prepares::ConfigPrepare.new, Prepares::InitializerPrepare.new],
-                                      reviews: ProtectMassAssignmentReview.new) }
+      let(:runner) {
+        Core::Runner.new(prepares: [Prepares::GemfilePrepare.new, Prepares::ConfigPrepare.new, Prepares::InitializerPrepare.new],
+                         reviews: ProtectMassAssignmentReview.new)
+      }
 
       it 'should protect mass assignment' do
         content = <<-EOF

data/spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb

@@ -5,10 +5,12 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveUnusedMethodsInControllersReview do
-      let(:runner) { Core::Runner.new(
-        prepares: [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
-        reviews: RemoveUnusedMethodsInControllersReview.new('except_methods' => ['ExceptableController#*'])
-      ) }
+      let(:runner) {
+        Core::Runner.new(
+          prepares: [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
+          reviews: RemoveUnusedMethodsInControllersReview.new('except_methods' => ['ExceptableController#*'])
+        )
+      }
 
       context 'private/protected' do
         it 'should remove unused methods' do

data/spec/rails_best_practices/reviews/remove_unused_methods_in_helpers_review_spec.rb

@@ -5,10 +5,12 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveUnusedMethodsInHelpersReview do
-      let(:runner) { Core::Runner.new(
-        prepares: [Prepares::ControllerPrepare.new, Prepares::HelperPrepare.new],
-        reviews: RemoveUnusedMethodsInHelpersReview.new(except_methods: [])
-      ) }
+      let(:runner) {
+        Core::Runner.new(
+          prepares: [Prepares::ControllerPrepare.new, Prepares::HelperPrepare.new],
+          reviews: RemoveUnusedMethodsInHelpersReview.new(except_methods: [])
+        )
+      }
 
       it 'should remove unused methods' do
         content = <<-EOF
@@ -116,7 +118,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-       it 'should not check ignored files' do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(prepares: [Prepares::ControllerPrepare.new, Prepares::HelperPrepare.new],
                                   reviews: RemoveUnusedMethodsInHelpersReview.new(ignored_files: /posts_helper/, except_methods: []))
 
@@ -129,7 +131,7 @@ module RailsBestPractices
         runner.review('app/helpers/posts_helper.rb', content)
         runner.after_review
         expect(runner.errors.size).to eq(0)
-       end
+      end
     end
   end
 end

data/spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb

@@ -5,10 +5,12 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveUnusedMethodsInModelsReview do
-      let(:runner) { Core::Runner.new(
-        prepares: Prepares::ModelPrepare.new,
-        reviews: RemoveUnusedMethodsInModelsReview.new('except_methods' => ['*#set_cache'])
-      ) }
+      let(:runner) {
+        Core::Runner.new(
+          prepares: Prepares::ModelPrepare.new,
+          reviews: RemoveUnusedMethodsInModelsReview.new('except_methods' => ['*#set_cache'])
+        )
+      }
 
       context 'private' do
         it 'should remove unused methods' do
@@ -473,7 +475,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-         it 'should not remove unused method with symbol alias' do
+        it 'should not remove unused method with symbol alias' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
@@ -710,25 +712,25 @@ module RailsBestPractices
         runner = Core::Runner.new(prepares: Prepares::ModelPrepare.new,
                                   reviews: RemoveUnusedMethodsInModelsReview.new(except_methods: [], ignored_files: /post/))
 
-          content = <<-EOF
+        content = <<-EOF
           class Post < ActiveRecord::Base
             def find; end
             private
             def find_by_sql; end
           end
-          EOF
-          runner.prepare('app/models/post.rb', content)
-          runner.review('app/models/post.rb', content)
-          content = <<-EOF
+        EOF
+        runner.prepare('app/models/post.rb', content)
+        runner.review('app/models/post.rb', content)
+        content = <<-EOF
           class PostsController < ApplicationController
             def get
               Post.new.find
             end
           end
-          EOF
-          runner.review('app/controllers/posts_controller.rb', content)
-          runner.after_review
-          expect(runner.errors.size).to eq(0)
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.after_review
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb

@@ -17,8 +17,8 @@ module RailsBestPractices
       end
 
       it 'should replace instance variable with local varialbe in haml file' do
-        content = <<-EOF
-= @post.title
+        content = <<~EOF
+          = @post.title
         EOF
         runner.review('app/views/posts/_post.html.haml', content)
         expect(runner.errors.size).to eq(1)
@@ -26,8 +26,8 @@ module RailsBestPractices
       end
 
       it 'should replace instance variable with local varialbe in slim file' do
-        content = <<-EOF
-= @post.title
+        content = <<~EOF
+          = @post.title
         EOF
         runner.review('app/views/posts/_post.html.slim', content)
         expect(runner.errors.size).to eq(1)

data/spec/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review_spec.rb

@@ -14,20 +14,20 @@ module RailsBestPractices
       end
 
       before do
-      content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (3.2.13)
-      actionmailer (= 3.2.13)
-      actionpack (= 3.2.13)
-      activerecord (= 3.2.13)
-      activeresource (= 3.2.13)
-      activesupport (= 3.2.13)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
-      EOF
-      runner.prepare('Gemfile.lock', content)
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (3.2.13)
+                actionmailer (= 3.2.13)
+                actionpack (= 3.2.13)
+                activerecord (= 3.2.13)
+                activeresource (= 3.2.13)
+                activesupport (= 3.2.13)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
+        EOF
+        runner.prepare('Gemfile.lock', content)
       end
 
       context 'project_mailer' do

data/spec/rails_best_practices/reviews/use_parentheses_in_method_def_review_spec.rb

@@ -41,7 +41,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: UseParenthesesInMethodDefReview.new(ignored_files: /posts_controller/))
-                content = <<-EOF
+        content = <<-EOF
         class PostsController < ApplicationController
           def edit foo, bar
           end

data/spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb

@@ -8,18 +8,18 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: UseTurboSprocketsRails3Review.new) }
 
       it 'should use turbo-sprockets-rails3' do
-        content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (3.2.13)
-      actionmailer (= 3.2.13)
-      actionpack (= 3.2.13)
-      activerecord (= 3.2.13)
-      activeresource (= 3.2.13)
-      activesupport (= 3.2.13)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (3.2.13)
+                actionmailer (= 3.2.13)
+                actionpack (= 3.2.13)
+                activerecord (= 3.2.13)
+                activeresource (= 3.2.13)
+                activesupport (= 3.2.13)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
         EOF
         runner.prepare('Gemfile.lock', content)
         content = <<-EOF
@@ -33,21 +33,21 @@ GEM
       end
 
       it 'should not use turbo-sprockets-rails3 with turbo-sprockets-rails3 gem' do
-        content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (3.2.13)
-      actionmailer (= 3.2.13)
-      actionpack (= 3.2.13)
-      activerecord (= 3.2.13)
-      activeresource (= 3.2.13)
-      activesupport (= 3.2.13)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
-    turbo-sprockets-rails3 (0.3.6)
-      railties (> 3.2.8, < 4.0.0)
-      sprockets (>= 2.0.0)
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (3.2.13)
+                actionmailer (= 3.2.13)
+                actionpack (= 3.2.13)
+                activerecord (= 3.2.13)
+                activeresource (= 3.2.13)
+                activesupport (= 3.2.13)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
+              turbo-sprockets-rails3 (0.3.6)
+                railties (> 3.2.8, < 4.0.0)
+                sprockets (>= 2.0.0)
         EOF
         runner.prepare('Gemfile.lock', content)
         content = <<-EOF
@@ -70,18 +70,18 @@ GEM
       end
 
       it 'should not use turbo-sprockets-rails3 with rails4 gem' do
-        content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (4.0.0)
-      actionmailer (= 4.0.0)
-      actionpack (= 4.0.0)
-      activerecord (= 4.0.0)
-      activeresource (= 4.0.0)
-      activesupport (= 4.0.0)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (4.0.0)
+                actionmailer (= 4.0.0)
+                actionpack (= 4.0.0)
+                activerecord (= 4.0.0)
+                activeresource (= 4.0.0)
+                activesupport (= 4.0.0)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
         EOF
         runner.prepare('Gemfile.lock', content)
         content = <<-EOF
@@ -96,18 +96,18 @@ GEM
       it 'should not check ignored files' do
         runner = Core::Runner.new(prepares: Prepares::GemfilePrepare.new,
                                   reviews: UseTurboSprocketsRails3Review.new(ignored_files: /Capfile/))
-        content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (3.2.13)
-      actionmailer (= 3.2.13)
-      actionpack (= 3.2.13)
-      activerecord (= 3.2.13)
-      activeresource (= 3.2.13)
-      activesupport (= 3.2.13)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (3.2.13)
+                actionmailer (= 3.2.13)
+                actionpack (= 3.2.13)
+                activerecord (= 3.2.13)
+                activeresource (= 3.2.13)
+                activesupport (= 3.2.13)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
         EOF
         runner.prepare('Gemfile.lock', content)
         content = <<-EOF

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.19.3
+  version: 1.19.4
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-22 00:00:00.000000000 Z
+date: 2018-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -205,6 +205,7 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - Guardfile
 - MIT_LICENSE
 - README.md
@@ -213,6 +214,7 @@ files:
 - bin/rails_best_practices
 - lib/rails_best_practices.rb
 - lib/rails_best_practices/analyzer.rb
+- lib/rails_best_practices/cli.rb
 - lib/rails_best_practices/colorize.rb
 - lib/rails_best_practices/command.rb
 - lib/rails_best_practices/core.rb
@@ -237,6 +239,7 @@ files:
 - lib/rails_best_practices/lexicals/long_line_check.rb
 - lib/rails_best_practices/lexicals/remove_tab_check.rb
 - lib/rails_best_practices/lexicals/remove_trailing_whitespace_check.rb
+- lib/rails_best_practices/option_parser.rb
 - lib/rails_best_practices/prepares.rb
 - lib/rails_best_practices/prepares/config_prepare.rb
 - lib/rails_best_practices/prepares/controller_prepare.rb