rails_best_practices 1.15.7 → 1.16.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.rspec +1 -1
- data/.rubocop.yml +1 -0
- data/.rubocop_todo.yml +382 -0
- data/.travis.yml +1 -0
- data/CHANGELOG.md +88 -0
- data/README.md +31 -33
- data/Rakefile +4 -1
- data/lib/rails_best_practices.rb +1 -0
- data/lib/rails_best_practices/analyzer.rb +2 -3
- data/lib/rails_best_practices/colorize.rb +11 -0
- data/lib/rails_best_practices/core/modules.rb +8 -8
- data/lib/rails_best_practices/prepares/controller_prepare.rb +4 -4
- data/lib/rails_best_practices/reviews/check_destroy_return_value_review.rb +60 -0
- data/lib/rails_best_practices/reviews/check_save_return_value_review.rb +3 -3
- data/lib/rails_best_practices/reviews/remove_unused_methods_in_helpers_review.rb +3 -3
- data/lib/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review.rb +2 -0
- data/lib/rails_best_practices/version.rb +1 -1
- data/rails_best_practices.gemspec +1 -1
- data/rails_best_practices.yml +1 -0
- data/spec/rails_best_practices/analyzer_spec.rb +5 -1
- data/spec/rails_best_practices/core/modules_spec.rb +5 -5
- data/spec/rails_best_practices/prepares/controller_prepare_spec.rb +2 -2
- data/spec/rails_best_practices/reviews/check_destroy_return_value_spec.rb +151 -0
- data/spec/rails_best_practices/reviews/remove_unused_methods_in_helpers_review_spec.rb +30 -0
- data/spec/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review_spec.rb +12 -18
- metadata +24 -17
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA1:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 6148fbef051b64b71999a14775871a94ed3bd984
|
4
|
+
data.tar.gz: 62ec9d8506b481f0a1ae715e9524f0bffdf00590
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: b3252c4c6a5a54919b419965d77e4baf7d68c7bfe21142ad09586ff333502211e7da1df85e15eb01a911c2ee96302255476658977251fc2aeeb08ab19aa27984
|
7
|
+
data.tar.gz: b0c595abc0835de3d4afad189d7531ed9807c261405d2a8d911c018562cbb8df8b1a69027a60df3dc6d22f073cdf86e6fc6abe00ce44381411ffffe766b972b9
|
data/.rspec
CHANGED
data/.rubocop.yml
ADDED
@@ -0,0 +1 @@
|
|
1
|
+
inherit_from: .rubocop_todo.yml
|
data/.rubocop_todo.yml
ADDED
@@ -0,0 +1,382 @@
|
|
1
|
+
# This configuration was generated by `rubocop --auto-gen-config`
|
2
|
+
# on 2015-05-04 15:10:48 +0100 using RuboCop version 0.30.1.
|
3
|
+
# The point is for the user to remove these configuration records
|
4
|
+
# one by one as the offenses are removed from the code base.
|
5
|
+
# Note that changes in the inspected code, or installation of new
|
6
|
+
# versions of RuboCop, may require this file to be generated again.
|
7
|
+
|
8
|
+
# Offense count: 1
|
9
|
+
Lint/AmbiguousOperator:
|
10
|
+
Enabled: false
|
11
|
+
|
12
|
+
# Offense count: 2
|
13
|
+
# Configuration parameters: AllowSafeAssignment.
|
14
|
+
Lint/AssignmentInCondition:
|
15
|
+
Enabled: false
|
16
|
+
|
17
|
+
# Offense count: 2
|
18
|
+
# Cop supports --auto-correct.
|
19
|
+
Lint/BlockAlignment:
|
20
|
+
Enabled: false
|
21
|
+
|
22
|
+
# Offense count: 3
|
23
|
+
# Cop supports --auto-correct.
|
24
|
+
Lint/DeprecatedClassMethods:
|
25
|
+
Enabled: false
|
26
|
+
|
27
|
+
# Offense count: 4
|
28
|
+
# Configuration parameters: AlignWith, SupportedStyles.
|
29
|
+
Lint/EndAlignment:
|
30
|
+
Enabled: false
|
31
|
+
|
32
|
+
# Offense count: 3
|
33
|
+
Lint/HandleExceptions:
|
34
|
+
Enabled: false
|
35
|
+
|
36
|
+
# Offense count: 6
|
37
|
+
Lint/ShadowingOuterLocalVariable:
|
38
|
+
Enabled: false
|
39
|
+
|
40
|
+
# Offense count: 1
|
41
|
+
# Cop supports --auto-correct.
|
42
|
+
Lint/StringConversionInInterpolation:
|
43
|
+
Enabled: false
|
44
|
+
|
45
|
+
# Offense count: 1
|
46
|
+
Lint/UnderscorePrefixedVariableName:
|
47
|
+
Enabled: false
|
48
|
+
|
49
|
+
# Offense count: 24
|
50
|
+
# Cop supports --auto-correct.
|
51
|
+
Lint/UnusedBlockArgument:
|
52
|
+
Enabled: false
|
53
|
+
|
54
|
+
# Offense count: 5
|
55
|
+
# Cop supports --auto-correct.
|
56
|
+
Lint/UnusedMethodArgument:
|
57
|
+
Enabled: false
|
58
|
+
|
59
|
+
# Offense count: 1
|
60
|
+
Lint/UselessAssignment:
|
61
|
+
Enabled: false
|
62
|
+
|
63
|
+
# Offense count: 23
|
64
|
+
Metrics/AbcSize:
|
65
|
+
Max: 96
|
66
|
+
|
67
|
+
# Offense count: 6
|
68
|
+
Metrics/BlockNesting:
|
69
|
+
Max: 4
|
70
|
+
|
71
|
+
# Offense count: 4
|
72
|
+
# Configuration parameters: CountComments.
|
73
|
+
Metrics/ClassLength:
|
74
|
+
Max: 223
|
75
|
+
|
76
|
+
# Offense count: 3
|
77
|
+
Metrics/CyclomaticComplexity:
|
78
|
+
Max: 16
|
79
|
+
|
80
|
+
# Offense count: 894
|
81
|
+
# Configuration parameters: AllowURI, URISchemes.
|
82
|
+
Metrics/LineLength:
|
83
|
+
Max: 269
|
84
|
+
|
85
|
+
# Offense count: 24
|
86
|
+
# Configuration parameters: CountComments.
|
87
|
+
Metrics/MethodLength:
|
88
|
+
Max: 79
|
89
|
+
|
90
|
+
# Offense count: 4
|
91
|
+
Metrics/PerceivedComplexity:
|
92
|
+
Max: 14
|
93
|
+
|
94
|
+
# Offense count: 4
|
95
|
+
# Cop supports --auto-correct.
|
96
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
97
|
+
Style/AlignParameters:
|
98
|
+
Enabled: false
|
99
|
+
|
100
|
+
# Offense count: 5
|
101
|
+
# Cop supports --auto-correct.
|
102
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
103
|
+
Style/AndOr:
|
104
|
+
Enabled: false
|
105
|
+
|
106
|
+
# Offense count: 17
|
107
|
+
# Cop supports --auto-correct.
|
108
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
|
109
|
+
Style/BlockDelimiters:
|
110
|
+
Enabled: false
|
111
|
+
|
112
|
+
# Offense count: 4
|
113
|
+
# Cop supports --auto-correct.
|
114
|
+
Style/BlockEndNewline:
|
115
|
+
Enabled: false
|
116
|
+
|
117
|
+
# Offense count: 25
|
118
|
+
# Cop supports --auto-correct.
|
119
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
120
|
+
Style/BracesAroundHashParameters:
|
121
|
+
Enabled: false
|
122
|
+
|
123
|
+
# Offense count: 17
|
124
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
125
|
+
Style/ClassAndModuleChildren:
|
126
|
+
Enabled: false
|
127
|
+
|
128
|
+
# Offense count: 2
|
129
|
+
# Configuration parameters: Keywords.
|
130
|
+
Style/CommentAnnotation:
|
131
|
+
Enabled: false
|
132
|
+
|
133
|
+
# Offense count: 76
|
134
|
+
Style/Documentation:
|
135
|
+
Enabled: false
|
136
|
+
|
137
|
+
# Offense count: 6
|
138
|
+
Style/DoubleNegation:
|
139
|
+
Enabled: false
|
140
|
+
|
141
|
+
# Offense count: 2
|
142
|
+
Style/EachWithObject:
|
143
|
+
Enabled: false
|
144
|
+
|
145
|
+
# Offense count: 5
|
146
|
+
# Cop supports --auto-correct.
|
147
|
+
Style/ElseAlignment:
|
148
|
+
Enabled: false
|
149
|
+
|
150
|
+
# Offense count: 10
|
151
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
152
|
+
Style/EmptyElse:
|
153
|
+
Enabled: false
|
154
|
+
|
155
|
+
# Offense count: 3
|
156
|
+
# Cop supports --auto-correct.
|
157
|
+
Style/EmptyLines:
|
158
|
+
Enabled: false
|
159
|
+
|
160
|
+
# Offense count: 30
|
161
|
+
# Cop supports --auto-correct.
|
162
|
+
Style/EmptyLinesAroundAccessModifier:
|
163
|
+
Enabled: false
|
164
|
+
|
165
|
+
# Offense count: 5
|
166
|
+
# Cop supports --auto-correct.
|
167
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
168
|
+
Style/EmptyLinesAroundBlockBody:
|
169
|
+
Enabled: false
|
170
|
+
|
171
|
+
# Offense count: 1
|
172
|
+
# Cop supports --auto-correct.
|
173
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
174
|
+
Style/EmptyLinesAroundClassBody:
|
175
|
+
Enabled: false
|
176
|
+
|
177
|
+
# Offense count: 2
|
178
|
+
# Configuration parameters: AllowedVariables.
|
179
|
+
Style/GlobalVars:
|
180
|
+
Enabled: false
|
181
|
+
|
182
|
+
# Offense count: 27
|
183
|
+
# Configuration parameters: MinBodyLength.
|
184
|
+
Style/GuardClause:
|
185
|
+
Enabled: false
|
186
|
+
|
187
|
+
# Offense count: 12
|
188
|
+
# Cop supports --auto-correct.
|
189
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
|
190
|
+
Style/HashSyntax:
|
191
|
+
Enabled: false
|
192
|
+
|
193
|
+
# Offense count: 11
|
194
|
+
# Cop supports --auto-correct.
|
195
|
+
# Configuration parameters: MaxLineLength.
|
196
|
+
Style/IfUnlessModifier:
|
197
|
+
Enabled: false
|
198
|
+
|
199
|
+
# Offense count: 2
|
200
|
+
# Cop supports --auto-correct.
|
201
|
+
Style/IndentArray:
|
202
|
+
Enabled: false
|
203
|
+
|
204
|
+
# Offense count: 2
|
205
|
+
# Cop supports --auto-correct.
|
206
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
207
|
+
Style/IndentHash:
|
208
|
+
Enabled: false
|
209
|
+
|
210
|
+
# Offense count: 99
|
211
|
+
# Cop supports --auto-correct.
|
212
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
213
|
+
Style/IndentationConsistency:
|
214
|
+
Enabled: false
|
215
|
+
|
216
|
+
# Offense count: 7
|
217
|
+
# Cop supports --auto-correct.
|
218
|
+
# Configuration parameters: Width.
|
219
|
+
Style/IndentationWidth:
|
220
|
+
Enabled: false
|
221
|
+
|
222
|
+
# Offense count: 2
|
223
|
+
# Cop supports --auto-correct.
|
224
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
225
|
+
Style/MethodDefParentheses:
|
226
|
+
Enabled: false
|
227
|
+
|
228
|
+
# Offense count: 1
|
229
|
+
Style/MultilineBlockChain:
|
230
|
+
Enabled: false
|
231
|
+
|
232
|
+
# Offense count: 4
|
233
|
+
# Cop supports --auto-correct.
|
234
|
+
Style/MultilineBlockLayout:
|
235
|
+
Enabled: false
|
236
|
+
|
237
|
+
# Offense count: 14
|
238
|
+
# Cop supports --auto-correct.
|
239
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
240
|
+
Style/MultilineOperationIndentation:
|
241
|
+
Enabled: false
|
242
|
+
|
243
|
+
# Offense count: 3
|
244
|
+
# Cop supports --auto-correct.
|
245
|
+
Style/NegatedIf:
|
246
|
+
Enabled: false
|
247
|
+
|
248
|
+
# Offense count: 4
|
249
|
+
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
|
250
|
+
Style/Next:
|
251
|
+
Enabled: false
|
252
|
+
|
253
|
+
# Offense count: 1
|
254
|
+
# Cop supports --auto-correct.
|
255
|
+
# Configuration parameters: PreferredDelimiters.
|
256
|
+
Style/PercentLiteralDelimiters:
|
257
|
+
Enabled: false
|
258
|
+
|
259
|
+
# Offense count: 10
|
260
|
+
# Cop supports --auto-correct.
|
261
|
+
Style/PerlBackrefs:
|
262
|
+
Enabled: false
|
263
|
+
|
264
|
+
# Offense count: 9
|
265
|
+
# Configuration parameters: NamePrefix, NamePrefixBlacklist.
|
266
|
+
Style/PredicateName:
|
267
|
+
Enabled: false
|
268
|
+
|
269
|
+
# Offense count: 1
|
270
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
271
|
+
Style/RaiseArgs:
|
272
|
+
Enabled: false
|
273
|
+
|
274
|
+
# Offense count: 1
|
275
|
+
# Cop supports --auto-correct.
|
276
|
+
Style/RedundantBegin:
|
277
|
+
Enabled: false
|
278
|
+
|
279
|
+
# Offense count: 1
|
280
|
+
# Cop supports --auto-correct.
|
281
|
+
# Configuration parameters: AllowMultipleReturnValues.
|
282
|
+
Style/RedundantReturn:
|
283
|
+
Enabled: false
|
284
|
+
|
285
|
+
# Offense count: 2
|
286
|
+
# Cop supports --auto-correct.
|
287
|
+
Style/RedundantSelf:
|
288
|
+
Enabled: false
|
289
|
+
|
290
|
+
# Offense count: 34
|
291
|
+
# Cop supports --auto-correct.
|
292
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
|
293
|
+
Style/RegexpLiteral:
|
294
|
+
Enabled: false
|
295
|
+
|
296
|
+
# Offense count: 1
|
297
|
+
# Cop supports --auto-correct.
|
298
|
+
# Configuration parameters: AllowAsExpressionSeparator.
|
299
|
+
Style/Semicolon:
|
300
|
+
Enabled: false
|
301
|
+
|
302
|
+
# Offense count: 1
|
303
|
+
# Cop supports --auto-correct.
|
304
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
305
|
+
Style/SignalException:
|
306
|
+
Enabled: false
|
307
|
+
|
308
|
+
# Offense count: 1
|
309
|
+
# Configuration parameters: Methods.
|
310
|
+
Style/SingleLineBlockParams:
|
311
|
+
Enabled: false
|
312
|
+
|
313
|
+
# Offense count: 3
|
314
|
+
# Cop supports --auto-correct.
|
315
|
+
Style/SpaceAfterComma:
|
316
|
+
Enabled: false
|
317
|
+
|
318
|
+
# Offense count: 20
|
319
|
+
# Cop supports --auto-correct.
|
320
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
321
|
+
Style/SpaceAroundEqualsInParameterDefault:
|
322
|
+
Enabled: false
|
323
|
+
|
324
|
+
# Offense count: 367
|
325
|
+
# Cop supports --auto-correct.
|
326
|
+
# Configuration parameters: MultiSpaceAllowedForOperators.
|
327
|
+
Style/SpaceAroundOperators:
|
328
|
+
Enabled: false
|
329
|
+
|
330
|
+
# Offense count: 5
|
331
|
+
# Cop supports --auto-correct.
|
332
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
333
|
+
Style/SpaceBeforeBlockBraces:
|
334
|
+
Enabled: false
|
335
|
+
|
336
|
+
# Offense count: 10
|
337
|
+
# Cop supports --auto-correct.
|
338
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
|
339
|
+
Style/SpaceInsideBlockBraces:
|
340
|
+
Enabled: false
|
341
|
+
|
342
|
+
# Offense count: 68
|
343
|
+
# Cop supports --auto-correct.
|
344
|
+
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
|
345
|
+
Style/SpaceInsideHashLiteralBraces:
|
346
|
+
Enabled: false
|
347
|
+
|
348
|
+
# Offense count: 2040
|
349
|
+
# Cop supports --auto-correct.
|
350
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
351
|
+
Style/StringLiterals:
|
352
|
+
Enabled: false
|
353
|
+
|
354
|
+
# Offense count: 5
|
355
|
+
# Cop supports --auto-correct.
|
356
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
357
|
+
Style/StringLiteralsInInterpolation:
|
358
|
+
Enabled: false
|
359
|
+
|
360
|
+
# Offense count: 2
|
361
|
+
# Cop supports --auto-correct.
|
362
|
+
# Configuration parameters: IgnoredMethods.
|
363
|
+
Style/SymbolProc:
|
364
|
+
Enabled: false
|
365
|
+
|
366
|
+
# Offense count: 4
|
367
|
+
# Cop supports --auto-correct.
|
368
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
369
|
+
Style/TrailingBlankLines:
|
370
|
+
Enabled: false
|
371
|
+
|
372
|
+
# Offense count: 1
|
373
|
+
# Cop supports --auto-correct.
|
374
|
+
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
|
375
|
+
Style/TrivialAccessors:
|
376
|
+
Enabled: false
|
377
|
+
|
378
|
+
# Offense count: 34
|
379
|
+
# Cop supports --auto-correct.
|
380
|
+
# Configuration parameters: WordRegex.
|
381
|
+
Style/WordArray:
|
382
|
+
MinSize: 9
|
data/.travis.yml
CHANGED
data/CHANGELOG.md
ADDED
@@ -0,0 +1,88 @@
|
|
1
|
+
# Next Release
|
2
|
+
|
3
|
+
## 1.16.0 (2016-02-22)
|
4
|
+
|
5
|
+
* Add check destroy return value review
|
6
|
+
* Support json and xml output
|
7
|
+
* Update urls on rails-bestpractices.com
|
8
|
+
|
9
|
+
## 1.15.0 (2014-02-03)
|
10
|
+
|
11
|
+
* Add `ignored_files` option to all checks
|
12
|
+
|
13
|
+
## 1.14.0 (2013-07-21)
|
14
|
+
|
15
|
+
* Add `--with-sublime` command option
|
16
|
+
* Add default_scope is evil check
|
17
|
+
|
18
|
+
## 1.13.0 (2012-11-23)
|
19
|
+
|
20
|
+
* Add use turbo-sprockets-rails3 check
|
21
|
+
* Add check save return value check
|
22
|
+
|
23
|
+
## 1.12.0 (2012-11-02)
|
24
|
+
|
25
|
+
* Add yaml output
|
26
|
+
* Add not rescue exception check
|
27
|
+
|
28
|
+
## 1.11.0 (2012-09-22)
|
29
|
+
|
30
|
+
* Add rabl support
|
31
|
+
* Extract `code_analyzer` gem
|
32
|
+
* Use `add_callback` for all checks
|
33
|
+
|
34
|
+
## 1.10.0 (2012-06-19)
|
35
|
+
|
36
|
+
* Do not support ripper in 1.8.7 anymore
|
37
|
+
* Add hash syntax check
|
38
|
+
* Add use parenthesis in method def check
|
39
|
+
* Add long line check
|
40
|
+
|
41
|
+
## 1.9.0 (2012-03-06)
|
42
|
+
|
43
|
+
* Parse nested scope routes
|
44
|
+
* Add protect mass assignment check
|
45
|
+
|
46
|
+
## 1.8.0 (2012-02-23)
|
47
|
+
|
48
|
+
* Add not use time ago in words check
|
49
|
+
* Ignore more unused methods
|
50
|
+
* Improve routes parser
|
51
|
+
|
52
|
+
## 1.7.0 (2011-12-14)
|
53
|
+
|
54
|
+
* Add slim template support
|
55
|
+
* Support mongomapper
|
56
|
+
|
57
|
+
## 1.6.0 (2011-12-10)
|
58
|
+
|
59
|
+
* Improve remove unused methods in controller check
|
60
|
+
* Add hg support
|
61
|
+
* Add `--output-file`, `--with-github`, `--only-table`,
|
62
|
+
`--last-commit-id` command options
|
63
|
+
|
64
|
+
## 1.5.0 (2011-11-26)
|
65
|
+
|
66
|
+
* Bug fixes
|
67
|
+
|
68
|
+
## 1.4.0 (2011-11-20)
|
69
|
+
|
70
|
+
* Parse routes better
|
71
|
+
|
72
|
+
## 1.3.0 (2011-11-13)
|
73
|
+
|
74
|
+
* Enable RemoveUsedMethodsInModelsCheck by default
|
75
|
+
|
76
|
+
## 1.2.0 (2011-10-16)
|
77
|
+
|
78
|
+
* No needless_deep_nesting for more than 3 levels in shallow
|
79
|
+
* Add remove unused methods in models check
|
80
|
+
|
81
|
+
## 1.1.0 (2011-10-06)
|
82
|
+
|
83
|
+
* Use `sexp_processor` instead of `ruby_parser`
|
84
|
+
* Add restrict auto-generated routes check
|
85
|
+
|
86
|
+
## 1.0.0 (2011-09-24)
|
87
|
+
|
88
|
+
* First release
|