rails_best_practices 1.15.2 → 1.15.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16424767a639f93e65221ccb0a759de20b7ce9fa
-  data.tar.gz: ce5f1080da4406d14d893246af12360ada46308f
+  metadata.gz: cef5dd69f1ae647200ad40a7fd84b9bd758df233
+  data.tar.gz: 7852c75a5be3ddda15983cd75177e7d187449928
 SHA512:
-  metadata.gz: 998a80e8e4399e80a8cb555ac596a2758c8beea6bd2f7e8fe13017b4a8931baa40efd2f892a899733dd94803418bdadde63069e21cd351e5dee9db49a2ce8adc
-  data.tar.gz: fb113c8116c5b0e575d2b6fed6e500b83bad9d96fbace45bdbfbb1eca6f5ebf77648ba1af5e16a09327e7a6eb1dc90e9a29e4b1268e9b4cfd2c8b57fe03caaaf
+  metadata.gz: e6bd653c5accb78475a08c6e56be229e35f2a8175632e423e994a07835d65952094f30cfed3d50da5d44ce7a4cf4ef755f3121bba7d1c1b0f3152b08ff8eaebb
+  data.tar.gz: 3ea57d56bf747f9bfbeea1709f5a9d6128a7375356321205c36185e21bc16fe96a649e7eb9c5925f923cc0c9c0934cdca535bbdc0777589ef99c11fd29469667

data/lib/rails_best_practices/core/check.rb

@@ -154,7 +154,7 @@ module RailsBestPractices
 
         # modules.
         def classable_modules
-          @class_moduels ||= []
+          @class_modules ||= []
         end
 
         def klasses
@@ -187,7 +187,7 @@ module RailsBestPractices
 
         # modules.
         def moduleable_modules
-          @moduleable_moduels ||= []
+          @moduleable_modules ||= []
         end
       end
 

data/lib/rails_best_practices/core/klasses.rb

@@ -21,17 +21,11 @@ module RailsBestPractices
       end
 
       def class_name
-        if @modules.empty?
-          @class_name
-        else
-          @modules.map { |modu| "#{modu}::" }.join("") + @class_name
-        end
+        @modules.map { |modu| "#{modu}::" }.join("") + @class_name
       end
 
       def extend_class_name
-        if @modules.empty?
-          @extend_class_name
-        else
+        if @extend_class_name.present?
           @modules.map { |modu| "#{modu}::" }.join("") + @extend_class_name
         end
       end

data/lib/rails_best_practices/prepares/route_prepare.rb

@@ -31,8 +31,12 @@ module RailsBestPractices
             elsif :array == first_argument.sexp_type
               action_names = first_argument.array_values.map(&:to_s)
             elsif :bare_assoc_hash == second_argument.try(:sexp_type) && second_argument.hash_value("to").present?
-              controller_name, action_name = second_argument.hash_value("to").to_s.split('#')
-              action_names = [action_name]
+              if :string_literal == second_argument.hash_value("to").sexp_type
+                controller_name, action_name = second_argument.hash_value("to").to_s.split('#')
+                action_names = [action_name]
+              else
+                action_names = [second_argument.hash_value("to").to_s]
+              end
             else
               action_names = [first_argument.to_s]
             end

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.15.2"
+  VERSION = "1.15.3"
 end

data/spec/rails_best_practices/prepares/route_prepare_spec.rb

@@ -713,6 +713,19 @@ module RailsBestPractices
           expect(routes.last.to_s).to eq("PostsController#stop")
         end
 
+        it "should parse custom route for resource with symbol action name" do
+          content =<<-EOF
+          RailsBestPracticesCom::Application.routes.draw do
+            resources :posts do
+              get :halt, to: :stop
+            end
+          end
+          EOF
+          runner.prepare('config/routes.rb', content)
+          routes = Prepares.routes
+          expect(routes.last.to_s).to eq("PostsController#stop")
+        end
+
         it "should not take former resources for direct get/post" do
           content =<<-EOF
           RailsBestPracticesCom::Application.routes.draw do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.15.2
+  version: 1.15.3
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-11 00:00:00.000000000 Z
+date: 2014-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport