rails_best_practices 1.13.8 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0bd66b9f885d3de24877f8f671c8caa7ec05a0de
-  data.tar.gz: 4c82581c64139d752d9205689a5c0c805735d7fe
+  metadata.gz: f156688bf7014687ef1fbe360333886dabc39369
+  data.tar.gz: 18c27a29f89c40d5c4fc621719685f5b281cc480
 SHA512:
-  metadata.gz: cc478b2544c16dd600bd97c126567638429bf16d3781e15123128e2e7381303019a795c15af8a05821d52d4619beae550c98b18bb6ae1b3c2013d8c126efa800
-  data.tar.gz: 0ea6abf20e3c61a99c42c4ebd311bc4b31f5eaa5055d07cfce79c7fdda8cd8ed866c8d34414837b9c050cf948c9cfbf8c19d981a7ae0e55b135a339b8129d476
+  metadata.gz: e59f2708ddd9c4e71d2e3d9be3544ddd05411d9ca038387a33bcc3c48ebf1a059d945421137b151ddaad9a4c67b91d17944e0f7caae70a5fed3cd21cfc6a9657
+  data.tar.gz: 51edce3a83696df402cebe5e20e32b1108c8dd2d594d05f54d47215585e7364b1cd929967e7fb6bf7ea6296b5904e7720426c23d843e7b251b7053a5fe059f95

data/README.md

@@ -124,6 +124,7 @@ Now you can customize this configuration file, the default configuration is as f
     AddModelVirtualAttributeCheck: { }
     AlwaysAddDbIndexCheck: { }
     #CheckSaveReturnValueCheck: { }
+    DefaultScopeIsEvilCheck: { }
     DryBundlerInCapistranoCheck: { }
     #HashSyntaxCheck: { }
     IsolateSeedDataCheck: { }

data/assets/result.html.erb

@@ -115,7 +115,7 @@
               <% elsif @textmate %>
                 <a href='txmt://open/?url=file://<%= File.expand_path(error.filename) %>&amp;line=<%= error.line_number %>'><%= error.short_filename %></a>
               <% elsif @sublime %>
-                <a href='"subl://open?url=file://"<%= File.expand_path(error.filename) %>&amp;line=<%= error.line_number %>'><%= error.short_filename %></a>
+                <a href='subl://open?url=file://<%= File.expand_path(error.filename) %>&amp;line=<%= error.line_number %>'><%= error.short_filename %></a>
               <% elsif @mvim %>
                 <a href='mvim://open/?url=file://<%= File.expand_path(error.filename) %>&amp;line=<%= error.line_number %>'><%= error.short_filename %></a>
               <% else %>

data/lib/rails_best_practices.rb

@@ -1,33 +1,11 @@
 # encoding: utf-8
-
-#--
-# Copyright (c) 2010 Richard Huang (flyerhzm@gmail.com)
-#
-# Permission is hereby granted, free of charge, to any person obtaining
-# a copy of this software and associated documentation files (the
-# "Software"), to deal in the Software without restriction, including
-# without limitation the rights to use, copy, modify, merge, publish,
-# distribute, sublicense, and/or sell copies of the Software, and to
-# permit persons to whom the Software is furnished to do so, subject to
-# the following conditions:
-#
-# The above copyright notice and this permission notice shall be
-# included in all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-#++
 require 'code_analyzer'
+require 'require_all'
+require 'rails_best_practices/core'
+require 'rails_best_practices/analyzer'
 require 'rails_best_practices/lexicals'
 require 'rails_best_practices/prepares'
 require 'rails_best_practices/reviews'
-require 'rails_best_practices/core'
-require 'rails_best_practices/analyzer'
 
 module RailsBestPractices
 end

data/lib/rails_best_practices/analyzer.rb

@@ -1,10 +1,8 @@
 # encoding: utf-8
+require 'ap'
+require 'colored'
 require 'fileutils'
-
 require 'ruby-progressbar'
-require 'colored'
-require 'ap'
-
 
 module RailsBestPractices
   # RailsBestPractices Analyzer helps you to analyze your rails code, according to best practices on http://rails-bestpractices.

data/lib/rails_best_practices/core.rb

@@ -1,18 +1,3 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-require 'rails_best_practices/core/runner'
-require 'rails_best_practices/core/error'
-require 'rails_best_practices/core/klasses'
-require 'rails_best_practices/core/modules'
-require 'rails_best_practices/core/models'
-require 'rails_best_practices/core/model_associations'
-require 'rails_best_practices/core/model_attributes'
-require 'rails_best_practices/core/mailers'
-require 'rails_best_practices/core/methods'
-require 'rails_best_practices/core/controllers'
-require 'rails_best_practices/core/helpers'
-require 'rails_best_practices/core/routes'
-require 'rails_best_practices/core/configs'
-require 'rails_best_practices/core/gems'
-
-require 'rails_best_practices/core_ext/erubis'
+require_rel 'core'
+require_rel 'core_ext'

data/lib/rails_best_practices/core/runner.rb

@@ -1,12 +1,12 @@
 # encoding: utf-8
 require 'yaml'
-require 'active_support/inflector'
 require 'active_support/core_ext/object/blank'
 begin
   require 'active_support/core_ext/object/try'
 rescue LoadError
   require 'active_support/core_ext/try'
 end
+require 'active_support/inflector'
 
 module RailsBestPractices
   module Core

data/lib/rails_best_practices/lexicals.rb

@@ -1,4 +1,2 @@
 # encoding: utf-8
-require 'rails_best_practices/lexicals/remove_trailing_whitespace_check'
-require 'rails_best_practices/lexicals/remove_tab_check'
-require 'rails_best_practices/lexicals/long_line_check'
+require_rel 'lexicals'

data/lib/rails_best_practices/lexicals/long_line_check.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Lexicals
     # Keep lines fewer than 80 characters.

data/lib/rails_best_practices/lexicals/remove_tab_check.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Lexicals
     # Make sure there are no tabs in files.

data/lib/rails_best_practices/lexicals/remove_trailing_whitespace_check.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Lexicals
     # Make sure there are no trailing whitespace in codes.

data/lib/rails_best_practices/prepares.rb

@@ -1,13 +1,5 @@
 # encoding: utf-8
-require 'rails_best_practices/prepares/model_prepare'
-require 'rails_best_practices/prepares/mailer_prepare'
-require 'rails_best_practices/prepares/schema_prepare'
-require 'rails_best_practices/prepares/controller_prepare'
-require 'rails_best_practices/prepares/route_prepare'
-require 'rails_best_practices/prepares/helper_prepare'
-require 'rails_best_practices/prepares/config_prepare'
-require 'rails_best_practices/prepares/gemfile_prepare'
-require 'rails_best_practices/prepares/initializer_prepare'
+require_rel 'prepares'
 
 module RailsBestPractices
   module Prepares

data/lib/rails_best_practices/prepares/config_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Remember all configs

data/lib/rails_best_practices/prepares/controller_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Remember controllers and controller methods

data/lib/rails_best_practices/prepares/gemfile_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Remember all gems in Gemfile

data/lib/rails_best_practices/prepares/helper_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Remember helper methods.

data/lib/rails_best_practices/prepares/initializer_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Check all initializers

data/lib/rails_best_practices/prepares/mailer_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Remember the mailer names.

data/lib/rails_best_practices/prepares/model_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Remember models and model associations.

data/lib/rails_best_practices/prepares/route_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Remembber routes.

data/lib/rails_best_practices/prepares/schema_prepare.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-
 module RailsBestPractices
   module Prepares
     # Remember the model attributes.

data/lib/rails_best_practices/reviews.rb

@@ -1,38 +1,2 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/move_finder_to_named_scope_review'
-require 'rails_best_practices/reviews/use_model_association_review'
-require 'rails_best_practices/reviews/use_scope_access_review'
-require 'rails_best_practices/reviews/add_model_virtual_attribute_review'
-require 'rails_best_practices/reviews/replace_complex_creation_with_factory_method_review'
-require 'rails_best_practices/reviews/move_model_logic_into_model_review'
-require 'rails_best_practices/reviews/overuse_route_customizations_review'
-require 'rails_best_practices/reviews/needless_deep_nesting_review'
-require 'rails_best_practices/reviews/not_use_default_route_review'
-require 'rails_best_practices/reviews/keep_finders_on_their_own_model_review'
-require 'rails_best_practices/reviews/law_of_demeter_review'
-require 'rails_best_practices/reviews/use_observer_review'
-require 'rails_best_practices/reviews/isolate_seed_data_review'
-require 'rails_best_practices/reviews/always_add_db_index_review'
-require 'rails_best_practices/reviews/use_before_filter_review'
-require 'rails_best_practices/reviews/move_code_into_controller_review'
-require 'rails_best_practices/reviews/move_code_into_model_review'
-require 'rails_best_practices/reviews/move_code_into_helper_review'
-require 'rails_best_practices/reviews/replace_instance_variable_with_local_variable_review'
-require 'rails_best_practices/reviews/dry_bundler_in_capistrano_review'
-require 'rails_best_practices/reviews/use_say_with_time_in_migrations_review'
-require 'rails_best_practices/reviews/use_query_attribute_review'
-require 'rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review'
-require 'rails_best_practices/reviews/simplify_render_in_views_review'
-require 'rails_best_practices/reviews/simplify_render_in_controllers_review'
-require 'rails_best_practices/reviews/remove_empty_helpers_review'
-require 'rails_best_practices/reviews/restrict_auto_generated_routes_review'
-require 'rails_best_practices/reviews/remove_unused_methods_in_models_review'
-require 'rails_best_practices/reviews/remove_unused_methods_in_controllers_review'
-require 'rails_best_practices/reviews/remove_unused_methods_in_helpers_review'
-require 'rails_best_practices/reviews/not_use_time_ago_in_words_review'
-require 'rails_best_practices/reviews/protect_mass_assignment_review'
-require 'rails_best_practices/reviews/use_parentheses_in_method_def_review'
-require 'rails_best_practices/reviews/hash_syntax_review'
-require 'rails_best_practices/reviews/not_rescue_exception_review'
-require 'rails_best_practices/reviews/check_save_return_value_review'
-require 'rails_best_practices/reviews/use_turbo_sprockets_rails3_review'
+require_rel 'reviews'

data/lib/rails_best_practices/reviews/add_model_virtual_attribute_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Make sure to add a model virual attribute to simplify model creation.

data/lib/rails_best_practices/reviews/always_add_db_index_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review db/schema.rb file to make sure every reference key has a database index.

data/lib/rails_best_practices/reviews/check_save_return_value_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review all code to make sure we either check the return value of "save"

data/lib/rails_best_practices/reviews/default_scope_is_evil_review.rb

@@ -0,0 +1,25 @@
+# encoding: utf-8
+module RailsBestPractices
+  module Reviews
+    # Review model files to make sure not use default_scope
+    #
+    # See the best practice details here http://rails-bestpractices.com/posts/806-default_scope-is-evil
+    #
+    # Implementation:
+    #
+    # Review process:
+    #   check all command node to see if its message is default_scope
+    class DefaultScopeIsEvilReview < Review
+      interesting_nodes :command
+      interesting_files MODEL_FILES
+      url "http://rails-bestpractices.com/posts/806-default_scope-is-evil"
+
+      # check all command nodes' message
+      add_callback :start_command do |node|
+        if "default_scope" == node.message.to_s
+          add_error "default_scope is evil"
+        end
+      end
+    end
+  end
+end

data/lib/rails_best_practices/reviews/dry_bundler_in_capistrano_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review config/deploy.rb file to make sure using the bundler's capistrano recipe.

data/lib/rails_best_practices/reviews/hash_syntax_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Check ruby 1.8 style hash and suggest to change hash syntax to 1.9.

data/lib/rails_best_practices/reviews/isolate_seed_data_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Make sure not to insert data in migration, move them to seed file.

data/lib/rails_best_practices/reviews/keep_finders_on_their_own_model_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review model files to ake sure finders are on their own model.

data/lib/rails_best_practices/reviews/law_of_demeter_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review to make sure not to avoid the law of demeter.

data/lib/rails_best_practices/reviews/move_code_into_controller_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a view file to make sure there is no finder, finder should be moved to controller.

data/lib/rails_best_practices/reviews/move_code_into_helper_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a view file to make sure there is no complex options_for_select message call.

data/lib/rails_best_practices/reviews/move_code_into_model_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a view file to make sure there is no complex logic call for model.

data/lib/rails_best_practices/reviews/move_finder_to_named_scope_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a controller file to make sure there are no complex finder.

data/lib/rails_best_practices/reviews/move_model_logic_into_model_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a controller file to make sure that complex model logic should not exist in controller, should be moved into a model.

data/lib/rails_best_practices/reviews/needless_deep_nesting_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review config/routes.rb file to make sure not to use too deep nesting routes.

data/lib/rails_best_practices/reviews/not_rescue_exception_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review all code to make sure we don't rescue Exception

data/lib/rails_best_practices/reviews/not_use_default_route_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review config/routes file to make sure not use default route that rails generated.

data/lib/rails_best_practices/reviews/not_use_time_ago_in_words_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review view and helper files to make sure not use time_ago_in_words or distance_of_time_in_words_to_now.

data/lib/rails_best_practices/reviews/overuse_route_customizations_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review config/routes.rb file to make sure there are no overuse route customizations.

data/lib/rails_best_practices/reviews/protect_mass_assignment_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review model files to make sure to use attr_accessible, attr_protected or strong_parameters to protect mass assignment.

data/lib/rails_best_practices/reviews/remove_empty_helpers_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a helper file to make sure it is not an empty moduel.

data/lib/rails_best_practices/reviews/remove_unused_methods_in_controllers_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Find out unused methods in controllers.

data/lib/rails_best_practices/reviews/remove_unused_methods_in_helpers_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Find out unused methods in helpers.

data/lib/rails_best_practices/reviews/remove_unused_methods_in_models_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Find out unused methods in models.

data/lib/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a controller file to make sure that complex model creation should not exist in

data/lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a partail view file to make sure there is no instance variable.

data/lib/rails_best_practices/reviews/restrict_auto_generated_routes_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a route file to make sure all auto-generated routes have corresponding actions in controller.

data/lib/rails_best_practices/reviews/review.rb

@@ -1,7 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/check'
-require 'rails_best_practices/core/error'
-
 module RailsBestPractices
   module Reviews
     # A Review class that takes charge of reviewing one rails best practice.

data/lib/rails_best_practices/reviews/simplify_render_in_controllers_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a controller file to make sure using simplified syntax for render.

data/lib/rails_best_practices/reviews/simplify_render_in_views_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a view file to make sure using simplified syntax for render.

data/lib/rails_best_practices/reviews/use_before_filter_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a controller file to make sure to use before_filter to remove duplicated first code

data/lib/rails_best_practices/reviews/use_model_association_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # review a controller file to make sure to use model association instead of foreign key id assignment.

data/lib/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review.rb

@@ -1,7 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/core/runner'
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Make sure to use multipart/alternative as content_type of email.

data/lib/rails_best_practices/reviews/use_observer_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Make sure to use observer (sorry we only check the mailer deliver now).

data/lib/rails_best_practices/reviews/use_parentheses_in_method_def_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Check if method definition has parentheses around parameters.

data/lib/rails_best_practices/reviews/use_query_attribute_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Make sure to use query attribute instead of nil?, blank? and present?.

data/lib/rails_best_practices/reviews/use_say_with_time_in_migrations_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a migration file to make sure to use say or say_with_time for customized data changes

data/lib/rails_best_practices/reviews/use_scope_access_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Review a controller to make sure to use scope access instead of manually checking current_user and redirect.

data/lib/rails_best_practices/reviews/use_turbo_sprockets_rails3_review.rb

@@ -1,6 +1,4 @@
 # encoding: utf-8
-require 'rails_best_practices/reviews/review'
-
 module RailsBestPractices
   module Reviews
     # Prepare Gemfile and review Capfile file to make sure using turbo-sprocket-rails3

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.13.8"
+  VERSION = "1.14.0"
 end

data/rails_best_practices.gemspec

@@ -14,13 +14,14 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 1.9.0"
   s.required_rubygems_version = ">= 1.3.6"
 
+  s.add_dependency("activesupport")
+  s.add_dependency("awesome_print")
   s.add_dependency("code_analyzer")
-  s.add_dependency("ruby-progressbar")
   s.add_dependency("colored")
   s.add_dependency("erubis")
   s.add_dependency("i18n")
-  s.add_dependency("activesupport")
-  s.add_dependency("awesome_print")
+  s.add_dependency("require_all")
+  s.add_dependency("ruby-progressbar")
 
   s.add_development_dependency("rake")
   s.add_development_dependency("rspec")

data/rails_best_practices.yml

@@ -1,6 +1,7 @@
 AddModelVirtualAttributeCheck: { }
 AlwaysAddDbIndexCheck: { }
 #CheckSaveReturnValueCheck: { }
+DefaultScopeIsEvilCheck: { }
 DryBundlerInCapistranoCheck: { }
 #HashSyntaxCheck: { }
 IsolateSeedDataCheck: { }

data/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+module RailsBestPractices
+  module Reviews
+    describe DefaultScopeIsEvilReview do
+      let(:runner) { Core::Runner.new(reviews: DefaultScopeIsEvilReview.new) }
+
+      it "should detect default_scope with -> syntax" do
+        content = <<-EOF
+        class User < ActiveRecord::Base
+          default_scope -> { order('created_at desc') }
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/models/user.rb:2 - default_scope is evil"
+      end
+
+      it "should detect default_scope with old syntax" do
+        content = <<-EOF
+        class User < ActiveRecord::Base
+          default_scope order('created_at desc')
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/models/user.rb:2 - default_scope is evil"
+      end
+
+      it "should not detect default_scope" do
+        content = <<-EOF
+        class User < ActiveRecord::Base
+          scope :default, -> { order('created_at desc') }
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
+    end
+  end
+end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.13.8
+  version: 1.14.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-21 00:00:00.000000000 Z
+date: 2013-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: code_analyzer
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -25,7 +25,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: ruby-progressbar
+  name: awesome_print
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: code_analyzer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -81,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: require_all
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -95,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: awesome_print
+  name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -238,6 +252,7 @@ files:
 - lib/rails_best_practices/reviews/add_model_virtual_attribute_review.rb
 - lib/rails_best_practices/reviews/always_add_db_index_review.rb
 - lib/rails_best_practices/reviews/check_save_return_value_review.rb
+- lib/rails_best_practices/reviews/default_scope_is_evil_review.rb
 - lib/rails_best_practices/reviews/dry_bundler_in_capistrano_review.rb
 - lib/rails_best_practices/reviews/hash_syntax_review.rb
 - lib/rails_best_practices/reviews/isolate_seed_data_review.rb
@@ -310,6 +325,7 @@ files:
 - spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
 - spec/rails_best_practices/reviews/check_save_return_value_spec.rb
+- spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb
 - spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb
 - spec/rails_best_practices/reviews/hash_syntax_review_spec.rb
 - spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb
@@ -420,6 +436,7 @@ test_files:
 - spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
 - spec/rails_best_practices/reviews/check_save_return_value_spec.rb
+- spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb
 - spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb
 - spec/rails_best_practices/reviews/hash_syntax_review_spec.rb
 - spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb