rails_best_practices 1.13.5 → 1.13.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c85e47e8a7e3168810ac545ece3d4dd9074c8325
-  data.tar.gz: 969e22d76e6815743f3971e61d495c875f37d4fc
+  metadata.gz: 0bd66b9f885d3de24877f8f671c8caa7ec05a0de
+  data.tar.gz: 4c82581c64139d752d9205689a5c0c805735d7fe
 SHA512:
-  metadata.gz: 4501aedb47b7c816495cda8936edd10a86d1f5025ac0dca814620d7a6cfedc7f7d3265540492d5fecdf332cd7e3cee908c08f5e1bef7b69b2d691e42acdb4c6f
-  data.tar.gz: d481948983897dc84fe224e4d2cea953123b9ad3838c0e0c619c24e93a78fe7c3973b68911871bbfaac95b06038f54a3db42a95efd2b2e435b59c617847cadcb
+  metadata.gz: cc478b2544c16dd600bd97c126567638429bf16d3781e15123128e2e7381303019a795c15af8a05821d52d4619beae550c98b18bb6ae1b3c2013d8c126efa800
+  data.tar.gz: 0ea6abf20e3c61a99c42c4ebd311bc4b31f5eaa5055d07cfce79c7fdda8cd8ed866c8d34414837b9c050cf948c9cfbf8c19d981a7ae0e55b135a339b8129d476

data/.gitignore

@@ -9,3 +9,4 @@ doc/**
 .yardoc/**
 rails_best_practices_output.*
 coverage/
+.coveralls.yml

data/.ruby-gemset

@@ -0,0 +1 @@
+rails_best_practices

data/.ruby-version

@@ -0,0 +1 @@
+ruby-2.0.0

data/lib/rails_best_practices/analyzer.rb

@@ -116,8 +116,9 @@ module RailsBestPractices
           files = file_ignore(files, pattern)
         end
 
-        files.unshift File.join(@path, "Capfile")
-        files.unshift File.join(@path, "Gemfile")
+        %w(Capfile Gemfile Gemfile.lock).each do |file|
+          files.unshift File.join(@path, file)
+        end
 
         files.compact
       end

data/lib/rails_best_practices/command.rb

@@ -44,7 +44,7 @@ OptionParser.new do |opts|
   opts.on("--with-textmate", "open file by textmate in html format") do
     options["with-textmate"] = true
   end
-  
+
   opts.on("--with-sublime", "open file by sublime in html format") do
     options["with-sublime"] = true
   end
@@ -122,6 +122,11 @@ OptionParser.new do |opts|
   opts.parse!
 end
 
+if ARGV.size > 0 && !File.exists?(ARGV.first)
+  puts "#{ARGV.first} doesn't exist"
+  exit 1
+end
+
 if options["generate"]
   RailsBestPractices::Analyzer.new(ARGV.first).generate
 else

data/lib/rails_best_practices/core/check.rb

@@ -15,8 +15,9 @@ module RailsBestPractices
       HELPER_FILES = /app\/helpers\/.*\.rb$/
       DEPLOY_FILES = /config\/deploy.*\.rb/
       CONFIG_FILES = /config\/(application|environment|environments\/.*)\.rb/
+      INITIALIZER_FILES = /config\/initializers\/.*\.rb/
       CAPFILE = /Capfile/
-      GEMFILE = /Gemfile/
+      GEMFILE_LOCK = /Gemfile\.lock/
 
       SKIP_FILES = /db\/schema.rb/
 

data/lib/rails_best_practices/core/gems.rb

@@ -2,6 +2,27 @@
 module RailsBestPractices
   module Core
     class Gems < Array
+      def has_gem?(gem_name)
+        self.find { |gem| gem.name == gem_name }
+      end
+
+      def gem_version(gem_name)
+        self.find { |gem| gem.name == gem_name }.try(:version)
+      end
+    end
+
+    # Gem info includes gem name and gem version
+    class Gem
+      attr_reader :name, :version
+
+      def initialize(name, version)
+        @name = name
+        @version = version
+      end
+
+      def to_s
+        "#{@name} (#{@version})"
+      end
     end
   end
 end

data/lib/rails_best_practices/core/klasses.rb

@@ -12,7 +12,7 @@ module RailsBestPractices
       end
     end
 
-    # Class info includes clas name, extend class name and module names.
+    # Class info includes class name, extend class name and module names.
     class Klass
       attr_reader :class_name, :extend_class_name
 

data/lib/rails_best_practices/core/runner.rb

@@ -49,7 +49,8 @@ module RailsBestPractices
         load_plugin_reviews if reviews.empty?
 
         @lexical_checker ||= CodeAnalyzer::CheckingVisitor::Plain.new(checkers: @lexicals)
-        @prepare_checker ||= CodeAnalyzer::CheckingVisitor::Default.new(checkers: @prepares)
+        @plain_prepare_checker ||= CodeAnalyzer::CheckingVisitor::Plain.new(checkers: @prepares.select { |checker| checker.is_a? Prepares::GemfilePrepare })
+        @default_prepare_checker ||= CodeAnalyzer::CheckingVisitor::Default.new(checkers: @prepares.select { |checker| !checker.is_a? Prepares::GemfilePrepare })
         @review_checker ||= CodeAnalyzer::CheckingVisitor::Default.new(checkers: @reviews)
       end
 
@@ -70,11 +71,13 @@ module RailsBestPractices
       # @param [String] filename of the file
       # @param [String] content of the file
       def prepare(filename, content)
-        @prepare_checker.check(filename, content)
+        @plain_prepare_checker.check(filename, content)
+        @default_prepare_checker.check(filename, content)
       end
 
       def after_prepare
-        @prepare_checker.after_check
+        @plain_prepare_checker.after_check
+        @default_prepare_checker.after_check
       end
 
       # review the file.

data/lib/rails_best_practices/lexicals/long_line_check.rb

@@ -5,6 +5,8 @@ module RailsBestPractices
   module Lexicals
     # Keep lines fewer than 80 characters.
     class LongLineCheck < Core::Check
+      interesting_files ALL_FILES
+
       def initialize(options = {})
         super()
         @max_line_length = options['max_line_length'] || 80

data/lib/rails_best_practices/lexicals/remove_tab_check.rb

@@ -7,6 +7,7 @@ module RailsBestPractices
     #
     # See the best practice details here http://rails-bestpractices.com/posts/81-remove-tab
     class RemoveTabCheck < Core::Check
+      interesting_files ALL_FILES
       url "http://rails-bestpractices.com/posts/81-remove-tab"
 
       # check if the content of file contains a tab.

data/lib/rails_best_practices/lexicals/remove_trailing_whitespace_check.rb

@@ -7,6 +7,7 @@ module RailsBestPractices
     #
     # See the best practice details here http://rails-bestpractices.com/posts/60-remove-trailing-whitespace
     class RemoveTrailingWhitespaceCheck < Core::Check
+      interesting_files ALL_FILES
       url "http://rails-bestpractices.com/posts/60-remove-trailing-whitespace"
 
       # check if the content of file contain a trailing whitespace.

data/lib/rails_best_practices/prepares/gemfile_prepare.rb

@@ -5,17 +5,17 @@ module RailsBestPractices
   module Prepares
     # Remember all gems in Gemfile
     class GemfilePrepare < Core::Check
-      interesting_nodes :command
-      interesting_files GEMFILE
+      interesting_files GEMFILE_LOCK
 
       def initialize
         @gems = Prepares.gems
       end
 
-      # Check all command nodes to get gem names.
-      add_callback :start_command do |node|
-        if "gem" == node.message.to_s
-          @gems << node.arguments.to_s
+      def check(filename, content)
+        content.split("\n").each do |line|
+          if line =~ /([^ ]+) \((\d.*)\)/
+            @gems << Core::Gem.new($1, $2)
+          end
         end
       end
     end

data/lib/rails_best_practices/prepares/initializer_prepare.rb

@@ -0,0 +1,31 @@
+# encoding: utf-8
+require 'rails_best_practices/core/check'
+
+module RailsBestPractices
+  module Prepares
+    # Check all initializers
+    class InitializerPrepare < Core::Check
+      interesting_nodes :method_add_arg, :class
+      interesting_files INITIALIZER_FILES
+
+      def initialize
+        @configs = Prepares.configs
+      end
+
+      # check if AR include ActiveModel::ForbiddenAttributesProtection
+      add_callback :start_method_add_arg do |node|
+        if include_forbidden_attributes_protection?(node)
+          @configs["railsbp.include_forbidden_attributes_protection"] = "true"
+        end
+      end
+
+      # check if the node is
+      #     ActiveRecord::Base.send(:include, ActiveModel::ForbiddenAttributesProtection)
+      def include_forbidden_attributes_protection?(node)
+        "ActiveRecord::Base" == node.receiver.to_s &&
+          "send" == node.message.to_s &&
+          ["include", "ActiveModel::ForbiddenAttributesProtection"] == node.arguments.all.map(&:to_s)
+      end
+    end
+  end
+end

data/lib/rails_best_practices/prepares.rb

@@ -7,6 +7,7 @@ require 'rails_best_practices/prepares/route_prepare'
 require 'rails_best_practices/prepares/helper_prepare'
 require 'rails_best_practices/prepares/config_prepare'
 require 'rails_best_practices/prepares/gemfile_prepare'
+require 'rails_best_practices/prepares/initializer_prepare'
 
 module RailsBestPractices
   module Prepares

data/lib/rails_best_practices/reviews/protect_mass_assignment_review.rb

@@ -20,7 +20,9 @@ module RailsBestPractices
       # we treat it as mass assignment by default.
       add_callback :start_class do |node|
         @mass_assignement = true
+        check_rails_version
         check_whitelist_attributes_config
+        check_include_forbidden_attributes_protection_config
       end
 
       # check if it is ActiveRecord::Base subclass and
@@ -52,12 +54,24 @@ module RailsBestPractices
       end
 
       private
+        def check_rails_version
+          if Prepares.gems.gem_version("rails").to_i > 3
+            @mass_assignement = false
+          end
+        end
+
         def check_whitelist_attributes_config
           if "true" == Prepares.configs["config.active_record.whitelist_attributes"]
             @whitelist_attributes = true
           end
         end
 
+        def check_include_forbidden_attributes_protection_config
+          if "true" == Prepares.configs["railsbp.include_forbidden_attributes_protection"]
+            @mass_assignement = false
+          end
+        end
+
         def check_rails_builtin(node)
           if @whitelist_attributes && [node.to_s, node.message.to_s].any? { |str| %w(attr_accessible attr_protected).include? str }
             @mass_assignement = false

data/lib/rails_best_practices/reviews/remove_unused_methods_in_controllers_review.rb

@@ -19,7 +19,7 @@ module RailsBestPractices
       include Exceptable
       include InheritedResourcesable
 
-      interesting_nodes :class, :command, :method_add_arg
+      interesting_nodes :class, :command, :method_add_arg, :assign
       interesting_files CONTROLLER_FILES, VIEW_FILES, HELPER_FILES
 
       INHERITED_RESOURCES_METHODS = %w(resource collection begin_of_association_chain build_resource)
@@ -77,6 +77,13 @@ module RailsBestPractices
         end
       end
 
+      # mark assignment as used, like current_user = @user
+      add_callback :start_assign do |node|
+        if :var_field == node.left_value.sexp_type
+          call_method "#{node.left_value}=", current_class_name
+        end
+      end
+
       # get all unused methods at the end of review process.
       add_callback :after_check do
         @routes.each do |route|

data/lib/rails_best_practices/reviews/remove_unused_methods_in_models_review.rb

@@ -98,7 +98,7 @@ module RailsBestPractices
             validate validate_each validate_on_create validate_on_update
             human_attribute_name
             assign_attributes
-            to_xml to_json to_param
+            to_xml to_json as_json to_param
             before_save before_create before_update before_destroy after_save after_create
             after_update after_destroy after_find after_initialize
             method_missing

data/lib/rails_best_practices/reviews/restrict_auto_generated_routes_review.rb

@@ -23,7 +23,6 @@ module RailsBestPractices
       RESOURCES_METHODS = RESOURCE_METHODS + ["index"]
 
       def initialize
-        super
         @namespaces = []
         @resource_controllers = []
       end
@@ -77,26 +76,12 @@ module RailsBestPractices
       private
         # check resources call, if the routes generated by resources does not exist in the controller.
         def check_resources(node)
-          controller_name = controller_name(node)
-          return unless Prepares.controllers.include? controller_name
-          resources_methods = resources_methods(node)
-          unless resources_methods.all? { |meth| Prepares.controller_methods.has_method?(controller_name, meth) }
-            prepared_method_names = Prepares.controller_methods.get_methods(controller_name).map(&:method_name)
-            only_methods = (resources_methods & prepared_method_names).map { |meth| ":#{meth}" }.join(", ")
-            add_error "restrict auto-generated routes #{friendly_route_name(node)} (only: [#{only_methods}])"
-          end
+          _check(node, RESOURCES_METHODS)
         end
 
         # check resource call, if the routes generated by resources does not exist in the controller.
         def check_resource(node)
-          controller_name = controller_name(node)
-          return unless Prepares.controllers.include? controller_name
-          resource_methods = resource_methods(node)
-          unless resource_methods.all? { |meth| Prepares.controller_methods.has_method?(controller_name, meth) }
-            prepared_method_names = Prepares.controller_methods.get_methods(controller_name).map(&:method_name)
-            only_methods = (resource_methods & prepared_method_names).map { |meth| ":#{meth}" }.join(", ")
-            add_error "restrict auto-generated routes #{friendly_route_name(node)} (only: [#{only_methods}])"
-          end
+          _check(node, RESOURCE_METHODS)
         end
 
         # get the controller name.
@@ -124,32 +109,23 @@ module RailsBestPractices
           end
         end
 
-        # get the route actions that should be generated by resources call.
-        def resources_methods(node)
-          methods = RESOURCES_METHODS
-
-          if option_with_hash(node)
-            option_node = node.arguments.all[1]
-            if hash_key_exist?(option_node, "only")
-              option_node.hash_value("only").to_s == "none" ? [] : Array(option_node.hash_value("only").to_object)
-            elsif hash_key_exist?(option_node, "except")
-              if option_node.hash_value("except").to_s == "all"
-                []
-              else
-                (methods - Array(option_node.hash_value("except").to_object))
-              end
-            else
-              methods
-            end
-          else
-            methods
+        def _check(node, methods)
+          controller_name = controller_name(node)
+          return unless Prepares.controllers.include? controller_name
+          _methods = _methods(node, methods)
+          unless _methods.all? { |meth| Prepares.controller_methods.has_method?(controller_name, meth) }
+            prepared_method_names = Prepares.controller_methods.get_methods(controller_name).map(&:method_name)
+            only_methods = (_methods & prepared_method_names).map { |meth| ":#{meth}" }
+            routes_message = if only_methods.size > 3
+                               "except: [#{(methods.map { |meth| ":" + meth } - only_methods).join(', ')}]"
+                             else
+                               "only: [#{only_methods.join(', ')}]"
+                             end
+            add_error "restrict auto-generated routes #{friendly_route_name(node)} (#{routes_message})"
           end
         end
 
-        # get the route actions that should be generated by resource call.
-        def resource_methods(node)
-          methods = RESOURCE_METHODS
-
+        def _methods(node, methods)
           if option_with_hash(node)
             option_node = node.arguments.all[1]
             if hash_key_exist?(option_node, "only")

data/lib/rails_best_practices/reviews/use_turbo_sprockets_rails3_review.rb

@@ -18,7 +18,7 @@ module RailsBestPractices
 
       # check command node to see if load 'deploy/assets'
       add_callback :start_command do |node|
-        if !Prepares.gems.include?("turbo-sprockets-rails3") && "load" == node.message.to_s && "deploy/assets" == node.arguments.to_s
+        if !Prepares.gems.has_gem?("turbo-sprockets-rails3") && "load" == node.message.to_s && "deploy/assets" == node.arguments.to_s
           add_error "speed up assets precompile with turbo-sprockets-rails3"
         end
       end

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.13.5"
+  VERSION = "1.13.8"
 end

data/spec/rails_best_practices/core/gems_spec.rb

@@ -3,5 +3,27 @@ require 'spec_helper'
 module RailsBestPractices::Core
   describe Gems do
     it { should be_a_kind_of Array }
+
+    let(:gems) { Gems.new }
+    before do
+      gems << Gem.new("rails", "4.0.0")
+      gems << Gem.new("mysql2", "0.2.0")
+    end
+
+    context "#has_gem?" do
+      it "has rails gem" do
+        expect(gems).to be_has_gem "rails"
+      end
+
+      it "hasn't sinatra gem" do
+        expect(gems).not_to be_has_gem "sinatra"
+      end
+    end
+
+    context "#gem_version" do
+      it "gets rails version" do
+        expect(gems.gem_version("rails")).to eq "4.0.0"
+      end
+    end
   end
 end

data/spec/rails_best_practices/prepares/gemfile_prepare_spec.rb

@@ -8,13 +8,25 @@ module RailsBestPractices
       context "gemfile" do
         it "should parse gems" do
           content =<<-EOF
-          source 'http://rubygems.org'
-          gem 'rails'
-          gem 'mysql2'
+GEM
+  remote: https://rubygems.org/
+  specs:
+    rails (3.2.13)
+      actionmailer (= 3.2.13)
+      actionpack (= 3.2.13)
+      activerecord (= 3.2.13)
+      activeresource (= 3.2.13)
+      activesupport (= 3.2.13)
+      bundler (~> 1.0)
+      railties (= 3.2.13)
+    mysql2 (0.3.12b6)
+
+PLATFORMS
+  ruby
           EOF
-          runner.prepare('Gemfile', content)
+          runner.prepare('Gemfile.lock', content)
           gems = Prepares.gems
-          gems.should == %w(rails mysql2)
+          gems.map(&:to_s).should == ["rails (3.2.13)", "mysql2 (0.3.12b6)"]
         end
       end
     end

data/spec/rails_best_practices/prepares/initializer_prepare_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+module RailsBestPractices
+  module Prepares
+    describe InitializerPrepare do
+      let(:runner) { Core::Runner.new(prepares: InitializerPrepare.new) }
+
+      context "initializers" do
+        it "should set include_forbidden_attributes_protection config" do
+          content =<<-EOF
+          class AR
+            ActiveRecord::Base.send(:include, ActiveModel::ForbiddenAttributesProtection)
+          end
+          EOF
+          runner.prepare('config/initializers/ar.rb', content)
+          configs = Prepares.configs
+          configs["railsbp.include_forbidden_attributes_protection"].should == "true"
+        end
+
+        it "should not set include_forbidden_attributes_protection config" do
+          content =<<-EOF
+          class AR
+          end
+          EOF
+          runner.prepare('config/initializers/ar.rb', content)
+          configs = Prepares.configs
+          configs["railsbp.include_forbidden_attributes_protection"].should be_nil
+        end
+      end
+    end
+  end
+end

data/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb

@@ -3,7 +3,8 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe ProtectMassAssignmentReview do
-      let(:runner) { Core::Runner.new(reviews: ProtectMassAssignmentReview.new) }
+      let(:runner) { Core::Runner.new(prepares: [Prepares::GemfilePrepare.new, Prepares::ConfigPrepare.new, Prepares::InitializerPrepare.new],
+                                      reviews: ProtectMassAssignmentReview.new) }
 
       it "should protect mass assignment" do
         content =<<-EOF
@@ -110,14 +111,65 @@ module RailsBestPractices
         runner.should have(0).errors
       end
 
-      it "should not protect mass assignment for strong_parameters" do
-        content =<<-EOF
-        class User < ActiveRecord::Base
-          include ActiveModel::ForbiddenAttributesProtection
+      context "strong_parameters" do
+        it "should not protect mass assignment for strong_parameters" do
+          content =<<-EOF
+          class User < ActiveRecord::Base
+            include ActiveModel::ForbiddenAttributesProtection
+          end
+          EOF
+          runner.review('app/models/user.rb', content)
+          runner.should have(0).errors
+        end
+
+        it "should not protect mass assignment for strong_parameters" do
+          content =<<-EOF
+          class AR
+            ActiveRecord::Base.send(:include, ActiveModel::ForbiddenAttributesProtection)
+          end
+          EOF
+          runner.prepare('config/initializers/ar.rb', content)
+          content =<<-EOF
+          class User < ActiveRecord::Base
+          end
+          EOF
+          runner.review('app/models/user.rb', content)
+          runner.should have(0).errors
+        end
+      end
+
+      context "rails 4" do
+        it "should not protect mass assignment for rails 4" do
+          content =<<-EOF
+  GEM
+    remote: http://rubygems.org
+    specs:
+      rails (4.0.0)
+          EOF
+          runner.prepare('Gemfile.lock', content)
+          content =<<-EOF
+          class User < ActiveRecord::Base
+          end
+          EOF
+          runner.review('app/models/user.rb', content)
+          runner.should have(0).errors
+        end
+
+        it "should protect mass assignment for rails 3" do
+          content =<<-EOF
+  GEM
+    remote: http://rubygems.org
+    specs:
+      rails (3.2.13)
+          EOF
+          runner.prepare('Gemfile.lock', content)
+          content =<<-EOF
+          class User < ActiveRecord::Base
+          end
+          EOF
+          runner.review('app/models/user.rb', content)
+          runner.should have(1).errors
         end
-        EOF
-        runner.review('app/models/user.rb', content)
-        runner.should have(0).errors
       end
     end
   end

data/spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb

@@ -186,6 +186,35 @@ module RailsBestPractices
         end
       end
 
+      context "assignment" do
+        it "should not remove unused methods if call in base class" do
+          content =<<-EOF
+          RailsBestPracticesCom::Application.routes.draw do
+            resources :user, only: :show do; end
+          end
+          EOF
+          runner.prepare('config/routes.rb', content)
+          application_content =<<-EOF
+          class ApplicationController
+            def current_user=(user); end
+          end
+          EOF
+          runner.prepare('app/controllers/application_controller.rb', application_content)
+          users_content =<<-EOF
+          class UsersController < ApplicationController
+            def show
+              current_user = @user
+            end
+          end
+          EOF
+          runner.prepare('app/controllers/users_controller.rb', users_content)
+          runner.review('app/controllers/application_controller.rb', application_content)
+          runner.review('app/controllers/users_controller.rb', users_content)
+          runner.after_review
+          runner.should have(0).errors
+        end
+      end
+
       context "helper_method" do
         it "should remove unused methods if helper method is not called" do
           content = <<-EOF

data/spec/rails_best_practices/reviews/restrict_auto_generated_routes_review_spec.rb

@@ -29,7 +29,7 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             runner.should have(1).errors
-            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (only: [:show, :new, :create, :edit, :update, :destroy])"
+            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])"
           end
 
           it "should not restrict auto-generated routes with only" do
@@ -81,7 +81,7 @@ module RailsBestPractices
               EOF
               runner.review('config/routes.rb', content)
               runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes articles (only: [:show, :new, :create, :edit, :update, :destroy])"
+              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes articles (except: [:index])"
             end
           end
 
@@ -111,7 +111,7 @@ module RailsBestPractices
               EOF
               runner.review('config/routes.rb', content)
               runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (only: [:show, :new, :create, :edit, :update, :destroy])"
+              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])"
             end
 
             it "should not restrict auto-generated routes with only" do
@@ -149,7 +149,7 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             runner.should have(1).errors
-            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (only: [:show, :new, :create, :edit, :update, :destroy])"
+            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])"
           end
 
           it "should not restrict auto-generated routes with only" do
@@ -181,7 +181,7 @@ module RailsBestPractices
               EOF
               runner.review('config/routes.rb', content)
               runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes articles (only: [:show, :new, :create, :edit, :update, :destroy])"
+              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes articles (except: [:index])"
             end
           end
 
@@ -208,7 +208,7 @@ module RailsBestPractices
               EOF
               runner.review('config/routes.rb', content)
               runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:3 - restrict auto-generated routes admin/comments (only: [:show, :new, :create, :edit, :update, :destroy])"
+              runner.errors[0].to_s.should == "config/routes.rb:3 - restrict auto-generated routes admin/comments (except: [:index])"
             end
           end
 
@@ -238,7 +238,7 @@ module RailsBestPractices
               EOF
               runner.review('config/routes.rb', content)
               runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (only: [:show, :new, :create, :edit, :update, :destroy])"
+              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])"
             end
 
             it "should not restrict auto-generated routes with only" do
@@ -291,7 +291,7 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             runner.should have(1).errors
-            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes account (only: [:show, :new, :create, :edit, :update])"
+            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes account (except: [:destroy])"
           end
 
           it "should not restrict auto-generated routes with only" do
@@ -324,7 +324,7 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             runner.should have(1).errors
-            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes account (only: [:show, :new, :create, :edit, :update])"
+            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes account (except: [:destroy])"
           end
 
           it "should not restrict auto-generated routes with only" do

data/spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb

@@ -23,13 +23,22 @@ module RailsBestPractices
 
       it "should not use turbo-sprockets-rails3 with turbo-sprockets-rails3 gem" do
         content = <<-EOF
-        source "http://rubygems.org"
-        gem "rails"
-        group :assets do
-          gem "turbo-sprockets-rails3"
-        end
+GEM
+  remote: http://rubygems.org
+  specs:
+    rails (3.2.13)
+      actionmailer (= 3.2.13)
+      actionpack (= 3.2.13)
+      activerecord (= 3.2.13)
+      activeresource (= 3.2.13)
+      activesupport (= 3.2.13)
+      bundler (~> 1.0)
+      railties (= 3.2.13)
+    turbo-sprockets-rails3 (0.3.6)
+      railties (> 3.2.8, < 4.0.0)
+      sprockets (>= 2.0.0)
         EOF
-        runner.prepare('Gemfile', content)
+        runner.prepare('Gemfile.lock', content)
         content = <<-EOF
         load 'deploy' if respond_to?(:namespace)
         load 'deploy/assets'
@@ -51,4 +60,3 @@ module RailsBestPractices
     end
   end
 end
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.13.5
+  version: 1.13.8
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-06 00:00:00.000000000 Z
+date: 2013-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_analyzer
@@ -186,11 +186,11 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .coveralls.yml
 - .gemtest
 - .gitignore
 - .rspec
-- .rvmrc
+- .ruby-gemset
+- .ruby-version
 - .travis.yml
 - Gemfile
 - Guardfile
@@ -229,6 +229,7 @@ files:
 - lib/rails_best_practices/prepares/controller_prepare.rb
 - lib/rails_best_practices/prepares/gemfile_prepare.rb
 - lib/rails_best_practices/prepares/helper_prepare.rb
+- lib/rails_best_practices/prepares/initializer_prepare.rb
 - lib/rails_best_practices/prepares/mailer_prepare.rb
 - lib/rails_best_practices/prepares/model_prepare.rb
 - lib/rails_best_practices/prepares/route_prepare.rb
@@ -301,6 +302,7 @@ files:
 - spec/rails_best_practices/prepares/controller_prepare_spec.rb
 - spec/rails_best_practices/prepares/gemfile_prepare_spec.rb
 - spec/rails_best_practices/prepares/helper_prepare_spec.rb
+- spec/rails_best_practices/prepares/initializer_prepare_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
 - spec/rails_best_practices/prepares/model_prepare_spec.rb
 - spec/rails_best_practices/prepares/route_prepare_spec.rb
@@ -410,6 +412,7 @@ test_files:
 - spec/rails_best_practices/prepares/controller_prepare_spec.rb
 - spec/rails_best_practices/prepares/gemfile_prepare_spec.rb
 - spec/rails_best_practices/prepares/helper_prepare_spec.rb
+- spec/rails_best_practices/prepares/initializer_prepare_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
 - spec/rails_best_practices/prepares/model_prepare_spec.rb
 - spec/rails_best_practices/prepares/route_prepare_spec.rb

data/.coveralls.yml

@@ -1 +0,0 @@
-repo_token: HdiJjr0c7NCGp2GIL3areCAENLRMT21Er

data/.rvmrc

@@ -1,2 +0,0 @@
-rvm_gemset_create_on_use_flag=1
-rvm gemset use rails_best_practices