rails_best_practices 1.13.0 → 1.13.1

data/.rvmrc

@@ -1,2 +1,2 @@
 rvm_gemset_create_on_use_flag=1
-rvm gemset use ruby-1.9.3@rails_best_practices
+rvm gemset use rails_best_practices

data/lib/rails_best_practices/reviews/check_save_return_value_review.rb

@@ -15,11 +15,11 @@ module RailsBestPractices
     #   Check all "save" calls to check the return value is used by a node we have visited.
     class CheckSaveReturnValueReview < Review
       include Classable
-      interesting_nodes :call, :command_call, :method_add_arg, :if, :ifop, :unless, :assign, :binary
+      interesting_nodes :call, :command_call, :method_add_arg, :if, :ifop, :elsif, :unless, :assign, :binary
       interesting_files ALL_FILES
       url "http://rails-bestpractices.com/posts/703-check-the-return-value-of-save-otherwise-use-save"
 
-      add_callback :start_if, :start_ifop, :start_unless do |node|
+      add_callback :start_if, :start_ifop, :start_elsif, :start_unless do |node|
         @used_return_value_of = node.conditional_statement.all_conditions
       end
 

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.13.0"
+  VERSION = "1.13.1"
 end

data/spec/rails_best_practices/reviews/check_save_return_value_spec.rb

@@ -50,6 +50,25 @@ module RailsBestPractices
           runner.should have(0).errors
         end
 
+        it "should allow save return value used in elsif" do
+          content =<<-EOF
+          def my_method
+            post = Posts.new do |p|
+              p.title = "foo"
+            end
+            if current_user
+              "YES"
+            elsif post.save
+              "OK"
+            else
+              raise "could not save"
+            end
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(0).errors
+        end
+
         it "should allow save return value used in unless" do
           content =<<-EOF
           def my_method

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.13.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-23 00:00:00.000000000 Z
+date: 2012-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_analyzer
@@ -386,7 +386,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2112599322304454342
+      hash: 4362184298328338159
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: