rails_best_practices 1.12.0 → 1.13.0

data/.rvmrc

@@ -1,2 +1,2 @@
 rvm_gemset_create_on_use_flag=1
-rvm gemset use ruby-1.9.3-p194@rails_best_practices
+rvm gemset use ruby-1.9.3@rails_best_practices

data/README.md

@@ -116,6 +116,7 @@ Now you can customize this configuration file, the default configuration is as f
 
     AddModelVirtualAttributeCheck: { }
     AlwaysAddDbIndexCheck: { }
+    CheckSaveReturnValueCheck: { }
     DryBundlerInCapistranoCheck: { }
     #HashSyntaxCheck: { }
     IsolateSeedDataCheck: { }
@@ -152,6 +153,7 @@ Now you can customize this configuration file, the default configuration is as f
     UseQueryAttributeCheck: { }
     UseSayWithTimeInMigrationsCheck: { }
     UseScopeAccessCheck: { }
+    UseTurboSprocketsRails3Check: { }
 
 You can remove or comment one review to disable it, and you can change the options.
 
@@ -165,6 +167,7 @@ Move code from Controller to Model
 4. Add model virtual attribute
 5. Replace complex creation with factory method
 6. Move model logic into the Model
+7. Check return value of "save!"
 
 RESTful Conventions
 
@@ -215,6 +218,7 @@ View
 Deployment
 
 1. Dry bundler in capistrano
+2. Speed up assets precompile with turbo-sprockets-rails3
 
 Other
 

data/lib/rails_best_practices/analyzer.rb

@@ -114,6 +114,9 @@ module RailsBestPractices
           files = file_ignore(files, pattern)
         end
 
+        files.unshift File.join(@path, "Capfile")
+        files.unshift File.join(@path, "Gemfile")
+
         files.compact
       end
     end

data/lib/rails_best_practices/core.rb

@@ -13,5 +13,6 @@ require 'rails_best_practices/core/controllers'
 require 'rails_best_practices/core/helpers'
 require 'rails_best_practices/core/routes'
 require 'rails_best_practices/core/configs'
+require 'rails_best_practices/core/gems'
 
 require 'rails_best_practices/core_ext/erubis'

data/lib/rails_best_practices/core/check.rb

@@ -15,6 +15,8 @@ module RailsBestPractices
       HELPER_FILES = /app\/helpers\/.*\.rb$/
       DEPLOY_FILES = /config\/deploy.*\.rb/
       CONFIG_FILES = /config\/(application|environment|environments\/.*)\.rb/
+      CAPFILE = /Capfile/
+      GEMFILE = /Gemfile/
 
       SKIP_FILES = /db\/schema.rb/
 

data/lib/rails_best_practices/core/gems.rb

@@ -0,0 +1,7 @@
+# encoding: utf-8
+module RailsBestPractices
+  module Core
+    class Gems < Array
+    end
+  end
+end

data/lib/rails_best_practices/core/routes.rb

@@ -19,6 +19,14 @@ module RailsBestPractices
 
       def initialize(namespaces, controller_name, action_name)
         @namespaces = namespaces
+
+        # mappings can be specified by e.g.
+        #   post 'some/:pattern' => 'controller#action'
+        if action_name =~ /^(\w+)#(\w+)$/
+          controller_name = $1
+          action_name = $2
+        end
+
         if controller_name
           entities = controller_name.split('/')
           @namespaces += entities[0..-2] if entities.size > 1

data/lib/rails_best_practices/core/runner.rb

@@ -153,7 +153,7 @@ module RailsBestPractices
           checks_from_config.inject([]) { |active_checks, check|
             begin
               check_name, options = *check
-              klass = RailsBestPractices::Reviews.const_get(check_name.gsub(/Check/, 'Review'))
+              klass = RailsBestPractices::Reviews.const_get(check_name.gsub(/Check$/, 'Review'))
               active_checks << (options.empty? ? klass.new : klass.new(options))
             rescue
               # the check does not exist in the Reviews namepace.

data/lib/rails_best_practices/prepares.rb

@@ -6,6 +6,7 @@ require 'rails_best_practices/prepares/controller_prepare'
 require 'rails_best_practices/prepares/route_prepare'
 require 'rails_best_practices/prepares/helper_prepare'
 require 'rails_best_practices/prepares/config_prepare'
+require 'rails_best_practices/prepares/gemfile_prepare'
 
 module RailsBestPractices
   module Prepares
@@ -58,6 +59,10 @@ module RailsBestPractices
         @configs ||= Core::Configs.new
       end
 
+      def gems
+        @gems ||= Core::Gems.new
+      end
+
       # Clear all prepare objects.
       def clear
         instance_variables.each do |instance_variable|

data/lib/rails_best_practices/prepares/config_prepare.rb

@@ -3,6 +3,7 @@ require 'rails_best_practices/core/check'
 
 module RailsBestPractices
   module Prepares
+    # Remember all configs
     class ConfigPrepare < Core::Check
       interesting_nodes :assign
       interesting_files CONFIG_FILES
@@ -11,6 +12,7 @@ module RailsBestPractices
         @configs = Prepares.configs
       end
 
+      # check assignments to config
       add_callback :start_assign do |node|
         if node.left_value.grep_node(sexp_type: [:vcall, :var_ref], to_s: "config").present?
           @configs[node.left_value.to_s] = node.right_value.to_s

data/lib/rails_best_practices/prepares/gemfile_prepare.rb

@@ -0,0 +1,23 @@
+# encoding: utf-8
+require 'rails_best_practices/core/check'
+
+module RailsBestPractices
+  module Prepares
+    # Remember all gems in Gemfile
+    class GemfilePrepare < Core::Check
+      interesting_nodes :command
+      interesting_files GEMFILE
+
+      def initialize
+        @gems = Prepares.gems
+      end
+
+      # Check all command nodes to get gem names.
+      add_callback :start_command do |node|
+        if "gem" == node.message.to_s
+          @gems << node.arguments.to_s
+        end
+      end
+    end
+  end
+end

data/lib/rails_best_practices/reviews.rb

@@ -34,3 +34,5 @@ require 'rails_best_practices/reviews/protect_mass_assignment_review'
 require 'rails_best_practices/reviews/use_parentheses_in_method_def_review'
 require 'rails_best_practices/reviews/hash_syntax_review'
 require 'rails_best_practices/reviews/not_rescue_exception_review'
+require 'rails_best_practices/reviews/check_save_return_value_review'
+require 'rails_best_practices/reviews/use_turbo_sprockets_rails3_review'

data/lib/rails_best_practices/reviews/check_save_return_value_review.rb

@@ -0,0 +1,78 @@
+# encoding: utf-8
+require 'rails_best_practices/reviews/review'
+
+module RailsBestPractices
+  module Reviews
+    # Review all code to make sure we either check the return value of "save"
+    # or use "save!"
+    #
+    # See the best practice details here http://rails-bestpractices.com/posts/703-check-the-return-value-of-save-otherwise-use-save
+    #
+    # Implementation:
+    #
+    # Review process:
+    #   Track which nodes are used by 'if', 'unless', '&&' nodes etc. as we pass them by.
+    #   Check all "save" calls to check the return value is used by a node we have visited.
+    class CheckSaveReturnValueReview < Review
+      include Classable
+      interesting_nodes :call, :command_call, :method_add_arg, :if, :ifop, :unless, :assign, :binary
+      interesting_files ALL_FILES
+      url "http://rails-bestpractices.com/posts/703-check-the-return-value-of-save-otherwise-use-save"
+
+      add_callback :start_if, :start_ifop, :start_unless do |node|
+        @used_return_value_of = node.conditional_statement.all_conditions
+      end
+
+      add_callback :start_assign do |node|
+        @used_return_value_of = node.right_value
+      end
+
+      add_callback :start_binary do |node|
+        # Consider anything used in an expression like "A or B" as used
+        if %w(&& || and or).include?(node[2].to_s)
+          all_conditions = node.all_conditions
+          # if our current binary is a subset of the @used_return_value_of
+          # then don't overwrite it
+          already_included = @used_return_value_of &&
+            (all_conditions - @used_return_value_of).empty?
+
+          @used_return_value_of = node.all_conditions unless already_included
+        end
+      end
+
+      def return_value_is_used? node
+        return false unless @used_return_value_of
+        node == @used_return_value_of or @used_return_value_of.include?(node)
+      end
+
+      def model_classnames
+        @model_classnames ||= models.map(&:to_s)
+      end
+
+      add_callback :start_call, :start_command_call, :start_method_add_arg do |node|
+        unless @already_checked == node
+          message = node.message.to_s
+          if ['save', 'update_attributes'].include? message
+            unless return_value_is_used? node
+              add_error "check '#{message}' return value or use '#{message}!'"
+            end
+          elsif message == 'create'
+            # We're only interested in 'create' calls on model classes:
+            possible_receiver_classes = [node.receiver.to_s] + classable_modules.map do |mod|
+                "#{mod}::#{node.receiver.to_s}"
+              end
+            unless (possible_receiver_classes & model_classnames).empty?
+              add_error "use 'create!' instead of 'create' as the latter may not always save"
+            end
+          end
+
+          if node.sexp_type == :method_add_arg
+            @already_checked = node[1]
+          end
+        end
+      end
+    end
+  end
+end
+
+

data/lib/rails_best_practices/reviews/use_turbo_sprockets_rails3_review.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+require 'rails_best_practices/reviews/review'
+
+module RailsBestPractices
+  module Reviews
+    # Prepare Gemfile and review Capfile file to make sure using turbo-sprocket-rails3
+    #
+    # See the best practice details here http://rails-bestpractices.com/posts/704-speed-up-assets-precompile-with-turbo-sprockets-rails3
+    #
+    # Implementation:
+    #
+    # Review process:
+    #   only check if turbo-sprockets-rails3 gem is not used and load 'deploy/assets' in Capfile.
+    class UseTurboSprocketsRails3Review < Review
+      interesting_nodes :command
+      interesting_files CAPFILE
+      url "http://rails-bestpractices.com/posts/704-speed-up-assets-precompile-with-turbo-sprockets-rails3"
+
+      # check command node to see if load 'deploy/assets'
+      add_callback :start_command do |node|
+        if !Prepares.gems.include?("turbo-sprockets-rails3") && "load" == node.message.to_s && "deploy/assets" == node.arguments.to_s
+          add_error "speed up assets precompile with turbo-sprockets-rails3"
+        end
+      end
+    end
+  end
+end

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.12.0"
+  VERSION = "1.13.0"
 end

data/rails_best_practices.yml

@@ -1,5 +1,6 @@
 AddModelVirtualAttributeCheck: { }
 AlwaysAddDbIndexCheck: { }
+CheckSaveReturnValueCheck: { }
 DryBundlerInCapistranoCheck: { }
 #HashSyntaxCheck: { }
 IsolateSeedDataCheck: { }
@@ -36,3 +37,4 @@ UseObserverCheck: { }
 UseQueryAttributeCheck: { }
 UseSayWithTimeInMigrationsCheck: { }
 UseScopeAccessCheck: { }
+UseTurboSprocketsRails3Check: { }

data/spec/rails_best_practices/core/gems_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+module RailsBestPractices::Core
+  describe Gems do
+    it { should be_a_kind_of Array }
+  end
+end

data/spec/rails_best_practices/prepares/gemfile_prepare_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+module RailsBestPractices
+  module Prepares
+    describe GemfilePrepare do
+      let(:runner) { Core::Runner.new(prepares: GemfilePrepare.new) }
+
+      context "gemfile" do
+        it "should parse gems" do
+          content =<<-EOF
+          source 'http://rubygems.org'
+          gem 'rails'
+          gem 'mysql2'
+          EOF
+          runner.prepare('Gemfile', content)
+          gems = Prepares.gems
+          gems.should == %w(rails mysql2)
+        end
+      end
+    end
+  end
+end

data/spec/rails_best_practices/prepares/route_prepare_spec.rb

@@ -354,6 +354,28 @@ module RailsBestPractices
             routes.size.should == 0
           end
 
+          it "should add resources routes with members" do
+            content =<<-EOF
+            RailsBestPracticesCom::Application.routes.draw do
+              namespace :admin do
+                resources :posts, :only => [:edit, :update] do
+                  member do
+                    post 'link_to/:other_id' => 'posts#link_to_post'
+                    post 'extra_update' => 'posts#extra_update'
+                  end
+                end
+              end
+            end
+            EOF
+            runner.prepare('config/routes.rb', content)
+            routes = Prepares.routes
+            routes.map(&:to_s).should == [
+              "Admin::PostsController#edit",
+              "Admin::PostsController#update",
+              "Admin::PostsController#link_to_post",
+              "Admin::PostsController#extra_update"]
+          end
+
           it "should add connect route" do
             content =<<-EOF
             ActionController::Routing::Routes.draw do |map|

data/spec/rails_best_practices/reviews/check_save_return_value_spec.rb

@@ -0,0 +1,198 @@
+require 'spec_helper'
+
+module RailsBestPractices
+  module Reviews
+    describe CheckSaveReturnValueReview do
+      let(:runner) { Core::Runner.new(reviews: CheckSaveReturnValueReview.new) }
+
+      describe "check_save_return_value" do
+        it "should warn you if you fail to check save return value" do
+          content =<<-EOF
+          def my_method
+            post = Posts.new do |p|
+              p.title = "foo"
+            end
+            post.save
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:5 - check 'save' return value or use 'save!'"
+        end
+
+        it "should allow save return value assigned to var" do
+          content =<<-EOF
+          def my_method
+            post = Posts.new do |p|
+              p.title = "foo"
+            end
+            check_this_later = post.save
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(0).errors
+        end
+
+        it "should allow save return value used in if" do
+          content =<<-EOF
+          def my_method
+            post = Posts.new do |p|
+              p.title = "foo"
+            end
+            if post.save
+              "OK"
+            else
+              raise "could not save"
+            end
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(0).errors
+        end
+
+        it "should allow save return value used in unless" do
+          content =<<-EOF
+          def my_method
+            unless @post.save
+              raise "could not save"
+            end
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(0).errors
+        end
+
+        it "should allow save return value used in unless with &&" do
+          content =<<-EOF
+          def my_method
+            unless some_method(1) && other_method(2) && @post.save
+              raise "could not save"
+            end
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(0).errors
+        end
+
+        it "should allow save!" do
+          content =<<-EOF
+          def my_method
+            post = Posts.new do |p|
+              p.title = "foo"
+            end
+            post.save!
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(0).errors
+        end
+
+        it "should warn you if you fail to check update_attributes return value" do
+          content =<<-EOF
+          def my_method
+            @post.update_attributes params
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:2 - check 'update_attributes' return value or use 'update_attributes!'"
+        end
+
+        it "should allow update_attributes if return value is checked" do
+          content =<<-EOF
+          def my_method
+            @post.update_attributes(params) or raise "failed to save"
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(0).errors
+        end
+
+        it "is not clever enough to allow update_attributes if value is returned from method" do
+          # This review is not clever enough to do a full liveness analysis
+          # of whether the returned value is used in all cases.
+          content =<<-EOF
+          class PostsController
+            def update
+              @post = Post.find params(:id)
+              if update_post
+                redirect_to view_post_path post
+              else
+                raise "post not saved"
+              end
+            end
+
+            def update_post
+              @post.update_attributes(params)
+            end
+          end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:12 - check 'update_attributes' return value or use 'update_attributes!'"
+        end
+
+        it "should warn you if you use create which is always unsafe" do
+          content =<<-EOF
+          class Post < ActiveRecord::Base
+          end
+          EOF
+          runner.prepare('app/models/post.rb', content)
+          content =<<-EOF
+          def my_method
+            if post = Post.create(params)
+              # post may or may not be saved here!
+              redirect_to view_post_path post
+            end
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:2 - use 'create!' instead of 'create' as the latter may not always save"
+        end
+
+        it "should warn you if you use create with a block which is always unsafe" do
+          content =<<-EOF
+          module Blog
+            class Post < ActiveRecord::Base
+            end
+          end
+          EOF
+          runner.prepare('app/models/blog/post.rb', content)
+          content =<<-EOF
+          module Blog
+            class PostsHelper
+              def my_method
+                post = Post.create do |p|
+                  p.title = 'new post'
+                end
+                if post
+                  # post may or may not be saved here!
+                  redirect_to view_post_path post
+                end
+              end
+            end
+          end
+          EOF
+          runner.review('app/helpers/blog/posts_helper.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/helpers/blog/posts_helper.rb:4 - use 'create!' instead of 'create' as the latter may not always save"
+        end
+
+        it "allows create called on non-model classes" do
+          content =<<-EOF
+          def my_method
+            pk12 = OpenSSL::PKCS12.create(
+              "", # password
+              descr, # friendly name
+              key,
+              cert)
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.errors.map(&:to_s).should == []
+        end
+      end
+    end
+  end
+end

data/spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb

@@ -12,13 +12,20 @@ module RailsBestPractices
         it "should remove unused methods" do
           content =<<-EOF
           RailsBestPracticesCom::Application.routes.draw do
-            resources :posts
+            resources :posts do
+              member do
+                post 'link_to/:other_id' => 'posts#link_to_post'
+                post 'extra_update' => 'posts#extra_update'
+              end
+            end
           end
           EOF
           runner.prepare('config/routes.rb', content)
           content =<<-EOF
           class PostsController < ActiveRecord::Base
             def show; end
+            def extra_update; end
+            def link_to_post; end
             protected
             def load_post; end
             private
@@ -29,8 +36,8 @@ module RailsBestPractices
           runner.review('app/controllers/posts_controller.rb', content)
           runner.after_review
           runner.should have(2).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:4 - remove unused methods (PostsController#load_post)"
-          runner.errors[1].to_s.should == "app/controllers/posts_controller.rb:6 - remove unused methods (PostsController#load_user)"
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - remove unused methods (PostsController#load_post)"
+          runner.errors[1].to_s.should == "app/controllers/posts_controller.rb:8 - remove unused methods (PostsController#load_user)"
         end
 
         it "should not remove unused methods for before_filter" do

data/spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+module RailsBestPractices
+  module Reviews
+    describe UseTurboSprocketsRails3Review do
+      let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: UseTurboSprocketsRails3Review.new) }
+
+      it "should use turbo-sprockets-rails3" do
+        content = <<-EOF
+        source "http://rubygems.org"
+        gem "rails"
+        EOF
+        runner.prepare('Gemfile', content)
+        content = <<-EOF
+        load 'deploy' if respond_to?(:namespace)
+        load 'deploy/assets'
+        load 'config/deploy'
+        EOF
+        runner.review('Capfile', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "Capfile:2 - speed up assets precompile with turbo-sprockets-rails3"
+      end
+
+      it "should not use turbo-sprockets-rails3 with turbo-sprockets-rails3 gem" do
+        content = <<-EOF
+        source "http://rubygems.org"
+        gem "rails"
+        group :assets do
+          gem "turbo-sprockets-rails3"
+        end
+        EOF
+        runner.prepare('Gemfile', content)
+        content = <<-EOF
+        load 'deploy' if respond_to?(:namespace)
+        load 'deploy/assets'
+        load 'config/deploy'
+        EOF
+        runner.review('Capfile', content)
+        runner.should have(0).errors
+      end
+
+      it "should not use turbo-sprockets-rails3 without deploy/assets" do
+        content = <<-EOF
+        load 'deploy' if respond_to?(:namespace)
+        #load 'deploy/assets'
+        load 'config/deploy'
+        EOF
+        runner.review('Capfile', content)
+        runner.should have(0).errors
+      end
+    end
+  end
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.13.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-02 00:00:00.000000000 Z
+date: 2012-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_analyzer
@@ -232,6 +232,7 @@ files:
 - lib/rails_best_practices/core/configs.rb
 - lib/rails_best_practices/core/controllers.rb
 - lib/rails_best_practices/core/error.rb
+- lib/rails_best_practices/core/gems.rb
 - lib/rails_best_practices/core/helpers.rb
 - lib/rails_best_practices/core/klasses.rb
 - lib/rails_best_practices/core/mailers.rb
@@ -250,6 +251,7 @@ files:
 - lib/rails_best_practices/prepares.rb
 - lib/rails_best_practices/prepares/config_prepare.rb
 - lib/rails_best_practices/prepares/controller_prepare.rb
+- lib/rails_best_practices/prepares/gemfile_prepare.rb
 - lib/rails_best_practices/prepares/helper_prepare.rb
 - lib/rails_best_practices/prepares/mailer_prepare.rb
 - lib/rails_best_practices/prepares/model_prepare.rb
@@ -258,6 +260,7 @@ files:
 - lib/rails_best_practices/reviews.rb
 - lib/rails_best_practices/reviews/add_model_virtual_attribute_review.rb
 - lib/rails_best_practices/reviews/always_add_db_index_review.rb
+- lib/rails_best_practices/reviews/check_save_return_value_review.rb
 - lib/rails_best_practices/reviews/dry_bundler_in_capistrano_review.rb
 - lib/rails_best_practices/reviews/hash_syntax_review.rb
 - lib/rails_best_practices/reviews/isolate_seed_data_review.rb
@@ -292,6 +295,7 @@ files:
 - lib/rails_best_practices/reviews/use_query_attribute_review.rb
 - lib/rails_best_practices/reviews/use_say_with_time_in_migrations_review.rb
 - lib/rails_best_practices/reviews/use_scope_access_review.rb
+- lib/rails_best_practices/reviews/use_turbo_sprockets_rails3_review.rb
 - lib/rails_best_practices/version.rb
 - rails_best_practices.gemspec
 - rails_best_practices.yml
@@ -302,6 +306,7 @@ files:
 - spec/rails_best_practices/core/configs_spec.rb
 - spec/rails_best_practices/core/controllers_spec.rb
 - spec/rails_best_practices/core/error_spec.rb
+- spec/rails_best_practices/core/gems_spec.rb
 - spec/rails_best_practices/core/helpers_spec.rb
 - spec/rails_best_practices/core/klasses_spec.rb
 - spec/rails_best_practices/core/mailers_spec.rb
@@ -318,6 +323,7 @@ files:
 - spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb
 - spec/rails_best_practices/prepares/config_prepare_spec.rb
 - spec/rails_best_practices/prepares/controller_prepare_spec.rb
+- spec/rails_best_practices/prepares/gemfile_prepare_spec.rb
 - spec/rails_best_practices/prepares/helper_prepare_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
 - spec/rails_best_practices/prepares/model_prepare_spec.rb
@@ -325,6 +331,7 @@ files:
 - spec/rails_best_practices/prepares/schema_prepare_spec.rb
 - spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
+- spec/rails_best_practices/reviews/check_save_return_value_spec.rb
 - spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb
 - spec/rails_best_practices/reviews/hash_syntax_review_spec.rb
 - spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb
@@ -358,6 +365,7 @@ files:
 - spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb
 - spec/rails_best_practices/reviews/use_scope_access_review_spec.rb
+- spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb
 - spec/spec_helper.rb
 homepage: http://rails-bestpractices.com
 licenses: []
@@ -378,7 +386,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 876012672984771359
+      hash: 2112599322304454342
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -398,6 +406,7 @@ test_files:
 - spec/rails_best_practices/core/configs_spec.rb
 - spec/rails_best_practices/core/controllers_spec.rb
 - spec/rails_best_practices/core/error_spec.rb
+- spec/rails_best_practices/core/gems_spec.rb
 - spec/rails_best_practices/core/helpers_spec.rb
 - spec/rails_best_practices/core/klasses_spec.rb
 - spec/rails_best_practices/core/mailers_spec.rb
@@ -414,6 +423,7 @@ test_files:
 - spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb
 - spec/rails_best_practices/prepares/config_prepare_spec.rb
 - spec/rails_best_practices/prepares/controller_prepare_spec.rb
+- spec/rails_best_practices/prepares/gemfile_prepare_spec.rb
 - spec/rails_best_practices/prepares/helper_prepare_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
 - spec/rails_best_practices/prepares/model_prepare_spec.rb
@@ -421,6 +431,7 @@ test_files:
 - spec/rails_best_practices/prepares/schema_prepare_spec.rb
 - spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
+- spec/rails_best_practices/reviews/check_save_return_value_spec.rb
 - spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb
 - spec/rails_best_practices/reviews/hash_syntax_review_spec.rb
 - spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb
@@ -454,4 +465,5 @@ test_files:
 - spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb
 - spec/rails_best_practices/reviews/use_scope_access_review_spec.rb
+- spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb
 - spec/spec_helper.rb