rails_best_practices 1.0.1 → 1.1.0
Sign up to get free protection for your applications and to get access to all the features.
- data/.gitignore +0 -1
- data/.travis.yml +1 -0
- data/Gemfile +2 -0
- data/Gemfile.lock +45 -0
- data/README.md +2 -0
- data/assets/result.html.erb +78 -0
- data/lib/rails_best_practices.rb +5 -4
- data/lib/rails_best_practices/core.rb +2 -0
- data/lib/rails_best_practices/core/check.rb +27 -1
- data/lib/rails_best_practices/core/controllers.rb +7 -0
- data/lib/rails_best_practices/core/methods.rb +26 -0
- data/lib/rails_best_practices/core/runner.rb +3 -1
- data/lib/rails_best_practices/core_ext/sexp.rb +33 -8
- data/lib/rails_best_practices/prepares.rb +13 -0
- data/lib/rails_best_practices/prepares/controller_prepare.rb +74 -0
- data/lib/rails_best_practices/prepares/mailer_prepare.rb +3 -2
- data/lib/rails_best_practices/prepares/model_prepare.rb +12 -10
- data/lib/rails_best_practices/reviews.rb +1 -0
- data/lib/rails_best_practices/reviews/needless_deep_nesting_review.rb +1 -1
- data/lib/rails_best_practices/reviews/not_use_default_route_review.rb +1 -1
- data/lib/rails_best_practices/reviews/overuse_route_customizations_review.rb +1 -1
- data/lib/rails_best_practices/reviews/restrict_auto_generated_routes_review.rb +149 -0
- data/lib/rails_best_practices/version.rb +1 -1
- data/rails_best_practices.gemspec +3 -3
- data/rails_best_practices.yml +1 -0
- data/spec/rails_best_practices/core/controllers_spec.rb +5 -0
- data/spec/rails_best_practices/core/methods_spec.rb +22 -0
- data/spec/rails_best_practices/core_ext/sexp_spec.rb +28 -1
- data/spec/rails_best_practices/prepares/controller_prepare_spec.rb +92 -0
- data/spec/rails_best_practices/prepares/model_prepare_spec.rb +22 -0
- data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb +4 -4
- data/spec/rails_best_practices/reviews/restrict_auto_generated_routes_review_spec.rb +334 -0
- data/spec/spec_helper.rb +6 -0
- metadata +27 -13
- data/assets/result.html.haml +0 -63
data/assets/result.html.haml
DELETED
|
@@ -1,63 +0,0 @@
|
|
|
1
|
-
!!!
|
|
2
|
-
%html
|
|
3
|
-
%head
|
|
4
|
-
%meta{:charset => "UTF-8"}
|
|
5
|
-
%title Output of rails_best_practices
|
|
6
|
-
:css
|
|
7
|
-
body {
|
|
8
|
-
color: #333;
|
|
9
|
-
background: #eee;
|
|
10
|
-
padding: 0 20px;
|
|
11
|
-
}
|
|
12
|
-
h1 {
|
|
13
|
-
color: ##4E4E4E;
|
|
14
|
-
}
|
|
15
|
-
table {
|
|
16
|
-
background: white;
|
|
17
|
-
border: 1px solid #666;
|
|
18
|
-
border-collapse: collapse;
|
|
19
|
-
margin: 20px 0;
|
|
20
|
-
font-size: 14px;
|
|
21
|
-
}
|
|
22
|
-
table th, table td {
|
|
23
|
-
padding: 4px;
|
|
24
|
-
border: 1px solid #D0D0D0;
|
|
25
|
-
}
|
|
26
|
-
table th {
|
|
27
|
-
background-color: #DFC;
|
|
28
|
-
color: #337022;
|
|
29
|
-
}
|
|
30
|
-
table td.filename {
|
|
31
|
-
color: #ED1556;
|
|
32
|
-
}
|
|
33
|
-
table tr:hover {
|
|
34
|
-
background-color: #FFFFC0;
|
|
35
|
-
}
|
|
36
|
-
%body
|
|
37
|
-
%h1 rails_best_practices output
|
|
38
|
-
%h2
|
|
39
|
-
Please go to
|
|
40
|
-
%a{:href=>"http://rails-bestpractices.com", :target=>"_blank"} http://rails-bestpractices.com
|
|
41
|
-
to see more useful Rails Best Practices.
|
|
42
|
-
%h2
|
|
43
|
-
- if errors.empty?
|
|
44
|
-
No error found. Cool!
|
|
45
|
-
- else
|
|
46
|
-
Found #{errors.size} errors.
|
|
47
|
-
%table
|
|
48
|
-
%tr
|
|
49
|
-
%th Filename
|
|
50
|
-
%th Line Number
|
|
51
|
-
%th Warning Message
|
|
52
|
-
- errors.each do |error|
|
|
53
|
-
%tr
|
|
54
|
-
%td.filename
|
|
55
|
-
- if textmate
|
|
56
|
-
%a{:href=>"txmt://open/?url=file://#{File.expand_path(error.filename)}&line=#{error.line_number}"}= error.filename
|
|
57
|
-
- elsif mvim
|
|
58
|
-
%a{:href=>"mvim://open/?url=file://#{File.expand_path(error.filename)}&line=#{error.line_number}"}= error.filename
|
|
59
|
-
- else
|
|
60
|
-
= error.filename
|
|
61
|
-
%td.line-number= error.line_number
|
|
62
|
-
%td.message
|
|
63
|
-
%a{:href=>"#{error.url}", :target=>"_blank"}= error.message
|