rails_best_practices 0.7.0 → 0.7.1

data/README.md

@@ -22,6 +22,7 @@ By default rails_best_practices will do parse codes in vendor, spec, test and fe
         -f, --format FORMAT              output format
             --without-color              only output plain text without color
             --with-textmate              open file by textmate in html format
+            --with-mvim                  open file by mvim in html format
             --vendor                     include vendor files
             --spec                       include spec files
             --test                       include test files

data/assets/result.html.haml

@@ -54,6 +54,8 @@
           %td.filename
             - if textmate
               %a{:href=>"txmt://open/?url=file://#{File.expand_path(error.filename)}&line=#{error.line_number}"}= error.filename
+            - elsif mvim
+              %a{:href=>"mvim://open/?url=file://#{File.expand_path(error.filename)}&line=#{error.line_number}"}= error.filename
             - else
               = error.filename
           %td.line-number= error.line_number

data/lib/rails_best_practices.rb

@@ -211,7 +211,7 @@ module RailsBestPractices
       template = File.read(File.join(File.dirname(__FILE__), "..", "assets", "result.html.haml"))
 
       File.open("rails_best_practices_output.html", "w+") do |file|
-        file.puts Haml::Engine.new(template).render(Object.new, :errors => @runner.errors, :textmate => @options["with-textmate"])
+        file.puts Haml::Engine.new(template).render(Object.new, :errors => @runner.errors, :textmate => @options["with-textmate"], :mvim => @options["with-mvim"])
       end
     end
   end

data/lib/rails_best_practices/command.rb

@@ -6,6 +6,7 @@ require 'optparse'
 #    -f, --format FORMAT              output format
 #        --without-color              only output plain text without color
 #        --with-textmate              open file by textmate in html format
+#        --with-mvim                  open file by mvim in html format
 #        --vendor                     include vendor files
 #        --spec                       include spec files
 #        --test                       include test files
@@ -35,6 +36,10 @@ OptionParser.new do |opts|
     options["with-textmate"] = true
   end
 
+  opts.on("--with-mvim", "open file by mvim in html format") do
+    options["with-mvim"] = true
+  end
+
   ['vendor', 'spec', 'test', 'features'].each do |pattern|
     opts.on("--#{pattern}", "include #{pattern} files") do
       options[pattern] = true

data/lib/rails_best_practices/core/runner.rb

@@ -61,7 +61,7 @@ module RailsBestPractices
       #
       # @param [String] filename
       def lexical_file(filename)
-        lexical(filename, File.read(filename))
+        lexical(filename, File.open(filename, "r:UTF-8") { |f| f.read })
       end
 
       # prepare and review a file's content with filename.
@@ -71,16 +71,16 @@ module RailsBestPractices
       # content is the source code.
       [:prepare, :review].each do |process|
         class_eval <<-EOS
-          def #{process}(filename, content)                      # def review(filename, content)
-            puts filename if @debug                              #   puts filename if @debug
-            content = parse_erb_or_haml(filename, content)       #   content = parse_erb_or_haml(filename, content)
-            node = parse_ruby(filename, content)                 #   node = parse_ruby(filename, content)
-            node.#{process}(@checker) if node                    #   node.review(@checker) if node
-          end                                                    # end
-                                                                 #
-          def #{process}_file(filename)                          # def review_file(filename)
-            #{process}(filename, File.read(filename))            #   review(filename, File.read(filename))
-          end                                                    # end
+          def #{process}(filename, content)                                        # def review(filename, content)
+            puts filename if @debug                                                #   puts filename if @debug
+            content = parse_erb_or_haml(filename, content)                         #   content = parse_erb_or_haml(filename, content)
+            node = parse_ruby(filename, content)                                   #   node = parse_ruby(filename, content)
+            node.#{process}(@checker) if node                                      #   node.review(@checker) if node
+          end                                                                      # end
+                                                                                   #
+          def #{process}_file(filename)                                            # def review_file(filename)
+            #{process}(filename, File.open(filename, "r:UTF-8") { |f| f.read })    #   review(filename, File.open(filename, "r:UTF-8") { |f| f.read })
+          end                                                                      # end
         EOS
       end
 

data/lib/rails_best_practices/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "0.7.0"
+  VERSION = "0.7.1"
 end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  hash: 3
+  hash: 1
   prerelease: 
   segments: 
   - 0
   - 7
-  - 0
-  version: 0.7.0
+  - 1
+  version: 0.7.1
 platform: ruby
 authors: 
 - Richard Huang
@@ -15,10 +15,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-15 00:00:00 +08:00
+date: 2011-02-24 00:00:00 +08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -30,11 +32,11 @@ dependencies:
         - 0
         - 4
         version: 2.0.4
-  prerelease: false
   version_requirements: *id001
-  type: :runtime
   name: ruby_parser
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -46,11 +48,11 @@ dependencies:
         - 0
         - 9
         version: 0.0.9
-  prerelease: false
   version_requirements: *id002
-  type: :runtime
   name: ruby-progressbar
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -61,11 +63,11 @@ dependencies:
         - 1
         - 2
         version: "1.2"
-  prerelease: false
   version_requirements: *id003
-  type: :runtime
   name: colored
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -77,11 +79,11 @@ dependencies:
         - 6
         - 6
         version: 2.6.6
-  prerelease: false
   version_requirements: *id004
-  type: :runtime
   name: erubis
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -93,11 +95,11 @@ dependencies:
         - 0
         - 18
         version: 3.0.18
-  prerelease: false
   version_requirements: *id005
-  type: :runtime
   name: haml
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -107,11 +109,11 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
   version_requirements: *id006
-  type: :runtime
   name: i18n
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -121,11 +123,11 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
   version_requirements: *id007
-  type: :runtime
   name: activesupport
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :development
   requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -135,11 +137,11 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
   version_requirements: *id008
-  type: :development
   name: rake
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :development
   requirement: &id009 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -151,11 +153,11 @@ dependencies:
         - 4
         - 0
         version: 2.4.0
-  prerelease: false
   version_requirements: *id009
-  type: :development
   name: rspec
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :development
   requirement: &id010 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -166,11 +168,11 @@ dependencies:
         - 0
         - 6
         version: "0.6"
-  prerelease: false
   version_requirements: *id010
-  type: :development
   name: watchr
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :development
   requirement: &id011 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -182,9 +184,7 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  prerelease: false
   version_requirements: *id011
-  type: :development
   name: bundler
 description: a code metric tool for rails codes, written in Ruby.
 email: 
@@ -335,7 +335,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.4.2
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
 summary: a code metric tool for rails codes.