rails_best_practices 0.6.1 → 0.6.5

data/spec/rails_best_practices/core_ext/enumerable_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe Enumerable do
+  it "should get duplications in enumerable" do
+    ["hello", "world", "hello", "java"].dups.should == ["hello"]
+  end
+end

data/spec/rails_best_practices/core_ext/nil_class_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe NilClass do
+  it "should return nil when calling undefined methods on nil" do
+    nil.undefined.should == nil
+  end
+
+  it "should do not return nil when calling exist methods" do
+    nil.nil?.should be_true
+  end
+end

data/spec/rails_best_practices_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe RailsBestPractices do
+
+  describe "expand_dirs_to_files" do
+    require 'find'
+    it "should expand all files in spec directory" do
+      dir = File.dirname(__FILE__)
+      RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices_spec.rb')
+      RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices/core/visitable_sexp_spec.rb')
+      RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices/checks/check_spec.rb')
+    end
+  end
+
+  describe "file_sort" do
+    it "should get models first, then mailers" do
+      files = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "lib/user.rb"]
+      RailsBestPractices.file_sort(files).should == ["app/models/user.rb", "app/mailers/user_mailer.rb", "app/controllers/users_controller.rb", "app/views/users/index.html.haml", "lib/user.rb"]
+    end
+  end
+
+  describe "file_ignore" do
+    it "should ignore lib" do
+      files = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "lib/user.rb"]
+      RailsBestPractices.file_ignore(files, 'lib/').should == ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml"]
+    end
+  end
+
+  describe "output_errors" do
+    check1 = RailsBestPractices::Checks::LawOfDemeterCheck.new
+    check2 = RailsBestPractices::Checks::UseQueryAttributeCheck.new
+    runner = RailsBestPractices::Core::Runner.new(check1, check2)
+    check1.add_error "law of demeter", "app/models/user.rb", 10
+    check2.add_error "use query attribute", "app/models/post.rb", 100
+    RailsBestPractices.runner = runner
+
+    $origin_stdout = $stdout
+    $stdout = StringIO.new
+    RailsBestPractices.output_errors
+    result = $stdout.string
+    $stdout = $origin_stdout
+    result.should == ["app/models/user.rb:10 - law of demeter".red, "app/models/post.rb:100 - use query attribute".red, "\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.".green, "\nFound 2 errors.".red].join("\n") + "\n"
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,4 @@
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
+
+require 'rails_best_practices'

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 13
   prerelease: false
   segments: 
   - 0
   - 6
-  - 1
-  version: 0.6.1
+  - 5
+  version: 0.6.5
 platform: ruby
 authors: 
 - Richard Huang
@@ -15,8 +15,8 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-12-24 00:00:00 +08:00
-default_executable: rails_best_practices
+date: 2011-01-04 00:00:00 +08:00
+default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   requirement: &id001 !ruby/object:Gem::Requirement 
@@ -85,13 +85,15 @@ dependencies:
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 3
+        hash: 35
         segments: 
+        - 3
         - 0
-        version: "0"
-  name: i18n
+        - 18
+        version: 3.0.18
+  name: haml
   prerelease: false
   type: :runtime
   version_requirements: *id005
@@ -105,7 +107,7 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: activesupport
+  name: i18n
   prerelease: false
   type: :runtime
   version_requirements: *id006
@@ -113,17 +115,15 @@ dependencies:
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version 
-        hash: 13
+        hash: 3
         segments: 
-        - 2
         - 0
-        - 1
-        version: 2.0.1
-  name: rspec
+        version: "0"
+  name: activesupport
   prerelease: false
-  type: :development
+  type: :runtime
   version_requirements: *id007
 - !ruby/object:Gem::Dependency 
   requirement: &id008 !ruby/object:Gem::Requirement 
@@ -131,13 +131,13 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 35
+        hash: 13
         segments: 
-        - 3
+        - 2
         - 0
-        - 18
-        version: 3.0.18
-  name: haml
+        - 1
+        version: 2.0.1
+  name: rspec
   prerelease: false
   type: :development
   version_requirements: *id008
@@ -156,6 +156,22 @@ dependencies:
   prerelease: false
   type: :development
   version_requirements: *id009
+- !ruby/object:Gem::Dependency 
+  requirement: &id010 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 23
+        segments: 
+        - 1
+        - 0
+        - 0
+        version: 1.0.0
+  name: bundler
+  prerelease: false
+  type: :development
+  version_requirements: *id010
 description: a code metric tool for rails codes, written in Ruby.
 email: 
 - flyerhzm@gmail.com
@@ -163,10 +179,22 @@ executables:
 - rails_best_practices
 extensions: []
 
-extra_rdoc_files: 
+extra_rdoc_files: []
+
+files: 
+- .gitignore
+- .rspec.example
+- .rvmrc.example
+- .watchr
+- .watchr.example
+- Gemfile
 - MIT_LICENSE
 - README.md
-files: 
+- Rakefile
+- assets/result.html.haml
+- bin/rails_best_practices
+- lib/rails_best_practices.rb
+- lib/rails_best_practices/checks.rb
 - lib/rails_best_practices/checks/add_model_virtual_attribute_check.rb
 - lib/rails_best_practices/checks/always_add_db_index_check.rb
 - lib/rails_best_practices/checks/check.rb
@@ -190,21 +218,47 @@ files:
 - lib/rails_best_practices/checks/use_query_attribute_check.rb
 - lib/rails_best_practices/checks/use_say_with_time_in_migrations_check.rb
 - lib/rails_best_practices/checks/use_scope_access_check.rb
-- lib/rails_best_practices/checks.rb
 - lib/rails_best_practices/command.rb
+- lib/rails_best_practices/core.rb
 - lib/rails_best_practices/core/checking_visitor.rb
 - lib/rails_best_practices/core/error.rb
 - lib/rails_best_practices/core/runner.rb
 - lib/rails_best_practices/core/visitable_sexp.rb
-- lib/rails_best_practices/core.rb
 - lib/rails_best_practices/core_ext/enumerable.rb
 - lib/rails_best_practices/core_ext/nil_class.rb
 - lib/rails_best_practices/version.rb
-- lib/rails_best_practices.rb
+- rails_best_practices.gemspec
 - rails_best_practices.yml
-- MIT_LICENSE
-- README.md
-- bin/rails_best_practices
+- rubies_test.sh
+- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
+- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
+- spec/rails_best_practices/checks/check_spec.rb
+- spec/rails_best_practices/checks/dry_bundler_in_capistrano_check_spec.rb
+- spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
+- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
+- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_model_check_spec.rb
+- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
+- spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
+- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
+- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
+- spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
+- spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
+- spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
+- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
+- spec/rails_best_practices/checks/use_model_association_check_spec.rb
+- spec/rails_best_practices/checks/use_observer_check_spec.rb
+- spec/rails_best_practices/checks/use_query_attribute_check_spec.rb
+- spec/rails_best_practices/checks/use_say_with_time_in_migrations_check_spec.rb
+- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
+- spec/rails_best_practices/core/error_spec.rb
+- spec/rails_best_practices/core/visitable_sexp_spec.rb
+- spec/rails_best_practices/core_ext/enumerable_spec.rb
+- spec/rails_best_practices/core_ext/nil_class_spec.rb
+- spec/rails_best_practices_spec.rb
+- spec/spec_helper.rb
 has_rdoc: true
 homepage: http://rails-bestpractices.com
 licenses: []
@@ -241,5 +295,33 @@ rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: a code metric tool for rails codes.
-test_files: []
-
+test_files: 
+- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
+- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
+- spec/rails_best_practices/checks/check_spec.rb
+- spec/rails_best_practices/checks/dry_bundler_in_capistrano_check_spec.rb
+- spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
+- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
+- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_model_check_spec.rb
+- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
+- spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
+- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
+- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
+- spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
+- spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
+- spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
+- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
+- spec/rails_best_practices/checks/use_model_association_check_spec.rb
+- spec/rails_best_practices/checks/use_observer_check_spec.rb
+- spec/rails_best_practices/checks/use_query_attribute_check_spec.rb
+- spec/rails_best_practices/checks/use_say_with_time_in_migrations_check_spec.rb
+- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
+- spec/rails_best_practices/core/error_spec.rb
+- spec/rails_best_practices/core/visitable_sexp_spec.rb
+- spec/rails_best_practices/core_ext/enumerable_spec.rb
+- spec/rails_best_practices/core_ext/nil_class_spec.rb
+- spec/rails_best_practices_spec.rb
+- spec/spec_helper.rb