rails_best_practices 0.4.2 → 0.4.3

data/README.textile

@@ -40,7 +40,7 @@ Wiki: "http://github.com/flyerhzm/rails_best_practices/wiki":http://github.com/f
 h2. Install
 
 <pre><code>
-sudo gem install rails_best_practices
+gem install rails_best_practices
 </code></pre>
 
 *************************************************
@@ -84,6 +84,7 @@ MoveCodeIntoControllerCheck: { }
 MoveCodeIntoModelCheck: { }
 MoveCodeIntoHelperCheck: { array_count: 3 }
 ReplaceInstanceVariableWithLocalVariableCheck: { }
+DryBundlerInCapistranoCheck: { }
 </code></pre>
 
 *************************************************
@@ -121,6 +122,9 @@ h2. Implementation
 ## Move code into helper
 ## Replace instance variable with local variable
 
+* Deployment
+## Dry bundler in capistrano
+
 *************************************************
 
 h2. Contribute

data/lib/rails_best_practices.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks'
 require 'rails_best_practices/core'
 

data/lib/rails_best_practices/checks.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/move_finder_to_named_scope_check'
 require 'rails_best_practices/checks/use_model_association_check'
 require 'rails_best_practices/checks/use_scope_access_check'
@@ -17,3 +18,4 @@ require 'rails_best_practices/checks/move_code_into_controller_check'
 require 'rails_best_practices/checks/move_code_into_model_check'
 require 'rails_best_practices/checks/move_code_into_helper_check'
 require 'rails_best_practices/checks/replace_instance_variable_with_local_variable_check'
+require 'rails_best_practices/checks/dry_bundler_in_capistrano_check'

data/lib/rails_best_practices/checks/add_model_virtual_attribute_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/always_add_db_index_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/core/error'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/dry_bundler_in_capistrano_check.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+require 'rails_best_practices/checks/check'
+
+module RailsBestPractices
+  module Checks
+    # Check config/deploy.rb file to make sure using the bundler's capistrano recipe.
+    #
+    # Implementation: check the method call,
+    # if there is a call "namespace :bundler", then it should use bundler's capistrano recipe.
+    class DryBundlerInCapistranoCheck < Check
+
+      def interesting_nodes
+        [:call]
+      end
+
+      def interesting_file
+        'config/deploy.rb'
+      end
+
+      def evaluate_start(node)
+        if :namespace == node.message and "bundler" == node.arguments.to_ruby_string
+          add_error "dry bundler in capistrano"
+        end
+      end
+    end
+  end
+end

data/lib/rails_best_practices/checks/isolate_seed_data_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/law_of_demeter_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/move_code_into_controller_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/move_code_into_helper_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/move_code_into_model_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/move_model_logic_into_model_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/needless_deep_nesting_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/not_use_default_route_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/overuse_route_customizations_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/replace_instance_variable_with_local_variable_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/use_before_filter_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/use_model_association_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/use_observer_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/checks/use_scope_access_check.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/checks/check'
 
 module RailsBestPractices

data/lib/rails_best_practices/command.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'optparse'
 require 'progressbar'
 require 'colored'

data/lib/rails_best_practices/core.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rails_best_practices/core/core_ext'
 require 'rails_best_practices/core/runner'
 require 'rails_best_practices/core/checking_visitor'

data/lib/rails_best_practices/core/checking_visitor.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 module RailsBestPractices
   module Core
     class CheckingVisitor

data/lib/rails_best_practices/core/core_ext.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 module Enumerable
   def dups
     inject({}) {|h,v| h[v]=h[v].to_i+1; h}.reject{|k,v| v==1}.keys

data/lib/rails_best_practices/core/error.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 module RailsBestPractices
   module Core
     class Error

data/lib/rails_best_practices/core/runner.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rubygems'
 require 'ruby_parser'
 require 'erb'
@@ -24,6 +25,8 @@ module RailsBestPractices
       def check(filename, content)
         if filename =~ /.*\.erb/
           content = ERB.new(content).src
+          # remove the coding line which exists in Ruby 1.9
+          content.gsub!(/#coding:US-ASCII\n/, '')
         end
         if filename =~ /.*\.haml/
           require 'haml'

data/lib/rails_best_practices/core/visitable_sexp.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rubygems'
 require 'sexp'
 require 'ruby2ruby'

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,5 @@
+# encoding: utf-8
 module RailsBestPractices
-  VERSION = "0.4.2"
+  VERSION = "0.4.3"
 end
 

data/rails_best_practices.yml

@@ -17,3 +17,4 @@ MoveCodeIntoControllerCheck: { }
 MoveCodeIntoModelCheck: { }
 MoveCodeIntoHelperCheck: { array_count: 3 }
 ReplaceInstanceVariableWithLocalVariableCheck: { }
+DryBundlerInCapistranoCheck: { }

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: false
   segments: 
   - 0
   - 4
-  - 2
-  version: 0.4.2
+  - 3
+  version: 0.4.3
 platform: ruby
 authors: 
 - Richard Huang
@@ -138,6 +138,7 @@ files:
 - lib/rails_best_practices/checks/move_model_logic_into_model_check.rb
 - lib/rails_best_practices/checks/not_use_default_route_check.rb
 - lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb
+- lib/rails_best_practices/checks/dry_bundler_in_capistrano_check.rb
 - lib/rails_best_practices/checks/isolate_seed_data_check.rb
 - lib/rails_best_practices/checks/always_add_db_index_check.rb
 - lib/rails_best_practices/checks/replace_instance_variable_with_local_variable_check.rb