rails_best_practices 0.3.9 → 0.3.10

data/VERSION

@@ -1 +1 @@
-0.3.9
+0.3.10

data/lib/rails_best_practices/checks/always_add_db_index_check.rb

@@ -31,16 +31,18 @@ module RailsBestPractices
       end
 
       def evaluate_start(node)
-        if @files.include? node.file
-          @parse = true if :up == node.message
-        else
-          @files << node.file
-        end
+        if :up == node.message
+          if @files.include? node.file
+            @parse = true if :up == node.message
+          else
+            @files << node.file
+          end
 
-        if @parse and :up == node.message
-          check_references(node.body)
-        else
-          remember_indexes(node.body)
+          if @parse
+            check_references(node.body)
+          else
+            remember_indexes(node.body)
+          end
         end
       end
 

data/rails_best_practices.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.9"
+  s.version = "0.3.10"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
-  s.date = %q{2009-11-26}
+  s.date = %q{2009-11-28}
   s.default_executable = %q{rails_best_practices}
   s.description = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.email = %q{flyerhzm@gmail.com}

data/spec/rails_best_practices/checks/always_add_db_index_check_spec.rb

@@ -148,9 +148,53 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
     end
     EOF
     @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090919130258_add_indexes_to_comments.rb', add_index_content)
+    @runner.check('db/migrate/20090919130260_add_indexes_to_comments.rb', add_index_content)
     @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090919130258_add_indexes_to_comments.rb', add_index_content)
+    @runner.check('db/migrate/20090919130260_add_indexes_to_comments.rb', add_index_content)
+    errors = @runner.errors
+    errors.should be_empty
+  end
+
+  it "should not always add db index with add_index in another migration file and a migration between them" do
+    content = <<-EOF
+    class CreateComments < ActiveRecord::Migration
+      def self.up
+        create_table "comments", :force => true do |t|
+          t.string :content
+          t.integer :post_id
+          t.integer :user_id
+        end
+      end
+
+      def self.down
+        drop_table "comments"
+      end
+    end
+    EOF
+    another_content = <<-EOF
+    class Settings < ActiveRecord::Migration
+      def self.my_escape(val)
+      end
+
+      def self.up
+        add_column :settings, :groep, :string, :limit => 50
+      end
+    end
+    EOF
+    add_index_content = <<-EOF
+    class AddIndexesToComments < ActiveRecord::Migration
+      def self.up
+        add_index :comments, :post_id
+        add_index :comments, :user_id
+      end
+    end
+    EOF
+    @runner.check('db/migrate/20090918140258_create_comments.rb', content)
+    @runner.check('db/migrate/20090918140259_settings.rb', another_content)
+    @runner.check('db/migrate/20090919140260_add_indexes_to_comments.rb', add_index_content)
+    @runner.check('db/migrate/20090918140258_create_comments.rb', content)
+    @runner.check('db/migrate/20090918140259_settings.rb', another_content)
+    @runner.check('db/migrate/20090919140260_add_indexes_to_comments.rb', add_index_content)
     errors = @runner.errors
     errors.should be_empty
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.3.9
+  version: 0.3.10
 platform: ruby
 authors: 
 - Richard Huang
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-26 00:00:00 +08:00
+date: 2009-11-28 00:00:00 +08:00
 default_executable: rails_best_practices
 dependencies: 
 - !ruby/object:Gem::Dependency