rails_best_practices 0.3.24 → 0.3.25

data/Rakefile

@@ -22,8 +22,8 @@ end
 
 Jeweler::Tasks.new do |gemspec|
   gemspec.name = "rails_best_practices"
-  gemspec.summary = "check rails files according to ihower's presentation 'rails best practices'"
-  gemspec.description = "check rails files according to ihower's presentation 'rails best practices'"
+  gemspec.summary = "a code metric tool for rails codes.'"
+  gemspec.description = "a code metric tool for rails codes.'"
   gemspec.email = "flyerhzm@gmail.com"
   gemspec.homepage = "http://rails-bestpractices.com"
   gemspec.authors = ["Richard Huang"]

data/VERSION

@@ -1 +1 @@
-0.3.24
+0.3.25

data/lib/rails_best_practices.rb

@@ -7,7 +7,6 @@ module RailsBestPractices
     def analyze_files(dir = '.', options = {})
       files = expand_dirs_to_files(dir)
       files = model_first_sort(files)
-      files = add_duplicate_migrations(files)
       ['vendor', 'spec', 'test', 'stories', 'features'].each do |pattern|
         files = ignore_files(files, "#{pattern}/") unless options[pattern]
       end
@@ -39,14 +38,8 @@ module RailsBestPractices
       }
     end
 
-    # for always_add_db_index_check
-    def add_duplicate_migrations files
-      migration_files = files.select { |file| file.index("db/migrate") }
-      (files << migration_files).flatten
-    end
-
     def ignore_files files, pattern
       files.reject { |file| file.index(pattern) }
     end
   end
-end
+end

data/lib/rails_best_practices/checks/isolate_seed_data_check.rb

@@ -8,7 +8,7 @@ module RailsBestPractices
     class IsolateSeedDataCheck < Check
 
       def interesting_nodes
-        [:defs, :call, :lasgn]
+        [:call, :lasgn]
       end
 
       def interesting_files
@@ -18,28 +18,15 @@ module RailsBestPractices
       def initialize
         super
         @new_variables = []
-        @files = []
-        @parse = false
       end
 
       def evaluate_start(node)
-        # check duplicate migration because of always_add_db_index_check.
-        if :defs == node.node_type
-          if @files.include? node.file
-            @parse = true if :up == node.message
-          else
-            @files << node.file
-          end
-        end
-        
-        if @parse
-          if [:create, :create!].include? node.message
-            add_error("isolate seed data")
-          elsif :lasgn == node.node_type
-            remember_new_variable(node)
-          elsif [:save, :save!].include? node.message
-            add_error("isolate seed data") if new_record?(node)
-          end
+        if [:create, :create!].include? node.message
+          add_error("isolate seed data")
+        elsif :lasgn == node.node_type
+          remember_new_variable(node)
+        elsif [:save, :save!].include? node.message
+          add_error("isolate seed data") if new_record?(node)
         end
       end
 

data/rails_best_practices.gemspec

@@ -5,13 +5,13 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.24"
+  s.version = "0.3.25"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
   s.date = %q{2010-07-25}
   s.default_executable = %q{rails_best_practices}
-  s.description = %q{check rails files according to ihower's presentation 'rails best practices'}
+  s.description = %q{a code metric tool for rails codes.'}
   s.email = %q{flyerhzm@gmail.com}
   s.executables = ["rails_best_practices"]
   s.extra_rdoc_files = [
@@ -89,7 +89,7 @@ Gem::Specification.new do |s|
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
   s.rubygems_version = %q{1.3.6}
-  s.summary = %q{check rails files according to ihower's presentation 'rails best practices'}
+  s.summary = %q{a code metric tool for rails codes.'}
   s.test_files = [
     "spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb",
      "spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb",

data/spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb

@@ -24,7 +24,6 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
     end
     EOF
     @runner.check('db/migrate/20090818130258_create_roles.rb', content)
-    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
     errors = @runner.errors
     errors.should_not be_empty
     errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:8 - isolate seed data"
@@ -51,7 +50,6 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
     end
     EOF
     @runner.check('db/migrate/20090818130258_create_roles.rb', content)
-    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
     errors = @runner.errors
     errors.should_not be_empty
     errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:9 - isolate seed data"
@@ -72,7 +70,6 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
     end
     EOF
     @runner.check('db/migrate/20090818130258_create_roles.rb', content)
-    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
     errors = @runner.errors
     errors.should be_empty
   end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 3
-  - 24
-  version: 0.3.24
+  - 25
+  version: 0.3.25
 platform: ruby
 authors: 
 - Richard Huang
@@ -45,7 +45,7 @@ dependencies:
         version: 1.2.4
   type: :runtime
   version_requirements: *id002
-description: check rails files according to ihower's presentation 'rails best practices'
+description: a code metric tool for rails codes.'
 email: flyerhzm@gmail.com
 executables: 
 - rails_best_practices
@@ -149,7 +149,7 @@ rubyforge_project:
 rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
-summary: check rails files according to ihower's presentation 'rails best practices'
+summary: a code metric tool for rails codes.'
 test_files: 
 - spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
 - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb