rails_best_practices 0.3.20 → 0.3.21

data/VERSION

@@ -1 +1 @@
-0.3.20
+0.3.21

data/lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb

@@ -22,7 +22,7 @@ module RailsBestPractices
       private
 
       def others_finder?(node)
-        node.message == :find and node.subject.node_type == :call
+        node.message == :find and node.subject.node_type == :call and node.arguments.size > 1
       end
     end
   end

data/rails_best_practices.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.20"
+  s.version = "0.3.21"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]

data/spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb

@@ -54,7 +54,7 @@ describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
     errors.should be_empty
   end
 
-  it "should not keep finders on thier own model without finder" do
+  it "should not keep finders on their own model without finder" do
     content = <<-EOF
     class Post < ActiveRecord::Base
       has_many :comments
@@ -68,4 +68,19 @@ describe RailsBestPractices::Checks::KeepFindersOnTheirOwnModelCheck do
     errors = @runner.errors
     errors.should be_empty
   end
+
+  it "should not keep finders on their own model with ruby Array#find" do
+    content = <<-EOF
+    class Post < ActiveRecord::Base
+      has_many :comments
+
+      def active_comments
+        self.comments.find {|comment| comment.status == 'active'}
+      end
+    end
+    EOF
+    @runner.check('app/models/post.rb', content)
+    errors = @runner.errors
+    errors.should be_empty
+  end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 3
-  - 20
-  version: 0.3.20
+  - 21
+  version: 0.3.21
 platform: ruby
 authors: 
 - Richard Huang