rails_best_practices 0.3.2 → 0.3.3

data/README.textile

@@ -68,7 +68,7 @@ LawOfDemeterCheck: { }
 UseObserverCheck: { }
 IsolateSeedDataCheck: { }
 AlwaysAddDbIndexCheck: { }
-UseFilterCheck: { }
+UseBeforeFilterCheck: { }
 MoveCodeIntoControllerCheck: { }
 MoveCodeIntoHelperCheck: { }
 ReplaceInstanceVariableWithLocalVariableCheck: { }

data/VERSION

@@ -1 +1 @@
-0.3.2
+0.3.3

data/lib/rails_best_practices/checks/{use_filter_check.rb → use_before_filter_check.rb}

@@ -2,10 +2,10 @@ require 'rails_best_practices/checks/check'
 
 module RailsBestPractices
   module Checks
-    # Check a controller file to make sure to use filter to remove duplicate call in different action.
+    # Check a controller file to make sure to use before_filter to remove duplicate call in different action.
     #
-    # Implementation: Check all methods' first call, if they are duplicate, then should use filter.
-    class UseFilterCheck < Check
+    # Implementation: Check all methods' first call, if they are duplicate, then should use before_filter.
+    class UseBeforeFilterCheck < Check
 
       def interesting_nodes
         [:class]
@@ -19,7 +19,7 @@ module RailsBestPractices
         @methods = {}
         node.grep_nodes({:node_type => :defn}).each { |method_node| remember_method(method_node) }
         @methods.each do |first_call, method_names|
-          add_error "use filter for #{first_call.to_ruby} in #{method_names.join(',')}" if method_names.size > 1
+          add_error "use before_filter for #{first_call.to_ruby} in #{method_names.join(',')}" if method_names.size > 1
         end
       end
 

data/lib/rails_best_practices/checks.rb

@@ -15,7 +15,7 @@ require 'rails_best_practices/checks/law_of_demeter_check'
 require 'rails_best_practices/checks/use_observer_check'
 require 'rails_best_practices/checks/isolate_seed_data_check'
 require 'rails_best_practices/checks/always_add_db_index_check'
-require 'rails_best_practices/checks/use_filter_check'
+require 'rails_best_practices/checks/use_before_filter_check'
 require 'rails_best_practices/checks/move_code_into_controller_check'
 require 'rails_best_practices/checks/move_code_into_helper_check'
 require 'rails_best_practices/checks/replace_instance_variable_with_local_variable_check'

data/rails_best_practices.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.2"
+  s.version = "0.3.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
-  s.date = %q{2009-11-17}
+  s.date = %q{2009-11-19}
   s.default_executable = %q{rails_best_practices}
   s.description = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.email = %q{flyerhzm@gmail.com}
@@ -44,7 +44,7 @@ Gem::Specification.new do |s|
      "lib/rails_best_practices/checks/overuse_route_customizations_check.rb",
      "lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb",
      "lib/rails_best_practices/checks/replace_instance_variable_with_local_variable_check.rb",
-     "lib/rails_best_practices/checks/use_filter_check.rb",
+     "lib/rails_best_practices/checks/use_before_filter_check.rb",
      "lib/rails_best_practices/checks/use_model_association_check.rb",
      "lib/rails_best_practices/checks/use_model_callback_check.rb",
      "lib/rails_best_practices/checks/use_observer_check.rb",
@@ -74,7 +74,7 @@ Gem::Specification.new do |s|
      "spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb",
      "spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb",
      "spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb",
-     "spec/rails_best_practices/checks/use_filter_check_spec.rb",
+     "spec/rails_best_practices/checks/use_before_filter_check_spec.rb",
      "spec/rails_best_practices/checks/use_model_association_check_spec.rb",
      "spec/rails_best_practices/checks/use_model_callback_check_spec.rb",
      "spec/rails_best_practices/checks/use_observer_check_spec.rb",
@@ -104,7 +104,7 @@ Gem::Specification.new do |s|
      "spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb",
      "spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb",
      "spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb",
-     "spec/rails_best_practices/checks/use_filter_check_spec.rb",
+     "spec/rails_best_practices/checks/use_before_filter_check_spec.rb",
      "spec/rails_best_practices/checks/use_model_association_check_spec.rb",
      "spec/rails_best_practices/checks/use_model_callback_check_spec.rb",
      "spec/rails_best_practices/checks/use_observer_check_spec.rb",

data/rails_best_practices.yml

@@ -15,7 +15,7 @@ LawOfDemeterCheck: { }
 UseObserverCheck: { }
 IsolateSeedDataCheck: { }
 AlwaysAddDbIndexCheck: { }
-UseFilterCheck: { }
+UseBeforeFilterCheck: { }
 MoveCodeIntoControllerCheck: { }
 MoveCodeIntoHelperCheck: { }
 ReplaceInstanceVariableWithLocalVariableCheck: { }

data/spec/rails_best_practices/checks/{use_filter_check_spec.rb → use_before_filter_check_spec.rb}

@@ -1,8 +1,8 @@
 require File.join(File.dirname(__FILE__) + '/../../spec_helper')
 
-describe RailsBestPractices::Checks::UseFilterCheck do
+describe RailsBestPractices::Checks::UseBeforeFilterCheck do
   before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseFilterCheck.new)
+    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseBeforeFilterCheck.new)
   end
   
   it "should use filter" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors: 
 - Richard Huang
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-17 00:00:00 +08:00
+date: 2009-11-19 00:00:00 +08:00
 default_executable: rails_best_practices
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -67,7 +67,7 @@ files:
 - lib/rails_best_practices/checks/overuse_route_customizations_check.rb
 - lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb
 - lib/rails_best_practices/checks/replace_instance_variable_with_local_variable_check.rb
-- lib/rails_best_practices/checks/use_filter_check.rb
+- lib/rails_best_practices/checks/use_before_filter_check.rb
 - lib/rails_best_practices/checks/use_model_association_check.rb
 - lib/rails_best_practices/checks/use_model_callback_check.rb
 - lib/rails_best_practices/checks/use_observer_check.rb
@@ -97,7 +97,7 @@ files:
 - spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
 - spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
 - spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
-- spec/rails_best_practices/checks/use_filter_check_spec.rb
+- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
 - spec/rails_best_practices/checks/use_model_association_check_spec.rb
 - spec/rails_best_practices/checks/use_model_callback_check_spec.rb
 - spec/rails_best_practices/checks/use_observer_check_spec.rb
@@ -149,7 +149,7 @@ test_files:
 - spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
 - spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
 - spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
-- spec/rails_best_practices/checks/use_filter_check_spec.rb
+- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
 - spec/rails_best_practices/checks/use_model_association_check_spec.rb
 - spec/rails_best_practices/checks/use_model_callback_check_spec.rb
 - spec/rails_best_practices/checks/use_observer_check_spec.rb