rails_best_practices 0.3.19 → 0.3.20

data/Rakefile

@@ -6,10 +6,10 @@ require 'jeweler'
 desc 'Default: run unit tests.'
 task :default => :spec
 
-desc 'Generate documentation for the sitemap plugin.'
+desc 'Generate documentation for the rails_best_practices plugin.'
 Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'Bullet'
+  rdoc.title    = 'rails_best_practices'
   rdoc.options << '--line-numbers' << '--inline-source'
   rdoc.rdoc_files.include('README')
   rdoc.rdoc_files.include('lib/**/*.rb')

data/VERSION

@@ -1 +1 @@
-0.3.19
+0.3.20

data/lib/rails_best_practices/checks/always_add_db_index_check.rb

@@ -2,125 +2,52 @@ require 'rails_best_practices/checks/check'
 
 module RailsBestPractices
   module Checks
-    # Check a migration file to make sure every reference key has a database index.
+    # Check db/schema.rb file to make sure every reference key has a database index.
     #
-    # Implementation:
-    # Parse migration files twice.
-    # First, remember all reference keys and index keys.
-    # Second, compare reference keys and index keys, and add error when reference keys are not in index keys.
+    # Implementation: read all add_index method calls to get the indexed columns in table, then read integer method call in create_table block to get the reference columns in tables, compare with indexed columns, if not in the indexed columns, then it violates always_add_db_index_check.
     class AlwaysAddDbIndexCheck < Check
 
       def interesting_nodes
-        [:defs]
+        [:block, :call]
       end
 
       def interesting_files
-        MIGRATION_FILES
+        /db\/schema.rb/
       end
 
       def initialize
         super
-        @files = []
-        @@indexes = {}
-        @@tables = []
-        @parse = false
-      end
-
-      # make indexes class method for get indexes out of AlwaysAddDbIndexCheck class.
-      def self.indexes
-        @@indexes
+        @index_columns = []
       end
 
       def evaluate_start(node)
-        if :up == node.message
-          if @files.include? node.file
-            @parse = true if :up == node.message
-          else
-            @files << node.file
-          end
-
-          if @parse
-            check_references(node.body)
-          else
-            remember(node.body)
-          end
-        end
-      end
-
-      private
-
-      def check_references(nodes)
-        nodes[1..-1].each do |node|
-          create_table_node = node.grep_nodes({:node_type => :call, :message => :create_table}).first
-          if create_table_node
-            table_name = create_table_node.arguments[1].to_ruby_string
-            next unless @@tables.include? table_name
-            node.grep_nodes({:node_type => :call, :message => :integer}).each do |integer_node|
-              column_name = integer_node.arguments[1].to_ruby_string
-              if column_name =~ /_id$/ and !@@indexes[table_name].include? column_name
-                add_error "always add db index (#{table_name} => #{column_name})", integer_node.file, integer_node.line
-              end
-            end
-            node.grep_nodes({:node_type => :call, :message => :references}).each do |references_node|
-              column_name = references_node.arguments[1].to_ruby_string + "_id"
-              if !@@indexes[table_name].include? column_name
-                add_error "always add db index (#{table_name} => #{column_name})", references_node.file, references_node.line
-              end
-            end
-            node.grep_nodes({:node_type => :call, :message => :column}).each do |column_node|
-              if 'integer' == column_node.arguments[2].to_ruby_string
-                column_name = column_node.arguments[1].to_ruby_string
-                if column_name =~ /_id$/ and !@@indexes[table_name].include? column_name
-                  add_error "always add db index (#{table_name} => #{column_name})", column_node.file, column_node.line
-                end
-              end
-            end
-          end
-          if :call == node.node_type and :add_column == node.message
-            table_name = node.arguments[1].to_ruby_string
-            column_name = node.arguments[2].to_ruby_string
-            column_type = node.arguments[3].to_ruby_string
-            if column_name =~ /_id$/ and column_type == "integer" and !@@indexes[table_name].include? column_name
-              add_error "always add db index (#{table_name} => #{column_name})", node.file, node.line
+        if :block == node.node_type
+          find_index_columns(node)
+        elsif :call == node.node_type
+          case node.message
+          when :create_table
+            @table_name = node.arguments[1].to_ruby_string
+          when :integer
+            column_name = node.arguments[1].to_ruby_string
+            if column_name =~ /_id$/ and !indexed?(@table_name, column_name)
+              add_error "always add db index (#@table_name => #{column_name})", node.file, node.line
             end
           end
         end
       end
       
-      def remember(nodes)
-        nodes.grep_nodes({:node_type => :call, :message => :create_table}).each do |create_table_node|
-          @@tables << create_table_node.arguments[1].to_ruby_string
-        end
-        nodes.grep_nodes({:node_type => :call, :message => :drop_table}).each do |drop_table_node|
-          @@tables.delete(drop_table_node.arguments[1].to_ruby_string)
+      private
+        def find_index_columns(node)
+          node.grep_nodes({:node_type => :call, :message => :add_index}).each do |index_node|
+            table_name = index_node.arguments[1].to_ruby_string
+            reference_column_name = index_node.arguments[2].to_ruby_string
+            @index_columns << [table_name, reference_column_name]
+          end
         end
-        @@tables.compact!
         
-        remember_indexes(nodes)
-      end
-
-      # dynamically execute add_index because static parser can't handle
-      #
-      # [[:comments, :post_id], [:comments, :user_id]].each do |args|
-      #   add_index *args
-      # end
-      def remember_indexes(nodes)
-        nodes[1..-1].each do |node|
-          begin
-            eval(node.to_ruby)
-          rescue Exception
-          end
+        def indexed?(table_name, column_name)
+          !!@index_columns.find { |reference| reference[0] == table_name and reference[1] == column_name }
         end
-      end
     end
   end
 end
-
-def add_index(*args)
-  table_name, column_names = *args
-  table_name = table_name.to_s
-  RailsBestPractices::Checks::AlwaysAddDbIndexCheck.indexes[table_name] ||= []
-  Array(column_names).each do |column_name|
-    RailsBestPractices::Checks::AlwaysAddDbIndexCheck.indexes[table_name] << column_name.to_s
-  end
-end

data/lib/rails_best_practices/checks/check.rb

@@ -3,7 +3,7 @@ require 'rails_best_practices/core/error'
 module RailsBestPractices
   module Checks
     class Check
-      NODE_TYPES = [:call, :defn, :defs, :if, :unless, :class, :lasgn, :ivar]
+      NODE_TYPES = [:call, :defn, :defs, :if, :unless, :class, :lasgn, :ivar, :block]
       
       CONTROLLER_FILES = /_controller.rb$/
       MIGRATION_FILES = /db\/migrate\/.*rb/

data/rails_best_practices.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.19"
+  s.version = "0.3.20"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
-  s.date = %q{2010-03-19}
+  s.date = %q{2010-06-03}
   s.default_executable = %q{rails_best_practices}
   s.description = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.email = %q{flyerhzm@gmail.com}
@@ -91,28 +91,28 @@ Gem::Specification.new do |s|
   s.rubygems_version = %q{1.3.6}
   s.summary = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.test_files = [
-    "spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb",
-     "spec/rails_best_practices/checks/always_add_db_index_check_spec.rb",
-     "spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb",
-     "spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb",
-     "spec/rails_best_practices/checks/law_of_demeter_check_spec.rb",
-     "spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb",
-     "spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb",
-     "spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb",
-     "spec/rails_best_practices/checks/move_code_into_model_check_spec.rb",
-     "spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb",
+    "spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb",
      "spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb",
-     "spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb",
-     "spec/rails_best_practices/checks/nested_model_forms_check_spec.rb",
-     "spec/rails_best_practices/checks/not_use_default_route_check_spec.rb",
+     "spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb",
+     "spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb",
+     "spec/rails_best_practices/checks/use_observer_check_spec.rb",
      "spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb",
+     "spec/rails_best_practices/checks/nested_model_forms_check_spec.rb",
+     "spec/rails_best_practices/checks/always_add_db_index_check_spec.rb",
+     "spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb",
+     "spec/rails_best_practices/checks/use_before_filter_check_spec.rb",
+     "spec/rails_best_practices/checks/law_of_demeter_check_spec.rb",
+     "spec/rails_best_practices/checks/use_scope_access_check_spec.rb",
      "spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb",
+     "spec/rails_best_practices/checks/not_use_default_route_check_spec.rb",
+     "spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb",
+     "spec/rails_best_practices/checks/use_model_callback_check_spec.rb",
+     "spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb",
      "spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb",
-     "spec/rails_best_practices/checks/use_before_filter_check_spec.rb",
      "spec/rails_best_practices/checks/use_model_association_check_spec.rb",
-     "spec/rails_best_practices/checks/use_model_callback_check_spec.rb",
-     "spec/rails_best_practices/checks/use_observer_check_spec.rb",
-     "spec/rails_best_practices/checks/use_scope_access_check_spec.rb",
+     "spec/rails_best_practices/checks/move_code_into_model_check_spec.rb",
+     "spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb",
+     "spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb",
      "spec/spec_helper.rb"
   ]
 

data/spec/rails_best_practices/checks/always_add_db_index_check_spec.rb

@@ -7,317 +7,50 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
 
   it "should always add db index" do
     content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-          t.integer :post_id
-          t.integer :user_id
-        end
-      end
-
-      def self.down
-        drop_table "comments"
+    ActiveRecord::Schema.define(:version => 20100603080629) do
+      create_table "comments", :force => true do |t|
+        t.string "content"
+        t.integer "post_id"
+        t.integer "user_id"
       end
     end
     EOF
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
+    @runner.check('db/schema.rb', content)
     errors = @runner.errors
     errors.should_not be_empty
-    errors[0].to_s.should == "db/migrate/20090918130258_create_comments.rb:5 - always add db index (comments => post_id)"
-    errors[1].to_s.should == "db/migrate/20090918130258_create_comments.rb:6 - always add db index (comments => user_id)"
+    errors[0].to_s.should == "db/schema.rb:4 - always add db index (comments => post_id)"
+    errors[1].to_s.should == "db/schema.rb:5 - always add db index (comments => user_id)"
   end
-
+  
   it "should always add db index with column has no id" do
     content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-          t.integer :position
-        end
-      end
-
-      def self.down
-        drop_table "comments"
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should always add db index with references" do
-    content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-          t.references :post
-          t.references :user
-        end
-      end
-
-      def self.down
-        drop_table "comments"
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/migrate/20090918130258_create_comments.rb:5 - always add db index (comments => post_id)"
-    errors[1].to_s.should == "db/migrate/20090918130258_create_comments.rb:6 - always add db index (comments => user_id)"
-  end
-
-  it "should always add db index with column" do
-    content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-          t.column :post_id, :integer
-          t.column :user_id, :integer
-        end
-      end
-
-      def self.down
-        drop_table "comments"
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/migrate/20090918130258_create_comments.rb:5 - always add db index (comments => post_id)"
-    errors[1].to_s.should == "db/migrate/20090918130258_create_comments.rb:6 - always add db index (comments => user_id)"
-  end
-
-  it "should not always add db index with add_index" do
-    content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-          t.integer :post_id
-          t.integer :user_id
-        end
-
-        add_index :comments, :post_id
-        add_index :comments, :user_id
-      end
-
-      def self.down
-        drop_table "comments"
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not always add db index with add_index in another migration file" do
-    content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-          t.integer :post_id
-          t.integer :user_id
-        end
-      end
-
-      def self.down
-        drop_table "comments"
-      end
-    end
-    EOF
-    add_index_content = <<-EOF
-    class AddIndexesToComments < ActiveRecord::Migration
-      def self.up
-        add_index :comments, :post_id
-        add_index :comments, :user_id
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090919130260_add_indexes_to_comments.rb', add_index_content)
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090919130260_add_indexes_to_comments.rb', add_index_content)
-    errors = @runner.errors
-    errors.should be_empty
-  end
-
-  it "should not always add db index with add_index in another migration file and a migration between them" do
-    content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-          t.integer :post_id
-          t.integer :user_id
-        end
-      end
-
-      def self.down
-        drop_table "comments"
-      end
-    end
-    EOF
-    another_content = <<-EOF
-    class Settings < ActiveRecord::Migration
-      def self.my_escape(val)
-      end
-
-      def self.up
-        add_column :settings, :groep, :string, :limit => 50
+    ActiveRecord::Schema.define(:version => 20100603080629) do
+      create_table "comments", :force => true do |t|
+        t.string "content"
+        t.integer "position"
       end
     end
     EOF
-    add_index_content = <<-EOF
-    class AddIndexesToComments < ActiveRecord::Migration
-      def self.up
-        add_index :comments, :post_id
-        add_index :comments, :user_id
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090918140258_create_comments.rb', content)
-    @runner.check('db/migrate/20090918140259_settings.rb', another_content)
-    @runner.check('db/migrate/20090919140260_add_indexes_to_comments.rb', add_index_content)
-    @runner.check('db/migrate/20090918140258_create_comments.rb', content)
-    @runner.check('db/migrate/20090918140259_settings.rb', another_content)
-    @runner.check('db/migrate/20090919140260_add_indexes_to_comments.rb', add_index_content)
+    @runner.check('db/schema.rb', content)
     errors = @runner.errors
     errors.should be_empty
   end
-
-  it "should always add db index without error" do
-    content = <<-EOF
-    class AddIndexes < ActiveRecord::Migration
-      def self.up
-        [[:site_wide_admins, :admin_id, { :unique => true }],
-         [:photos, [:target_id, :target_type, :type]],
-         [:photos, [:target_id, :target_type, :parent_id, :is_avatar]],
-         [:category_assignments, [:category_id, :sub_category_id, :target_id, :target_type]],
-         [:network_connections, :user_id]].each do |args|
-          add_index(*args) rescue say "Failed to add index"
-        end
-        # raise "abort migration"
-      end
-
-      def self.down
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20091111113612_add_indexes.rb', content)
-    @runner.check('db/migrate/20091111113612_add_indexes.rb', content)
-    errors = @runner.errors
-  end
-
-  it "should always add db index without error 2" do
-    content = <<-EOF
-    class MoveCategoriesToProfileArea < ActiveRecord::Migration
-      def self.up
-        CategoryArea.update_all({:name => "Profile"}, ["name IN (?)", %w(UserSite UserProfile Site)])
-      end
-
-      def self.down
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090706091635_move_categories_to_profile_area.rb', content)
-    @runner.check('db/migrate/20090706091635_move_categories_to_profile_area.rb', content)
-    errors = @runner.errors
-  end
-  
-  it "should always add db index without duplicate error outputs" do
-    content = <<-EOF
-    class AllTables < ActiveRecord::Migration
-      def self.up
-        create_table "ducks" do |t|
-          t.column "registration", :string, :limit => 32
-          t.column "description",  :string
-        end
-
-        create_table "lab_data" do |t|
-          t.integer "input_biologist_id", :null => true
-          t.integer "owner_biologist_id", :null => false
-          t.column "remark",             :string,   :limit => 250
-        end
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090204160203_all_tables.rb', content)
-    @runner.check('db/migrate/20090204160203_all_tables.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/migrate/20090204160203_all_tables.rb:9 - always add db index (lab_data => input_biologist_id)"
-    errors[1].to_s.should == "db/migrate/20090204160203_all_tables.rb:10 - always add db index (lab_data => owner_biologist_id)"
-  end
   
-  it "should not always add db index when table is created and droped" do
+  it "should not always add db index with add_index" do
     content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-          t.integer :post_id
-          t.integer :user_id
-        end
+    ActiveRecord::Schema.define(:version => 20100603080629) do
+      create_table "comments", :force => true do |t|
+        t.string "content"
+        t.integer "post_id"
+        t.integer "user_id"
       end
 
-      def self.down
-        drop_table "comments"
-      end
+      add_index "comments", ["post_id"], :name => "index_comments_on_post_id"
+      add_index "comments", ["user_id"], :name => "index_comments_on_user_id"
     end
     EOF
-    another_content = <<-EOF
-    class DropComments < ActiveRecord::Migration
-      def self.up
-        drop_table "comments"
-      end
-      
-      def self.down
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20100118140258_create_comments.rb', content)
-    @runner.check('db/migrate/20100118140259_drop_comments.rb', another_content)
-    @runner.check('db/migrate/20100118140258_create_comments.rb', content)
-    @runner.check('db/migrate/20100118140259_drop_comments.rb', another_content)
+    @runner.check('db/schema.rb', content)
     errors = @runner.errors
     errors.should be_empty
   end
-
-  it "should always add db index when add_column" do
-    content = <<-EOF
-    class CreateComments < ActiveRecord::Migration
-      def self.up
-        create_table "comments", :force => true do |t|
-          t.string :content
-        end
-        add_column :comments, :post_id, :integer
-        add_column :comments, :user_id, :integer
-      end
-
-      def self.down
-        drop_table "comments"
-      end
-    end
-    EOF
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "db/migrate/20090918130258_create_comments.rb:7 - always add db index (comments => post_id)"
-    errors[1].to_s.should == "db/migrate/20090918130258_create_comments.rb:8 - always add db index (comments => user_id)"
-  end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 3
-  - 19
-  version: 0.3.19
+  - 20
+  version: 0.3.20
 platform: ruby
 authors: 
 - Richard Huang
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-19 00:00:00 +08:00
+date: 2010-06-03 00:00:00 +08:00
 default_executable: rails_best_practices
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -151,26 +151,26 @@ signing_key:
 specification_version: 3
 summary: check rails files according to ihower's presentation 'rails best practices'
 test_files: 
-- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
-- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
 - spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
-- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
-- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
-- spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_model_check_spec.rb
-- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
 - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
-- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
-- spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
-- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
+- spec/rails_best_practices/checks/use_observer_check_spec.rb
 - spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
+- spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
+- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
+- spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
+- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
+- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
+- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
 - spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
+- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
+- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
+- spec/rails_best_practices/checks/use_model_callback_check_spec.rb
+- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
 - spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
-- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
 - spec/rails_best_practices/checks/use_model_association_check_spec.rb
-- spec/rails_best_practices/checks/use_model_callback_check_spec.rb
-- spec/rails_best_practices/checks/use_observer_check_spec.rb
-- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_model_check_spec.rb
+- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
+- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
 - spec/spec_helper.rb