rails_best_practices 0.3.18 → 0.3.19

data/VERSION

@@ -1 +1 @@
-0.3.18
+0.3.19

data/lib/rails_best_practices/checks/always_add_db_index_check.rb

@@ -76,6 +76,14 @@ module RailsBestPractices
               end
             end
           end
+          if :call == node.node_type and :add_column == node.message
+            table_name = node.arguments[1].to_ruby_string
+            column_name = node.arguments[2].to_ruby_string
+            column_type = node.arguments[3].to_ruby_string
+            if column_name =~ /_id$/ and column_type == "integer" and !@@indexes[table_name].include? column_name
+              add_error "always add db index (#{table_name} => #{column_name})", node.file, node.line
+            end
+          end
         end
       end
       

data/rails_best_practices.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.18"
+  s.version = "0.3.19"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
-  s.date = %q{2010-03-15}
+  s.date = %q{2010-03-19}
   s.default_executable = %q{rails_best_practices}
   s.description = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.email = %q{flyerhzm@gmail.com}

data/spec/rails_best_practices/checks/always_add_db_index_check_spec.rb

@@ -296,4 +296,28 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
     errors = @runner.errors
     errors.should be_empty
   end
+
+  it "should always add db index when add_column" do
+    content = <<-EOF
+    class CreateComments < ActiveRecord::Migration
+      def self.up
+        create_table "comments", :force => true do |t|
+          t.string :content
+        end
+        add_column :comments, :post_id, :integer
+        add_column :comments, :user_id, :integer
+      end
+
+      def self.down
+        drop_table "comments"
+      end
+    end
+    EOF
+    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
+    @runner.check('db/migrate/20090918130258_create_comments.rb', content)
+    errors = @runner.errors
+    errors.should_not be_empty
+    errors[0].to_s.should == "db/migrate/20090918130258_create_comments.rb:7 - always add db index (comments => post_id)"
+    errors[1].to_s.should == "db/migrate/20090918130258_create_comments.rb:8 - always add db index (comments => user_id)"
+  end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 3
-  - 18
-  version: 0.3.18
+  - 19
+  version: 0.3.19
 platform: ruby
 authors: 
 - Richard Huang
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-15 00:00:00 +08:00
+date: 2010-03-19 00:00:00 +08:00
 default_executable: rails_best_practices
 dependencies: 
 - !ruby/object:Gem::Dependency