rails_best_practices 0.3.14 → 0.3.15

data/VERSION

@@ -1 +1 @@
-0.3.14
+0.3.15

data/lib/rails_best_practices/checks/always_add_db_index_check.rb

@@ -56,20 +56,20 @@ module RailsBestPractices
             node.grep_nodes({:node_type => :call, :message => :integer}).each do |integer_node|
               column_name = integer_node.arguments[1].to_ruby_string
               if column_name =~ /_id$/ and !@@indexes[table_name].include? column_name
-                add_error "always add db index (#{table_name} => #{column_name})", integer_node
+                add_error "always add db index (#{table_name} => #{column_name})", integer_node.file, integer_node.line
               end
             end
             node.grep_nodes({:node_type => :call, :message => :references}).each do |references_node|
               column_name = references_node.arguments[1].to_ruby_string + "_id"
               if !@@indexes[table_name].include? column_name
-                add_error "always add db index (#{table_name} => #{column_name})", references_node
+                add_error "always add db index (#{table_name} => #{column_name})", references_node.file, references_node.line
               end
             end
             node.grep_nodes({:node_type => :call, :message => :column}).each do |column_node|
               if 'integer' == column_node.arguments[2].to_ruby_string
                 column_name = column_node.arguments[1].to_ruby_string
                 if column_name =~ /_id$/ and !@@indexes[table_name].include? column_name
-                  add_error "always add db index (#{table_name} => #{column_name})", column_node
+                  add_error "always add db index (#{table_name} => #{column_name})", column_node.file, column_node.line
                 end
               end
             end

data/lib/rails_best_practices/checks/check.rb

@@ -52,9 +52,10 @@ module RailsBestPractices
         evaluate_end(node)
       end
       
-      def add_error(error, node = nil)
-        node ||= @node
-        @errors << RailsBestPractices::Core::Error.new("#{node.file}", "#{node.line}", error)
+      def add_error(error, file = nil, line = nil)
+        file ||= @node.file
+        line ||= @node.line
+        @errors << RailsBestPractices::Core::Error.new("#{file}", "#{line}", error)
       end
   
       def errors

data/lib/rails_best_practices/checks/use_before_filter_check.rb

@@ -18,19 +18,21 @@ module RailsBestPractices
       def evaluate_start(node)
         @methods = {}
         node.grep_nodes({:node_type => :defn}).each { |method_node| remember_method(method_node) }
-        @methods.each do |first_call, method_names|
-          add_error "use before_filter for #{first_call.to_ruby} in #{method_names.join(',')}" if method_names.size > 1
+        @methods.each do |first_call, method_nodes|
+          if method_nodes.size > 1
+            add_error "use before_filter for #{method_nodes.collect{|method_node| method_node.message_name}.join(',')}", 
+              node.file, method_nodes.collect{|method_node| method_node.line}.join(',')
+          end
         end
       end
 
       private
 
       def remember_method(method_node)
-        method_name = method_node.message_name
         first_call = method_node.body[1]
         unless first_call == s(:nil)
           @methods[first_call] ||= []
-          @methods[first_call] << method_name
+          @methods[first_call] << method_node
         end
       end
     end

data/rails_best_practices.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.14"
+  s.version = "0.3.15"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
-  s.date = %q{2009-12-15}
+  s.date = %q{2009-12-22}
   s.default_executable = %q{rails_best_practices}
   s.description = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.email = %q{flyerhzm@gmail.com}

data/spec/rails_best_practices/checks/use_before_filter_check_spec.rb

@@ -32,7 +32,7 @@ describe RailsBestPractices::Checks::UseBeforeFilterCheck do
     @runner.check('app/controllers/posts_controller.rb', content)
     errors = @runner.errors
     errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:1 - use before_filter for @post = current_user.posts.find(params[:id]) in show,edit,update,destroy"
+    errors[0].to_s.should == "app/controllers/posts_controller.rb:3,7,11,16 - use before_filter for show,edit,update,destroy"
   end
   
   it "should not use before_filter" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.3.14
+  version: 0.3.15
 platform: ruby
 authors: 
 - Richard Huang
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-12-15 00:00:00 +08:00
+date: 2009-12-22 00:00:00 +08:00
 default_executable: rails_best_practices
 dependencies: 
 - !ruby/object:Gem::Dependency