rails_best_practices 0.3.0 → 0.4.0

data/spec/rails_best_practices/checks/{use_filter_check_spec.rb → use_before_filter_check_spec.rb}

@@ -1,11 +1,11 @@
 require File.join(File.dirname(__FILE__) + '/../../spec_helper')
 
-describe RailsBestPractices::Checks::UseFilterCheck do
+describe RailsBestPractices::Checks::UseBeforeFilterCheck do
   before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseFilterCheck.new)
+    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseBeforeFilterCheck.new)
   end
   
-  it "should use filter" do
+  it "should use before_filter" do
     content = <<-EOF
     class PostsController < ApplicationController
 
@@ -32,10 +32,10 @@ describe RailsBestPractices::Checks::UseFilterCheck do
     @runner.check('app/controllers/posts_controller.rb', content)
     errors = @runner.errors
     errors.should_not be_empty
-    errors[0].to_s.should == "app/controllers/posts_controller.rb:1 - use filter for @post = current_user.posts.find(params[:id]) in show,edit,update,destroy"
+    errors[0].to_s.should == "app/controllers/posts_controller.rb:3,7,11,16 - use before_filter for show,edit,update,destroy"
   end
   
-  it "should not use filter" do
+  it "should not use before_filter" do
     content = <<-EOF
     class PostsController < ApplicationController
       before_filter :find_post, :only => [:show, :edit, :update, :destroy]
@@ -60,7 +60,7 @@ describe RailsBestPractices::Checks::UseFilterCheck do
     errors.should be_empty
   end
 
-  it "should not use filter by nil" do
+  it "should not use before_filter by nil" do
     content = <<-EOF
     class PostsController < ApplicationController
 

data/spec/rails_best_practices/checks/use_scope_access_check_spec.rb

@@ -167,5 +167,27 @@ describe RailsBestPractices::Checks::UseScopeAccessCheck do
       errors.should_not be_empty
       errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
+    
+    it "should no error in use_scope_access_check" do
+      content = <<-EOF
+      class CommentsController < ApplicationController
+      
+        def add_comment
+          @current_user = User.find_by_id(session[:user_id])
+          @id = params[:post_id]
+          @error = ""
+          if (@text = params[:text]) == ""
+            @error = "Please enter a comment!"
+          else
+            @comment = Comment.create_object(@text,  @id, @current_user.id)
+          end
+          unless @comment
+            @error = "Comment could not be saved."
+          end
+        end
+      end
+      EOF
+      @runner.check('app/controllers/comments_controller.rb', content)
+    end
   end
 end

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
+  prerelease: false
+  segments: 
+  - 0
+  - 4
+  - 0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Richard Huang
@@ -9,30 +14,38 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-10 00:00:00 +08:00
+date: 2010-08-15 00:00:00 +08:00
 default_executable: rails_best_practices
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: ruby_parser
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 2
+        - 0
+        - 4
         version: 2.0.4
-    version: 
+  type: :runtime
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: ruby2ruby
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 2
+        - 4
         version: 1.2.4
-    version: 
-description: check rails files according to ihower's presentation 'rails best practices'
+  type: :runtime
+  version_requirements: *id002
+description: a code metric tool for rails codes.
 email: flyerhzm@gmail.com
 executables: 
 - rails_best_practices
@@ -48,6 +61,7 @@ files:
 - Rakefile
 - VERSION
 - bin/rails_best_practices
+- identifier
 - lib/rails_best_practices.rb
 - lib/rails_best_practices/checks.rb
 - lib/rails_best_practices/checks/add_model_virtual_attribute_check.rb
@@ -56,20 +70,18 @@ files:
 - lib/rails_best_practices/checks/isolate_seed_data_check.rb
 - lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
 - lib/rails_best_practices/checks/law_of_demeter_check.rb
-- lib/rails_best_practices/checks/many_to_many_collection_check.rb
 - lib/rails_best_practices/checks/move_code_into_controller_check.rb
 - lib/rails_best_practices/checks/move_code_into_helper_check.rb
+- lib/rails_best_practices/checks/move_code_into_model_check.rb
 - lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb
 - lib/rails_best_practices/checks/move_model_logic_into_model_check.rb
 - lib/rails_best_practices/checks/needless_deep_nesting_check.rb
-- lib/rails_best_practices/checks/nested_model_forms_check.rb
 - lib/rails_best_practices/checks/not_use_default_route_check.rb
 - lib/rails_best_practices/checks/overuse_route_customizations_check.rb
 - lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb
 - lib/rails_best_practices/checks/replace_instance_variable_with_local_variable_check.rb
-- lib/rails_best_practices/checks/use_filter_check.rb
+- lib/rails_best_practices/checks/use_before_filter_check.rb
 - lib/rails_best_practices/checks/use_model_association_check.rb
-- lib/rails_best_practices/checks/use_model_callback_check.rb
 - lib/rails_best_practices/checks/use_observer_check.rb
 - lib/rails_best_practices/checks/use_scope_access_check.rb
 - lib/rails_best_practices/command.rb
@@ -86,26 +98,24 @@ files:
 - spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
 - spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
 - spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
-- spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
 - spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
 - spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_model_check_spec.rb
 - spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
 - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
 - spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
-- spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
 - spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
 - spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
 - spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
 - spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
-- spec/rails_best_practices/checks/use_filter_check_spec.rb
+- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
 - spec/rails_best_practices/checks/use_model_association_check_spec.rb
-- spec/rails_best_practices/checks/use_model_callback_check_spec.rb
 - spec/rails_best_practices/checks/use_observer_check_spec.rb
 - spec/rails_best_practices/checks/use_scope_access_check_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
 has_rdoc: true
-homepage: http://github.com/flyerhzm/rails_best_practices
+homepage: http://rails-bestpractices.com
 licenses: []
 
 post_install_message: 
@@ -117,41 +127,41 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
-summary: check rails files according to ihower's presentation 'rails best practices'
+summary: a code metric tool for rails codes.
 test_files: 
-- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
-- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
 - spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
-- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
-- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
-- spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
-- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
-- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
 - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
-- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
-- spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
-- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
+- spec/rails_best_practices/checks/use_observer_check_spec.rb
 - spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
+- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
+- spec/rails_best_practices/checks/use_before_filter_check_spec.rb
+- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
+- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
 - spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
+- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
+- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
+- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
 - spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
-- spec/rails_best_practices/checks/use_filter_check_spec.rb
 - spec/rails_best_practices/checks/use_model_association_check_spec.rb
-- spec/rails_best_practices/checks/use_model_callback_check_spec.rb
-- spec/rails_best_practices/checks/use_observer_check_spec.rb
-- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_model_check_spec.rb
+- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
+- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
 - spec/spec_helper.rb

data/lib/rails_best_practices/checks/many_to_many_collection_check.rb

@@ -1,12 +0,0 @@
-require 'rails_best_practices/checks/check'
-
-module RailsBestPractices
-  module Checks
-    # TODO: unknown how to realize it.
-    class ManyToManyCollectionCheck < Check
-      
-      def interesting_nodes
-      end
-    end
-  end
-end

data/lib/rails_best_practices/checks/nested_model_forms_check.rb

@@ -1,12 +0,0 @@
-require 'rails_best_practices/checks/check'
-
-module RailsBestPractices
-  module Checks
-    # TODO: unknown how to realize it.
-    class NestedModelFormsCheck < Check
-      
-      def interesting_nodes
-      end
-    end
-  end
-end

data/lib/rails_best_practices/checks/use_model_callback_check.rb

@@ -1,12 +0,0 @@
-require 'rails_best_practices/checks/check'
-
-module RailsBestPractices
-  module Checks
-    # TODO: unknown how to realize it.
-    class UseModelCallbackCheck < Check
-      
-      def interesting_nodes
-      end
-    end
-  end
-end

data/spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb

@@ -1,11 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::ManyToManyCollectionCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::ManyToManyCollectionCheck.new)
-  end
-  
-  it "should many to many collection check" do
-    pending
-  end
-end

data/spec/rails_best_practices/checks/nested_model_forms_check_spec.rb

@@ -1,11 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::NestedModelFormsCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::NestedModelFormsCheck.new)
-  end
-  
-  it "should nested model form check" do
-    pending
-  end
-end

data/spec/rails_best_practices/checks/use_model_callback_check_spec.rb

@@ -1,11 +0,0 @@
-require File.join(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe RailsBestPractices::Checks::UseModelCallbackCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::UseModelCallbackCheck.new)
-  end
-  
-  it "should use model callback check" do
-    pending
-  end
-end