rails_best_practices 0.2.5 → 0.2.6

data/VERSION

@@ -1 +1 @@
-0.2.5
+0.2.6

data/lib/rails_best_practices/checks/use_observer_check.rb

@@ -33,7 +33,9 @@ module RailsBestPractices
       private
 
       def remember_callbacks(node)
-        @callbacks << eval(node.arguments.to_ruby).to_s
+        node.arguments[1..-1].each do |argument|
+          @callbacks << eval(argument.to_ruby).to_s
+        end
       end
 
       def use_observer?(node)

data/lib/rails_best_practices/command.rb

@@ -1,11 +1,12 @@
 require 'optparse'
 
 def expand_dirs_to_files *dirs
+  # extensions = ['rb', 'erb', 'builder']
   extensions = ['rb', 'builder']
 
   dirs.flatten.map { |p|
     if File.directory? p
-      Dir[File.join(p, '**', "*{#{extensions.join(',')}}")]
+      Dir[File.join(p, '**', "*.{#{extensions.join(',')}}")]
     else
       p
     end
@@ -27,6 +28,10 @@ def add_duplicate_migration_files files
   (files << migration_files).flatten
 end
 
+def ignore_vendor_directories files
+  files.reject { |file| file.index("vendor/") }
+end
+
 options = {}
 OptionParser.new do |opts|
   opts.banner = "Usage: rails_best_practices [options]"
@@ -40,7 +45,7 @@ OptionParser.new do |opts|
 end
 
 runner = RailsBestPractices::Core::Runner.new
-add_duplicate_migration_files(expand_dirs_to_files(ARGV)).each { |file| runner.check_file(file) }
+ignore_vendor_directories(add_duplicate_migration_files(expand_dirs_to_files(ARGV))).each { |file| runner.check_file(file) }
 runner.errors.each {|error| puts error}
 puts "\nFound #{runner.errors.size} errors."
 

data/lib/rails_best_practices/core/runner.rb

@@ -49,7 +49,7 @@ module RailsBestPractices
         begin
           @parser.parse(content, filename)
         rescue Exception => e
-          puts "#{filename} looks like it's not a valid Ruby file.  Skipping..." if ENV["ROODI_DEBUG"]
+          puts "#{filename} looks like it's not a valid Ruby file.  Skipping..."
           nil
         end
       end

data/rails_best_practices.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.2.5"
+  s.version = "0.2.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]

data/spec/rails_best_practices/checks/use_observer_check_spec.rb

@@ -41,4 +41,27 @@ describe RailsBestPractices::Checks::UseObserverCheck do
     errors = @runner.errors
     errors.should be_empty
   end
+
+  it "should use observer with two after_create" do
+    content =<<-EOF
+    class Project < ActiveRecord::Base
+      after_create :send_create_notification, :update_author
+
+      private
+
+      def send_create_notification
+        self.members.each do |member|
+          ProjectMailer.deliver_notification(self, member)
+        end
+      end
+
+      def update_author
+      end
+    end
+    EOF
+    @runner.check('app/models/project.rb', content)
+    errors = @runner.errors
+    errors.should_not be_empty
+    errors[0].to_s.should == "app/models/project.rb:6 - use observer"
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors: 
 - Richard Huang