rails_best_practices 0.2.12 → 0.2.13

data/README.textile

@@ -1,4 +1,5 @@
 h1. rails_best_practices
+
 rails_best_practices is a gem to check quality of rails app files according to ihower's presentation Rails Best Practices.
 rails_best_practices is a code static parser tool based on ruby_parser.
 

data/VERSION

@@ -1 +1 @@
-0.2.12
+0.2.13

data/lib/rails_best_practices/checks/isolate_seed_data_check.rb

@@ -8,7 +8,7 @@ module RailsBestPractices
     class IsolateSeedDataCheck < Check
 
       def interesting_nodes
-        [:call, :lasgn]
+        [:defs, :call, :lasgn]
       end
 
       def interesting_files
@@ -18,15 +18,28 @@ module RailsBestPractices
       def initialize
         super
         @new_variables = []
+        @files = []
+        @parse = false
       end
 
       def evaluate_start(node)
-        if [:create, :create!].include? node.message
-          add_error("isolate seed data")
-        elsif :lasgn == node.node_type
-          remember_new_variable(node)
-        elsif [:save, :save!].include? node.message
-          add_error("isolate seed data") if new_record?(node)
+        # check duplicate migration because of always_add_db_index_check.
+        if :defs == node.node_type
+          if @files.include? node.file
+            @parse = true if :up == node.message
+          else
+            @files << node.file
+          end
+        end
+        
+        if @parse
+          if [:create, :create!].include? node.message
+            add_error("isolate seed data")
+          elsif :lasgn == node.node_type
+            remember_new_variable(node)
+          elsif [:save, :save!].include? node.message
+            add_error("isolate seed data") if new_record?(node)
+          end
         end
       end
 

data/lib/rails_best_practices/core/runner.rb

@@ -54,7 +54,7 @@ module RailsBestPractices
         begin
           RubyParser.new.parse(content, filename)
         rescue Exception => e
-          puts "#{filename} looks like it's not a valid Ruby file.  Skipping..."
+          puts "#{filename} looks like it's not a valid Ruby file.  Skipping..." if @debug
           nil
         end
       end

data/rails_best_practices.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.2.12"
+  s.version = "0.2.13"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
-  s.date = %q{2009-11-09}
+  s.date = %q{2009-11-10}
   s.default_executable = %q{rails_best_practices}
   s.description = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.email = %q{flyerhzm@gmail.com}
@@ -82,24 +82,24 @@ Gem::Specification.new do |s|
   s.rubygems_version = %q{1.3.5}
   s.summary = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.test_files = [
-    "spec/rails_best_practices/checks/use_scope_access_check_spec.rb",
-     "spec/rails_best_practices/checks/not_use_default_route_check_spec.rb",
-     "spec/rails_best_practices/checks/use_filter_check_spec.rb",
-     "spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb",
-     "spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb",
-     "spec/rails_best_practices/checks/use_model_callback_check_spec.rb",
+    "spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb",
+     "spec/rails_best_practices/checks/always_add_db_index_check_spec.rb",
      "spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb",
-     "spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb",
-     "spec/rails_best_practices/checks/use_model_association_check_spec.rb",
-     "spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb",
+     "spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb",
      "spec/rails_best_practices/checks/law_of_demeter_check_spec.rb",
-     "spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb",
-     "spec/rails_best_practices/checks/nested_model_forms_check_spec.rb",
-     "spec/rails_best_practices/checks/use_observer_check_spec.rb",
+     "spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb",
      "spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb",
+     "spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb",
      "spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb",
+     "spec/rails_best_practices/checks/nested_model_forms_check_spec.rb",
+     "spec/rails_best_practices/checks/not_use_default_route_check_spec.rb",
      "spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb",
-     "spec/rails_best_practices/checks/always_add_db_index_check_spec.rb",
+     "spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb",
+     "spec/rails_best_practices/checks/use_filter_check_spec.rb",
+     "spec/rails_best_practices/checks/use_model_association_check_spec.rb",
+     "spec/rails_best_practices/checks/use_model_callback_check_spec.rb",
+     "spec/rails_best_practices/checks/use_observer_check_spec.rb",
+     "spec/rails_best_practices/checks/use_scope_access_check_spec.rb",
      "spec/spec_helper.rb"
   ]
 

data/spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb

@@ -24,11 +24,14 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
     end
     EOF
     @runner.check('db/migrate/20090818130258_create_roles.rb', content)
+    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
     errors = @runner.errors
     errors.should_not be_empty
     errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:8 - isolate seed data"
+    puts errors.inspect
+    errors.size.should == 1
   end
-
+  
   it "should isolate seed data with new and save" do
     content = <<-EOF
     class CreateRoles < ActiveRecord::Migration
@@ -36,24 +39,25 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
         create_table "roles", :force => true do |t|
           t.string :name
         end
-
+  
         ["admin", "author", "editor", "account"].each do |name|
           role = Role.new(:name => name)
           role.save!
         end
       end
-
+  
       def self.down
         drop_table "roles"
       end
     end
     EOF
     @runner.check('db/migrate/20090818130258_create_roles.rb', content)
+    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
     errors = @runner.errors
     errors.should_not be_empty
     errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:9 - isolate seed data"
   end
-
+  
   it "should not isolate seed data without data insert" do
     content = <<-EOF
     class CreateRoles < ActiveRecord::Migration
@@ -62,13 +66,14 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
           t.string :name
         end
       end
-
+  
       def self.down
         drop_table "roles"
       end
     end
     EOF
     @runner.check('db/migrate/20090818130258_create_roles.rb', content)
+    @runner.check('db/migrate/20090818130258_create_roles.rb', content)
     errors = @runner.errors
     errors.should be_empty
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.2.12
+  version: 0.2.13
 platform: ruby
 authors: 
 - Richard Huang
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-09 00:00:00 +08:00
+date: 2009-11-10 00:00:00 +08:00
 default_executable: rails_best_practices
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -127,22 +127,22 @@ signing_key:
 specification_version: 3
 summary: check rails files according to ihower's presentation 'rails best practices'
 test_files: 
-- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
-- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
-- spec/rails_best_practices/checks/use_filter_check_spec.rb
 - spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
-- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
-- spec/rails_best_practices/checks/use_model_callback_check_spec.rb
+- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
 - spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
-- spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
-- spec/rails_best_practices/checks/use_model_association_check_spec.rb
-- spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
+- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
 - spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
-- spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
-- spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
-- spec/rails_best_practices/checks/use_observer_check_spec.rb
+- spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
 - spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
+- spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
 - spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
+- spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
+- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
 - spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
-- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
+- spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
+- spec/rails_best_practices/checks/use_filter_check_spec.rb
+- spec/rails_best_practices/checks/use_model_association_check_spec.rb
+- spec/rails_best_practices/checks/use_model_callback_check_spec.rb
+- spec/rails_best_practices/checks/use_observer_check_spec.rb
+- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
 - spec/spec_helper.rb