rails_best_practices 0.2.0 → 0.3.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (41) hide show
  1. data/README.textile +32 -14
  2. data/Rakefile +2 -2
  3. data/VERSION +1 -1
  4. data/lib/rails_best_practices/checks/add_model_virtual_attribute_check.rb +12 -7
  5. data/lib/rails_best_practices/checks/always_add_db_index_check.rb +90 -0
  6. data/lib/rails_best_practices/checks/check.rb +9 -3
  7. data/lib/rails_best_practices/checks/isolate_seed_data_check.rb +59 -0
  8. data/lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb +29 -0
  9. data/lib/rails_best_practices/checks/law_of_demeter_check.rb +47 -0
  10. data/lib/rails_best_practices/checks/move_code_into_controller_check.rb +31 -0
  11. data/lib/rails_best_practices/checks/move_code_into_helper_check.rb +29 -0
  12. data/lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb +1 -1
  13. data/lib/rails_best_practices/checks/move_model_logic_into_model_check.rb +1 -1
  14. data/lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb +1 -1
  15. data/lib/rails_best_practices/checks/replace_instance_variable_with_local_variable_check.rb +23 -0
  16. data/lib/rails_best_practices/checks/use_filter_check.rb +38 -0
  17. data/lib/rails_best_practices/checks/use_observer_check.rb +49 -0
  18. data/lib/rails_best_practices/checks/use_scope_access_check.rb +3 -3
  19. data/lib/rails_best_practices/checks.rb +10 -1
  20. data/lib/rails_best_practices/command.rb +50 -5
  21. data/lib/rails_best_practices/core/core_ext.rb +12 -1
  22. data/lib/rails_best_practices/core/runner.rb +12 -3
  23. data/lib/rails_best_practices/core/visitable_sexp.rb +21 -5
  24. data/rails_best_practices.gemspec +43 -16
  25. data/rails_best_practices.yml +9 -0
  26. data/spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb +57 -4
  27. data/spec/rails_best_practices/checks/always_add_db_index_check_spec.rb +153 -0
  28. data/spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb +79 -0
  29. data/spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb +71 -0
  30. data/spec/rails_best_practices/checks/law_of_demeter_check_spec.rb +37 -0
  31. data/spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb +33 -0
  32. data/spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb +29 -0
  33. data/spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb +6 -6
  34. data/spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb +4 -4
  35. data/spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb +5 -5
  36. data/spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb +26 -0
  37. data/spec/rails_best_practices/checks/use_filter_check_spec.rb +85 -0
  38. data/spec/rails_best_practices/checks/use_model_association_check_spec.rb +6 -6
  39. data/spec/rails_best_practices/checks/use_observer_check_spec.rb +67 -0
  40. data/spec/rails_best_practices/checks/use_scope_access_check_spec.rb +17 -17
  41. metadata +38 -11
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rails_best_practices
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.2.0
4
+ version: 0.3.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Richard Huang
@@ -9,7 +9,7 @@ autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
11
 
12
- date: 2009-11-06 00:00:00 +08:00
12
+ date: 2009-11-10 00:00:00 +08:00
13
13
  default_executable: rails_best_practices
14
14
  dependencies:
15
15
  - !ruby/object:Gem::Dependency
@@ -20,7 +20,7 @@ dependencies:
20
20
  requirements:
21
21
  - - ">="
22
22
  - !ruby/object:Gem::Version
23
- version: "0"
23
+ version: 2.0.4
24
24
  version:
25
25
  - !ruby/object:Gem::Dependency
26
26
  name: ruby2ruby
@@ -30,7 +30,7 @@ dependencies:
30
30
  requirements:
31
31
  - - ">="
32
32
  - !ruby/object:Gem::Version
33
- version: "0"
33
+ version: 1.2.4
34
34
  version:
35
35
  description: check rails files according to ihower's presentation 'rails best practices'
36
36
  email: flyerhzm@gmail.com
@@ -51,8 +51,14 @@ files:
51
51
  - lib/rails_best_practices.rb
52
52
  - lib/rails_best_practices/checks.rb
53
53
  - lib/rails_best_practices/checks/add_model_virtual_attribute_check.rb
54
+ - lib/rails_best_practices/checks/always_add_db_index_check.rb
54
55
  - lib/rails_best_practices/checks/check.rb
56
+ - lib/rails_best_practices/checks/isolate_seed_data_check.rb
57
+ - lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
58
+ - lib/rails_best_practices/checks/law_of_demeter_check.rb
55
59
  - lib/rails_best_practices/checks/many_to_many_collection_check.rb
60
+ - lib/rails_best_practices/checks/move_code_into_controller_check.rb
61
+ - lib/rails_best_practices/checks/move_code_into_helper_check.rb
56
62
  - lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb
57
63
  - lib/rails_best_practices/checks/move_model_logic_into_model_check.rb
58
64
  - lib/rails_best_practices/checks/needless_deep_nesting_check.rb
@@ -60,8 +66,11 @@ files:
60
66
  - lib/rails_best_practices/checks/not_use_default_route_check.rb
61
67
  - lib/rails_best_practices/checks/overuse_route_customizations_check.rb
62
68
  - lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb
69
+ - lib/rails_best_practices/checks/replace_instance_variable_with_local_variable_check.rb
70
+ - lib/rails_best_practices/checks/use_filter_check.rb
63
71
  - lib/rails_best_practices/checks/use_model_association_check.rb
64
72
  - lib/rails_best_practices/checks/use_model_callback_check.rb
73
+ - lib/rails_best_practices/checks/use_observer_check.rb
65
74
  - lib/rails_best_practices/checks/use_scope_access_check.rb
66
75
  - lib/rails_best_practices/command.rb
67
76
  - lib/rails_best_practices/core.rb
@@ -73,7 +82,13 @@ files:
73
82
  - rails_best_practices.gemspec
74
83
  - rails_best_practices.yml
75
84
  - spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
85
+ - spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
86
+ - spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
87
+ - spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
88
+ - spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
76
89
  - spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
90
+ - spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
91
+ - spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
77
92
  - spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
78
93
  - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
79
94
  - spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
@@ -81,8 +96,11 @@ files:
81
96
  - spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
82
97
  - spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
83
98
  - spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
99
+ - spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
100
+ - spec/rails_best_practices/checks/use_filter_check_spec.rb
84
101
  - spec/rails_best_practices/checks/use_model_association_check_spec.rb
85
102
  - spec/rails_best_practices/checks/use_model_callback_check_spec.rb
103
+ - spec/rails_best_practices/checks/use_observer_check_spec.rb
86
104
  - spec/rails_best_practices/checks/use_scope_access_check_spec.rb
87
105
  - spec/spec.opts
88
106
  - spec/spec_helper.rb
@@ -115,16 +133,25 @@ signing_key:
115
133
  specification_version: 3
116
134
  summary: check rails files according to ihower's presentation 'rails best practices'
117
135
  test_files:
118
- - spec/rails_best_practices/checks/use_scope_access_check_spec.rb
119
- - spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
120
136
  - spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
121
- - spec/rails_best_practices/checks/use_model_callback_check_spec.rb
137
+ - spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
138
+ - spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
139
+ - spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
140
+ - spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
122
141
  - spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
123
- - spec/rails_best_practices/checks/use_model_association_check_spec.rb
124
- - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
125
- - spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
126
- - spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
142
+ - spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
143
+ - spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
127
144
  - spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
145
+ - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
128
146
  - spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
147
+ - spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
148
+ - spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
129
149
  - spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
150
+ - spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
151
+ - spec/rails_best_practices/checks/replace_instance_variable_with_local_variable_check_spec.rb
152
+ - spec/rails_best_practices/checks/use_filter_check_spec.rb
153
+ - spec/rails_best_practices/checks/use_model_association_check_spec.rb
154
+ - spec/rails_best_practices/checks/use_model_callback_check_spec.rb
155
+ - spec/rails_best_practices/checks/use_observer_check_spec.rb
156
+ - spec/rails_best_practices/checks/use_scope_access_check_spec.rb
130
157
  - spec/spec_helper.rb