rails_best_practices 0.2.0 → 0.2.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- data/README.textile +11 -6
- data/VERSION +1 -1
- data/lib/rails_best_practices/checks/always_add_db_index_check.rb +83 -0
- data/lib/rails_best_practices/checks/check.rb +1 -1
- data/lib/rails_best_practices/checks/isolate_seed_data_check.rb +46 -0
- data/lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb +29 -0
- data/lib/rails_best_practices/checks/law_of_demeter_check.rb +47 -0
- data/lib/rails_best_practices/checks/use_observer_check.rb +49 -0
- data/lib/rails_best_practices/checks/use_scope_access_check.rb +2 -2
- data/lib/rails_best_practices/checks.rb +6 -1
- data/lib/rails_best_practices/command.rb +24 -4
- data/lib/rails_best_practices/core/core_ext.rb +12 -1
- data/lib/rails_best_practices/core/runner.rb +5 -1
- data/lib/rails_best_practices/core/visitable_sexp.rb +14 -5
- data/rails_best_practices.gemspec +17 -2
- data/rails_best_practices.yml +5 -0
- data/spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb +22 -4
- data/spec/rails_best_practices/checks/always_add_db_index_check_spec.rb +153 -0
- data/spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb +75 -0
- data/spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb +71 -0
- data/spec/rails_best_practices/checks/law_of_demeter_check_spec.rb +37 -0
- data/spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb +6 -6
- data/spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb +4 -4
- data/spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb +5 -5
- data/spec/rails_best_practices/checks/use_model_association_check_spec.rb +6 -6
- data/spec/rails_best_practices/checks/use_observer_check_spec.rb +67 -0
- data/spec/rails_best_practices/checks/use_scope_access_check_spec.rb +17 -17
- metadata +17 -2
metadata
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: rails_best_practices
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 0.2.
|
|
4
|
+
version: 0.2.6
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Richard Huang
|
|
@@ -9,7 +9,7 @@ autorequire:
|
|
|
9
9
|
bindir: bin
|
|
10
10
|
cert_chain: []
|
|
11
11
|
|
|
12
|
-
date: 2009-11-
|
|
12
|
+
date: 2009-11-08 00:00:00 +08:00
|
|
13
13
|
default_executable: rails_best_practices
|
|
14
14
|
dependencies:
|
|
15
15
|
- !ruby/object:Gem::Dependency
|
|
@@ -51,7 +51,11 @@ files:
|
|
|
51
51
|
- lib/rails_best_practices.rb
|
|
52
52
|
- lib/rails_best_practices/checks.rb
|
|
53
53
|
- lib/rails_best_practices/checks/add_model_virtual_attribute_check.rb
|
|
54
|
+
- lib/rails_best_practices/checks/always_add_db_index_check.rb
|
|
54
55
|
- lib/rails_best_practices/checks/check.rb
|
|
56
|
+
- lib/rails_best_practices/checks/isolate_seed_data_check.rb
|
|
57
|
+
- lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
|
|
58
|
+
- lib/rails_best_practices/checks/law_of_demeter_check.rb
|
|
55
59
|
- lib/rails_best_practices/checks/many_to_many_collection_check.rb
|
|
56
60
|
- lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb
|
|
57
61
|
- lib/rails_best_practices/checks/move_model_logic_into_model_check.rb
|
|
@@ -62,6 +66,7 @@ files:
|
|
|
62
66
|
- lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb
|
|
63
67
|
- lib/rails_best_practices/checks/use_model_association_check.rb
|
|
64
68
|
- lib/rails_best_practices/checks/use_model_callback_check.rb
|
|
69
|
+
- lib/rails_best_practices/checks/use_observer_check.rb
|
|
65
70
|
- lib/rails_best_practices/checks/use_scope_access_check.rb
|
|
66
71
|
- lib/rails_best_practices/command.rb
|
|
67
72
|
- lib/rails_best_practices/core.rb
|
|
@@ -73,6 +78,10 @@ files:
|
|
|
73
78
|
- rails_best_practices.gemspec
|
|
74
79
|
- rails_best_practices.yml
|
|
75
80
|
- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
|
|
81
|
+
- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
|
|
82
|
+
- spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
|
|
83
|
+
- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
|
|
84
|
+
- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
|
|
76
85
|
- spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
|
|
77
86
|
- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
|
|
78
87
|
- spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
|
|
@@ -83,6 +92,7 @@ files:
|
|
|
83
92
|
- spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
|
|
84
93
|
- spec/rails_best_practices/checks/use_model_association_check_spec.rb
|
|
85
94
|
- spec/rails_best_practices/checks/use_model_callback_check_spec.rb
|
|
95
|
+
- spec/rails_best_practices/checks/use_observer_check_spec.rb
|
|
86
96
|
- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
|
|
87
97
|
- spec/spec.opts
|
|
88
98
|
- spec/spec_helper.rb
|
|
@@ -118,13 +128,18 @@ test_files:
|
|
|
118
128
|
- spec/rails_best_practices/checks/use_scope_access_check_spec.rb
|
|
119
129
|
- spec/rails_best_practices/checks/not_use_default_route_check_spec.rb
|
|
120
130
|
- spec/rails_best_practices/checks/add_model_virtual_attribute_check_spec.rb
|
|
131
|
+
- spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
|
|
121
132
|
- spec/rails_best_practices/checks/use_model_callback_check_spec.rb
|
|
133
|
+
- spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb
|
|
122
134
|
- spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
|
|
123
135
|
- spec/rails_best_practices/checks/use_model_association_check_spec.rb
|
|
124
136
|
- spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
|
|
137
|
+
- spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
|
|
125
138
|
- spec/rails_best_practices/checks/replace_complex_creation_with_factory_method_check_spec.rb
|
|
126
139
|
- spec/rails_best_practices/checks/nested_model_forms_check_spec.rb
|
|
140
|
+
- spec/rails_best_practices/checks/use_observer_check_spec.rb
|
|
127
141
|
- spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
|
|
128
142
|
- spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
|
|
129
143
|
- spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb
|
|
144
|
+
- spec/rails_best_practices/checks/always_add_db_index_check_spec.rb
|
|
130
145
|
- spec/spec_helper.rb
|