rails_best_practices 0.10.1 → 1.0.0

data/spec/rails_best_practices/prepares/model_prepare_spec.rb

@@ -18,10 +18,10 @@ describe RailsBestPractices::Prepares::ModelPrepare do
     EOF
     runner.prepare('app/models/project.rb', content)
     model_associations = RailsBestPractices::Prepares.model_associations
-    model_associations.get_association("Project", "portfolio").should == {:meta => :belongs_to, :class_name => "Portfolio"}
-    model_associations.get_association("Project", "project_manager").should == {:meta => :has_one, :class_name => "ProjectManager"}
-    model_associations.get_association("Project", "milestones").should == {:meta => :has_many, :class_name => "Milestone"}
-    model_associations.get_association("Project", "categories").should == {:meta => :has_and_belongs_to_many, :class_name => "Category"}
+    model_associations.get_association("Project", "portfolio").should == {"meta" => "belongs_to", "class_name" => "Portfolio"}
+    model_associations.get_association("Project", "project_manager").should == {"meta" => "has_one", "class_name" => "ProjectManager"}
+    model_associations.get_association("Project", "milestones").should == {"meta" => "has_many", "class_name" => "Milestone"}
+    model_associations.get_association("Project", "categories").should == {"meta" => "has_and_belongs_to_many", "class_name" => "Category"}
   end
 
   it "should not raise error for finder_sql option" do
@@ -38,45 +38,45 @@ describe RailsBestPractices::Prepares::ModelPrepare do
     it "should parse belongs_to" do
       content =<<-EOF
       class Post < ActiveRecord::Base
-        belongs_to :author, :class_name => "Person"
+        belongs_to :author, "class_name" => "Person"
       end
       EOF
       runner.prepare("app/models/post.rb", content)
       model_associations = RailsBestPractices::Prepares.model_associations
-      model_associations.get_association("Post", "author").should == {:meta => :belongs_to, :class_name => "Person"}
+      model_associations.get_association("Post", "author").should == {"meta" => "belongs_to", "class_name" => "Person"}
     end
 
     it "should parse has_one" do
       content =<<-EOF
       class Project < ActiveRecord::Base
-        has_one :project_manager, :class_name => "Person"
+        has_one :project_manager, "class_name" => "Person"
       end
       EOF
       runner.prepare("app/models/post.rb", content)
       model_associations = RailsBestPractices::Prepares.model_associations
-      model_associations.get_association("Project", "project_manager").should == {:meta => :has_one, :class_name => "Person"}
+      model_associations.get_association("Project", "project_manager").should == {"meta" => "has_one", "class_name" => "Person"}
     end
 
     it "should parse has_many" do
       content =<<-EOF
       class Project < ActiveRecord::Base
-        has_many :people, :class_name => "Person"
+        has_many :people, "class_name" => "Person"
       end
       EOF
       runner.prepare("app/models/project.rb", content)
       model_associations = RailsBestPractices::Prepares.model_associations
-      model_associations.get_association("Project", "people").should == {:meta => :has_many, :class_name => "Person"}
+      model_associations.get_association("Project", "people").should == {"meta" => "has_many", "class_name" => "Person"}
     end
 
     it "should parse has_and_belongs_to_many" do
       content =<<-EOF
       class Citizen < ActiveRecord::Base
-        has_and_belongs_to_many :nations, :class_name => "Country"
+        has_and_belongs_to_many :nations, "class_name" => "Country"
       end
       EOF
       runner.prepare("app/models/citizen.rb", content)
       model_associations = RailsBestPractices::Prepares.model_associations
-      model_associations.get_association("Citizen", "nations").should == {:meta => :has_and_belongs_to_many, :class_name => "Country"}
+      model_associations.get_association("Citizen", "nations").should == {"meta" => "has_and_belongs_to_many", "class_name" => "Country"}
     end
   end
 end

data/spec/rails_best_practices/prepares/schema_prepare_spec.rb

@@ -18,11 +18,11 @@ describe RailsBestPractices::Prepares::SchemaPrepare do
     EOF
     runner.prepare("db/schema.rb", content)
     model_attributes = RailsBestPractices::Prepares.model_attributes
-    model_attributes.get_attribute_type("Post", "title").should == :string
-    model_attributes.get_attribute_type("Post", "body").should == :text
-    model_attributes.get_attribute_type("Post", "created_at").should == :datetime
-    model_attributes.get_attribute_type("Post", "user_id").should == :integer
-    model_attributes.get_attribute_type("Post", "comments_count").should == :integer
-    model_attributes.get_attribute_type("Post", "published").should == :boolean
+    model_attributes.get_attribute_type("Post", "title").should == "string"
+    model_attributes.get_attribute_type("Post", "body").should == "text"
+    model_attributes.get_attribute_type("Post", "created_at").should == "datetime"
+    model_attributes.get_attribute_type("Post", "user_id").should == "integer"
+    model_attributes.get_attribute_type("Post", "comments_count").should == "integer"
+    model_attributes.get_attribute_type("Post", "published").should == "boolean"
   end
 end

data/spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb

@@ -3,9 +3,21 @@ require 'spec_helper'
 describe RailsBestPractices::Reviews::MoveCodeIntoControllerReview do
   let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::MoveCodeIntoControllerReview.new) }
 
-  it "should move code into controller" do
+  it "should move code into controller for method call" do
     content = <<-EOF
-    <% @posts = Post.find(:all) %>
+    <% Post.find(:all).each do |post| %>
+      <%=h post.title %>
+      <%=h post.content %>
+    <% end %>
+    EOF
+    runner.review('app/views/posts/index.html.erb', content)
+    runner.should have(1).errors
+    runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - move code into controller"
+  end
+
+  it "should move code into controller for assign" do
+    content = <<-EOF
+    <% @posts = Post.all %>
     <% @posts.each do |post| %>
       <%=h post.title %>
       <%=h post.content %>

data/spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb

@@ -11,7 +11,7 @@ describe RailsBestPractices::Reviews::MoveCodeIntoHelperReview do
     EOF
     runner.review('app/views/posts/show.html.erb', content)
     runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/posts/show.html.erb:3 - move code into helper (array_count >= 2)"
+    runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)"
   end
 
   it "should not move code into helper with simple arguments" do

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -93,7 +93,7 @@ describe RailsBestPractices::Reviews::NeedlessDeepNestingReview do
       EOF
       runner.review('config/routes.rb', content)
       runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
+      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
     end
 
     it "should not needless deep nesting for shallow" do
@@ -118,7 +118,7 @@ describe RailsBestPractices::Reviews::NeedlessDeepNestingReview do
       EOF
       runner.review('config/routes.rb', content)
       runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
+      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
     end
 
     it "should needless deep nesting with block node" do
@@ -132,7 +132,7 @@ describe RailsBestPractices::Reviews::NeedlessDeepNestingReview do
       EOF
       runner.review('config/routes.rb', content)
       runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:4 - needless deep nesting (nested_count > 2)"
+      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
     end
 
     it "should no needless deep nesting" do

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -41,7 +41,7 @@ describe RailsBestPractices::Reviews::NotUseDefaultRouteReview do
       EOF
       runner.review('config/routes.rb', content)
       runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:5 - not use default route"
+      runner.errors[0].to_s.should == "config/routes.rb:4 - not use default route"
     end
 
     it "should no not use default route" do

data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb

@@ -32,7 +32,7 @@ describe RailsBestPractices::Reviews::OveruseRouteCustomizationsReview do
       runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
     end
 
-    it "should overuse route customizations with collection 2" do
+    it "should overuse route customizations with hash member and collection" do
       content = <<-EOF
       ActionController::Routing::Routes.draw do |map|
         map.resources :categories do |category|
@@ -48,6 +48,20 @@ describe RailsBestPractices::Reviews::OveruseRouteCustomizationsReview do
       runner.errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
     end
 
+    it "should overuse route customizations with array member and collection" do
+      content = <<-EOF
+      ActionController::Routing::Routes.draw do |map|
+        map.resources :categories do |category|
+          category.resources :posts, :member => [:create_comment, :update_comment, :delete_comment],
+                                     :collection => [:comments]
+        end
+      end
+      EOF
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
+    end
+
     it "should not overuse route customizations without customization" do
       content = <<-EOF
       ActionController::Routing::Routes.draw do |map|

data/spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb

@@ -11,7 +11,7 @@ describe RailsBestPractices::Reviews::SimplifyRenderInControllersReview do
     EOF
     runner.review("app/controllers/posts_controller.rb", content)
     runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - simplify render in controllers"
+    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
   end
 
   it "should simplify render actions's template" do
@@ -22,7 +22,7 @@ describe RailsBestPractices::Reviews::SimplifyRenderInControllersReview do
     EOF
     runner.review("app/controllers/posts_controller.rb", content)
     runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - simplify render in controllers"
+    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
   end
 
   it "should simplify render an arbitrary file" do
@@ -33,7 +33,7 @@ describe RailsBestPractices::Reviews::SimplifyRenderInControllersReview do
     EOF
     runner.review("app/controllers/posts_controller.rb", content)
     runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - simplify render in controllers"
+    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
   end
 
   it "should not simplify render action view" do

data/spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb

@@ -77,7 +77,7 @@ describe RailsBestPractices::Reviews::UseQueryAttributeReview do
 
   it "should use query attribute within and conditions" do
     content = <<-EOF
-    <% if @user.active? and @user.login.present? %>
+    <% if @user.active? && @user.login.present? %>
       <%= @user.login %>
     <% end %>
     EOF

data/spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb

@@ -113,6 +113,6 @@ describe RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview do
     end
     EOF
     runner.review('db/migrate/20101010080658_create_users.rb', content)
-    runner.should have(0).errors
+    runner.should have(3).errors
   end
 end

data/spec/rails_best_practices/reviews/use_scope_access_review_spec.rb

@@ -20,7 +20,7 @@ describe RailsBestPractices::Reviews::UseScopeAccessReview do
       EOF
       runner.review('app/controllers/posts_controller.rb', content)
       runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
 
     it "shoud use scope access by comparing with id" do
@@ -39,7 +39,7 @@ describe RailsBestPractices::Reviews::UseScopeAccessReview do
       EOF
       runner.review('app/controllers/posts_controller.rb', content)
       runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
 
     it "shoud use scope access with current_user ==" do
@@ -58,7 +58,7 @@ describe RailsBestPractices::Reviews::UseScopeAccessReview do
       EOF
       runner.review('app/controllers/posts_controller.rb', content)
       runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
 
     it "shoud use scope access by current_user.id ==" do
@@ -77,7 +77,7 @@ describe RailsBestPractices::Reviews::UseScopeAccessReview do
       EOF
       runner.review('app/controllers/posts_controller.rb', content)
       runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:7 - use scope access"
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
     end
   end
 

data/spec/rails_best_practices_spec.rb

@@ -7,8 +7,6 @@ describe RailsBestPractices do
     it "should expand all files in spec directory" do
       dir = File.dirname(__FILE__)
       RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices_spec.rb')
-      RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices/core/visitable_sexp_spec.rb')
-      RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices/reviews/review_spec.rb')
     end
   end
 
@@ -40,6 +38,6 @@ describe RailsBestPractices do
     RailsBestPractices.output_terminal_errors
     result = $stdout.string
     $stdout = $origin_stdout
-    result.should == ["app/models/user.rb:10 - law of demeter".red, "app/models/post.rb:100 - use query attribute".red, "\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.".green, "\nFound 2 errors.".red].join("\n") + "\n"
+    result.should == ["app/models/user.rb:10 - law of demeter".red, "app/models/post.rb:100 - use query attribute".red, "\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.".green, "\nFound 2 warnings.".red].join("\n") + "\n"
   end
 end

data/spec/spec_helper.rb

@@ -3,3 +3,7 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
 require 'rspec/expectations'
 require 'rails_best_practices'
+
+def parse_content(content)
+  Sexp.from_array(Ripper::SexpBuilder.new(content).parse)[1]
+end

metadata

@@ -2,7 +2,7 @@
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.10.1
+  version: 1.0.0
 platform: ruby
 authors: 
 - Richard Huang
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-16 00:00:00 +09:00
+date: 2011-09-24 00:00:00 +08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -170,8 +170,8 @@ files:
 - lib/rails_best_practices/core/models.rb
 - lib/rails_best_practices/core/nil.rb
 - lib/rails_best_practices/core/runner.rb
-- lib/rails_best_practices/core/visitable_sexp.rb
 - lib/rails_best_practices/core_ext/enumerable.rb
+- lib/rails_best_practices/core_ext/sexp.rb
 - lib/rails_best_practices/lexicals.rb
 - lib/rails_best_practices/lexicals/remove_tab_check.rb
 - lib/rails_best_practices/lexicals/remove_trailing_whitespace_check.rb
@@ -218,8 +218,8 @@ files:
 - spec/rails_best_practices/core/model_attributes_spec.rb
 - spec/rails_best_practices/core/models_spec.rb
 - spec/rails_best_practices/core/nil_spec.rb
-- spec/rails_best_practices/core/visitable_sexp_spec.rb
 - spec/rails_best_practices/core_ext/enumerable_spec.rb
+- spec/rails_best_practices/core_ext/sexp_spec.rb
 - spec/rails_best_practices/lexicals/remove_tab_check_spec.rb
 - spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
@@ -242,7 +242,6 @@ files:
 - spec/rails_best_practices/reviews/remove_empty_helpers_review_spec.rb
 - spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb
 - spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb
-- spec/rails_best_practices/reviews/review_spec.rb
 - spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb
 - spec/rails_best_practices/reviews/simplify_render_in_views_review_spec.rb
 - spec/rails_best_practices/reviews/use_before_filter_review_spec.rb
@@ -282,7 +281,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -1121248838931870428
+      hash: 3845996389708993408
       segments: 
       - 0
       version: "0"
@@ -307,8 +306,8 @@ test_files:
 - spec/rails_best_practices/core/model_attributes_spec.rb
 - spec/rails_best_practices/core/models_spec.rb
 - spec/rails_best_practices/core/nil_spec.rb
-- spec/rails_best_practices/core/visitable_sexp_spec.rb
 - spec/rails_best_practices/core_ext/enumerable_spec.rb
+- spec/rails_best_practices/core_ext/sexp_spec.rb
 - spec/rails_best_practices/lexicals/remove_tab_check_spec.rb
 - spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
@@ -331,7 +330,6 @@ test_files:
 - spec/rails_best_practices/reviews/remove_empty_helpers_review_spec.rb
 - spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb
 - spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb
-- spec/rails_best_practices/reviews/review_spec.rb
 - spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb
 - spec/rails_best_practices/reviews/simplify_render_in_views_review_spec.rb
 - spec/rails_best_practices/reviews/use_before_filter_review_spec.rb

data/lib/rails_best_practices/core/visitable_sexp.rb

@@ -1,444 +0,0 @@
-# encoding: utf-8
-require 'sexp'
-
-class Sexp
-  # prepare current node.
-  #
-  # @param [RailsBestPractices::Core::CheckingVisitor] visitor the visitor to prepare current node
-  def prepare(visitor)
-    visitor.prepare(self)
-  end
-
-  # prepare current node.
-  #
-  # @param [RailsBestPractices::Core::CheckingVisitor] visitor the visitor to review current node
-  def review(visitor)
-    visitor.review(self)
-  end
-
-  # return child nodes of a sexp node.
-  #
-  #     s(:call, nil, :puts,
-  #       s(:arglist, s(:str, "hello "), s(:str, "world"))
-  #     )
-  #       => [s(:arglist, s(:str, "hello "), s(:str, "world"))]
-  #
-  # @return [Array] child nodes.
-  def children
-    find_all { | sexp | Sexp === sexp }
-  end
-
-  # recursively find all child nodes, and yeild each child node.
-  def recursive_children
-    children.each do |child|
-      yield child
-      child.recursive_children { |c| yield c }
-    end
-  end
-
-  # grep all the recursive child nodes with conditions, and yield each match node.
-  #
-  # @param [Hash] options grep conditions
-  #
-  # options is the grep conditions, like
-  #
-  #     :node_type => :call,
-  #     :subject => s(:const, Post),
-  #     :message => [:find, :new],
-  #     :arguments => s(:arglist)
-  #
-  # the condition key is one of :node_type, :subject, :message or :arguments,
-  # the condition value can be Symbol, Array or Sexp.
-  def grep_nodes(options)
-    node_type = options[:node_type]
-    subject = options[:subject]
-    message = options[:message]
-    arguments = options[:arguments]
-    self.recursive_children do |child|
-      if (!node_type || (node_type.is_a?(Array) ? node_type.include?(child.node_type) : node_type == child.node_type)) &&
-         (!subject || (subject.is_a?(Array) ? subject.include?(child.subject) : subject == child.subject)) &&
-         (!message || (message.is_a?(Array) ? message.include?(child.message) : message == child.message)) &&
-         (!arguments || (arguments.is_?(Array) ? arguments.include?(child.arguments) : arguments == child.arguments))
-        yield child
-      end
-    end
-  end
-
-  # grep all the recursive child nodes with conditions, and yield the first match node.
-  #
-  # @param [Hash] options grep conditions
-  #
-  # options is the grep conditions, like
-  #
-  #     :node_type => :call,
-  #     :subject => s(:const, Post),
-  #     :message => [:find, :new],
-  #     :arguments => s(:arglist)
-  #
-  # the condition key is one of :node_type, :subject, :message or :arguments,
-  # the condition value can be Symbol, Array or Sexp.
-  def grep_node(options)
-    grep_nodes(options) { |node| return node }
-  end
-
-  # grep all the recursive child nodes with conditions, and get the count of match nodes.
-  #
-  # @param [Hash] options grep conditions
-  # @return [Integer] the count of metch nodes
-  def grep_nodes_count(options)
-    count = 0
-    grep_nodes(options) { |node| count += 1 }
-    count
-  end
-
-  # Get subject of attrasgan, call and iter node.
-  #
-  #     s(:attrasgn,
-  #       s(:call, nil, :user, s(:arglist)),
-  #       :name=,
-  #       s(:arglist,
-  #         s(:call,
-  #           s(:call, nil, :params, s(:arglist)),
-  #           :[],
-  #           s(:arglist, s(:lit, :name))
-  #         )
-  #       )
-  #     )
-  #         => s(:call, nil, :user, s(:arglist))
-  #
-  #     s(:call,
-  #       s(:call, nil, :user, s(:arglist)),
-  #       :name,
-  #       s(:arglist)
-  #     )
-  #         => s(:call, nil, :user, s(:arglist))
-  #
-  #     s(:iter,
-  #       s(:call, s(:ivar, :@users), :each, s(:arglist)),
-  #       s(:lasgn, :user),
-  #       s(:call, nil, :p,
-  #         s(:arglist, s(:lvar, :user))
-  #       )
-  #     )
-  #         => s(:call, :s(:ivar, ;@users), :each, s(:arglist))
-  #
-  # @return [Sexp] subject of attrasgn, call or iter node
-  def subject
-    if [:attrasgn, :call, :iter].include? node_type
-      self[1]
-    end
-  end
-
-  # Get the class name of the class node.
-  #
-  #     s(:class, :User, nil, s(:scope))
-  #         => :User
-  #
-  # @return [Symbol] class name of class node
-  def class_name
-    if :class == node_type
-      self[1]
-    end
-  end
-
-  # Get the base class of the class node.
-  #
-  #     s(:class, :User, s(:colon2, s(:const, :ActiveRecord), :Base), s(:scope))
-  #         => s(:colon2, s(:const, :ActiveRecord), :Base)
-  #
-  # @return [Sexp] base class of class node
-  def base_class
-    if :class == node_type
-      self[2]
-    end
-  end
-
-  # Get the left value of the lasgn or iasgn node.
-  #
-  #     s(:lasgn,
-  #       :user,
-  #       s(:call,
-  #         s(:call, nil, :params, s(:arglist)),
-  #         :[],
-  #         s(:arglist, s(:lit, :user))
-  #       )
-  #     )
-  #         => :user
-  #
-  #     s(:iasgn,
-  #       :@user,
-  #       s(:call,
-  #         s(:call, nil, :params, s(:arglist)),
-  #         :[],
-  #         s(:arglist, s(:lit, :user))
-  #       )
-  #     )
-  #         => :@user
-  #
-  # @return [Symbol] left value of lasgn or iasgn node
-  def left_value
-    if [:lasgn, :iasgn].include? node_type
-      self[1]
-    end
-  end
-
-  # Get the right value of lasgn and iasgn node.
-  #
-  #     s(:lasgn,
-  #       :user,
-  #       s(:call, nil, :current_user, s(:arglist))
-  #     )
-  #         => s(:call, nil, :current_user, s(:arglist))
-  #
-  #     s(:iasgn,
-  #       :@user,
-  #       s(:call, nil, :current_user, s(:arglist))
-  #     )
-  #         => s(:call, nil, :current_user, s(:arglist))
-  #
-  # @return [Sexp] right value of lasgn or iasgn node
-  def right_value
-    if [:lasgn, :iasgn].include? node_type
-      self[2]
-    end
-  end
-
-  # Get the message of attrasgn and call node.
-  #
-  #     s(:attrasgn,
-  #       s(:call, nil, :user, s(:arglist)),
-  #       :name=,
-  #       s(:arglist,
-  #         s(:call,
-  #           s(:call, nil, :params, s(:arglist)),
-  #           :[],
-  #           s(:arglist, s(:lit, :name))
-  #         )
-  #       )
-  #     )
-  #         => :name=
-  #
-  #     s(:call, nil, :has_many, s(:arglist, s(:lit, :projects)))
-  #         => :has_many
-  #
-  # @return [Symbol] message of attrasgn or call node
-  def message
-    if [:attrasgn, :call].include? node_type
-      self[2]
-    end
-  end
-
-  # Get arguments of call node.
-  #
-  #     s(:attrasgn,
-  #       s(:call, nil, :post, s(:arglist)),
-  #       :user=,
-  #       s(:arglist,
-  #         s(:call, nil, :current_user, s(:arglist))
-  #       )
-  #     )
-  #         => s(:arglist, s(:call, nil, :current_user, s(:arglist)))
-  #
-  #     s(:call,
-  #       s(:call, nil, :username, s(:arglist)),
-  #       :==,
-  #       s(:arglist, s(:str, ""))
-  #     )
-  #         => s(:arglist, s(:str, ""))
-  #
-  # @return [Sexp] arguments of attrasgn or call node
-  def arguments
-    if [:attrasgn, :call].include? node_type
-      self[3]
-    end
-  end
-
-  # Get the conditional statement of if node.
-  #
-  #     s(:if,
-  #       s(:call,
-  #         s(:call, nil, :current_user, s(:arglist)),
-  #         :present?,
-  #         s(:arglist)
-  #       ),
-  #       s(:call, nil, :puts,
-  #         s(:arglist,
-  #           s(:call,
-  #             s(:call, nil, :current_user, s(:arglist)),
-  #             :login,
-  #             s(:arglist)
-  #           )
-  #         )
-  #       ),
-  #       nil
-  #     )
-  #         => s(:call, s(:call, nil, :current_user, s(:arglist)), :present?, s(:arglist))
-  #
-  # @return [Sexp] conditional statement of if node
-  def conditional_statement
-    if :if == node_type
-      self[1]
-    end
-  end
-
-  # Get the body node when conditional statement is true.
-  #
-  #     s(:if,
-  #       s(:call, s(:call, nil, :current_user, s(:arglist)), :login?, s(:arglist)),
-  #       s(:call, s(:call, nil, :current_user, s(:arglist)), :login, s(:arglist)),
-  #       s(:call, s(:call, nil, :current_user, s(:arglist)), :email, s(:arglist))
-  #     )
-  #         => s(:call, s(:call, nil, :current_user, s(:arglist)), :login, s(:arglist))
-  #
-  # @return [Sexp] the body node when conditional statement is true
-  def true_node
-    if :if == node_type
-      self[2]
-    end
-  end
-
-  # Get the body node when conditional statement is false.
-  #
-  #     s(:if,
-  #       s(:call, s(:call, nil, :current_user, s(:arglist)), :login?, s(:arglist)),
-  #       s(:call, s(:call, nil, :current_user, s(:arglist)), :login, s(:arglist)),
-  #       s(:call, s(:call, nil, :current_user, s(:arglist)), :email, s(:arglist))
-  #     )
-  #         => s(:call, s(:call, nil, :current_user, s(:arglist)), :email, s(:arglist))
-  #
-  # @return [Sexp] the body node when conditional statement is false
-  def false_node
-    if :if == node_type
-      self[3]
-    end
-  end
-
-  # Get the method name of defn node.
-  #
-  #     s(:defn, :show, s(:args), s(:scope, s(:block, s(:nil))))
-  #         => :show
-  #
-  # @return [Symbol] method name of defn node
-  def method_name
-    if :defn == node_type
-      self[1]
-    end
-  end
-
-  # Get body of iter, class and defn node.
-  #
-  #     s(:iter,
-  #       s(:call, nil, :resources, s(:arglist, s(:lit, :posts))),
-  #       nil,
-  #       s(:call, nil, :resources, s(:arglist, s(:lit, :comments)))
-  #     )
-  #         => s(:call, nil, :resources, s(:arglist, s(:lit, :comments)))
-  #
-  #     s(:class, :User, nil,
-  #       s(:scope,
-  #         s(:block,
-  #           s(:defn, :login, s(:args), s(:scope, s(:block, s(:nil)))),
-  #           s(:defn, :email, s(:args), s(:scope, s(:block, s(:nil))))
-  #         )
-  #       )
-  #     )
-  #         => s(:block,
-  #              s(:defn, :login, s(:args), s(:scope, s(:block, s(:nil)))),
-  #              s(:defn, :email, s(:args), s(:scope, s(:block, s(:nil))))
-  #            )
-  #
-  #     s(:defn, :fullname, s(:args),
-  #       s(:scope,
-  #         s(:block,
-  #           s(:call,
-  #             s(:call,
-  #               s(:call, nil, :first_name, s(:arglist)),
-  #               :+,
-  #               s(:arglist,
-  #                 s(:call, nil, :last, s(:arglist))
-  #               )
-  #             ),
-  #             :+,
-  #             s(:arglist,
-  #               s(:call, nil, :name, s(:arglist))
-  #             )
-  #           )
-  #         )
-  #       )
-  #     )
-  #         => s(:block,
-  #              s(:call,
-  #                s(:call,
-  #                  s(:call, nil, :first_name, s(:arglist)),
-  #                  :+,
-  #                  s(:arglist,
-  #                    s(:call, nil, :last, s(:arglist))
-  #                  )
-  #                ),
-  #                :+,
-  #                s(:arglist,
-  #                  s(:call, nil, :name, s(:arglist))
-  #                )
-  #              )
-  #            )
-  #
-  # @return [Sexp] body of iter, class or defn node
-  def body
-    if :iter == node_type
-      self[3]
-    elsif :class == node_type
-      self[3][1]
-    elsif :module == node_type
-      self[2][1]
-    elsif :defn == node_type
-      self[3][1]
-    end
-  end
-
-  # to_s for lvar, ivar, lit, const, array, hash, and colon2 node.
-  #
-  # @param [Hash] options
-  #   :remove_at remove the @ symbol for ivar.
-  # @return [String] to_s
-  def to_s(options={})
-    case node_type
-    when :true, :false, :nil
-      self[0].to_s
-    when :ivar
-      options[:remove_at] ? self[1].to_s[1..-1] : self[1].to_s
-    when :lvar, :str, :lit, :const
-      self[1].to_s
-    when :array
-      "[\"#{self.children.collect(&:to_s).join('", "')}\"]"
-    when :hash
-      key_value = false # false is key, true is value
-      result = ['{']
-      children.each do |child|
-        if [:true, :false, :nil, :array, :hash].include? child.node_type
-          result << "#{child}"
-        else
-          result << "\"#{child}\""
-        end
-        result << (key_value ? ", " : " => ")
-        key_value = !key_value
-      end
-      result.join("").sub(/, $/, '') + '}'
-    when :colon2
-      "#{self[1]}::#{self[2]}"
-    else
-      ""
-    end
-  end
-
-  # if the return value of these methods is nil, then return RailsBestPractices::Core::Nil.new instead
-  [:node_type, :subject, :message, :arguments, :class_name, :base_class, :method_name, :body, :conditional_statement, :true_node, :false_node, :left_value, :right_value].each do |method|
-    class_eval <<-EOS
-      alias_method :origin_#{method}, :#{method}
-
-      def #{method}
-        ret = origin_#{method}
-        ret.nil? ? RailsBestPractices::Core::Nil.new : ret
-      end
-    EOS
-  end
-end