rails_best_practices 0.1.1 → 0.1.2

data/README.textile

@@ -1,6 +1,6 @@
 h1. rails_best_practices
 
-rails_best_practices is a gem to check quality of rails app files according to ihower's presentation "Rails Best Practices".
+rails_best_practices is a gem to check quality of rails app files according to ihower's presentation "Rails Best Practices":http://www.slideshare.net/ihower/rails-best-practices.
 rails_best_practices is a static file parser tool based on ruby_parser.
 
 *************************************************

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.1.2

data/lib/rails_best_practices/checks/overuse_route_customizations_check.rb

@@ -2,6 +2,9 @@ require 'rails_best_practices/checks/check'
 
 module RailsBestPractices
   module Checks
+    # Check config/routes.rb to make sure there are no much route customizations.
+    #
+    # Implementation: check member and collection route count, if more than customize_count, then it is overuse route customizations.
     class OveruseRouteCustomizationsCheck < Check
       
       def interesting_nodes
@@ -26,7 +29,9 @@ module RailsBestPractices
       private
 
       def member_and_collection_count(node)
-        customize_hash = eval(Ruby2Ruby.new.process(node.grep_nodes(:node_type => :hash).first))
+        hash_nodes = node.grep_nodes(:node_type => :hash)
+        return 0 if hash_nodes.empty?
+        customize_hash = eval(hash_nodes.first.to_ruby)
         (customize_hash[:member].size || 0) + (customize_hash[:collection].size || 0)
       end
     end

data/lib/rails_best_practices/core/runner.rb

@@ -1,6 +1,5 @@
 require 'rubygems'
 require 'ruby_parser'
-require 'ruby2ruby'
 require 'yaml'
 
 module RailsBestPractices

data/lib/rails_best_practices/core/visitable_sexp.rb

@@ -1,5 +1,6 @@
 require 'rubygems'
 require 'sexp'
+require 'ruby2ruby'
 
 class Sexp
   def accept(visitor)
@@ -100,4 +101,8 @@ class Sexp
     else
     end
   end
+
+  def to_ruby
+    Ruby2Ruby.new.process(self)
+  end
 end

data/rails_best_practices.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.1.1"
+  s.version = "0.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]

data/rails_best_practices.yml

@@ -7,4 +7,4 @@ ReplaceComplexCreationWithFactoryMethodCheck: { attribute_assignment_count: 2 }
 MoveModelLogicIntoModelCheck: { called_count: 4 }
 # ManyToManyCollectionCheck: { }
 # NestedModelFormsCheck: { }
-OveruseRouteCustomizations: { customize_count: 3 }
+OveruseRouteCustomizationsCheck: { customize_count: 3 }

data/spec/rails_best_practices/checks/overuse_route_customizations_check_spec.rb

@@ -34,6 +34,17 @@ describe RailsBestPractices::Checks::OveruseRouteCustomizationsCheck do
     errors.should_not be_empty
     errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations"
   end
+  
+  it "should not overuse route customizations without customization" do
+    content = <<-EOF
+    ActionController::Routing::Routes.draw do |map|
+      map.resources :posts
+    end
+    EOF
+    @runner.check('config/routes.rb', content)
+    errors = @runner.errors
+    errors.should be_empty
+  end
 
   it "should not overuse route customizations when customize route is only one" do
     content = <<-EOF

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Richard Huang