rails_appcache 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cad24b0943612791f9429cc73559029a070622ef
-  data.tar.gz: 2b6ac4a04f968d9828277aaa1e487c0255c571c7
+  metadata.gz: a80a1ab0bc8b2d888c5d699a012c907bac05b921
+  data.tar.gz: 675a9c02678f4e2fa3df4e8261980ceb57d08e51
 SHA512:
-  metadata.gz: 2c0e81878ce55a2ba6c0130af23cddb51d235dc000920943e3c5f6b783750369dc21a6a7c95c588d65548b2cee28f7a1a9e7e88275a5fcf2fa43d8ead478c486
-  data.tar.gz: 7ba8ff694b56c0ad43db4c04846f5657cd548087b599d5bf99fb9d71f4233183d35075841340f92c3950ff5809e90ae18f94623fb8a6de6f5b47b24387cbd959
+  metadata.gz: d41d5df2a9e99c0e526dcf595e754a735b9fcbfcfed0cf86a2f24e9d8962744aa2c430f2c5d6d81d9f3ed3b1c9d54ccfbb3d195e7b4c85035310a38f9ae434f9
+  data.tar.gz: e435f9ca87e6a6060387269ae37dc89ecb2989ba278217dd4e1cc13a1769eb0ae328182dacd3c5d1097e3992cf6eb699f1e11f009f5356a595a84a4c801d9bfb

data/app/controllers/rails_appcache/manifests_controller.rb

@@ -1,6 +1,31 @@
 
 class RailsAppcache::ManifestsController < RailsAppcache::ApplicationController
+  include RailsAppcache::ApplicationHelper
+
+  before_filter :check_caching_enabled
+
   def show
-    render params[:manifest]
+    if params[:version] == appcache_version_string
+      # This is a request from a current version of the page
+      render params[:manifest]
+    else
+      # This is a request from an obsolete page, using an obsolete manifest
+      # Serving a 404 enough to trigger an obsoletion event, which is purge
+      # the manifest from the appcache.
+      #
+      # The client will get the correct version on the *next* page request
+      display_404
+    end
+  end
+
+  private
+
+  def display_404
+    render status: :not_found, text: ''
+  end
+
+  def check_caching_enabled
+    display_404 unless RailsAppcache.config.perform_caching?
   end
+
 end

data/config/routes.rb

@@ -1,3 +1,3 @@
 RailsAppcache::Engine.routes.draw do
-  get ':manifest.appcache' => 'manifests#show', format: 'appcache'
+  get ':manifest-:version.appcache' => 'manifests#show', format: 'appcache', constraints: { version: /[a-zA-Z0-9.]+/ }
 end

data/lib/rails_appcache/application_helper.rb

@@ -1,14 +1,17 @@
 module RailsAppcache
   module ApplicationHelper
     def appcache_manifest_path(path)
-      "/#{path}.appcache"
+      return "" unless RailsAppcache.config.perform_caching?
+
+      "/#{path}-#{appcache_version_string}.appcache"
     end
 
     # In development, serve up a new manifest every time
     # In production, serve the current Git revision
     def appcache_version_string
+
       if Rails.env.development?
-        Time.now.to_i.to_s
+        Rails.application.config.assets.version
       else
         # Use the REVISION file left in root from capistrano
         if File.exists?(Rails.root.join('REVISION'))

data/lib/rails_appcache/config.rb

@@ -0,0 +1,20 @@
+
+module RailsAppcache
+
+  def self.config
+    @config ||= Config.new
+  end
+
+  class Config
+    # Default to off outside of production
+    def perform_caching?
+      @perform_caching || !Rails.env.development?
+    end
+
+    def perform_caching=(val)
+      @perform_caching = !!val
+    end
+  end
+
+end
+

data/lib/rails_appcache/version.rb

@@ -1,3 +1,3 @@
 module RailsAppcache
-  VERSION = "0.0.2"
+  VERSION = "0.0.4"
 end

data/lib/rails_appcache.rb

@@ -1,5 +1,6 @@
 require 'rails_appcache/engine'
 require 'rails_appcache/application_helper'
+require 'rails_appcache/config'
 
 module RailsAppcache
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_appcache
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - Matthew Eagar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-07 00:00:00.000000000 Z
+date: 2015-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -39,6 +39,7 @@ files:
 - lib/generators/appcache_manifest_generator.rb
 - lib/rails_appcache.rb
 - lib/rails_appcache/application_helper.rb
+- lib/rails_appcache/config.rb
 - lib/rails_appcache/engine.rb
 - lib/rails_appcache/version.rb
 - test/dummy/README.rdoc