rails_anonymous_controller_testing 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc85a760430231b13db61ed3f20e5aa47c30323cc84c5409344e4c7594c96a1c
-  data.tar.gz: 4b14dd564d41bef6f77597f3ce2f9a3da1873513a7a5e10c18f21ec3459df0f5
+  metadata.gz: ae4209c78f5fbe04812401242ebc41f448005547b3a99f95e4100a6c86ebc33d
+  data.tar.gz: 3ccbd4f88dc6ebd29ac0ab69f3875467949896df125941d386e9ceaa373be7f1
 SHA512:
-  metadata.gz: 9abece243a2654e95fcf67ef6df0f806bbced2764077048850f8e53586eb9deb7cef735f5aef3c1c31c24b0c3e9cac5ef62d778394a65e7a28556e28d2ed8274
-  data.tar.gz: 53a7682c51375d2d172fb591c87d100cd967a3179a69d7c983cc9f029e7ed3db7d327585b5d36c7fc2fc31e793b3aca6785a484a0426a144edb5ae347b34f3ce
+  metadata.gz: 0530f6b5890971a25ce0c2f5ffc709542bc99bb02c7e754853f8b16ba1a4df0af46736a392664c19a5d129cacd36bfbdce3970da055ea8634e1b1d2bc08306c5
+  data.tar.gz: 7c99f8c676676c219d6e730bcb640967b27da28bbd086ba86dff4833d47c14c16d5c6403274a0bb3b4a40bd1e13787d67b2cde1fda7034b30e8b037864fc7074

data/README.md

@@ -12,6 +12,9 @@ This only works with Minitest, specifically for tests that inherit from
 
 ## Usage
 
+Here's a relatively straightforward example. There are a few caveats you might
+need to keep in mind for more complicated cases; see the Caveats section below.
+
 ```ruby
 class MyControllerTest < ActionDispatch::IntegrationTest
   # 1. Call the `controller` method. You must specify the base controller to
@@ -25,7 +28,8 @@ class MyControllerTest < ActionDispatch::IntegrationTest
     end
   end
 
-  # 2. Optionally, set views. There are some caveats, see below
+  # 2. Optionally, set views. You can set the layout for your anonymous
+  #    controller too.
   views["layouts/application.html.erb"] = <<~HTML
     <h1>My anonymous test</h1>
     <%= yield %>
@@ -63,18 +67,23 @@ end
 ```
 
 
-### Views
+### Caveats
 
-A few things to note about views:
+A few things to note
 
-* Views are generated only once and cached. This is determined by the MD5 hash
-  of the test **file** you defined the **controller**. You can disable caching
-  by calling `disable_anonymous_view_cache!` in your Rails test. The view cache
-  is located in `tmp/anonymous_controller_views`.
-* If you override the layout for your anonymous controller, you'll also override
-  the layout for your other controllers. This is because this library uses
-  `prepend_view_path`, so the views defined in the test take precedence over the
-  other view directories.
+* You can only define **one** `controller do` per test class. But you can get
+  around this limitation by defining another test class in one file.
+* Views are generated only once and cached. The cache key is determined by MD5
+  hashing the test file contents, and test file path, and the line number of the
+  `controller do`.
+* You can disable the view cache by calling `disable_anonymous_view_cache!` on
+  your test class. This doesn't get around the limitation of having just one
+  `controller do` definition in your test class.
+* The view cache is located in `tmp/anonymous_controller_views` and can be
+  cleared anytime
+* Setting a custom layout will only affect your anonymous controller. This gem
+  does not provide any way to affect the behavior of existing controllers
+  defined by your Rails application or engine
 
 
 ## Installation

data/lib/rails_anonymous_controller_testing/railtie.rb

@@ -11,15 +11,6 @@ class RailsAnonymousControllerTesting::Railtie < ::Rails::Railtie
         @_anonymous_view_base_path = value
       end
 
-      def self._anonymous_view_path
-        if instance_variable_defined?(:@_anonymous_view_path)
-          return @_anonymous_view_path
-        end
-
-        caller_path = caller_locations(1, 10).find { |location| location.absolute_path != __FILE__ }.absolute_path
-        @_anonymous_view_path = _anonymous_view_base_path.join(Digest::MD5.file(caller_path).hexdigest)
-      end
-
       def self._anonymous_controller_name
         @_anonymous_controller_name ||= "AnonymousController"
       end
@@ -49,7 +40,26 @@ class RailsAnonymousControllerTesting::Railtie < ::Rails::Railtie
       end
 
       def self.controller(base_controller, routes: nil, &block)
-        anonymous_view_path = _anonymous_view_path
+        caller_location = caller_locations(1, 10).find { |location| location.absolute_path != __FILE__ }
+
+        display_name =
+          if caller_location
+            "#{caller_location.absolute_path.split("/").last.split(".").first}_#{caller_location.lineno}"
+          else
+            "path_unknown"
+          end
+
+        unique_identifier =
+          if caller_location
+            Digest::MD5
+              .file(caller_location.absolute_path)
+              .tap { |d| d << caller_location.absolute_path }
+              .tap { |d| d << caller_location.lineno.to_s }
+          else
+            SecureRandom.hex
+          end
+
+        anonymous_view_path = _anonymous_view_base_path.join("#{display_name}_#{unique_identifier}")
         anonymous_controller_name = _anonymous_controller_name
 
         # Define the controller

data/lib/rails_anonymous_controller_testing/version.rb

@@ -1,3 +1,3 @@
 module RailsAnonymousControllerTesting
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: rails_anonymous_controller_testing
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Zach Ahn
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-01 00:00:00.000000000 Z
+date: 2021-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 5.0.0
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement