rails_admin_next 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a47ededbcad2a173ee6e0d77e581ef0e4e7649458a7bf0e659592726299c6ae2
-  data.tar.gz: bded3ecf250c69185107635e6877b4d9467f678fb12919b08146a3e67fdb7842
+  metadata.gz: a1e669bb86719b972a161917a8f2b88747a6be2e2233ada17c3a437e6dfdeaaf
+  data.tar.gz: 66a69ecedbd7e4fdca9991e2044bede57d842f5bc7e1d29159a2fb4ef41a361f
 SHA512:
-  metadata.gz: 88379320dc12d64a6311ed451b82a685862b7c7c3ea4449c44fc391a6b1cdad8beed31623a7d4709cc8bef210779cdfe41593e24b7a6688fdf7dcbdd101a6bbb
-  data.tar.gz: 6baf5beb0080b57a8f1fe08ccd6407872b1bec576fb43a493f58fefc76d5883c04f74c3d66e674756684c224038f6235c6f7e54b97483aa9d073a45c7dde8294
+  metadata.gz: 85c4a2ad4d178fee59d393020db78d735c114c8b0bb41cf42f14e70017363edd78bb49e0c461db95e8098901f30bf974a2a93683f70faf3cbb935978468cd24f
+  data.tar.gz: 0a60be77736c263a0dabea8abb46f573948b56ee672b0ca75473012feeb5a8889a3d5bac60668a3057602f7c5b51db097f9ff39171e210671a8d16ef3856db99

data/app/helpers/rails_admin_next/application_helper.rb

@@ -144,7 +144,7 @@ module RailsAdminNext
           content_tag(:li, class: ["breadcrumb-item", current_action?(a, am, o) && "active"]) do
             if current_action?(a, am, o)
               wording_for(:breadcrumb, a, am, o)
-            elsif a.http_methods.include?(:get)
+            elsif a.linkable?
               link_to rails_admin_next.url_for(action: a.action_name, controller: "rails_admin_next/main", model_name: am.try(:to_param), id: o.try(:persisted?) && o.try(:id) || nil) do
                 wording_for(:breadcrumb, a, am, o)
               end
@@ -159,7 +159,7 @@ module RailsAdminNext
     # parent => :root, :collection, :member
     # perf matters here (no action view trickery)
     def menu_for(parent, abstract_model = nil, object = nil, only_icon = false)
-      actions = actions(parent, abstract_model, object).select { |a| a.http_methods.include?(:get) && a.show_in_menu }
+      actions = actions(parent, abstract_model, object).select { |a| a.linkable? && a.show_in_menu }
       actions.collect do |action|
         wording = wording_for(:menu, action)
         li_class = ["nav-item", "icon", "#{action.key}_#{parent}_link"]

data/lib/rails_admin_next/abstract_model.rb

@@ -131,6 +131,17 @@ module RailsAdminNext
       end
 
       def to_statement
+        # A multi-select filter submits its values as an array, so the sentinel has to
+        # be stripped out of one rather than compared against it. An array emptied by
+        # that strip discards the filter, but one that arrived empty does not: a date
+        # filter carries its meaning in the operator alone ("today", "this_week").
+        #
+        # "between" is excluded because it alone reads the array by index, so removing
+        # an element would shift the range ends rather than discard anything.
+        if @value.is_a?(Array) && @operator != "between" && @value.include?("_discard")
+          @value -= ["_discard"]
+          return if @value.empty?
+        end
         return if [@operator, @value].any? { |v| v == "_discard" }
 
         unary_operators[@operator] || unary_operators[@value] ||

data/lib/rails_admin_next/config/actions/base.rb

@@ -147,6 +147,13 @@ module RailsAdminNext
 
         # Off API.
 
+        # Whether visiting the action's URL performs it, so it can be rendered as a
+        # plain link rather than a button. Verbs are host-supplied, so they may be
+        # written as :GET or "get".
+        def linkable?
+          http_methods.include?(:get) || http_methods.any? { |verb| verb.to_s.casecmp?("get") }
+        end
+
         def key
           self.class.key
         end

data/lib/rails_admin_next/config/actions/show.rb

@@ -20,9 +20,11 @@ module RailsAdminNext
 
         register_instance_option :controller do
           proc do
+            # HTML first: an Accept-less request arrives as */*, which matches every
+            # registered type, so Rails falls back to whichever is declared first.
             respond_to do |format|
-              format.json { render json: @object }
               format.html { render @action.template_name }
+              format.json { render json: @object }
             end
           end
         end

data/lib/rails_admin_next/config/fields/base.rb

@@ -16,6 +16,9 @@ module RailsAdminNext
         include RailsAdminNext::Config::Groupable
         include RailsAdminNext::Config::Inspectable
 
+        # The length-validation options that are compared against the column limit.
+        LENGTH_BOUNDS = %i[is maximum minimum].freeze
+
         attr_reader :name, :properties, :abstract_model, :parent, :root
         attr_accessor :defined, :order, :section
 
@@ -196,8 +199,14 @@ module RailsAdminNext
 
         # Accessor for field's length restrictions per validations
         #
+        # ActiveModel also accepts a bound as a Proc or a Symbol, which it resolves
+        # against the record at validation time. Neither can be compared against the
+        # column limit here, so both are dropped. Devise's password length validation
+        # declares its bounds as Procs.
         register_instance_option :valid_length do
-          @valid_length ||= abstract_model.model.validators_on(name).detect { |v| v.kind == :length }.try(&:options) || {}
+          @valid_length ||=
+            (abstract_model.model.validators_on(name).detect { |v| v.kind == :length }.try(&:options) || {})
+              .reject { |option, bound| LENGTH_BOUNDS.include?(option) && (bound.is_a?(Proc) || bound.is_a?(Symbol)) }
         end
 
         register_instance_option :partial do
@@ -266,8 +275,6 @@ module RailsAdminNext
           false
         end
 
-        register_deprecated_instance_option :eager_load?, :eager_load
-
         def eager_load_values
           case eager_load
           when true

data/lib/rails_admin_next/config/fields/types/datetime.rb

@@ -63,11 +63,6 @@ module RailsAdminNext
             :form_datetime
           end
 
-          # Picker-only legacy option; native HTML5 inputs render per the browser locale, so it is ignored.
-          register_deprecated_instance_option :momentjs_format do
-            RailsAdminNext.deprecator.warn("The momentjs_format configuration option is deprecated and ignored; date/time fields now use native HTML5 inputs.")
-          end
-
           # The native <input type="datetime-local" step="1"> control accepts and emits ISO 8601 only.
           def form_value
             value&.in_time_zone&.strftime("%Y-%m-%dT%H:%M:%S") || form_default_value

data/lib/rails_admin_next/config/fields/types/multiple_file_upload.rb

@@ -29,8 +29,6 @@ module RailsAdminNext
               nil
             end
 
-            register_deprecated_instance_option :delete_key, :delete_value
-
             register_instance_option :pretty_value do
               if value.presence
                 v = bindings[:view]

data/lib/rails_admin_next/config/sections/list.rb

@@ -46,17 +46,9 @@ module RailsAdminNext
           ""
         end
 
-        register_deprecated_instance_option :sidescroll do
-          RailsAdminNext.deprecator.warn("The sidescroll configuration option was removed, it is always enabled now.")
-        end
-
         def fields_for_table
           visible_fields.partition(&:sticky?).flatten
         end
-
-        register_deprecated_instance_option :sort_reverse do
-          RailsAdminNext.deprecator.warn("The sort_reverse configuration option is deprecated and has no effect.")
-        end
       end
     end
   end

data/lib/rails_admin_next/config.rb

@@ -316,14 +316,6 @@ module RailsAdminNext
         end
       end
 
-      def total_columns_width=(_)
-        RailsAdminNext.deprecator.warn("The total_columns_width configuration option is deprecated and has no effect.")
-      end
-
-      def sidescroll=(_)
-        RailsAdminNext.deprecator.warn("The sidescroll configuration option was removed, it is always enabled now.")
-      end
-
       # Setup actions to be used.
       def actions(&block)
         return unless block

data/lib/rails_admin_next/version.rb

@@ -6,8 +6,8 @@ module RailsAdminNext
     # the tag's version over these constants at build time, so the in-repo values are only
     # the floor a local `gem build` produces.
     MAJOR = 1
-    MINOR = 0
-    PATCH = 2
+    MINOR = 1
+    PATCH = 0
     PRE = nil
 
     class << self

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_admin_next
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Daniel López Prat