rails_admin_authorized_fields 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 630ecc8455721679635659fe7beb2014b82324af
-  data.tar.gz: c8e3ee562266ddf7b558e9f07af04bb4fe3b7fed
+  metadata.gz: cfc10142f5dda9f9ea86cf24a2e53ce73ffbcb8a
+  data.tar.gz: c76f3e89d0a435f250d48d97d92d82c9767c34e6
 SHA512:
-  metadata.gz: 113fe183f863aed56520fbb77d1cfe8b9ae7b03f9dc3bc0a3ffe44bdd30c396410d614f7a730e261529d8e6e4297bef8b94d996ea127782fbcc07ddefdbaa42a
-  data.tar.gz: e6f5cc1f0ba54387189ffc2077bf91e6bc0229934755e8965d61bbbf63cc826bcb77db148943503fc4bf7316efeb6de1b98509be9c173bc181e61a1209bcdbb6
+  metadata.gz: ccab6dc93d869fd9f355aa21da604c2799e75568211992cef35cb9180cf1f4d0aae24311b9a5438857796a68143b659f07804221dcb657ae6fa4c42d32c79ab4
+  data.tar.gz: 3d260de5a2ab2a616480fa20675d49a3f3382b56ab9572d1588079d00caba4e1f75f73de91c4e2537c49b7e1f41973c969685ef4988dfb45dda9f565a7305845

data/.editorconfig

@@ -0,0 +1,25 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+tab_width = 2
+indent_style = space
+indent_size = 2
+
+[**.bat]
+end_of_line = crlf
+
+[**.min.*]
+indent_style = ignore
+trim_trailing_whitespace = false
+insert_final_newline = ignore
+
+[*.slim]
+insert_final_newline = false
+trim_trailing_whitespace = false
+
+[*.txt]
+insert_final_newline = false
+trim_trailing_whitespace = false

data/.ruby-version

@@ -1 +1 @@
-2.1.2
+2.2.2

data/README.md

@@ -47,10 +47,14 @@ You can also use ```unauthorized_fields``` section in opposite of ```authorized_
       field :text_slug
     end
 
-Note: all fields are ```authorized``` by default.
+Note: all fields are not ```authorized``` by default if any rules present.
 
 TODO: just a small changes needed to make ```authorized_fields``` section overridable in subsection (list, edit)
 
+## Changelog
+
+  0.1.0 - changed default authorized logic. In 0.0.3 all fields were authorized by default. In 0.1.0 fields unauthorized when authorized_fields or unauthorized_fields sections are present.
+
 ## Contributing
 
 1. Fork it

data/lib/rails_admin_authorized_fields/section.rb

@@ -1,5 +1,5 @@
 module RailsAdminAuthorizedFields
-  module AuthorazedFieldsSection
+  module AuthorizedFieldsSection
     def initialize(parent)
       @allow_rules, @deny_rules = {}, {}
 
@@ -32,18 +32,23 @@ module RailsAdminAuthorizedFields
 
     def visible_fields
       return super if bindings.nil?
-      
-      super.select do |field|
-        authorized = true
 
+      super.select do |field|
         rules = field.section.field_authorization_rules(field.name)
 
-        rules[:allow].each do |rule|
-          authorized &= instance_eval(&rule)
-        end
+        if field.section.plugin_included?
+          authorized = rules[:allow].any? || rules[:deny].any?
+
+          rules[:allow].each do |rule|
+            authorized &= instance_eval(&rule)
+          end
+
+          rules[:deny].each do |rule|
+            authorized &= !instance_eval(&rule)
+          end
 
-        rules[:deny].each do |rule|
-          authorized &= !instance_eval(&rule)
+        else
+          authorized = true
         end
 
         authorized
@@ -51,9 +56,19 @@ module RailsAdminAuthorizedFields
     end
 
     protected
-  
+
+      def plugin_included?( descendant = nil )
+        result = @allow_rules.any? || @deny_rules.any?
+
+        return result if result
+        return false if @parent.nil?
+        return false if self == descendant
+
+        @parent.plugin_included?( self )
+      end
+
       def field_authorization_rules(name)
-        { 
+        {
           allow: extract_rules(name, :allow_rules),
           deny: extract_rules(name, :deny_rules),
         }
@@ -64,7 +79,7 @@ module RailsAdminAuthorizedFields
 
         return rules[name] || [] if rules.any?
         return [] if @parent.nil?
-        return [] if self == descendant 
+        return [] if self == descendant
 
         @parent.extract_rules(name, kind, self)
       end
@@ -77,7 +92,7 @@ module RailsAdmin
     module Sections
       # Configuration of the show view for a new object
       class Base
-        prepend RailsAdminAuthorizedFields::AuthorazedFieldsSection
+        prepend RailsAdminAuthorizedFields::AuthorizedFieldsSection
       end
     end
   end

data/lib/rails_admin_authorized_fields/version.rb

@@ -1,3 +1,3 @@
 module RailsAdminAuthorizedFields
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_admin_authorized_fields
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Sergey Malykh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-03 00:00:00.000000000 Z
+date: 2015-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails_admin
@@ -59,6 +59,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".editorconfig"
 - ".gitignore"
 - ".ruby-gemset"
 - ".ruby-version"
@@ -90,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Simplified authorization rules for rails_admin fields