rails_admin 0.6.0 → 0.6.1

data/spec/integration/config/show/rails_admin_config_show_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "RailsAdmin Config DSL Show Section" do
+describe 'RailsAdmin Config DSL Show Section' do
   subject { page }
   let(:team) { FactoryGirl.create :team }
 
@@ -10,74 +10,74 @@ describe "RailsAdmin Config DSL Show Section" do
       c.compact_show_view = false
     end
 
-    visit show_path(:model_name => "team", :id => team.id)
+    visit show_path(model_name: 'team', id: team.id)
   end
 
-  describe "JSON show view" do
+  describe 'JSON show view' do
     before do
       @player = FactoryGirl.create :player
-       visit uri
+      visit uri
     end
 
-    let(:uri) { show_path(:model_name => 'player', :id => @player.id, :format => :json) }
+    let(:uri) { show_path(model_name: 'player', id: @player.id, format: :json) }
     let(:body) { page.body }
 
-    it "creates a JSON uri" do
+    it 'creates a JSON uri' do
       expect(uri).to eq("/admin/player/#{@player.id}.json")
     end
 
-    it "contains the JSONified object" do
+    it 'contains the JSONified object' do
       expect(body).to include(@player.reload.to_json)
     end
   end
 
-  describe "compact_show_view" do
+  describe 'compact_show_view' do
 
-    it "hides empty fields in show view by default" do
+    it 'hides empty fields in show view by default' do
       @player = FactoryGirl.create :player
-      visit show_path(:model_name => "league", :id => @player.id)
-      should_not have_css(".born_on_field")
+      visit show_path(model_name: 'league', id: @player.id)
+      should_not have_css('.born_on_field')
     end
 
-
-    it "is disactivable" do
+    it 'is disactivable' do
       RailsAdmin.config do |c|
         c.compact_show_view = false
       end
 
       @player = FactoryGirl.create :player
-      visit show_path(:model_name => "player", :id => @player.id)
-      should have_css(".born_on_field")
+      visit show_path(model_name: 'player', id: @player.id)
+      should have_css('.born_on_field')
     end
   end
 
-  describe "bindings" do
-    it "should be present" do
+  describe 'bindings' do
+    it 'should be present' do
       RailsAdmin.config Team do |c|
         show do
           field :name do
             show do
-              bindings[:object] and bindings[:view] and bindings[:controller]
+              bindings[:object] && bindings[:view] && bindings[:controller]
             end
           end
         end
       end
 
-    do_request
+      do_request
 
-    should have_selector("dt .name_field.string_type")    end
+      should have_selector('dt .name_field.string_type')
+    end
   end
 
-  describe "css hooks" do
-    it "is present" do
+  describe 'css hooks' do
+    it 'is present' do
       do_request
 
-      should have_selector("dt .name_field.string_type")
+      should have_selector('dt .name_field.string_type')
     end
   end
 
-  describe "field groupings" do
-    it "is hideable" do
+  describe 'field groupings' do
+    it 'is hideable' do
       RailsAdmin.config Team do
         show do
           group :default do
@@ -88,17 +88,17 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      should_not have_selector("h4", :text => "Basic info")
+      should_not have_selector('h4', text: 'Basic info')
 
       %w[division name logo_url manager
-        ballpark mascot founded wins
-        losses win_percentage revenue
+         ballpark mascot founded wins
+         losses win_percentage revenue
       ].each do |field|
         should_not have_selector(".#{field}_field")
       end
     end
 
-    it "hides association groupings by the name of the association" do
+    it 'hides association groupings by the name of the association' do
       RailsAdmin.config Team do
         show do
           group :players do
@@ -109,24 +109,24 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      should_not have_selector("h4", :text => "Players")
+      should_not have_selector('h4', text: 'Players')
     end
 
-    it "is renameable" do
+    it 'is renameable' do
       RailsAdmin.config Team do
         show do
           group :default do
-            label "Renamed group"
+            label 'Renamed group'
           end
         end
       end
 
       do_request
 
-      should have_selector("h4", :text => "Renamed group")
+      should have_selector('h4', text: 'Renamed group')
     end
 
-    it "has accessor for its fields" do
+    it 'has accessor for its fields' do
       RailsAdmin.config Team do
         show do
           group :default do
@@ -142,15 +142,15 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      should have_selector("h4", :text => "Basic info")
-      should have_selector("h4", :text => "Belong's to associations")
+      should have_selector('h4', text: 'Basic info')
+      should have_selector('h4', text: "Belong's to associations")
 
-      should have_selector(".name_field")
-      should have_selector(".logo_url_field")
-      should have_selector(".division_field")
+      should have_selector('.name_field')
+      should have_selector('.logo_url_field')
+      should have_selector('.division_field')
     end
 
-    it "has accessor for its fields by type" do
+    it 'has accessor for its fields by type' do
       RailsAdmin.config Team do
         show do
           group :default do
@@ -170,28 +170,28 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      should have_selector(".label", :text => "Name")
-      should have_selector(".label", :text => "Logo url")
-      should have_selector(".label", :text => "Division")
-      should have_selector(".label", :text => "Manager (STRING)")
-      should have_selector(".label", :text => "Ballpark (STRING)")
+      should have_selector('.label', text: 'Name')
+      should have_selector('.label', text: 'Logo url')
+      should have_selector('.label', text: 'Division')
+      should have_selector('.label', text: 'Manager (STRING)')
+      should have_selector('.label', text: 'Ballpark (STRING)')
     end
   end
 
   describe "items' fields" do
 
-    it "shows all by default" do
+    it 'shows all by default' do
       do_request
 
       %w[division name logo_url manager
-        ballpark mascot founded wins
-        losses win_percentage revenue players fans
+         ballpark mascot founded wins
+         losses win_percentage revenue players fans
       ].each do |field|
         should have_selector(".#{field}_field")
       end
     end
 
-    it "only shows the defined fields and appear in order defined" do
+    it 'only shows the defined fields and appear in order defined' do
       RailsAdmin.config Team do
         show do
           field :manager
@@ -202,13 +202,12 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      should have_selector(".manager_field")
-      should have_selector(".division_field")
-      should have_selector(".name_field")
+      should have_selector('.manager_field')
+      should have_selector('.division_field')
+      should have_selector('.name_field')
     end
 
-
-    it "delegates the label option to the ActiveModel API" do
+    it 'delegates the label option to the ActiveModel API' do
       RailsAdmin.config Team do
         show do
           field :manager
@@ -218,15 +217,15 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      should have_selector(".label", :text => "Team Manager")
-      should have_selector(".label", :text => "Some Fans")
+      should have_selector('.label', text: 'Team Manager')
+      should have_selector('.label', text: 'Some Fans')
     end
 
-    it "is renameable" do
+    it 'is renameable' do
       RailsAdmin.config Team do
         show do
           field :manager do
-            label "Renamed field"
+            label 'Renamed field'
           end
           field :division
           field :name
@@ -235,12 +234,12 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      should have_selector(".label", :text => "Renamed field")
-      should have_selector(".label", :text => "Division")
-      should have_selector(".label", :text => "Name")
+      should have_selector('.label', text: 'Renamed field')
+      should have_selector('.label', text: 'Division')
+      should have_selector('.label', text: 'Name')
     end
 
-    it "is renameable by type" do
+    it 'is renameable by type' do
       RailsAdmin.config Team do
         show do
           fields_of_type :string do
@@ -251,15 +250,15 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      ["Division", "Name (STRING)", "Logo url (STRING)", "Manager (STRING)",
-        "Ballpark (STRING)", "Mascot (STRING)", "Founded", "Wins", "Losses",
-        "Win percentage", "Revenue", "Players", "Fans"
+      ['Division', 'Name (STRING)', 'Logo url (STRING)', 'Manager (STRING)',
+       'Ballpark (STRING)', 'Mascot (STRING)', 'Founded', 'Wins', 'Losses',
+       'Win percentage', 'Revenue', 'Players', 'Fans'
       ].each do |text|
-        should have_selector(".label", :text => text)
+        should have_selector('.label', text: text)
       end
     end
 
-    it "is globally renameable by type" do
+    it 'is globally renameable by type' do
       RailsAdmin.config Team do
         show do
           fields_of_type :string do
@@ -270,15 +269,15 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      ["Division", "Name (STRING)", "Logo url (STRING)", "Manager (STRING)",
-        "Ballpark (STRING)", "Mascot (STRING)", "Founded", "Wins", "Losses",
-        "Win percentage", "Revenue", "Players", "Fans"
+      ['Division', 'Name (STRING)', 'Logo url (STRING)', 'Manager (STRING)',
+       'Ballpark (STRING)', 'Mascot (STRING)', 'Founded', 'Wins', 'Losses',
+       'Win percentage', 'Revenue', 'Players', 'Fans'
       ].each do |text|
-        should have_selector(".label", :text => text)
+        should have_selector('.label', text: text)
       end
     end
 
-    it "is hideable" do
+    it 'is hideable' do
       RailsAdmin.config Team do
         show do
           field :manager do
@@ -291,11 +290,11 @@ describe "RailsAdmin Config DSL Show Section" do
 
       do_request
 
-      should have_selector(".division_field")
-      should have_selector(".name_field")
+      should have_selector('.division_field')
+      should have_selector('.name_field')
     end
 
-    it "is hideable by type" do
+    it 'is hideable by type' do
       RailsAdmin.config Team do
         show do
           fields_of_type :string do
@@ -307,15 +306,15 @@ describe "RailsAdmin Config DSL Show Section" do
       do_request
 
       %w[Name Logo\ url Manager Ballpark Mascot].each do |text|
-        should_not have_selector(".label", :text => text)
+        should_not have_selector('.label', text: text)
       end
 
       %w[Division Founded Wins Losses Win\ percentage Revenue Players Fans].each do |text|
-        should have_selector(".label", :text => text)
+        should have_selector('.label', text: text)
       end
     end
 
-    it "is globally hideable by type" do
+    it 'is globally hideable by type' do
       RailsAdmin.config Team do
         show do
           fields_of_type :string do
@@ -327,20 +326,20 @@ describe "RailsAdmin Config DSL Show Section" do
       do_request
 
       %w[Name Logo\ url Manager Ballpark Mascot].each do |text|
-        should_not have_selector(".label", :text => text)
+        should_not have_selector('.label', text: text)
       end
 
       %w[Division Founded Wins Losses Win\ percentage Revenue Players Fans].each do |text|
-        should have_selector(".label", :text => text)
+        should have_selector('.label', text: text)
       end
     end
   end
 
-  describe "embedded model", :mongoid => true do
+  describe 'embedded model', mongoid: true do
     it "does not show link to individual object's page" do
       @record = FactoryGirl.create :field_test
-      2.times.each{|i| @record.embeds.create :name => "embed #{i}"}
-      visit show_path(:model_name => "field_test", :id => @record.id)
+      2.times.each { |i| @record.embeds.create name: "embed #{i}" }
+      visit show_path(model_name: 'field_test', id: @record.id)
       should_not have_link('embed 0')
       should_not have_link('embed 1')
     end

data/spec/integration/history/rails_admin_history_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
-describe "RailsAdmin History", :active_record => true do
-  describe "model history fetch" do
+describe 'RailsAdmin History', active_record: true do
+  describe 'model history fetch' do
     before :each do
       RailsAdmin::History.delete_all
-      @model = RailsAdmin::AbstractModel.new("Player")
+      @model = RailsAdmin::AbstractModel.new('Player')
       player = FactoryGirl.create :player
       30.times do |i|
         player.number = i
@@ -12,20 +12,20 @@ describe "RailsAdmin History", :active_record => true do
       end
     end
 
-    it "fetches on page of history" do
+    it 'fetches on page of history' do
       histories = RailsAdmin::History.history_for_model @model, nil, false, false, false, nil, 20
       expect(histories.total_count).to eq(30)
       expect(histories.count).to eq(20)
     end
 
-    it "respects RailsAdmin::Config.default_items_per_page" do
+    it 'respects RailsAdmin::Config.default_items_per_page' do
       RailsAdmin.config.default_items_per_page = 15
       histories = RailsAdmin::History.history_for_model @model, nil, false, false, false, nil
       expect(histories.total_count).to eq(30)
       expect(histories.count).to eq(15)
     end
 
-    context "with Kaminari" do
+    context 'with Kaminari' do
       before do
         Kaminari.config.page_method_name = :per_page_kaminari
         @paged = RailsAdmin::History.page(1)
@@ -42,7 +42,7 @@ describe "RailsAdmin History", :active_record => true do
       end
     end
 
-    context "GET admin/history/@model" do
+    context 'GET admin/history/@model' do
       before :each do
         RailsAdmin.config do |c|
           c.audit_with :history
@@ -59,27 +59,27 @@ describe "RailsAdmin History", :active_record => true do
         expect(page).to have_no_selector("a[href^='/rails_admin/history/for_model']")
       end
 
-      context "with a lot of histories" do
+      context 'with a lot of histories' do
         before :each do
-          player = Player.create(:team_id => -1, :number => -1, :name => "Player 1")
+          player = Player.create(team_id: -1, number: -1, name: 'Player 1')
           101.times do |i|
             player.number = i
             RailsAdmin::History.create_history_item "change #{i}", player, @model, nil
           end
         end
 
-        it "gets latest ones" do
+        it 'gets latest ones' do
           expect(RailsAdmin::History.latest.count).to eq(100)
         end
 
-        it "gets latest ones orderly" do
+        it 'gets latest ones orderly' do
           latest = RailsAdmin::History.latest
-          expect(latest.first.message).to eq("change 100")
-          expect(latest.last.message).to eq("change 1")
+          expect(latest.first.message).to eq('change 100')
+          expect(latest.last.message).to eq('change 1')
         end
 
-        it "renders a XHR request successfully" do
-          xhr :get, history_index_path(@model, :page => 2)
+        it 'renders a XHR request successfully' do
+          xhr :get, history_index_path(@model, page: 2)
         end
       end
     end