rails_admin 0.0.5 → 0.1.0

data/spec/integration/config/list/rails_admin_config_list_spec.rb

@@ -28,18 +28,6 @@ describe "RailsAdmin Config DSL List Section" do
       end
     end
 
-    it "should be configurable" do
-      RailsAdmin::Config.models do
-        list do
-          items_per_page 1
-        end
-      end
-      visit index_path(:model_name => "league")
-      should have_selector("tbody tr", :count => 1)
-      visit index_path(:model_name => "player")
-      should have_selector("tbody tr", :count => 1)
-    end
-
     it "should be configurable per model" do
       RailsAdmin.config League do
         list do
@@ -51,23 +39,6 @@ describe "RailsAdmin Config DSL List Section" do
       visit index_path(:model_name => "player")
       should have_selector("tbody tr", :count => 2)
     end
-
-    it "should be globally configurable and overrideable per model" do
-      RailsAdmin::Config.models do
-        list do
-          items_per_page 20
-        end
-      end
-      RailsAdmin.config League do
-        list do
-          items_per_page 1
-        end
-      end
-      visit index_path(:model_name => "league")
-      should have_selector("tbody tr", :count => 1)
-      visit index_path(:model_name => "player")
-      should have_selector("tbody tr", :count => 2)
-    end
   end
 
   describe "items' fields" do
@@ -211,7 +182,7 @@ describe "RailsAdmin Config DSL List Section" do
     end
 
     it "should be globally renameable by type" do
-      RailsAdmin::Config.models do
+      RailsAdmin.config 'Fan' do
         list do
           fields_of_type :datetime do
             label { "#{label} (datetime)" }
@@ -265,7 +236,7 @@ describe "RailsAdmin Config DSL List Section" do
     end
 
     it "should have option to disable sortability by type globally" do
-      RailsAdmin::Config.models do
+      RailsAdmin.config 'Fan' do
         list do
           fields_of_type :datetime do
             sortable false
@@ -297,7 +268,7 @@ describe "RailsAdmin Config DSL List Section" do
     end
 
     it "should have option to hide fields by type globally" do
-      RailsAdmin::Config.models do
+      RailsAdmin.config 'Fan' do
         list do
           fields_of_type :datetime do
             hide
@@ -415,21 +386,6 @@ describe "RailsAdmin Config DSL List Section" do
     before(:each) { @players = players.map{|h| Player.create(h) }}
 
     context "should be configurable" do
-      it "globaly" do
-        RailsAdmin.config do |config|
-          config.models do
-            list do
-              sort_by :created_at
-              sort_reverse true
-            end
-          end
-        end
-        visit index_path(:model_name => "player")
-        player_names_by_date.reverse.each_with_index do |name, i|
-          find("tbody tr:nth-child(#{i + 1})").should have_content(name)
-        end
-      end
-
       it "per model" do
         RailsAdmin.config Player do
           list do
@@ -442,40 +398,6 @@ describe "RailsAdmin Config DSL List Section" do
           find("tbody tr:nth-child(#{i + 1})").should have_content(name)
         end
       end
-
-      it "globaly and overrideable per model" do
-        leagues.map{|h| League.create(h) }
-
-        RailsAdmin::Config.models do
-          list do
-            sort_by :created_at
-            sort_reverse true
-          end
-        end
-
-        RailsAdmin.config Player do
-          list do
-            sort_by PK_COLUMN
-            sort_reverse true
-          end
-        end
-
-        visit index_path(:model_name => "league")
-        league_names_by_date.reverse.each_with_index do |name, i|
-          find("tbody tr:nth-child(#{i + 1})").should have_content(name)
-        end
-
-        visit index_path(:model_name => "player")
-        @players.sort_by do |p|
-          if p[PK_COLUMN].is_a?(Integer)
-            p[PK_COLUMN]
-          else
-            p[PK_COLUMN].to_s
-          end
-        end.map{|p| p[:name]}.reverse.each_with_index do |name, i|
-          find("tbody tr:nth-child(#{i + 1})").should have_content(name)
-        end
-      end
     end
 
     it "should have reverse direction by default" do

data/spec/integration/config/show/rails_admin_config_show_spec.rb

@@ -242,7 +242,7 @@ describe "RailsAdmin Config DSL Show Section" do
     end
 
     it "should be globally renameable by type" do
-      RailsAdmin::Config.models do
+      RailsAdmin.config 'Team' do
         show do
           fields_of_type :string do
             label { "#{label} (STRING)" }
@@ -298,7 +298,7 @@ describe "RailsAdmin Config DSL Show Section" do
     end
 
     it "should be globally hideable by type" do
-      RailsAdmin::Config.models do
+      RailsAdmin.config 'Team' do
         show do
           fields_of_type :string do
             hide

data/spec/spec_helper.rb

@@ -58,6 +58,7 @@ RSpec.configure do |config|
     RailsAdmin::Config.reset
     RailsAdmin::AbstractModel.reset
     RailsAdmin::Config.audit_with(:history) if CI_ORM == :active_record
+    RailsAdmin::Config.yell_for_non_accessible_fields = false
     login_as User.create(
       :email => "username@example.com",
       :password => "password"

data/spec/unit/active_record_extension_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+require File.expand_path('../../../config/initializers/active_record_extensions', __FILE__)
+
+describe 'ActiveRecord::Base', :active_record => true do
+  describe '#safe_send' do
+    it "only calls #read_attribute once" do
+      @player = Player.new
+      @player.number = 23
+      original_method = @player.method(:read_attribute)
+      @player.should_receive(:read_attribute).exactly(1).times do |*args|
+        original_method.call(*args)
+      end
+      @player.safe_send(:number).should == 23
+    end
+  end
+end

data/spec/unit/adapters/active_record_spec.rb

@@ -151,14 +151,15 @@ describe 'RailsAdmin::Adapters::ActiveRecord', :active_record => true do
   
 
   describe "#properties" do
-    before do
-      @abstract_model = RailsAdmin::AbstractModel.new('Player')
-    end
-
     it "returns parameters of string-type field" do
-      @abstract_model.properties.select{|f| f[:name] == :name}.should ==
+      RailsAdmin::AbstractModel.new('Player').properties.select{|f| f[:name] == :name}.should ==
         [{:name => :name, :pretty_name => "Name", :type => :string, :length => 100, :nullable? => false, :serial? => false}]
     end
+
+    it "maps serialized attribute to :serialized field type" do
+      RailsAdmin::AbstractModel.new('User').properties.find{|f| f[:name] == :roles}.should ==
+        {:name => :roles, :pretty_name => "Roles", :length => 255, :nullable? => true, :serial? => false, :type => :serialized}
+    end
   end
 
   describe "data access method" do
@@ -323,6 +324,11 @@ describe 'RailsAdmin::Adapters::ActiveRecord', :active_record => true do
       @abstract_model.send(:build_statement, :field, :integer, 'word', nil).should be_nil
     end
 
+    it "supports decimal type query" do
+      @abstract_model.send(:build_statement, :field, :decimal, "1.1", nil).should == ["(field = ?)", 1.1]
+      @abstract_model.send(:build_statement, :field, :decimal, 'word', nil).should be_nil
+    end
+
     it "supports string type query" do
       @abstract_model.send(:build_statement, :field, :string, "", nil).should be_nil
       @abstract_model.send(:build_statement, :field, :string, "foo", "was").should be_nil
@@ -365,9 +371,5 @@ describe 'RailsAdmin::Adapters::ActiveRecord', :active_record => true do
     it "#table_name works" do
       @abstract_model.table_name.should == 'players'
     end
-
-    it "#serialized_attributes works" do
-      RailsAdmin::AbstractModel.new('User').serialized_attributes.should == ["roles"]
-    end
   end
 end

data/spec/unit/adapters/mongoid_spec.rb

@@ -686,10 +686,10 @@ describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
     it "supports string type query" do
       @abstract_model.send(:build_statement, :field, :string, "", nil).should be_nil
       @abstract_model.send(:build_statement, :field, :string, "foo", "was").should be_nil
-      @abstract_model.send(:build_statement, :field, :string, "foo", "default").should == {:field=>/foo/}
-      @abstract_model.send(:build_statement, :field, :string, "foo", "like").should == {:field=>/foo/}
-      @abstract_model.send(:build_statement, :field, :string, "foo", "starts_with").should == {:field=>/^foo/}
-      @abstract_model.send(:build_statement, :field, :string, "foo", "ends_with").should == {:field=>/foo$/}
+      @abstract_model.send(:build_statement, :field, :string, "foo", "default").should == {:field=>/foo/i}
+      @abstract_model.send(:build_statement, :field, :string, "foo", "like").should == {:field=>/foo/i}
+      @abstract_model.send(:build_statement, :field, :string, "foo", "starts_with").should == {:field=>/^foo/i}
+      @abstract_model.send(:build_statement, :field, :string, "foo", "ends_with").should == {:field=>/foo$/i}
       @abstract_model.send(:build_statement, :field, :string, "foo", "is").should == {:field=>'foo'}
     end
 

data/spec/unit/config/actions/base_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe RailsAdmin::Config::Actions::Base do
+
+  describe "#visible?" do
+    it 'should exclude models not referenced in the only array' do
+      RailsAdmin.config do |config|
+        config.actions do
+          index do
+            only [Player, Cms::BasicPage]
+          end
+        end
+      end
+      RailsAdmin::Config::Actions.find(:index, {:controller => double(:authorized? => true), :abstract_model => RailsAdmin::AbstractModel.new(Player)}).should be_visible
+      RailsAdmin::Config::Actions.find(:index, {:controller => double(:authorized? => true), :abstract_model => RailsAdmin::AbstractModel.new(Team)}).should be_nil
+      RailsAdmin::Config::Actions.find(:index, {:controller => double(:authorized? => true), :abstract_model => RailsAdmin::AbstractModel.new(Cms::BasicPage)}).should be_visible
+    end
+    
+    it 'should exclude models referenced in the except array' do
+      RailsAdmin.config do |config|
+        config.actions do
+          index do
+            except [Player, Cms::BasicPage]
+          end
+        end
+      end
+      RailsAdmin::Config::Actions.find(:index, {:controller => double(:authorized? => true), :abstract_model => RailsAdmin::AbstractModel.new(Player)}).should be_nil
+      RailsAdmin::Config::Actions.find(:index, {:controller => double(:authorized? => true), :abstract_model => RailsAdmin::AbstractModel.new(Team)}).should be_visible
+      RailsAdmin::Config::Actions.find(:index, {:controller => double(:authorized? => true), :abstract_model => RailsAdmin::AbstractModel.new(Cms::BasicPage)}).should be_nil
+    end
+  end
+end

data/spec/unit/config/fields/base_spec.rb

@@ -2,6 +2,17 @@ require 'spec_helper'
 
 describe RailsAdmin::Config::Fields::Base do
 
+  describe "#required" do
+    it "should read the :on => :create/:update validate option" do
+      RailsAdmin.config Ball do
+        field 'color'
+      end
+      
+      RailsAdmin.config('Ball').fields.first.with(:object => Ball.new).should be_required
+      RailsAdmin.config('Ball').fields.first.with(:object => FactoryGirl.create(:ball)).should_not be_required
+    end
+  end
+
   describe "#name" do
     it 'should be normalized to Symbol' do
       RailsAdmin.config Team do
@@ -92,6 +103,21 @@ describe RailsAdmin::Config::Fields::Base do
     end
   end
 
+  describe "#hint" do
+    it "should be user customizable" do
+      RailsAdmin.config Team do
+        list do
+          field :division do
+            hint "Great Division"
+          end
+          field :name
+        end
+      end
+      RailsAdmin.config('Team').list.fields.find{|f| f.name == :division}.hint.should == "Great Division" # custom
+      RailsAdmin.config('Team').list.fields.find{|f| f.name == :name}.hint.should == "" # default
+    end
+  end
+
   describe "#css_class" do
     it "should have a default and be user customizable" do
       RailsAdmin.config Team do
@@ -345,4 +371,34 @@ describe RailsAdmin::Config::Fields::Base do
       RailsAdmin.config(FieldVisibilityTest).show.fields.select{|f| f.visible? }.map(&:name).should =~ [:name]
     end
   end
+  
+  describe '#editable?' do
+    before do
+      Moped.logger.stub!(:debug) if defined?(Moped)
+    end
+
+    it 'should yell for non attr_accessible fields if config.yell_for_non_accessible_fields is true' do
+      RailsAdmin.config do |config|
+        config.yell_for_non_accessible_fields = true
+        config.model FieldTest do
+          field :protected_field
+        end
+      end
+      Rails.logger.should_receive(:debug).with {|msg| msg =~ /Please add 'attr_accessible :protected_field'/ }
+      editable = RailsAdmin.config(FieldTest).field(:protected_field).with(:object => FactoryGirl.create(:field_test), :view => double(:controller => double(:_attr_accessible_role => :default))).editable?
+      editable.should == false
+    end
+    
+    it 'should not yell for non attr_accessible fields if config.yell_for_non_accessible_fields is false' do
+      RailsAdmin.config do |config|
+        config.yell_for_non_accessible_fields = false
+        config.model FieldTest do
+          field :protected_field
+        end
+      end
+      Rails.logger.should_not_receive(:debug).with {|msg| msg =~ /Please add 'attr_accessible :protected_field'/ }
+      editable = RailsAdmin.config(FieldTest).field(:protected_field).with(:object => FactoryGirl.create(:field_test), :view => double(:controller => double(:_attr_accessible_role => :default))).editable?
+      editable.should == false
+    end
+  end
 end

data/spec/unit/config/fields/date_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe RailsAdmin::Config::Fields::Types::Date do
+  describe "#parse_input" do
+    before :each do
+      @object = FactoryGirl.create(:field_test)
+      @time = ::Time.now.getutc
+      @field = RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :date_field }
+    end
+
+    after :each do
+      Time.zone = 'UTC'
+    end
+
+    it "should read %B %d, %Y by default" do
+      @object.date_field = @field.parse_input({ :date_field => @time.strftime("%B %d, %Y") })
+      @object.date_field.should eql(::Date.parse(@time.to_s))
+    end
+
+    it "should cover a timezone lag even if in UTC+n:00 timezone." do
+      Time.zone = 'Tokyo' # +09:00
+
+      @object.date_field = @field.parse_input({ :date_field => @time.strftime("%B %d, %Y") })
+      @object.date_field.should eql(::Date.parse(@time.to_s))
+    end
+
+    it "should have a simple customization option" do
+      RailsAdmin.config FieldTest do
+        edit do
+          field :date_field do
+            date_format :default
+          end
+        end
+      end
+
+      @object.date_field = @field.parse_input({ :date_field => @time.strftime("%Y-%m-%d") })
+      @object.date_field.should eql(::Date.parse(@time.to_s))
+    end
+
+    it "should have a customization option" do
+      RailsAdmin.config FieldTest do
+        edit do
+          field :date_field do
+            strftime_format "%Y/%m/%d"
+          end
+        end
+      end
+
+      @object.date_field = @field.parse_input({ :date_field => @time.strftime("%Y/%m/%d") })
+      @object.date_field.should eql(::Date.parse(@time.to_s))
+    end
+  end
+end

data/spec/unit/config/fields/datetime_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe RailsAdmin::Config::Fields::Types::Datetime do
+  describe "#parse_input" do
+    before :each do
+      @field = RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :datetime_field }
+      @object = FactoryGirl.create(:field_test)
+      @time = ::Time.now.getutc
+    end
+
+    after :each do
+      Time.zone = 'UTC'
+    end
+
+    it "should be able to read %B %d, %Y %H:%M" do
+      @object = FactoryGirl.create(:field_test)
+      @object.datetime_field = @field.parse_input({ :datetime_field => @time.strftime("%B %d, %Y %H:%M") })
+      @object.datetime_field.strftime("%Y-%m-%d %H:%M").should eql(@time.strftime("%Y-%m-%d %H:%M"))     
+    end
+
+    it "should be able to read %a, %d %b %Y %H:%M:%S" do
+      RailsAdmin.config FieldTest do
+        edit do
+          field :datetime_field do
+            date_format :default
+          end
+        end
+      end
+      @object = FactoryGirl.create(:field_test)
+      @object.datetime_field = @field.parse_input({ :datetime_field => @time.strftime("%a, %d %b %Y %H:%M:%S") })
+      @object.datetime_field.to_s(:rfc822).should eql(@time.to_s(:rfc822))     
+    end
+
+    it "should have a customization option" do
+      RailsAdmin.config FieldTest do
+        list do
+          field :datetime_field do
+            strftime_format "%Y-%m-%d %H:%M:%S"
+          end
+        end
+      end
+      @object = FactoryGirl.create(:field_test)
+      @object.datetime_field = @field.parse_input({ :datetime_field => @time.strftime("%Y-%m-%d %H:%M:%S") })
+      @object.datetime_field.to_s(:rfc822).should eql(@time.to_s(:rfc822))     
+    end
+
+    it "should do round-trip saving properly with non-UTC timezones" do
+      Time.zone = 'Vienna'
+      @object = FactoryGirl.create(:field_test)
+      @object.datetime_field = @field.parse_input({ :datetime_field => '2012-09-01 12:00:00 +02:00' })
+      @object.datetime_field.should == Time.zone.parse('2012-09-01 12:00:00 +02:00')
+    end
+  end
+end
+