rails_accessibility_testing 1.5.2 → 1.5.4

data/lib/rails_accessibility_testing/accessibility_helper.rb

@@ -213,16 +213,16 @@ module RailsAccessibilityTesting
     @accessibility_warnings = []
     @in_comprehensive_check = true
     
-    # Show page being checked
+    # Show page being checked - simplified header
     page_path = safe_page_path || 'current page'
     page_url = safe_page_url || 'current URL'
+    view_file = determine_view_file(page_path, page_url, {})
+    
     puts "\n" + "="*70
-    puts "🔍 Scanning page for accessibility issues..."
-    puts "="*70
-    puts "📍 Page: #{page_path}"
-    puts "🔗 URL: #{page_url}"
+    puts "🔍 Scanning: #{view_file || page_path}"
     puts "="*70
-    puts ""
+    print "  Running checks"
+    $stdout.flush
     
     # Use RuleEngine to run checks from checks/ folder
     begin
@@ -234,23 +234,26 @@ module RailsAccessibilityTesting
         path: safe_page_path
       }
       
-      # Progress callback for real-time feedback
+      # Progress callback for real-time feedback - show dots only
       progress_callback = lambda do |check_number, total_checks, check_name, status, data = nil|
         case status
         when :start
-          print "  [#{check_number}/#{total_checks}] Checking #{check_name}... "
+          print "."
           $stdout.flush
         when :passed
-          puts "✓"
+          # Already printed dot, no need to print anything
         when :found_issues
-          puts "✗ Found #{data} issue#{'s' if data != 1}"
+          # Already printed dot, no need to print anything
         when :error
-          puts "⚠ Error: #{data}"
+          # Already printed dot, no need to print anything
         end
       end
       
       violations = engine.check(page, context: context, progress_callback: progress_callback)
       
+      # Print newline after dots
+      puts ""
+      
       # Convert violations to our error/warning format
       violations.each do |violation|
         element_context = violation.element_context || {}
@@ -306,33 +309,60 @@ module RailsAccessibilityTesting
       puts error_output
       $stdout.flush  # Flush immediately to ensure errors are visible
       
-      # Show warnings after errors (if any)
-      if @accessibility_warnings.any?
+      # Check config for errors_only flag
+      errors_only = false
+      begin
+        require 'rails_accessibility_testing/config/yaml_loader'
+        profile = defined?(Rails) && Rails.env.test? ? :test : :development
+        config = RailsAccessibilityTesting::Config::YamlLoader.load(profile: profile)
+        summary_config = config['summary'] || {}
+        errors_only = summary_config.fetch('errors_only', false)
+      rescue StandardError
+        # Use default if config can't be loaded
+      end
+      
+      # Check if we're in live scanner mode (detect by checking caller)
+      is_live_scanner = caller.any? { |line| line.include?('a11y_live_scanner') }
+      
+      # Show warnings after errors (if any) - but skip if errors_only or live scanner
+      if @accessibility_warnings.any? && !is_live_scanner && !errors_only
         warning_output = format_all_warnings(@accessibility_warnings)
         puts warning_output
         $stdout.flush
       end
       
-      # Summary - make it very clear
-      puts "\n" + "="*70
-      puts "📊 SUMMARY: Found #{error_count} ERROR#{'S' if error_count != 1}"
-      puts "   #{warning_count} warning#{'s' if warning_count != 1}" if warning_count > 0
-      puts "="*70
+      # Compact summary
+      puts "📊 #{error_count} error#{'s' if error_count != 1}"
+      puts "   #{warning_count} warning#{'s' if warning_count != 1}" if warning_count > 0 && !is_live_scanner && !errors_only
       $stdout.flush
       
       # Raise to fail the test (errors already formatted above)
       # Include error and warning counts in message so they can be extracted even if exception is caught
       raise "ACCESSIBILITY ERRORS FOUND: #{error_count} error(s), #{warning_count} warning(s) - see details above"
     elsif @accessibility_warnings.any?
-      # Only warnings, no errors - show warnings and indicate test passed with warnings
-      puts format_all_warnings(@accessibility_warnings)
-      puts "\n" + "="*70
-      puts "📊 SUMMARY: Test passed with #{@accessibility_warnings.length} warning#{'s' if @accessibility_warnings.length != 1}"
-      puts "   ✓ #{timestamp}"
-      puts "="*70
-      puts "\n✅ Accessibility checks completed with warnings (test passed, but please address warnings above)"
-      puts "   📄 Page: #{page_context_info[:path] || 'current page'}"
-      puts "   📝 View: #{page_context_info[:view_file] || 'unknown'}"
+      # Check config for errors_only flag
+      errors_only = false
+      begin
+        require 'rails_accessibility_testing/config/yaml_loader'
+        profile = defined?(Rails) && Rails.env.test? ? :test : :development
+        config = RailsAccessibilityTesting::Config::YamlLoader.load(profile: profile)
+        summary_config = config['summary'] || {}
+        errors_only = summary_config.fetch('errors_only', false)
+      rescue StandardError
+        # Use default if config can't be loaded
+      end
+      
+      # Check if we're in live scanner mode - skip warnings in live scanner
+      is_live_scanner = caller.any? { |line| line.include?('a11y_live_scanner') }
+      
+      if !is_live_scanner && !errors_only
+        # Only warnings, no errors - show warnings and indicate test passed with warnings
+        puts format_all_warnings(@accessibility_warnings)
+        puts "📊 #{@accessibility_warnings.length} warning#{'s' if @accessibility_warnings.length != 1}"
+      else
+        # Live scanner or errors_only - just show success
+        puts "✅ No errors"
+      end
     else
       # All checks passed with no errors and no warnings - show success message
       puts "📊 SUMMARY: All checks passed!"
@@ -396,141 +426,103 @@ module RailsAccessibilityTesting
     }
   end
 
-  # Format all collected errors with summary at top and details at bottom
+  # Format all collected errors - compact format grouped by file
   def format_all_errors(errors)
     return "" if errors.empty?
     
-    timestamp = format_timestamp_for_terminal
+    # Group errors by view file
+    errors_by_file = errors.group_by { |e| e[:page_context][:view_file] || e[:page_context][:path] || 'unknown' }
     
     output = []
     output << "\n" + "="*70
-    output << "❌ ACCESSIBILITY ERRORS FOUND: #{errors.length} issue(s) • #{timestamp}"
+    output << "❌ #{errors.length} error#{'s' if errors.length != 1} found"
     output << "="*70
     output << ""
-    output << "📋 SUMMARY OF ISSUES:"
-    output << ""
     
-    # Summary list at top
-    errors.each_with_index do |error, index|
-      error_type = error[:error_type]
-      page_context = error[:page_context]
-      element_context = error[:element_context]
+    # Show errors grouped by file with clear spacing
+    errors_by_file.each_with_index do |(file_path, file_errors), file_index|
+      # Add spacing between files (except first)
+      output << "" if file_index > 0
       
-      # Build summary line - prioritize view file
-      summary = "   #{index + 1}. #{error_type}"
+      # File header
+      output << "📝 #{file_path} (#{file_errors.length} error#{'s' if file_errors.length != 1})"
       
-      # Add view file prominently first
-      if page_context[:view_file]
-        summary += "\n      📝 File: #{page_context[:view_file]}"
-      end
-      
-      # Add element identifier if available
-      if element_context[:id].present?
-        summary += "\n      🔍 Element: [id: #{element_context[:id]}]"
-      elsif element_context[:href].present?
-        href_display = element_context[:href].length > 40 ? "#{element_context[:href][0..37]}..." : element_context[:href]
-        summary += "\n      🔍 Element: [href: #{href_display}]"
-      elsif element_context[:src].present?
-        src_display = element_context[:src].length > 40 ? "#{element_context[:src][0..37]}..." : element_context[:src]
-        summary += "\n      🔍 Element: [src: #{src_display}]"
-      end
-      
-      # Add path as fallback if no view file
-      if !page_context[:view_file] && page_context[:path]
-        summary += "\n      🔗 Path: #{page_context[:path]}"
+      # List errors for this file
+      file_errors.each_with_index do |error, index|
+        error_type = error[:error_type]
+        element_context = error[:element_context]
+        
+        # Compact error line
+        error_line = "   • #{error_type}"
+        
+        # Add element identifier if available (compact)
+        if element_context[:id].present?
+          error_line += " [id: #{element_context[:id]}]"
+        elsif element_context[:href].present?
+          href_display = element_context[:href].length > 30 ? "#{element_context[:href][0..27]}..." : element_context[:href]
+          error_line += " [href: #{href_display}]"
+        elsif element_context[:src].present?
+          src_display = element_context[:src].length > 30 ? "#{element_context[:src][0..27]}..." : element_context[:src]
+          error_line += " [src: #{src_display}]"
+        end
+        
+        output << error_line
       end
-      
-      output << summary
-    end
-    
-    output << ""
-    output << "="*70
-    output << "📝 DETAILED ERROR DESCRIPTIONS:"
-    output << "="*70
-    output << ""
-    
-    # Detailed descriptions at bottom
-    errors.each_with_index do |error, index|
-      output << "\n" + "-"*70
-      output << "ERROR #{index + 1} of #{errors.length}:"
-      output << "-"*70
-      output << error[:message]
     end
     
     output << ""
     output << "="*70
-    output << "💡 Fix all issues above, then re-run the accessibility checks"
-    output << "="*70
     output << ""
     
     output.join("\n")
   end
 
-  # Format all collected warnings with summary at top and details at bottom (same format as errors)
+  # Format all collected warnings - compact format grouped by file
   def format_all_warnings(warnings)
     return "" if warnings.empty?
     
-    timestamp = format_timestamp_for_terminal
+    # Group warnings by view file
+    warnings_by_file = warnings.group_by { |w| w[:page_context][:view_file] || w[:page_context][:path] || 'unknown' }
     
     output = []
     output << "\n" + "="*70
-    output << "⚠️  ACCESSIBILITY WARNINGS FOUND: #{warnings.length} warning(s) • #{timestamp}"
+    output << "⚠️  #{warnings.length} warning#{'s' if warnings.length != 1} found"
     output << "="*70
     output << ""
-    output << "📋 SUMMARY OF WARNINGS:"
-    output << ""
     
-    # Summary list at top
-    warnings.each_with_index do |warning, index|
-      warning_type = warning[:warning_type]
-      page_context = warning[:page_context]
-      element_context = warning[:element_context]
-      
-      # Build summary line - prioritize view file
-      summary = "   #{index + 1}. #{warning_type}"
+    # Show warnings grouped by file with clear spacing
+    warnings_by_file.each_with_index do |(file_path, file_warnings), file_index|
+      # Add spacing between files (except first)
+      output << "" if file_index > 0
       
-      # Add view file prominently first
-      if page_context[:view_file]
-        summary += "\n      📝 File: #{page_context[:view_file]}"
-      end
-      
-      # Add element identifier if available
-      if element_context[:id].present?
-        summary += "\n      🔍 Element: [id: #{element_context[:id]}]"
-      elsif element_context[:href].present?
-        href_display = element_context[:href].length > 40 ? "#{element_context[:href][0..37]}..." : element_context[:href]
-        summary += "\n      🔍 Element: [href: #{href_display}]"
-      elsif element_context[:src].present?
-        src_display = element_context[:src].length > 40 ? "#{element_context[:src][0..37]}..." : element_context[:src]
-        summary += "\n      🔍 Element: [src: #{src_display}]"
-      end
+      # File header
+      output << "📝 #{file_path} (#{file_warnings.length} warning#{'s' if file_warnings.length != 1})"
       
-      # Add path as fallback if no view file
-      if !page_context[:view_file] && page_context[:path]
-        summary += "\n      🔗 Path: #{page_context[:path]}"
+      # List warnings for this file
+      file_warnings.each_with_index do |warning, index|
+        warning_type = warning[:warning_type]
+        element_context = warning[:element_context]
+        
+        # Compact warning line
+        warning_line = "   • #{warning_type}"
+        
+        # Add element identifier if available (compact)
+        if element_context[:id].present?
+          warning_line += " [id: #{element_context[:id]}]"
+        elsif element_context[:href].present?
+          href_display = element_context[:href].length > 30 ? "#{element_context[:href][0..27]}..." : element_context[:href]
+          warning_line += " [href: #{href_display}]"
+        elsif element_context[:src].present?
+          src_display = element_context[:src].length > 30 ? "#{element_context[:src][0..27]}..." : element_context[:src]
+          warning_line += " [src: #{src_display}]"
+        end
+        
+        output << warning_line
       end
-      
-      output << summary
-    end
-    
-    output << ""
-    output << "="*70
-    output << "📝 DETAILED WARNING DESCRIPTIONS:"
-    output << "="*70
-    output << ""
-    
-    # Detailed descriptions at bottom
-    warnings.each_with_index do |warning, index|
-      output << "\n" + "-"*70
-      output << "WARNING #{index + 1} of #{warnings.length}:"
-      output << "-"*70
-      output << warning[:message]
     end
     
     output << ""
     output << "="*70
-    output << "💡 Consider addressing these warnings to improve accessibility"
-    output << "="*70
     output << ""
     
     output.join("\n")
@@ -542,10 +534,23 @@ module RailsAccessibilityTesting
   # @param page_context [Hash] Context about the page being tested
   # @return [String] Formatted error message
   def build_error_message(error_type, element_context, page_context)
+    # Check config for show_fixes setting
+    show_fixes = true
+    begin
+      require 'rails_accessibility_testing/config/yaml_loader'
+      profile = defined?(Rails) && Rails.env.test? ? :test : :development
+      config = RailsAccessibilityTesting::Config::YamlLoader.load(profile: profile)
+      summary_config = config['summary'] || {}
+      show_fixes = summary_config.fetch('show_fixes', true)
+    rescue StandardError
+      # Use default if config can't be loaded
+    end
+    
     RailsAccessibilityTesting::ErrorMessageBuilder.build(
       error_type: error_type,
       element_context: element_context,
-      page_context: page_context
+      page_context: page_context,
+      show_fixes: show_fixes
     )
   end
 

data/lib/rails_accessibility_testing/checks/base_check.rb

@@ -80,11 +80,20 @@ module RailsAccessibilityTesting
       # @param element_context [Hash] Optional element context to help find partials
       # @return [Hash]
       def page_context(element_context = nil)
-        {
-          url: safe_page_url,
-          path: safe_page_path,
-          view_file: determine_view_file(element_context)
-        }
+        # For static scanning, use view_file from context if available
+        if @context && @context[:view_file]
+          {
+            url: nil,
+            path: nil,
+            view_file: @context[:view_file]
+          }
+        else
+          {
+            url: safe_page_url,
+            path: safe_page_path,
+            view_file: determine_view_file(element_context)
+          }
+        end
       end
       
       # Get element context from Capybara element

data/lib/rails_accessibility_testing/checks/form_errors_check.rb

@@ -17,7 +17,7 @@ module RailsAccessibilityTesting
         
         page.all('.field_with_errors input, .field_with_errors textarea, .field_with_errors select, .is-invalid, [aria-invalid="true"]').each do |input|
           id = input[:id]
-          next if id.blank?
+          next if id.nil? || id.to_s.strip.empty?
           
           has_error_message = page.has_css?("[aria-describedby*='#{id}'], .field_with_errors label[for='#{id}'] + .error, .field_with_errors label[for='#{id}'] + .invalid-feedback", wait: false)
           

data/lib/rails_accessibility_testing/checks/form_labels_check.rb

@@ -18,13 +18,15 @@ module RailsAccessibilityTesting
         
         page.all('input[type="text"], input[type="email"], input[type="password"], input[type="number"], input[type="tel"], input[type="url"], input[type="search"], input[type="date"], input[type="time"], input[type="datetime-local"], textarea, select').each do |input|
           id = input[:id]
-          next if id.blank?
+          next if id.nil? || id.to_s.strip.empty?
           
           has_label = page.has_css?("label[for='#{id}']", wait: false)
-          aria_label = input[:"aria-label"].present?
-          aria_labelledby = input[:"aria-labelledby"].present?
+          aria_label = input[:"aria-label"]
+          aria_labelledby = input[:"aria-labelledby"]
+          has_aria_label = aria_label && !aria_label.to_s.strip.empty?
+          has_aria_labelledby = aria_labelledby && !aria_labelledby.to_s.strip.empty?
           
-          unless has_label || aria_label || aria_labelledby
+          unless has_label || has_aria_label || has_aria_labelledby
             element_ctx = element_context(input)
             element_ctx[:input_type] = input[:type] || input.tag_name
             

data/lib/rails_accessibility_testing/checks/heading_check.rb

@@ -95,22 +95,14 @@ module RailsAccessibilityTesting
         end
         
         # Check 5: Headings with only images (no alt text or empty alt) (WCAG 4.1.2)
+        # Note: For static scanning, we check if heading text is empty
+        # Full image checking within headings requires more complex DOM traversal
+        # This is a simplified check - full implementation would require xpath queries
         headings.each do |heading|
-          # Check if heading contains only images
-          images = heading.all('img', visible: true)
-          if images.any? && heading.text.strip.empty?
-            # Check if all images have alt text
-            images_without_alt = images.select { |img| img[:alt].nil? || img[:alt].strip.empty? }
-            if images_without_alt.any?
-              element_ctx = element_context(heading)
-              violations << violation(
-                message: "Heading contains images without alt text - headings must have accessible text",
-                element_context: element_ctx,
-                wcag_reference: "4.1.2",
-                remediation: "Add alt text to images in the heading, or add visible text alongside the images:\n\n<h1><img src=\"image.jpg\" alt=\"Descriptive text\">Heading Text</h1>"
-              )
-            end
-          end
+          heading_text = heading.text.strip
+          # If heading has no text, it might be image-only (but we can't easily check images within heading in static mode)
+          # This check is primarily for dynamic scanning where we can traverse the DOM
+          # For static scanning, we rely on the empty heading check above
         end
         
         # Check 6: Headings used only for styling (WCAG 2.4.6)

data/lib/rails_accessibility_testing/checks/image_alt_text_check.rb

@@ -31,7 +31,7 @@ module RailsAccessibilityTesting
               wcag_reference: "1.1.1",
               remediation: generate_remediation(element_ctx)
             )
-          elsif alt_value.blank? && has_alt_attribute
+          elsif (alt_value.nil? || alt_value.to_s.strip.empty?) && has_alt_attribute
             # Image has alt attribute but it's empty - warn about this
             # Empty alt is valid for decorative images, but we should check if it's actually decorative
             element_ctx = element_context(img)

data/lib/rails_accessibility_testing/checks/interactive_elements_check.rb

@@ -18,22 +18,26 @@ module RailsAccessibilityTesting
         page.all('button, a[href], [role="button"], [role="link"]').each do |element|
           next unless element.visible?
           
-          text = element.text.strip
+          text = element.text.to_s.strip
           aria_label = element[:"aria-label"]
           aria_labelledby = element[:"aria-labelledby"]
           title = element[:title]
           
           # Check if element contains an image with alt text (common pattern for logo links)
           has_image_with_alt = false
-          if text.blank?
-            images = element.all('img', visible: :all)
-            has_image_with_alt = images.any? do |img|
-              alt = img[:alt]
-              alt.present? && !alt.strip.empty?
-            end
+          if text.empty?
+            # For static scanning, we can't easily check images within elements
+            # This check works better in dynamic scanning with Capybara
+            # For now, skip image checking in static mode
+            has_image_with_alt = false
           end
           
-          if text.blank? && aria_label.blank? && aria_labelledby.blank? && title.blank? && !has_image_with_alt
+          text_empty = text.empty?
+          aria_label_empty = aria_label.nil? || aria_label.to_s.strip.empty?
+          aria_labelledby_empty = aria_labelledby.nil? || aria_labelledby.to_s.strip.empty?
+          title_empty = title.nil? || title.to_s.strip.empty?
+          
+          if text_empty && aria_label_empty && aria_labelledby_empty && title_empty && !has_image_with_alt
             element_ctx = element_context(element)
             tag = element.tag_name
             

data/lib/rails_accessibility_testing/config/yaml_loader.rb

@@ -68,8 +68,21 @@ module RailsAccessibilityTesting
           
           merged_checks = checks.merge(profile_checks)
           
+          # Deep merge summary configuration
+          base_summary = base_config['summary'] || {}
+          profile_summary = profile_config['summary'] || {}
+          merged_summary = base_summary.merge(profile_summary)
+          
+          # Merge static_scanner config
+          base_static_scanner = base_config['static_scanner'] || {}
+          profile_static_scanner = profile_config['static_scanner'] || {}
+          merged_static_scanner = base_static_scanner.merge(profile_static_scanner)
+          
           base_config.merge(
             'checks' => merged_checks,
+            'summary' => merged_summary,
+            'scan_strategy' => profile_config['scan_strategy'] || base_config['scan_strategy'] || 'paths',
+            'static_scanner' => merged_static_scanner,
             'profile' => profile.to_s,
             'ignored_rules' => parse_ignored_rules(parsed, profile)
           )
@@ -105,6 +118,13 @@ module RailsAccessibilityTesting
           {
             'wcag_level' => 'AA',
             'checks' => default_checks,
+            'summary' => {
+              'show_summary' => true,
+              'errors_only' => false,
+              'show_fixes' => true,
+              'ignore_warnings' => false
+            },
+            'scan_strategy' => 'paths',
             'ignored_rules' => [],
             'profile' => 'test'
           }