rails_accessibility_testing 1.5.1 → 1.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed1c4100059b21f4a777e9691fec08fe59fc59f7accecc5b8f47e15b68b913ed
-  data.tar.gz: b65e45644fd839d960ef461b5a3c350903c93ad0a89337f5f3423e2d87b7c57a
+  metadata.gz: 58922a0f7334ba5695d55aeb1d02576e975504492d7ae47c1ae37552cba246c3
+  data.tar.gz: a07f66b20c17b6da10ef18518d58a20d4de9429f2fac3af7dc9e2505bf3d218e
 SHA512:
-  metadata.gz: 827873b27a3a9ee68c39090838d3d422a628567df1134ea4ed807be28b909e5fe3b976fb232493633ed8f521ebf2c94eca8ce051b78b844a86424095ffcc31fc
-  data.tar.gz: 2f682ff20a50b1a0ec99911f0d260a6fc6400df9aac19451538efe882a7c7dd98582895e8dd151ad4bd1d80ec998a7c86ac6906b22da46beef048f2a7226490c
+  metadata.gz: 5f12b4e6da01ca76d1deb3aba955f284915857bf003fa6cb7568b8be05ea78e2eb7dddaf94bbe89fbe665cf99afb951ffbb86517eb3ea4862084b767939e779a
+  data.tar.gz: f638f6fbc1a0e4f7f3405f2c49929172d364910ad8140be4b662e823ab3c734fcde487666ae9874d973ec6d2643cb97ca2dc33e4419f805be45b0e2dec8daa2e

data/CHANGELOG.md

@@ -5,6 +5,32 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.5.3] - 2024-11-20
+
+### Fixed
+- **Gem packaging**: Verified all required files are included in gem package
+  - All executables (rails_a11y, rails_server_safe, a11y_live_scanner)
+  - All generator templates (.erb files)
+  - Complete library files and documentation
+
+### Verified
+- All executables properly included in gemspec
+- Generator templates correctly packaged
+- rails_server_safe Ruby script working correctly
+- Local development setup confirmed working
+
+## [1.5.2] - 2024-11-20
+
+### Fixed
+- **Bundler compatibility**: Converted `rails_server_safe` from shell script to Ruby script to fix Bundler wrapper loading issues
+- **Generator Procfile.dev setup**: Generator now automatically uses `rails_server_safe` in Procfile.dev to prevent Foreman from terminating all processes when server is already running
+
+### Changed
+- Generator behavior: When installing, automatically replaces `web: bin/rails server` with `web: bundle exec rails_server_safe` in existing Procfile.dev files
+- Generator behavior: When creating new Procfile.dev, uses `rails_server_safe` by default
+
+## [1.5.1] - 2024-11-20
+
 ## [1.5.0] - 2025-11-19
 
 ### 🎉 Major Release: Enhanced View Detection & Performance Optimizations
@@ -301,6 +327,7 @@ This release introduces significant improvements to view file detection, partial
 - Compatible with RSpec Rails 6.0+
 - Modular architecture with rule engine and check definitions
 
+[1.5.2]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.5.2
 [1.5.0]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.5.0
 [1.4.3]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.4.3
 [1.4.2]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.4.2

data/README.md

@@ -99,7 +99,8 @@ This creates:
 - `config/accessibility.yml` - Check settings
 - `spec/system/all_pages_accessibility_spec.rb` - Comprehensive spec that dynamically tests all GET routes
 - Updates `spec/rails_helper.rb` (if using RSpec)
-- Updates `Procfile.dev` with accessibility watch command (if present)
+- Updates `Procfile.dev` with live accessibility scanner (if present)
+  - Optionally uses `rails_server_safe` wrapper (convenience helper, not required)
 
 ### Setup (Option 2: Manual)
 
@@ -445,6 +446,7 @@ See [ARCHITECTURE.md](ARCHITECTURE.md) for detailed architecture documentation.
 1. **🎯 Live Accessibility Scanner**
    - Real-time scanning as you browse during development
    - Integrated with `bin/dev` via Procfile.dev
+   - Uses `rails_server_safe` wrapper to prevent Foreman process termination issues
    - Smart cancellation when navigating to new pages
    - Detailed reporting showing exactly what's being scanned
 

data/exe/rails_server_safe

@@ -1,58 +1,66 @@
-#!/usr/bin/env sh
+#!/usr/bin/env ruby
+# frozen_string_literal: true
 
 # Safe wrapper for Rails server that doesn't fail if server is already running
 # This prevents Foreman from terminating all processes when server is already up
 
-PIDFILE="${PIDFILE:-tmp/pids/server.pid}"
-PORT="${PORT:-3000}"
+require 'fileutils'
 
-# Check if PID file exists
-if [ -f "$PIDFILE" ]; then
-  PID=$(cat "$PIDFILE" 2>/dev/null)
+pidfile = ENV.fetch('PIDFILE', 'tmp/pids/server.pid')
+port = ENV.fetch('PORT', '3000').to_i
+
+# Check if PID file exists and process is running
+if File.exist?(pidfile)
+  pid = File.read(pidfile).strip.to_i rescue nil
   
-  # Check if the process is actually running
-  if [ -n "$PID" ] && kill -0 "$PID" 2>/dev/null; then
-    # Check if it's listening on the expected port
-    if lsof -ti:$PORT -sTCP:LISTEN | grep -q "^$PID$" 2>/dev/null; then
-      echo "Server is already running (pid: $PID, port: $PORT)"
-      echo "Keeping process alive for Foreman..."
-      # Keep the process alive by waiting indefinitely
-      # This prevents Foreman from shutting down all processes
-      while true; do
-        # Check if the server process is still running
-        if ! kill -0 "$PID" 2>/dev/null; then
-          echo "Server process ended. Exiting."
-      exit 0
-        fi
-        sleep 5
-      done
-    else
-      # PID exists but not listening on port - stale PID file
-      echo "Removing stale PID file (pid: $PID not listening on port $PORT)"
-      rm -f "$PIDFILE"
-    fi
-  else
-    # PID file exists but process is dead - stale PID file
-    echo "Removing stale PID file (process $PID not running)"
-    rm -f "$PIDFILE"
-  fi
-fi
+  if pid && pid > 0
+    # Check if the process is actually running
+    begin
+      Process.kill(0, pid)
+      # Process is running, check if it's listening on the expected port
+      port_check = `lsof -ti:#{port} -sTCP:LISTEN 2>/dev/null`.strip
+      if port_check == pid.to_s
+        puts "Server is already running (pid: #{pid}, port: #{port})"
+        puts "Keeping process alive for Foreman..."
+        # Keep the process alive by waiting indefinitely
+        loop do
+          begin
+            Process.kill(0, pid)
+          rescue Errno::ESRCH
+            puts "Server process ended. Exiting."
+            exit 0
+          end
+          sleep 5
+        end
+      else
+        # PID exists but not listening on port - stale PID file
+        puts "Removing stale PID file (pid: #{pid} not listening on port #{port})"
+        FileUtils.rm_f(pidfile)
+      end
+    rescue Errno::ESRCH
+      # PID file exists but process is dead - stale PID file
+      puts "Removing stale PID file (process #{pid} not running)"
+      FileUtils.rm_f(pidfile)
+    end
+  end
+end
 
 # Check if something else is using the port
-if lsof -ti:$PORT -sTCP:LISTEN >/dev/null 2>&1; then
-  EXISTING_PID=$(lsof -ti:$PORT -sTCP:LISTEN | head -1)
-  echo "Port $PORT is already in use by process $EXISTING_PID"
-  echo "Server may already be running. Keeping process alive for Foreman..."
+port_check = `lsof -ti:#{port} -sTCP:LISTEN 2>/dev/null`.strip
+if !port_check.empty?
+  existing_pid = port_check.split("\n").first.to_i
+  puts "Port #{port} is already in use by process #{existing_pid}"
+  puts "Server may already be running. Keeping process alive for Foreman..."
   # Keep the process alive by monitoring the existing server
-  while true; do
-    if ! lsof -ti:$PORT -sTCP:LISTEN >/dev/null 2>&1; then
-      echo "Port $PORT is now free. Exiting so Foreman can restart."
-  exit 0
-    fi
+  loop do
+    port_check = `lsof -ti:#{port} -sTCP:LISTEN 2>/dev/null`.strip
+    if port_check.empty?
+      puts "Port #{port} is now free. Exiting so Foreman can restart."
+      exit 0
+    end
     sleep 5
-  done
-fi
+  end
+end
 
 # Start the server normally
-exec bin/rails server "$@"
-
+exec('bin/rails', 'server', *ARGV)

data/lib/generators/rails_a11y/install/install_generator.rb

@@ -53,34 +53,49 @@ module RailsA11y
         end
       end
       
-      def update_procfile_dev
-        procfile_path = 'Procfile.dev'
-        
-        if File.exist?(procfile_path)
-          procfile_content = File.read(procfile_path)
-          
-          # Check if a11y line already exists
-          unless procfile_content.include?('a11y:')
-            # Add live scanner to Procfile.dev
-            a11y_line = "a11y: bundle exec a11y_live_scanner\n"
-            procfile_content += a11y_line
-            File.write(procfile_path, procfile_content)
-            say "✅ Added live accessibility scanner to #{procfile_path}", :green
-            say "   💡 Run 'bin/dev' to start live scanning as you browse pages", :cyan
-          else
-            say "⚠️  Procfile.dev already contains an a11y entry. Skipping.", :yellow
-          end
-        else
-          # Create Procfile.dev if it doesn't exist
-          procfile_content = <<~PROCFILE
-            web: bin/rails server
-            a11y: bundle exec a11y_live_scanner
-          PROCFILE
-          
-          File.write(procfile_path, procfile_content)
-          say "✅ Created #{procfile_path} with live accessibility scanner", :green
-        end
-      end
+              def update_procfile_dev
+                procfile_path = 'Procfile.dev'
+                
+                if File.exist?(procfile_path)
+                  procfile_content = File.read(procfile_path)
+                  modified = false
+                  
+                  # Update web line to use rails_server_safe if it's using standard rails server
+                  if procfile_content.match?(/^web:\s*bin\/rails server/)
+                    procfile_content.gsub!(/^web:\s*bin\/rails server/, 'web: bundle exec rails_server_safe')
+                    modified = true
+                    say "✅ Updated web process to use rails_server_safe in #{procfile_path}", :green
+                    say "   💡 This prevents Foreman from terminating processes when server is already running", :cyan
+                  end
+                  
+                  # Check if a11y line already exists
+                  unless procfile_content.include?('a11y:')
+                    # Add live scanner to Procfile.dev
+                    a11y_line = "a11y: bundle exec a11y_live_scanner\n"
+                    procfile_content += a11y_line
+                    modified = true
+                    say "✅ Added live accessibility scanner to #{procfile_path}", :green
+                    say "   💡 Run 'bin/dev' to start live scanning as you browse pages", :cyan
+                  else
+                    say "⚠️  Procfile.dev already contains an a11y entry. Skipping.", :yellow
+                  end
+                  
+                  # Save if we made changes
+                  File.write(procfile_path, procfile_content) if modified
+                else
+                  # Create Procfile.dev if it doesn't exist
+                  # Use rails_server_safe to prevent Foreman termination issues
+                  procfile_content = <<~PROCFILE
+                    web: bundle exec rails_server_safe
+                    a11y: bundle exec a11y_live_scanner
+                  PROCFILE
+                  
+                  File.write(procfile_path, procfile_content)
+                  say "✅ Created #{procfile_path} with live accessibility scanner", :green
+                  say "   💡 Using rails_server_safe to prevent Foreman process termination", :cyan
+                  say "   💡 Run 'bin/dev' to start live scanning as you browse pages", :cyan
+                end
+              end
       
       def update_gitignore
         gitignore_path = '.gitignore'

data/lib/rails_accessibility_testing/version.rb

@@ -1,4 +1,4 @@
 module RailsAccessibilityTesting
-  VERSION = "1.5.1"
+  VERSION = "1.5.3"
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_accessibility_testing
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.3
 platform: ruby
 authors:
 - Regan Maharjan