rails_accessibility_testing 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7f693b05664c88f5b08e1917caa94ad360754d3113787d89c8d7b59331c1b55
-  data.tar.gz: 29bfe1bfa996b04d9f779c4d576c9a2b799a041ecc52d0d35c94b1cefb9b2f0a
+  metadata.gz: 916b677bef5f630731d65df12bdd430949d70876ec0c5a9c047e15353084ae7b
+  data.tar.gz: 4960a239874be87bc96a74ba7804cfc3213ae0ea62a4b9a367d437fed337e0d0
 SHA512:
-  metadata.gz: b525904eca4df9bf87d32fed9b27587681a45cfb73ae4f630ba8700929fa763fef316940e0b246c84eb2d7216b3def1df82e99d6375c859760d72f34e05ac1fa
-  data.tar.gz: 750912a05ec0b37f24bdb2011052f140c827940ec1063f6beaf1d5974708e386d21399808ecc3133ed7899f4ba7202638292f20950de953dca9508f0a275af70
+  metadata.gz: f0d0e645d4d2929da2b0d2461459510759dab172192e7564be8dd2e57f2771ff86144f4fb8ece7fcbd04351ba2cc0ee08964ea7a0e07d65485171718e7608a5c
+  data.tar.gz: d8678b98bd3978104dd2158ff04f3494ff291d690b75ecee4bc29121eb76d283fd378a1cb6f763f14904060a1e8cc9e39288dcc4ca7f8ab8420253fcbc1273e1

data/CHANGELOG.md

@@ -5,6 +5,32 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.3.0] - 2024-12-XX
+
+### Added
+- CLI reports now use ErrorMessageBuilder for detailed, formatted error messages
+- CLI reports include comprehensive remediation steps, element details, and WCAG references
+- Better empty alt text detection (checks both Capybara attributes and JavaScript getAttribute)
+- Improved server port detection with better error handling and timeout management
+
+### Changed
+- CLI default profile changed to `:development` for faster checks (color contrast disabled by default)
+- Improved server wait logic with longer retry times (up to 20 seconds) and better port re-detection
+- Report generation now skips when no URLs are checked (cleaner output when server isn't ready)
+- Port detection now prioritizes common Rails ports (3000, 3001, 4000, 5000) and excludes problematic ports
+
+### Fixed
+- Fixed logger accessor compatibility issue - logger access is now optional to work with older gem versions
+- Fixed CLI connection issues by improving port detection and server readiness checks
+- Fixed CLI showing empty reports when server isn't ready - now shows informative message instead
+- Improved error handling for connection timeouts and connection refused errors
+- Better handling of interrupt signals during server wait operations
+
+### Improved
+- CLI error messages are now more detailed and actionable with specific remediation steps
+- Server detection is more reliable with improved timeout handling and error recovery
+- Better user experience when running in Procfile.dev with automatic retries
+
 ## [1.2.0] - 2024-12-XX
 
 ### Changed
@@ -111,6 +137,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Compatible with RSpec Rails 6.0+
 - Modular architecture with rule engine and check definitions
 
+[1.3.0]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.3.0
 [1.2.0]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.2.0
 [1.1.6]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.1.6
 [1.1.5]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.1.5

data/README.md

@@ -7,7 +7,7 @@
 
 **The RSpec + RuboCop of accessibility for Rails. Catch WCAG violations before they reach production.**
 
-**Current Version:** 1.1.0
+**Current Version:** 1.2.0
 
 📖 **[📚 Full Documentation](https://rayraycodes.github.io/rails-accessibility-testing/)** | [💻 GitHub](https://github.com/rayraycodes/rails-accessibility-testing) | [💎 RubyGems](https://rubygems.org/gems/rails_accessibility_testing)
 
@@ -40,6 +40,8 @@ Add to your `Gemfile`:
 group :development, :test do
   gem 'rails_accessibility_testing'
   gem 'axe-core-capybara', '~> 4.0'
+  # Your existing Capybara, selenium-webdriver, webdrivers gems
+  # The gem has minimal dependencies - you control your own driver setup
 end
 ```
 
@@ -301,9 +303,13 @@ See [ARCHITECTURE.md](ARCHITECTURE.md) for detailed architecture documentation.
 - Ruby 3.0+ (3.1+ recommended)
 - Rails 6.0+ (7.1+ recommended)
 - RSpec Rails 6.0+ (for RSpec) or Minitest (for Minitest)
-- Capybara 3.0+
+- Capybara 3.0+ (provided by your project)
+- selenium-webdriver 4.0+ (provided by your project, for system specs)
+- webdrivers (optional, provided by your project, for automatic driver management)
 - Chrome/Chromium browser
 
+**Note:** As of version 1.2.0, the gem has minimal dependencies. You provide and configure Capybara, selenium-webdriver, and webdrivers in your own Gemfile, giving you full control over your test driver setup.
+
 ## 🤝 Contributing
 
 We welcome contributions! Please see [CONTRIBUTING.md](CONTRIBUTING.md) for guidelines.

data/lib/rails_accessibility_testing/accessibility_helper.rb

@@ -83,6 +83,9 @@ module AccessibilityHelper
     # If we collected any errors and this was called directly (not from comprehensive), raise them
     if @accessibility_errors.any? && !@in_comprehensive_check
       raise format_all_errors(@accessibility_errors)
+    elsif @accessibility_errors.empty? && !@in_comprehensive_check
+      # Show success message when all checks pass
+      puts "\n✅ All basic accessibility checks passed! (5 checks: form labels, images, interactive elements, headings, keyboard)"
     end
   end
 
@@ -103,6 +106,9 @@ module AccessibilityHelper
     # If we collected any errors, raise them all together
     if @accessibility_errors.any?
       raise format_all_errors(@accessibility_errors)
+    else
+      # Show success message when all checks pass
+      puts "\n✅ All comprehensive accessibility checks passed! (11 checks: form labels, images, interactive elements, headings, keyboard, ARIA landmarks, form errors, table structure, duplicate IDs, skip links, color contrast)"
     end
   end
 

data/lib/rails_accessibility_testing/checks/image_alt_text_check.rb

@@ -17,6 +17,10 @@ module RailsAccessibilityTesting
         
         page.all('img', visible: :all).each do |img|
           has_alt_attribute = page.evaluate_script("arguments[0].hasAttribute('alt')", img.native)
+          # Get alt value - might be nil, empty string, or actual text
+          alt_value = img[:alt] || ""
+          # Also check via JavaScript to be sure
+          alt_value_js = page.evaluate_script("arguments[0].getAttribute('alt')", img.native) || ""
           
           if has_alt_attribute == false
             element_ctx = element_context(img)
@@ -27,6 +31,17 @@ module RailsAccessibilityTesting
               wcag_reference: "1.1.1",
               remediation: generate_remediation(element_ctx)
             )
+          elsif (alt_value.blank? || alt_value_js.blank?) && has_alt_attribute
+            # Image has alt attribute but it's empty - warn about this
+            # Empty alt is valid for decorative images, but we should check if it's actually decorative
+            element_ctx = element_context(img)
+            
+            violations << violation(
+              message: "Image has empty alt attribute - ensure this image is purely decorative. If it conveys information, add descriptive alt text.",
+              element_context: element_ctx,
+              wcag_reference: "1.1.1",
+              remediation: generate_remediation(element_ctx)
+            )
           end
         end
         

data/lib/rails_accessibility_testing/cli/command.rb

@@ -53,7 +53,7 @@ module RailsAccessibilityTesting
       
       def parse_options(argv)
         options = {
-          profile: :test,
+          profile: :development,  # Use development profile by default (faster, no color contrast)
           format: :human,
           output: nil,
           debug: false
@@ -135,12 +135,44 @@ module RailsAccessibilityTesting
             url = normalize_url(target)
             
             # Wait for server to be ready (with retries)
-            wait_for_server(url) if url.match?(/\Ahttps?:\/\//)
+            # If wait fails, try to re-detect port and update URL
+            if url.match?(/\Ahttps?:\/\//)
+              # First, try to detect the port (might not be ready yet)
+              uri = URI.parse(url)
+              detected_port = detect_server_port
+              
+              # If we detected a different port, update the URL
+              if detected_port != uri.port.to_s
+                url = "#{uri.scheme}://#{uri.host}:#{detected_port}#{uri.path}"
+              end
+              
+              # Now wait for server to be ready
+              server_ready = wait_for_server(url, max_retries: 20, retry_delay: 1)
+              
+              # If still not ready, try re-detecting port one more time
+              unless server_ready
+                new_port = detect_server_port
+                if new_port != uri.port.to_s
+                  url = "#{uri.scheme}://#{uri.host}:#{new_port}#{uri.path}"
+                  server_ready = wait_for_server(url, max_retries: 20, retry_delay: 1)
+                end
+                
+                # If still not ready, skip this check and try next time
+                unless server_ready
+                  # Server still starting - this is normal, will retry automatically
+                  $stderr.puts "Waiting for server to start... (will retry automatically)"
+                  next
+                end
+              end
+            end
             
             Capybara.visit(url)
             violations = engine.check(Capybara.current_session, context: { url: url })
             all_violations.concat(violations)
             checked_urls << { url: url, violations: violations.count }
+          rescue Interrupt
+            # Handle interrupt gracefully - exit the loop
+            break
           rescue StandardError => e
             $stderr.puts "Error checking #{target}: #{e.message}"
           end
@@ -180,8 +212,8 @@ module RailsAccessibilityTesting
         return target if target.match?(/\Ahttps?:\/\//)
         
         # If it's a path and we're using Selenium, construct a full URL
-        # Default to localhost:3000 (standard Rails port)
-        port = ENV['PORT'] || ENV['RAILS_PORT'] || '3000'
+        # Try to detect the actual port, or use environment variables, or default to 3000
+        port = detect_server_port
         base_url = ENV['RAILS_URL'] || "http://localhost:#{port}"
         
         # Ensure path starts with /
@@ -189,7 +221,42 @@ module RailsAccessibilityTesting
         "#{base_url}#{path}"
       end
       
-      def wait_for_server(url, max_retries: 10, retry_delay: 2)
+      def detect_server_port
+        # Check environment variables first
+        return ENV['PORT'] if ENV['PORT']
+        return ENV['RAILS_PORT'] if ENV['RAILS_PORT']
+        
+        # Try to detect port from Rails server - check common Rails ports
+        # Check in order: 3000 (most common), then others
+        # Prioritize 3000 first as it's the Rails default
+        common_ports = [3000, 3001, 4000, 5000]
+        
+        common_ports.each do |port|
+          begin
+            require 'net/http'
+            http = Net::HTTP.new('localhost', port)
+            http.open_timeout = 1
+            http.read_timeout = 1
+            # Try to get a response - check if it looks like a Rails server
+            response = http.head('/')
+            # Accept 2xx, 3xx, or 4xx responses (server is responding)
+            # Reject 5xx as it might be a proxy or error
+            if response.code.to_i < 500
+              # Additional check: Rails servers usually have certain headers
+              # But for now, any HTTP response on these common ports is likely Rails
+              return port.to_s
+            end
+          rescue Errno::ECONNREFUSED, Net::OpenTimeout, Net::ReadTimeout, SocketError, Interrupt, Errno::EHOSTUNREACH, Errno::ETIMEDOUT
+            # Port not available or interrupted, try next
+            next
+          end
+        end
+        
+        # Default to 3000 if nothing found
+        '3000'
+      end
+      
+      def wait_for_server(url, max_retries: 15, retry_delay: 1)
         require 'net/http'
         require 'uri'
         
@@ -199,22 +266,31 @@ module RailsAccessibilityTesting
         max_retries.times do |attempt|
           begin
             http = Net::HTTP.new(uri.host, uri.port)
-            http.open_timeout = 1
-            http.read_timeout = 1
+            http.open_timeout = 2
+            http.read_timeout = 2
             response = http.head('/')
-            return if response.code.to_i < 500 # Server is responding
-          rescue Errno::ECONNREFUSED, Errno::ETIMEDOUT, Net::OpenTimeout, Net::ReadTimeout, SocketError
+            return true if response.code.to_i < 500 # Server is responding
+          rescue Errno::ECONNREFUSED, Errno::ETIMEDOUT, Net::OpenTimeout, Net::ReadTimeout, SocketError, Errno::EHOSTUNREACH
             # Server not ready yet
             if attempt < max_retries - 1
-              sleep(retry_delay)
+              begin
+                sleep(retry_delay)
+              rescue Interrupt
+                # Handle interrupt gracefully - return false to indicate failure
+                return false
+              end
               next
             else
-              # Last attempt failed, but we'll still try to visit (might be a different error)
-              $stderr.puts "Warning: Server at #{base_url} not responding after #{max_retries} attempts, attempting anyway..."
-              return
+              # Last attempt failed
+              return false
             end
+          rescue Interrupt
+            # Handle interrupt gracefully
+            return false
           end
         end
+        
+        false
       end
       
       def resolve_routes(routes)
@@ -230,6 +306,11 @@ module RailsAccessibilityTesting
       end
       
       def generate_report(results, options)
+        # Don't generate report if no URLs were checked (server not ready)
+        if results[:summary][:urls_checked] == 0
+          return
+        end
+        
         output = case options[:format]
                  when :json
                    generate_json_report(results)
@@ -262,11 +343,14 @@ module RailsAccessibilityTesting
           output << ""
           
           results[:violations].each_with_index do |violation, index|
-            output << "#{index + 1}. #{violation.message}"
-            output << "   Rule: #{violation.rule_name}"
-            output << "   URL: #{violation.page_context[:url]}"
-            output << "   View: #{violation.page_context[:view_file]}" if violation.page_context[:view_file]
-            output << ""
+            # Use ErrorMessageBuilder for detailed formatted messages
+            detailed_message = ErrorMessageBuilder.build(
+              error_type: violation.message,
+              element_context: violation.element_context || {},
+              page_context: violation.page_context || {}
+            )
+            output << detailed_message
+            output << "" if index < results[:violations].count - 1  # Add spacing between violations
           end
         else
           output << "✅ No accessibility violations found!"
@@ -300,7 +384,8 @@ module RailsAccessibilityTesting
             -v, --version                 Show version
           
           Examples:
-            rails_a11y check /home /about
+            rails_a11y /home /about
+            rails_a11y /
             rails_a11y --urls https://example.com
             rails_a11y --routes home_path about_path --format json --output report.json
         HELP

data/lib/rails_accessibility_testing/config/yaml_loader.rb

@@ -38,7 +38,9 @@ module RailsAccessibilityTesting
           
           merge_profile_config(parsed, profile)
         rescue StandardError => e
-          RailsAccessibilityTesting.config.logger&.warn("Failed to load config: #{e.message}") if defined?(RailsAccessibilityTesting)
+          if defined?(RailsAccessibilityTesting) && RailsAccessibilityTesting.config.respond_to?(:logger) && RailsAccessibilityTesting.config.logger
+            RailsAccessibilityTesting.config.logger.warn("Failed to load config: #{e.message}")
+          end
           default_config
         end
         

data/lib/rails_accessibility_testing/configuration.rb

@@ -9,11 +9,13 @@ module RailsAccessibilityTesting
   #   end
   #
   # @attr [Boolean] auto_run_checks Whether to automatically run checks after system specs
+  # @attr [Logger, nil] logger Optional logger for accessibility check output
   class Configuration
-    attr_accessor :auto_run_checks
+    attr_accessor :auto_run_checks, :logger
 
     def initialize
       @auto_run_checks = true
+      @logger = nil
     end
   end
 

data/lib/rails_accessibility_testing/engine/rule_engine.rb

@@ -38,7 +38,9 @@ module RailsAccessibilityTesting
             @violation_collector.add(violations) if violations.any?
           rescue StandardError => e
             # Log but don't fail - one check error shouldn't stop others
-            RailsAccessibilityTesting.config.logger&.error("Check #{check_class.rule_name} failed: #{e.message}") if defined?(RailsAccessibilityTesting)
+            if defined?(RailsAccessibilityTesting) && RailsAccessibilityTesting.config.respond_to?(:logger) && RailsAccessibilityTesting.config.logger
+              RailsAccessibilityTesting.config.logger.error("Check #{check_class.rule_name} failed: #{e.message}")
+            end
           end
         end
         

data/lib/rails_accessibility_testing/rspec_integration.rb

@@ -48,6 +48,12 @@ module RailsAccessibilityTesting
           # Run comprehensive accessibility checks
           instance = example.example_group_instance
           instance.check_comprehensive_accessibility
+          
+          # Show success message if checks passed (no exception was raised)
+          unless example.exception
+            $stdout.puts "\n✅ All comprehensive accessibility checks passed! (11 checks)"
+            $stdout.flush
+          end
         rescue StandardError => e
           example.set_exception(e)
         end

data/lib/rails_accessibility_testing/version.rb

@@ -1,4 +1,4 @@
 module RailsAccessibilityTesting
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end
 

data/lib/rails_accessibility_testing.rb

@@ -38,7 +38,7 @@ begin
   require_relative 'rails_accessibility_testing/version'
 rescue LoadError
   module RailsAccessibilityTesting
-    VERSION = '1.1.0'
+    VERSION = '1.3.0'
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_accessibility_testing
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Regan Maharjan