rails_accessibility_testing 1.1.3 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89f14f3b243162c7b720591696e24b93954ec07617ae32d013f310f19a9aaa31
-  data.tar.gz: 589decae39d6ebb6af2fd0b6313951dad1815aefa0c471e266044387a8ec828c
+  metadata.gz: a7f693b05664c88f5b08e1917caa94ad360754d3113787d89c8d7b59331c1b55
+  data.tar.gz: 29bfe1bfa996b04d9f779c4d576c9a2b799a041ecc52d0d35c94b1cefb9b2f0a
 SHA512:
-  metadata.gz: 90bd6508c114d12a322e00b63e99eb209af7681dd8f4d8549450bd6e58383aa58d59561ae6b313a614979cfd9e5b849227176a0c91171179c0d9e1ade8199cb5
-  data.tar.gz: a543bf113f78b4c9555874e0b944294e9337690f06385eea989a9270c3d9a9287b550c93a680f4c5dcb91688dda4e906483f61f67bdab222f49d4fb9e3103766
+  metadata.gz: b525904eca4df9bf87d32fed9b27587681a45cfb73ae4f630ba8700929fa763fef316940e0b246c84eb2d7216b3def1df82e99d6375c859760d72f34e05ac1fa
+  data.tar.gz: 750912a05ec0b37f24bdb2011052f140c827940ec1063f6beaf1d5974708e386d21399808ecc3133ed7899f4ba7202638292f20950de953dca9508f0a275af70

data/CHANGELOG.md

@@ -5,6 +5,35 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.2.0] - 2024-12-XX
+
+### Changed
+- **BREAKING**: Removed unnecessary dependencies (selenium-webdriver, capybara from gemspec)
+- Gem now has minimal dependencies - only requires `axe-core-capybara`
+- Users provide their own capybara, selenium-webdriver, webdrivers in their Gemfile
+- This allows users to control their own driver configuration for RSpec system specs
+- CLI tool still works but requires users to have selenium-webdriver in their Gemfile if they want to use it
+
+## [1.1.6] - 2024-12-XX
+
+### Fixed
+- Added server readiness check with retry mechanism to prevent connection refused errors
+- CLI tool now waits up to 20 seconds for Rails server to be ready before attempting accessibility checks
+- Prevents race conditions when running in Procfile.dev where a11y process starts before web server
+
+## [1.1.5] - 2024-12-XX
+
+### Fixed
+- Fixed CLI tool "invalid argument" error when visiting paths by automatically converting paths to full URLs
+- CLI tool now properly constructs `http://localhost:PORT/path` URLs when using Selenium with Rails apps
+- Respects PORT, RAILS_PORT, and RAILS_URL environment variables for server URL configuration
+
+## [1.1.4] - 2024-12-XX
+
+### Fixed
+- Fixed CLI tool chromedriver discovery issue by automatically requiring webdrivers gem when available
+- CLI tool now works properly with projects that use webdrivers for driver management
+
 ## [1.1.3] - 2024-12-XX
 
 ### Fixed
@@ -82,6 +111,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Compatible with RSpec Rails 6.0+
 - Modular architecture with rule engine and check definitions
 
+[1.2.0]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.2.0
+[1.1.6]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.1.6
+[1.1.5]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.1.5
+[1.1.4]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.1.4
 [1.1.3]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.1.3
 [1.1.0]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.1.0
 [1.0.0]: https://github.com/rayraycodes/rails-accessibility-testing/releases/tag/v1.0.0

data/lib/rails_accessibility_testing/cli/command.rb

@@ -110,9 +110,17 @@ module RailsAccessibilityTesting
         require 'capybara/dsl'
         require 'selenium-webdriver'
         
+        # Try to require webdrivers for automatic chromedriver management
+        begin
+          require 'webdrivers'
+        rescue LoadError
+          # webdrivers gem not available, selenium-webdriver will try to manage drivers
+        end
+        
         # Setup Capybara
         Capybara.default_driver = :selenium_chrome_headless
-        Capybara.app = Rails.application if defined?(Rails)
+        # Don't set Capybara.app when using Selenium - it needs a real HTTP server
+        # The Rails server should be running separately (e.g., via Procfile.dev)
         
         engine = Engine::RuleEngine.new(config: config)
         all_violations = []
@@ -123,10 +131,16 @@ module RailsAccessibilityTesting
         
         targets.each do |target|
           begin
-            Capybara.visit(target)
-            violations = engine.check(Capybara.current_session, context: { url: target })
+            # Convert path to full URL if needed (when using Selenium with Rails)
+            url = normalize_url(target)
+            
+            # Wait for server to be ready (with retries)
+            wait_for_server(url) if url.match?(/\Ahttps?:\/\//)
+            
+            Capybara.visit(url)
+            violations = engine.check(Capybara.current_session, context: { url: url })
             all_violations.concat(violations)
-            checked_urls << { url: target, violations: violations.count }
+            checked_urls << { url: url, violations: violations.count }
           rescue StandardError => e
             $stderr.puts "Error checking #{target}: #{e.message}"
           end
@@ -161,6 +175,48 @@ module RailsAccessibilityTesting
         targets.uniq
       end
       
+      def normalize_url(target)
+        # If it's already a full URL, return as-is
+        return target if target.match?(/\Ahttps?:\/\//)
+        
+        # If it's a path and we're using Selenium, construct a full URL
+        # Default to localhost:3000 (standard Rails port)
+        port = ENV['PORT'] || ENV['RAILS_PORT'] || '3000'
+        base_url = ENV['RAILS_URL'] || "http://localhost:#{port}"
+        
+        # Ensure path starts with /
+        path = target.start_with?('/') ? target : "/#{target}"
+        "#{base_url}#{path}"
+      end
+      
+      def wait_for_server(url, max_retries: 10, retry_delay: 2)
+        require 'net/http'
+        require 'uri'
+        
+        uri = URI.parse(url)
+        base_url = "#{uri.scheme}://#{uri.host}:#{uri.port}"
+        
+        max_retries.times do |attempt|
+          begin
+            http = Net::HTTP.new(uri.host, uri.port)
+            http.open_timeout = 1
+            http.read_timeout = 1
+            response = http.head('/')
+            return if response.code.to_i < 500 # Server is responding
+          rescue Errno::ECONNREFUSED, Errno::ETIMEDOUT, Net::OpenTimeout, Net::ReadTimeout, SocketError
+            # Server not ready yet
+            if attempt < max_retries - 1
+              sleep(retry_delay)
+              next
+            else
+              # Last attempt failed, but we'll still try to visit (might be a different error)
+              $stderr.puts "Warning: Server at #{base_url} not responding after #{max_retries} attempts, attempting anyway..."
+              return
+            end
+          end
+        end
+      end
+      
       def resolve_routes(routes)
         return [] unless defined?(Rails) && Rails.application
         

data/lib/rails_accessibility_testing/version.rb

@@ -1,4 +1,4 @@
 module RailsAccessibilityTesting
-  VERSION = "1.1.3"
+  VERSION = "1.2.0"
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_accessibility_testing
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.2.0
 platform: ruby
 authors:
 - Regan Maharjan
@@ -24,20 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: capybara
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -66,20 +52,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -94,34 +66,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.12'
-- !ruby/object:Gem::Dependency
-  name: capybara
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: selenium-webdriver
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
 description: Comprehensive, opinionated but configurable accessibility testing gem
   for Rails. Integrates seamlessly into your test suite with RSpec and Minitest support.
   Includes CLI tool, Rails generator, YAML configuration, and 11+ WCAG 2.1 AA aligned