rails_4_invalid_foreign_key_migration_checker 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 9db0813cdb1af146e205661ad316f51d746d8da8
+  data.tar.gz: 53dd0aef5434e6ad0ec927254ef3cf61b423092b
+SHA512:
+  metadata.gz: e6a7affe013f7f6a55d8bad1f7994e72770d3b42f61130c8702a2ea47a06326a619c56a57260accef9fa71fab271b837e4d691fb5aa47735bea4eb415bc61a60
+  data.tar.gz: 12903b6b3ab4e139f3d876c26701ecf9e82f19fe4277860dd51b1727f7f5310cecda5adc92ba86e6ad2fe163bc21a00b8d063dd23c45057076c89547b896817d

data/.gitignore

@@ -0,0 +1,12 @@
+/.bundle/
+/.yardoc
+/Gemfile.lock
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
+
+# rspec failure tracking
+.rspec_status

data/.rspec

@@ -0,0 +1,2 @@
+--format documentation
+--color

data/.travis.yml

@@ -0,0 +1,5 @@
+sudo: false
+language: ruby
+rvm:
+  - 2.5.0
+before_install: gem install bundler -v 1.15.4

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,74 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, gender identity and expression, level of experience,
+nationality, personal appearance, race, religion, or sexual identity and
+orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at ota42y@gmail.com. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/

data/Gemfile

@@ -0,0 +1,6 @@
+source "https://rubygems.org"
+
+git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+
+# Specify your gem's dependencies in rails_4_invalid_foreign_key_migration_checker.gemspec
+gemspec

data/LICENSE.txt

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2017 ota42y
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -0,0 +1,50 @@
+# Rails4InvalidForeignKeyMigrationChecker
+
+When there are 'users'table and 'posts' table exist and execute add_foreignkey(:posts, :user).
+
+`remove_foreign_key :users, :posts` is correct migration. 
+`remove_foreign_key :users, :post` is invalid migration but rails 4 not raise error and rails 5 raise error.
+So if you upgrade rails 4 to 5, your migration fail.
+
+This gem check this invalid migration and raise error.
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'rails_4_invalid_foreign_key_migration_checker'
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install rails_4_invalid_foreign_key_migration_checker
+
+## Usage
+
+    $  RAILS_ENV=test bundle exec rake db:drop db:create db:migrate
+    
+If any migration isn't correct, it will be failed.
+(This gem work only RAILS_ENV=test)
+
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
+## Contributing
+
+Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/rails_4_invalid_foreign_key_migration_checker. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+
+## License
+
+The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
+
+## Code of Conduct
+
+Everyone interacting in the Rails4InvalidForeignKeyMigrationChecker project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/rails_4_invalid_foreign_key_migration_checker/blob/master/CODE_OF_CONDUCT.md).

data/Rakefile

@@ -0,0 +1,6 @@
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/bin/console

@@ -0,0 +1,14 @@
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+require "rails_4_invalid_foreign_key_migration_checker"
+
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
+
+# (If you use this, don't forget to add pry to your Gemfile!)
+# require "pry"
+# Pry.start
+
+require "irb"
+IRB.start(__FILE__)

data/bin/setup

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/lib/rails_4_invalid_foreign_key_migration_checker.rb

@@ -0,0 +1,11 @@
+require "rails_4_invalid_foreign_key_migration_checker/version"
+require "rails_4_invalid_foreign_key_migration_checker/active_record/schema_statements"
+require "rails_4_invalid_foreign_key_migration_checker/active_record/database_tasks"
+
+if ActiveRecord::VERSION::MAJOR >= 5
+  raise 'rails_4_invalid_foreign_key_migration_checker no longer need in rails 5 so please remove it'
+end
+
+module Rails4InvalidForeignKeyMigrationChecker
+  class InvalidRemoveForeignKeyError < StandardError; end
+end

data/lib/rails_4_invalid_foreign_key_migration_checker/active_record/database_tasks.rb

@@ -0,0 +1,18 @@
+require 'active_record/tasks/database_tasks'
+
+module ActiveRecord
+  module Tasks
+    module DatabaseTasks
+      def alias_migrate
+        return original_migrate unless Rails.env.test?
+
+        original_migrate
+        errors = ::ActiveRecord::ConnectionAdapters::SchemaStatements.instance_variable_get(:@alias_remove_foreign_key_errors)
+        raise ::Rails4InvalidForeignKeyMigrationChecker::InvalidRemoveForeignKeyError.new(errors.join("\n")) unless errors.empty?
+      end
+
+      alias_method :original_migrate, :migrate
+      alias_method :migrate, :alias_migrate
+    end
+  end
+end

data/lib/rails_4_invalid_foreign_key_migration_checker/active_record/schema_statements.rb

@@ -0,0 +1,42 @@
+require 'active_record/connection_adapters/abstract/schema_statements'
+
+module ActiveRecord
+  module ConnectionAdapters
+    module SchemaStatements
+      @alias_remove_foreign_key_errors = []
+      def alias_remove_foreign_key(from_table, options_or_to_table = {})
+        return original_remove_foreign_key(from_table, options_or_to_table) unless Rails.env.test?
+
+        return unless supports_foreign_keys?
+
+        unless options_or_to_table.is_a?(Hash)
+          # options_or_to_table == table_name
+          # check rails 5 compatibility
+          table = foreign_keys(from_table).detect do |fk|
+            fk.to_table == options_or_to_table.to_s
+          end
+
+          unless table
+            # rails_app/db/migrate/xxxxxxx_xxxxxxxx.rb:3:in `change' we want to this line
+            # lib/active_record/migration.rb:608:in `exec_migration' find this line from caller
+            cl = caller()
+            migration_index = cl.index{ |s| s =~ /:in `exec_migration'$/ } - 1
+
+            ::ActiveRecord::ConnectionAdapters::SchemaStatements.add_foreign_key_errors(cl[migration_index], "remove_foreign_key(#{from_table}, #{options_or_to_table}) is invalid migration in rails 5")
+          end
+        end
+
+        original_remove_foreign_key(from_table, options_or_to_table)
+      end
+
+      def self.add_foreign_key_errors(msg, path)
+        @alias_remove_foreign_key_errors << ''
+        @alias_remove_foreign_key_errors << msg
+        @alias_remove_foreign_key_errors << path
+      end
+
+      alias_method :original_remove_foreign_key, :remove_foreign_key
+      alias_method :remove_foreign_key, :alias_remove_foreign_key
+    end
+  end
+end

data/lib/rails_4_invalid_foreign_key_migration_checker/version.rb

@@ -0,0 +1,3 @@
+module Rails4InvalidForeignKeyMigrationChecker
+  VERSION = "0.1.0"
+end

data/rails_4_invalid_foreign_key_migration_checker.gemspec

@@ -0,0 +1,29 @@
+# coding: utf-8
+lib = File.expand_path("../lib", __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require "rails_4_invalid_foreign_key_migration_checker/version"
+
+Gem::Specification.new do |spec|
+  spec.name          = "rails_4_invalid_foreign_key_migration_checker"
+  spec.version       = Rails4InvalidForeignKeyMigrationChecker::VERSION
+  spec.authors       = ["ota42y"]
+  spec.email         = ["ota42y@gmail.com"]
+
+  spec.summary       = 'check invalid foreign key migration'
+  spec.description   = 'when there are users table and posts table, "remove_foreign_key :users, :post" is invalid migration but rails 4 not raise error and rails 5 raise error this gem check it'
+  spec.homepage      = "https://github.com/ota42y/rails_4_invalid_foreign_key_migration_checker"
+  spec.license       = "MIT"
+
+  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+    f.match(%r{^(test|spec|features)/})
+  end
+  spec.bindir        = "exe"
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+
+  spec.add_runtime_dependency "activerecord", "< 5.0"
+
+  spec.add_development_dependency "bundler", "~> 1.15"
+  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rspec", "~> 3.0"
+end

metadata

@@ -0,0 +1,117 @@
+--- !ruby/object:Gem::Specification
+name: rails_4_invalid_foreign_key_migration_checker
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- ota42y
+autorequire: 
+bindir: exe
+cert_chain: []
+date: 2017-09-26 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.15'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.15'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+description: when there are users table and posts table, "remove_foreign_key :users,
+  :post" is invalid migration but rails 4 not raise error and rails 5 raise error
+  this gem check it
+email:
+- ota42y@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- CODE_OF_CONDUCT.md
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- bin/console
+- bin/setup
+- lib/rails_4_invalid_foreign_key_migration_checker.rb
+- lib/rails_4_invalid_foreign_key_migration_checker/active_record/database_tasks.rb
+- lib/rails_4_invalid_foreign_key_migration_checker/active_record/schema_statements.rb
+- lib/rails_4_invalid_foreign_key_migration_checker/version.rb
+- rails_4_invalid_foreign_key_migration_checker.gemspec
+homepage: https://github.com/ota42y/rails_4_invalid_foreign_key_migration_checker
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.6.13
+signing_key: 
+specification_version: 4
+summary: check invalid foreign key migration
+test_files: []