rails5-spec-converter 1.0.10 → 1.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: decc1a2e5df2d25320f01d2bbcb93e03054382e3
-  data.tar.gz: e26b4a67c196eb1dde0240d5bcb4a2dbc9bf1036
+  metadata.gz: 5358fe3940ec49c5084895afcffe7cf51a07d06a
+  data.tar.gz: b0363014912a09bf02040da8f8b2f738358f4613
 SHA512:
-  metadata.gz: b42d4eb6bf97ad55b37885c6d9778e3060847b3c9a8d81a2e1ad230f12de02f16b5fff07dc20c97afeea320041b7440203544580de7591355bdf30786ea9d4d9
-  data.tar.gz: d7756ca27cf33f234175a33fb9b8569adbcf123cbce411cab9164a382bb105e616a9d41a09ad87ed78f749235112933cce2ffd4ca6a39c9d43c9fbc6352a847b
+  metadata.gz: 3d1f2a9f62a860a713aed9450112d3964aab94b626e09352d262082cb2a9a649ee473e2c017c5220b122a4a3df1106616bb3c26631911bc2594eced205f4c901
+  data.tar.gz: 65f4b19f4086ec55cb1d24cadb0473e9277005d977e4ceddf6b53d0d10e07b529d52aa7350d3c5985ad4f8f957d54f4ce82db0c148eec8ae33fce99390a2f726

data/README.md

@@ -85,6 +85,45 @@ To force hashes to be written without extra whitespace in all files regardless o
 
 To force hashes to be written WITH extra whitespace in all files regardless of context, use the argument `--hash-spacing`.
 
+## Limitations
+
+`rails5-spec-converter` wants to partition your arguments into two sets, those that belong in `params` and those that don't.
+
+But it doesn't do any runtime analysis, so it can only effectively sort out non-`params` keys if they're included in a hash literal on the test invocation site. Hence:
+
+```
+all_the_params = {
+  search: 'bayleef',
+  format: :json
+}
+
+get :users, all_the_params
+```
+
+will become
+
+```
+get :users, params: all_the_params
+```
+
+even though `format` should be **outside** the params hash.
+
+#### Future Work
+
+In cases where the hash keys are unknowable at parse time, future versions may optionally attempt to produce this sort of result:
+
+```
+all_the_params = {
+  search: 'bayleef',
+  format: :json
+}
+
+r5sc_user_params, r5sc_other_params = all_the_params.partition { |k,v| %i{session flash method body xhr format}.include?(k) }.map { |a| Hash[a] }
+get :users, r5sc_other_params.merge(params: r5sc_user_params)
+```
+
+...which should allow your tests to pass without deprecation warnings while introducing an enticing code cleanup oppurtunity.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `bundle exec rspec spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/rails5/spec_converter/text_transformer.rb

@@ -32,6 +32,7 @@ module Rails5
 
           if args[0].hash_type? && args[0].children.length > 0
             next if looks_like_route_definition?(args[0])
+            next if has_kwsplat?(args[0])
             next if has_key?(args[0], :params)
 
             write_params_hash(
@@ -68,6 +69,10 @@ module Rails5
         false
       end
 
+      def has_kwsplat?(hash_node)
+        hash_node.children.any? { |node| node.kwsplat_type? }
+      end
+
       def has_key?(hash_node, key)
         hash_node.children.any? { |pair| pair.children[0].children[0] == key }
       end

data/lib/rails5/spec_converter/version.rb

@@ -1,5 +1,5 @@
 module Rails5
   module SpecConverter
-    VERSION = "1.0.10"
+    VERSION = "1.0.11"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails5-spec-converter
 version: !ruby/object:Gem::Version
-  version: 1.0.10
+  version: 1.0.11
 platform: ruby
 authors:
 - Travis Grathwell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-08-28 00:00:00.000000000 Z
+date: 2016-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser