rails-sqlserver-2000-2005-adapter 2.2.0 → 2.2.1

data/CHANGELOG

@@ -1,25 +1,19 @@
 
-sqlserver_adapter.rb -- ActiveRecord adapter for Microsoft SQL Server
+*MASTER* ()
 
-Author: Joey Gibson <joey@joeygibson.com>
-Date:   10/14/2004
+* 
 
-Modifications: DeLynn Berry <delynnb@megastarfinancial.com>
-Date: 3/22/2005
 
-Modifications (ODBC): Mark Imbriaco <mark.imbriaco@pobox.com>
-Date: 6/26/2005
+*2.2.1* (November 25th, 2008)
 
-Modifications (Migrations): Tom Ward <tom@popdog.net>
-Date: 27/10/2005
+* Add identity insert support for views. Cache #views so that identity #table_name_or_views_table_name 
+  will run quickly. [Ken Collins]
 
-Modifications (Numerous fixes as maintainer): Ryan Tomayko <rtomayko@gmail.com>
-Date: Up to July 2006
+* Add views support. ActiveRecord classes can use views. The connection now has a #views method and 
+  #table_exists? will not fall back to checking views too. [Ken Collins]
 
-Previous maintainer: Tom Ward <tom@popdog.net>
 
+*2.2.0* (November 21st, 2008)
 
+* Release for rails 2.2.2. Many many changes.  [Ken Collins], [Murray Steele], [Shawn Balestracci], [Joe Rafaniello]
 
-
-
-Current (interim/unofficial) maintainer: Shawn Balestracci <shawn@vegantech.com>

data/README.rdoc

@@ -80,7 +80,7 @@ It should be noted that this version of the adapter was developed using both the
 
   $ gem install dbi --version 0.4.0
   $ gem install dbd-odbc --version 0.2.4
-  $ gem install rails-sqlserver-2000-2005-adapter
+  $ gem install rails-sqlserver-2000-2005-adapter -s http://gems.github.com
 
 Optionally configure your gem dependencies in your rails environment.rb file.
 

data/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -167,7 +167,7 @@ module ActiveRecord
       def initialize(connection, logger, connection_options=nil)
         super(connection, logger)
         @connection_options = connection_options
-        @sqlserver_columns_cache = {}
+        initialize_sqlserver_caches
         unless SUPPORTED_VERSIONS.include?(database_year)
           raise NotImplementedError, "Currently, only #{SUPPORTED_VERSIONS.to_sentence} are supported."
         end
@@ -446,6 +446,24 @@ module ActiveRecord
         select_values "SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_TYPE = 'BASE TABLE' AND TABLE_NAME <> 'dtproperties'"
       end
       
+      def views(name = nil)
+        @sqlserver_views_cache ||= 
+          select_values "SELECT TABLE_NAME FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME NOT IN ('sysconstraints','syssegments')"
+      end
+      
+      def view_information(table_name)
+        select_one "SELECT * FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME = '#{table_name}'"
+      end
+      
+      def view_table_name(table_name)
+        view_info = view_information(table_name)
+        view_info ? get_table_name(view_info['VIEW_DEFINITION']) : table_name
+      end
+      
+      def table_exists?(table_name)
+        super || views.include?(table_name.to_s)
+      end
+      
       def indexes(table_name, name = nil)
         select("EXEC sp_helpindex #{quote_table_name(table_name)}",name).inject([]) do |indexes,index|
           if index['index_description'] =~ /primary key/
@@ -733,6 +751,7 @@ module ActiveRecord
       # IDENTITY INSERTS =========================================#
       
       def with_identity_insert_enabled(table_name, &block)
+        table_name = table_name_or_views_table_name(table_name)
         set_identity_insert(table_name, true)
         yield
       ensure
@@ -760,6 +779,11 @@ module ActiveRecord
         columns(table_name).detect(&:is_identity?)
       end
       
+      def table_name_or_views_table_name(table_name)
+        unquoted_table_name = unqualify_table_name(table_name)
+        views.include?(unquoted_table_name) ? view_table_name(unquoted_table_name) : table_name
+      end
+      
       # HELPER METHODS ===========================================#
       
       def insert_sql?(sql)
@@ -815,6 +839,12 @@ module ActiveRecord
       def remove_sqlserver_columns_cache_for(table_name)
         cache_key = unqualify_table_name(table_name)
         @sqlserver_columns_cache[cache_key] = nil
+        initialize_sqlserver_caches(false)
+      end
+      
+      def initialize_sqlserver_caches(reset_columns=true)
+        @sqlserver_columns_cache = {} if reset_columns
+        @sqlserver_views_cache = nil
       end
       
       def column_definitions(table_name)

data/lib/core_ext/active_record.rb

@@ -5,7 +5,7 @@ module ActiveRecord
       def self.included(klass)
         klass.extend ClassMethods
         class << klass
-          alias_method_chain :reset_column_information, :sqlserver_columns_cache_support
+          alias_method_chain :reset_column_information, :sqlserver_cache_support
           alias_method_chain :add_order!, :sqlserver_unique_checking
         end
       end
@@ -28,9 +28,9 @@ module ActiveRecord
           read_inheritable_attribute(:coerced_sqlserver_time_columns) || []
         end
         
-        def reset_column_information_with_sqlserver_columns_cache_support
-          connection.instance_variable_set :@sqlserver_columns_cache, {}
-          reset_column_information_without_sqlserver_columns_cache_support
+        def reset_column_information_with_sqlserver_cache_support
+          connection.send(:initialize_sqlserver_caches)
+          reset_column_information_without_sqlserver_cache_support
         end
         
         private

data/test/cases/adapter_test_sqlserver.rb

@@ -351,6 +351,78 @@ class AdapterTestSqlserver < ActiveRecord::TestCase
     
   end
   
+  context 'For views' do
+    
+    context 'using @connection.views' do
+
+      should 'return an array' do
+        assert_instance_of Array, @connection.views
+      end
+      
+      should 'find CustomersView table name' do
+        assert_contains @connection.views, 'customers_view'
+      end
+      
+      should 'not contain system views' do
+        systables = ['sysconstraints','syssegments']
+        systables.each do |systable|
+          assert !@connection.views.include?(systable), "This systable #{systable} should not be in the views array."
+        end
+      end
+      
+      should 'allow the connection.view_information method to return meta data on the view' do
+        view_info = @connection.view_information('customers_view')
+        assert_equal('customers_view', view_info['TABLE_NAME'])
+        assert_match(/CREATE VIEW customers_view/, view_info['VIEW_DEFINITION'])
+      end
+      
+      should 'allow the connection.view_table_name method to return true table_name for the view' do
+        assert_equal 'customers', @connection.view_table_name('customers_view')
+        assert_equal 'topics', @connection.view_table_name('topics'), 'No view here, the same table name should come back.'
+      end
+      
+    end
+    
+    context 'used by a class for table_name' do
+      
+      should 'yield column objects' do
+        assert !CustomersView.columns.blank?
+        ['id','name','balance'].each do |colname|
+          assert_instance_of ActiveRecord::ConnectionAdapters::SQLServerColumn, 
+            CustomersView.columns_hash[colname], "Column name #{colname.inspect} was not found"
+        end
+      end
+      
+      should 'yield all column objects having the correct table name' do
+        assert CustomersView.columns.all?{ |c| c.table_name == 'customers_view' }
+      end
+      
+      should 'respond true to table_exists?' do
+        assert CustomersView.table_exists?
+      end
+      
+    end
+    
+    context 'doing identity inserts' do
+
+      setup do
+        @view_insert_sql = "INSERT INTO [customers_view] ([id],[name],[balance]) VALUES (420,'Microsoft',0)"
+      end
+      
+      should 'respond true/tablename to #query_requires_identity_insert?' do
+        assert_equal '[customers_view]', @connection.send(:query_requires_identity_insert?,@view_insert_sql)
+      end
+      
+      should 'be able to do an identity insert' do
+        assert_nothing_raised { @connection.execute(@view_insert_sql) }
+        assert CustomersView.find(420)
+      end
+
+    end
+    
+  end
+  
+  
   
   private
   

data/test/cases/sqlserver_helper.rb

@@ -19,6 +19,7 @@ class TableWithRealColumn < ActiveRecord::Base; end
 class FkTestHasFk < ActiveRecord::Base ; end
 class FkTestHasPk < ActiveRecord::Base ; end
 class NumericData < ActiveRecord::Base ; self.table_name = 'numeric_data' ; end
+class CustomersView < ActiveRecord::Base ; self.table_name = 'customers_view' ; end
 class SqlServerUnicode < ActiveRecord::Base ; end
 class SqlServerString < ActiveRecord::Base ; end
 class SqlServerChronic < ActiveRecord::Base

data/test/cases/table_name_test_sqlserver.rb

@@ -12,7 +12,6 @@ class TableNameTestSqlserver < ActiveRecord::TestCase
   
   should 'load columns with escaped table name for model' do
     assert_equal 4, Order.columns.length
-    
   end
   
   should 'not re-escape table name if it is escaped already for SQL queries' do

data/test/schema/sqlserver_specific_schema.rb

@@ -61,4 +61,12 @@ ActiveRecord::Schema.define do
     # TODO: Add some different native binary types and test.
   end
   
+  execute "IF EXISTS (SELECT TABLE_NAME FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME = 'customers_view') DROP VIEW customers_view"
+  execute <<-CUSTOMERSVIEW
+    CREATE VIEW customers_view AS
+      SELECT id, name, balance
+      FROM customers
+  CUSTOMERSVIEW
+  
+  
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails-sqlserver-2000-2005-adapter
 version: !ruby/object:Gem::Version 
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors: 
 - Ken Collins
@@ -13,7 +13,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-11-21 00:00:00 -08:00
+date: 2008-11-25 00:00:00 -08:00
 default_executable: 
 dependencies: []