rails-schema-validations 0.9 → 0.9.2

data/README

@@ -9,12 +9,13 @@ validations_from_schema
 Generated Validations
 =====================
 
-| schema type | rails validation          | extra                     |
+| schema type | rails validation          | extra constraints         |
 |-------------|---------------------------|---------------------------|
 | non-null    | validates_presence_of     |                           |
-| string      | validates_length_of       | :limit                    |
+| string      | validates_length_of       | :maximum                  |
 | integer     | validates_numericality_of | :only_integer, :less_than |
 | float       | validates_numericality_of |                           |
+| boolean     | validates_inclusion_of    |                           |
 
 for boolean non-null it uses validates_inclusion_of :in => [true,false]
 
@@ -24,5 +25,5 @@ To exclude a column use the `:except => ['excluded']` option.
 
 Warning
 =======
-Tested on MySQL.
+Tested on MySQL. Rails 2.3 and Rails 3
 Assume it doesn't work on your database unless you modify the test suite to run against your db and all tests pass

data/lib/rails-schema-validations.rb

@@ -17,7 +17,7 @@ module ActiveRecord::Validations::ClassMethods
         validates_numericality_of col.name, :allow_nil => col.null
       #when :time, :datetime
       when :string 
-        if col.limit
+        if col.limit.to_i > 0 # Mysql enum type shows up as a string with a limit of 0
           validates_length_of col.name, :maximum => col.limit, :allow_nil => col.null
         end
       when :boolean

data/test/test_helper.rb

@@ -1,6 +1,5 @@
 ENV['RAILS_ENV'] = 'test'
 
-#require 'rubygems'
 require 'active_record'
 require 'riot'
 require 'riot/rails'

data/test/validations_from_schema_test.rb

@@ -21,6 +21,9 @@ def load_schema
 
       t.integer :indexed_id, :null => false
       t.integer :unique_id, :null => false
+
+      # very edge case of MySQL enum column
+      t.string "enum", :limit => 0, :null => false
     end
 
     add_index 'models', ['indexed_id']
@@ -86,4 +89,7 @@ context Model do
 
   # ignore
   asserts_no_error_on :id, nil
+
+  asserts_no_error_on :enum, 'enum'
+  asserts_error_on :enum, nil
 end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rails-schema-validations
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 63
   prerelease: false
   segments: 
   - 0
   - 9
-  version: "0.9"
+  - 2
+  version: 0.9.2
 platform: ruby
 authors: 
 - Greg Weber
@@ -14,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-25 00:00:00 -07:00
+date: 2010-11-28 00:00:00 -08:00
 default_executable: 
 dependencies: []