rails-patterns 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: af39ea7538e043642610c2ea2ff35a9fa5c8a0e7
-  data.tar.gz: ff3231a21b94a92280acf664497a40b3039f7140
+  metadata.gz: c0527dc116049d1579ba19deadf9ad643b0abf9b
+  data.tar.gz: 52f5f8cae780e21a3a91b7b82602d71814883a3c
 SHA512:
-  metadata.gz: c3653e8ce337a6225ad14162600f8b2a462321fcca8595f8f1463920935749e17b48d3f7359530dff528bc7ff3f7175ddaa23b7ac1203903ff42b296bfb8c51d
-  data.tar.gz: 37f4e6cb0fc581140dfee9372386b9d37b77a092d63d798fb98d8617475ac249d2e8f49aa9d8092ae5630e3de5e48a0aa6677ed7d62e89429a788c9fb51e44f2
+  metadata.gz: 58005bd76bfb7d2c30d83025343765b201994e1b4161e0e7c04b37a54ed5e88a98180afde2d4c46f8e70e4dd51ad06c0733bd073d47a5647721d7dbda43f0b49
+  data.tar.gz: b461d4fa96a92acb04a56ccc202a41aa79cbdb2948a0c94f5a56ebc3bd228c277a5db17331c6e690a9bdade2b84fe4a6ae008e835c84556ede60b4a038f991b9

data/README.md

@@ -4,7 +4,7 @@ A collection of lightweight, standardized, rails-oriented patterns.
 
 - [Query - complex querying on active record relation](#query)
 - [Service - useful for handling processes involving multiple steps](#service)
-- [Collection - when in need to add a method that relates to the collection a whole](#collection)
+- [Collection - when in need to add a method that relates to the collection as whole](#collection)
 - [Form - when you need a place for callbacks, want to replace strong parameters or handle virtual/composite resources](#form)
 
 ## Installation
@@ -82,7 +82,7 @@ end
 ### When to use it
 
 Service objects are commonly used to mitigate problems with model callbacks that interact with external classes ([read more...](http://samuelmullen.com/2013/05/the-problem-with-rails-callbacks/)).
-Service objects are also useful for handling processes involving multiple steps. E.g. a controller that performs more than one operation on its subject (usually a model instance) is a possible candidate for Extract ServiceObject (or Extract FormObject) refactoring.
+Service objects are also useful for handling processes involving multiple steps. E.g. a controller that performs more than one operation on its subject (usually a model instance) is a possible candidate for Extract ServiceObject (or Extract FormObject) refactoring. In many cases service object can be used as scaffolding for [replace method with object refactoring](https://sourcemaking.com/refactoring/replace-method-with-method-object).
 
 ### Assumptions and rules
 
@@ -93,6 +93,10 @@ Service objects are also useful for handling processes involving multiple steps.
 * It is recommended for `#call` method to be the only public method of service object (besides state readers)
 * It is recommended to name service object classes after commands (e.g. `ActivateUser` instead of `UserActivation`)
 
+### Other 
+
+A bit higher level of abstraction is provided by [business_process gem](https://github.com/Selleo/business_process). 
+
 ### Examples
 
 #### Declaration
@@ -162,7 +166,7 @@ class CustomerEventsByTypeCollection < Patterns::Collection
     subject.
     events.
     group_by(&:type).
-    transform_values{ |event| event.public_send(options.fetch(:label_method, "description")) }
+    transform_values{ |events| events.map{ |e| e.public_send(options.fetch(:label_method, "description")) }}
   end
 end
 ```
@@ -183,6 +187,7 @@ Form objects, just like service objects, are commonly used to mitigate problems
 Form objects can also be used as replacement for `ActionController::StrongParameters` strategy, as all writable attributes are re-defined within each form.
 Finally form objects can be used as wrappers for virtual (with no model representation) or composite (saving multiple models at once) resources.
 In the latter case this may act as replacement for `ActiveRecord::NestedAttributes`.
+In some cases FormObject can be used as scaffolding for [replace method with object refactoring](https://sourcemaking.com/refactoring/replace-method-with-method-object).
 
 ### Assumptions and rules
 
@@ -191,7 +196,7 @@ In the latter case this may act as replacement for `ActiveRecord::NestedAttribut
 * Forms can be initialized using `.new`.
 * Forms accept optional resource object as first constructor argument.
 * Forms accept optional attributes hash as latter constructor argument.
-* forms have to implement `#persist` method that returns falsey (if failed) or truthy (if succeeded) value.
+* Forms have to implement `#persist` method that returns falsey (if failed) or truthy (if succeeded) value.
 * Forms provide access to first constructor argument using `#resource`.
 * Forms are saved using their `#save` or `#save!` methods.
 * Forms will attempt to pre-populate their fields using `resource#attributes` and public getters for `resource`

data/VERSION

@@ -1 +1 @@
-0.4.0
+0.4.1

data/lib/patterns/form.rb

@@ -50,7 +50,7 @@ module Patterns
     end
 
     def persisted?
-      if resource&.respond_to?(:persisted?)
+      if resource.present? && resource.respond_to?(:persisted?)
         resource.persisted?
       else
         false
@@ -77,7 +77,7 @@ module Patterns
 
     def param_key
       param_key = self.class.param_key
-      param_key ||= resource&.respond_to?(:model_name) && resource.model_name.param_key
+      param_key ||= resource.present? && resource.respond_to?(:model_name) && resource.model_name.param_key
       raise NoParamKey if param_key.blank?
       param_key
     end

data/rails-patterns.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: rails-patterns 0.4.0 ruby lib
+# stub: rails-patterns 0.4.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails-patterns".freeze
-  s.version = "0.4.0"
+  s.version = "0.4.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Stevo".freeze]
-  s.date = "2017-04-21"
+  s.date = "2017-05-09"
   s.description = "A collection of lightweight, standardized, rails-oriented patterns.".freeze
   s.email = "b.kosmowski@selleo.com".freeze
   s.extra_rdoc_files = [

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-patterns
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Stevo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-21 00:00:00.000000000 Z
+date: 2017-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord