rails-patch-json-encode 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7de82dfcf0621f732cbb61b7973a2a8be0af6576
-  data.tar.gz: 52320bd295199b7797f6715a425ae5594c20652f
+  metadata.gz: fc0249750b2f5bb056856a8f3174ec5d7c96ab61
+  data.tar.gz: d9c341cb2f47d207cccc25f208c43e9929b2d7b3
 SHA512:
-  metadata.gz: 0f6a698e80c1f7279f58f421e3227045b5d81335ae8f148b2c9c53774c1e3e94880d465ca0a9f6d6e672ae5696eca351d272f1be1e54834e76a3110b8d229e76
-  data.tar.gz: 01eb45b91075c2e77b9d985de3e1a0bbe46eed10b8c0b7fa9b41b85f0d536785e4a7a4e39bc56ffe4c838e9eaa9facdc372774dd347b774d008d4fe591d93468
+  metadata.gz: 3a435841a65c874ef8735a29f751ff19e406fa52579057b800ae15f8d0d1de05f7813fb9be4159dee01248b41a7cd48b0b15d968e5d9960f34fdc785896e792d
+  data.tar.gz: f9a2fa556af989e56efc38ce7b5cf5ed4534145e777b2e7e6ba7634e6fa3039280941653f1c21f4a21a737db30578ee3fd7df11576b6d881fd9038be4baa377f

data/README.md

@@ -8,38 +8,44 @@ All credits goes to [Jason Hutchens](https://github.com/jasonhutchens) for disco
 
 ## Installation
 
-First, go to your Rails console and type:
+First, let's measure the time before the patch.  
+Go to your Rails console and type:
 
-    data = Hash.new
+    require 'benchmark'
+    DATA = Hash.new
     key = 'aaa'
-    1000.times { data[key.succ!] = data.keys }
-    1000 * Benchmark.realtime { data.to_json }
+    1000.times { DATA[key.succ!] = DATA.keys }
+    Benchmark.realtime { 5.times { DATA.to_json } }
     
-See how Rails performs before the patch.
-
-Second, bundle install this gem with a fast JSON encoding gem in your Rails' Gemfile.
+Then bundle install this gem with a fast JSON encoding gem in your Rails' Gemfile.
 
     gem 'rails-patch-json-encode'
-    gem 'oj'
+    gem 'yajl-ruby', require: 'yajl'
     
-In this case I choose the oj gem, but you can [choose a json-encoder gem that multi_json supports](https://github.com/intridea/multi_json#supported-json-engines).
+In this case I choose the yajl-ruby gem, but you can [choose a json-encoder gem that multi_json supports](https://github.com/intridea/multi_json#supported-json-engines).
 
-Last, there are two levels of patch available. You have to choose one and call it explictly:
+The final step is to choose a patch. Two types of patches are available, and you have to choose one and invoke it explictly:
 
 * `Rails::Patch::Json::Encode.patch_base_classes` patches all Ruby base classes.
 * `Rails::Patch::Json::Encode.patch_renderers` patches Rails' ActionController::Renderers only. This is for those who had issue with the JSON gem, as patching base classes cause infinite recursive loop. 
 
-Place one of them in Rails' initializers like config/initializers/rails_patch_json_encode.rb, and Rails should now use the faster encoder.
+Place one of them in a Rails initializer (e.g. `config/initializers/rails_patch_json_encode.rb`), and Rails should now use the faster encoder.
 
-## Benchmark
+Now it's done. Reopen your Rails console and rerun the benchmark to see the difference.
 
-For console benchmark comparison, restart console after the above installation. Call `Rails::Patch::Json::Encode.patch_base_classes` in console, then re-run the test to see how the performance changes.
+## Warning
 
-The actual performance boost on real-world applications will probably be less than that. For one of my page I see the rendering time dropped by 25%.
+If you are using Oj gem, there is no need to install this gem. Call `Oj.optimize_rails` instead.
 
-## Warning
+Rails in recent years added safety nets to handle nested NaN, infinity and IO objects. This gem does not handle these cases.
 
-This gem may break your app. **Test your app**. I am not sure if this is production ready.
+This gem may break your app. **Test your app**.
+
+## Benchmark
+
+`rake benchmark` is provided to show the difference before and after the patch. From my machine the time is dropped to 14% when using yajl on Rails 5.2.
+
+The actual performance boost on real-world applications will probably be less than that. For one of my page I see the rendering time dropped by 25%.
 
 ## What's with the name
 

data/Rakefile

@@ -1 +1,19 @@
 require "bundler/gem_tasks"
+
+task default: :test
+
+desc "Benchmark"
+task :benchmark do
+  require_relative 'benchmark/base_classes'
+end
+
+### Test
+require "rake/testtask"
+dir = File.dirname(__FILE__)
+Rake::TestTask.new do |t|
+  t.libs << "test"
+  t.test_files = Dir.glob("#{dir}/test/**/*_test.rb")
+  t.warning = true
+  t.verbose = true
+  t.ruby_opts = ["--dev"] if defined?(JRUBY_VERSION)
+end

data/benchmark/base_classes.rb

@@ -0,0 +1,38 @@
+require 'benchmark'
+require 'json'
+require 'yajl'
+require 'active_support'
+require 'active_support/json'
+require 'active_support/core_ext/object/json'
+require 'rails/patch/json/encode'
+
+puts <<MESSAGE
+Benchmark: base classes patch mode
+
+Gem versions:
+  ActiveSupport: #{ActiveSupport.version}
+  MultiJson: #{MultiJson::VERSION}
+
+MESSAGE
+
+# Prepare data
+
+DATA = Hash.new
+key = 'aaa'
+1000.times { DATA[key.succ!] = DATA.keys }
+DATA.freeze
+
+LOOP = 5
+def loop_encoding
+  LOOP.times { DATA.to_json }
+end
+
+# Benchmark
+
+print 'before patch: '
+puts(Benchmark.measure{ loop_encoding })
+
+Rails::Patch::Json::Encode.patch_base_classes
+
+print 'after patch:  '
+puts(Benchmark.measure{ loop_encoding })

data/lib/rails/patch/json/encode.rb

@@ -1,4 +1,5 @@
 require "rails/patch/json/encode/version"
+require 'multi_json'
 
 module Rails::Patch::Json::Encode
   # Use multi_json instead of Rails' to_json method (which calls ActiveSupport::JSON)
@@ -20,15 +21,24 @@ module Rails::Patch::Json::Encode
     end
   end
 
-  # Code from http://devblog.agworld.com.au/post/42586025923/the-performance-of-to-json-in-rails-sucks-and-theres
+
+
+  # Combine http://devblog.agworld.com.au/post/42586025923/the-performance-of-to-json-in-rails-sucks-and-theres
+  # and Rails' ToJsonWithActiveSupportEncoder together,
   # essentially reversing Rails' hard-coded call to ActiveSupport::JSON.encode
-  def self.patch_base_classes
-    [Object, Array, FalseClass, Float, Hash, Integer, NilClass, String, TrueClass].each do |klass|
-      klass.class_eval do
-        def to_json(opts = {})
-          MultiJson::dump(self.as_json(opts), opts)
-        end
+  module ToJsonWithMultiJson
+    def to_json(options = {})
+      if options.is_a?(::JSON::State)
+        super(options)
+      else
+        ::MultiJson::dump(self.as_json(options), options)
       end
     end
   end
+
+  def self.patch_base_classes
+    [Object, Array, FalseClass, Float, Hash, Integer, NilClass, String, TrueClass, Enumerable].reverse_each do |klass|
+      klass.prepend(ToJsonWithMultiJson)
+    end
+  end
 end

data/lib/rails/patch/json/encode/version.rb

@@ -2,7 +2,7 @@ module Rails
   module Patch
     module Json
       module Encode
-        VERSION = "0.1.1"
+        VERSION = "0.2.0"
       end
     end
   end

data/rails-patch-json-encode.gemspec

@@ -18,8 +18,11 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency "bundler", "~> 1.16.0"
+  spec.add_development_dependency "rake", "~> 12.3.0"
+  spec.add_development_dependency "activesupport", "~> 5.1.4"
+  spec.add_development_dependency "yajl-ruby"
+  spec.add_development_dependency "byebug"
 
   spec.add_dependency 'multi_json', '>= 1.9.3', '~> 1.0'
 end

data/test/abstract_unit.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+ORIG_ARGV = ARGV.dup
+
+require "active_support/core_ext/kernel/reporting"
+
+silence_warnings do
+  Encoding.default_internal = Encoding::UTF_8
+  Encoding.default_external = Encoding::UTF_8
+end
+
+require "active_support/testing/autorun"
+require "active_support/testing/method_call_assertions"
+
+ENV["NO_RELOAD"] = "1"
+require "active_support"
+
+Thread.abort_on_exception = true
+
+# Show backtraces for deprecated behavior for quicker cleanup.
+ActiveSupport::Deprecation.debug = true
+
+# Default to old to_time behavior but allow running tests with new behavior
+ActiveSupport.to_time_preserves_timezone = ENV["PRESERVE_TIMEZONES"] == "1"
+
+# Disable available locale checks to avoid warnings running the test suite.
+I18n.enforce_available_locales = false
+
+class ActiveSupport::TestCase
+  include ActiveSupport::Testing::MethodCallAssertions
+
+  # Skips the current run on Rubinius using Minitest::Assertions#skip
+  private def rubinius_skip(message = "")
+    skip message if RUBY_ENGINE == "rbx"
+  end
+
+  # Skips the current run on JRuby using Minitest::Assertions#skip
+  private def jruby_skip(message = "")
+    skip message if defined?(JRUBY_VERSION)
+  end
+
+  def frozen_error_class
+    Object.const_defined?(:FrozenError) ? FrozenError : RuntimeError
+  end
+end

data/test/encoding_test.rb

@@ -0,0 +1,485 @@
+# frozen_string_literal: true
+
+require 'yajl'
+require "securerandom"
+require "abstract_unit"
+require "active_support/core_ext/string/inflections"
+require "active_support/core_ext/regexp"
+require "active_support/json"
+require "active_support/time"
+require "time_zone_test_helpers"
+require "encoding_test_cases"
+require 'rails/patch/json/encode'
+
+Rails::Patch::Json::Encode.patch_base_classes
+
+class TestJSONEncoding < ActiveSupport::TestCase
+  include TimeZoneTestHelpers
+
+  def sorted_json(json)
+    if json.start_with?("{") && json.end_with?("}")
+      "{" + json[1..-2].split(",").sort.join(",") + "}"
+    else
+      json
+    end
+  end
+
+  JSONTest::EncodingTestCases.constants.each do |class_tests|
+    define_method("test_#{class_tests[0..-6].underscore}") do
+      begin
+        prev = ActiveSupport.use_standard_json_time_format
+
+        standard_class_tests = /Standard/.match?(class_tests)
+
+        ActiveSupport.escape_html_entities_in_json  = !standard_class_tests
+        ActiveSupport.use_standard_json_time_format = standard_class_tests
+        JSONTest::EncodingTestCases.const_get(class_tests).each do |pair|
+          assert_equal pair.last, sorted_json(ActiveSupport::JSON.encode(pair.first))
+        end
+      ensure
+        ActiveSupport.escape_html_entities_in_json  = false
+        ActiveSupport.use_standard_json_time_format = prev
+      end
+    end
+  end
+
+  def test_process_status
+    rubinius_skip "https://github.com/rubinius/rubinius/issues/3334"
+
+    # There doesn't seem to be a good way to get a handle on a Process::Status object without actually
+    # creating a child process, hence this to populate $?
+    system("not_a_real_program_#{SecureRandom.hex}")
+    assert_equal %({"exitstatus":#{$?.exitstatus},"pid":#{$?.pid}}), ActiveSupport::JSON.encode($?)
+  end
+
+  def test_hash_encoding
+    assert_equal %({\"a\":\"b\"}), ActiveSupport::JSON.encode(a: :b)
+    assert_equal %({\"a\":1}), ActiveSupport::JSON.encode("a" => 1)
+    assert_equal %({\"a\":[1,2]}), ActiveSupport::JSON.encode("a" => [1, 2])
+    assert_equal %({"1":2}), ActiveSupport::JSON.encode(1 => 2)
+
+    assert_equal %({\"a\":\"b\",\"c\":\"d\"}), sorted_json(ActiveSupport::JSON.encode(a: :b, c: :d))
+  end
+
+  def test_hash_keys_encoding
+    ActiveSupport.escape_html_entities_in_json = true
+    assert_equal "{\"\\u003c\\u003e\":\"\\u003c\\u003e\"}", ActiveSupport::JSON.encode("<>" => "<>")
+  ensure
+    ActiveSupport.escape_html_entities_in_json = false
+  end
+
+  def test_utf8_string_encoded_properly
+    result = ActiveSupport::JSON.encode("€2.99")
+    assert_equal '"€2.99"', result
+    assert_equal(Encoding::UTF_8, result.encoding)
+
+    result = ActiveSupport::JSON.encode("✎☺")
+    assert_equal '"✎☺"', result
+    assert_equal(Encoding::UTF_8, result.encoding)
+  end
+
+  def test_non_utf8_string_transcodes
+    s = "二".encode("Shift_JIS")
+    result = ActiveSupport::JSON.encode(s)
+    assert_equal '"二"', result
+    assert_equal Encoding::UTF_8, result.encoding
+  end
+
+  def test_wide_utf8_chars
+    w = "𠜎"
+    result = ActiveSupport::JSON.encode(w)
+    assert_equal '"𠜎"', result
+  end
+
+  def test_wide_utf8_roundtrip
+    hash = { string: "𐒑" }
+    json = ActiveSupport::JSON.encode(hash)
+    decoded_hash = ActiveSupport::JSON.decode(json)
+    assert_equal "𐒑", decoded_hash["string"]
+  end
+
+  def test_hash_key_identifiers_are_always_quoted
+    values = { 0 => 0, 1 => 1, :_ => :_, "$" => "$", "a" => "a", :A => :A, :A0 => :A0, "A0B" => "A0B" }
+    assert_equal %w( "$" "A" "A0" "A0B" "_" "a" "0" "1" ).sort, object_keys(ActiveSupport::JSON.encode(values))
+  end
+
+  def test_hash_should_allow_key_filtering_with_only
+    assert_equal %({"a":1}), ActiveSupport::JSON.encode({ "a" => 1, :b => 2, :c => 3 }, { only: "a" })
+  end
+
+  def test_hash_should_allow_key_filtering_with_except
+    assert_equal %({"b":2}), ActiveSupport::JSON.encode({ "foo" => "bar", :b => 2, :c => 3 }, { except: ["foo", :c] })
+  end
+
+  def test_time_to_json_includes_local_offset
+    with_standard_json_time_format(true) do
+      with_env_tz "US/Eastern" do
+        assert_equal %("2005-02-01T15:15:10.000-05:00"), ActiveSupport::JSON.encode(Time.local(2005, 2, 1, 15, 15, 10))
+      end
+    end
+  end
+
+  def test_hash_with_time_to_json
+    with_standard_json_time_format(false) do
+      assert_equal '{"time":"2009/01/01 00:00:00 +0000"}', { time: Time.utc(2009) }.to_json
+    end
+  end
+
+  def test_nested_hash_with_float
+    assert_nothing_raised do
+      hash = {
+        "CHI" => {
+          display_name: "chicago",
+          latitude: 123.234
+        }
+      }
+      ActiveSupport::JSON.encode(hash)
+    end
+  end
+
+  def test_hash_like_with_options
+    h = JSONTest::Hashlike.new
+    json = h.to_json only: [:foo]
+
+    assert_equal({ "foo" => "hello" }, JSON.parse(json))
+  end
+
+  def test_object_to_json_with_options
+    obj = Object.new
+    obj.instance_variable_set :@foo, "hello"
+    obj.instance_variable_set :@bar, "world"
+    json = obj.to_json only: ["foo"]
+
+    assert_equal({ "foo" => "hello" }, JSON.parse(json))
+  end
+
+  def test_struct_to_json_with_options
+    struct = Struct.new(:foo, :bar).new
+    struct.foo = "hello"
+    struct.bar = "world"
+    json = struct.to_json only: [:foo]
+
+    assert_equal({ "foo" => "hello" }, JSON.parse(json))
+  end
+
+  def test_hash_should_pass_encoding_options_to_children_in_as_json
+    person = {
+      name: "John",
+      address: {
+        city: "London",
+        country: "UK"
+      }
+    }
+    json = person.as_json only: [:address, :city]
+
+    assert_equal({ "address" => { "city" => "London" } }, json)
+  end
+
+  def test_hash_should_pass_encoding_options_to_children_in_to_json
+    person = {
+      name: "John",
+      address: {
+        city: "London",
+        country: "UK"
+      }
+    }
+    json = person.to_json only: [:address, :city]
+
+    assert_equal(%({"address":{"city":"London"}}), json)
+  end
+
+  def test_array_should_pass_encoding_options_to_children_in_as_json
+    people = [
+      { name: "John", address: { city: "London", country: "UK" } },
+      { name: "Jean", address: { city: "Paris", country: "France" } }
+    ]
+    json = people.as_json only: [:address, :city]
+    expected = [
+      { "address" => { "city" => "London" } },
+      { "address" => { "city" => "Paris" } }
+    ]
+
+    assert_equal(expected, json)
+  end
+
+  def test_array_should_pass_encoding_options_to_children_in_to_json
+    people = [
+      { name: "John", address: { city: "London", country: "UK" } },
+      { name: "Jean", address: { city: "Paris", country: "France" } }
+    ]
+    json = people.to_json only: [:address, :city]
+
+    assert_equal(%([{"address":{"city":"London"}},{"address":{"city":"Paris"}}]), json)
+  end
+
+  People = Class.new(BasicObject) do
+    include Enumerable
+    def initialize
+      @people = [
+        { name: "John", address: { city: "London", country: "UK" } },
+        { name: "Jean", address: { city: "Paris", country: "France" } }
+      ]
+    end
+    def each(*, &blk)
+      @people.each do |p|
+        yield p if blk
+        p
+      end.each
+    end
+  end
+
+  def test_enumerable_should_generate_json_with_as_json
+    json = People.new.as_json only: [:address, :city]
+    expected = [
+      { "address" => { "city" => "London" } },
+      { "address" => { "city" => "Paris" } }
+    ]
+
+    assert_equal(expected, json)
+  end
+
+  def test_enumerable_should_generate_json_with_to_json
+    json = People.new.to_json only: [:address, :city]
+    assert_equal(%([{"address":{"city":"London"}},{"address":{"city":"Paris"}}]), json)
+  end
+
+  def test_enumerable_should_pass_encoding_options_to_children_in_as_json
+    json = People.new.each.as_json only: [:address, :city]
+    expected = [
+      { "address" => { "city" => "London" } },
+      { "address" => { "city" => "Paris" } }
+    ]
+
+    assert_equal(expected, json)
+  end
+
+  def test_enumerable_should_pass_encoding_options_to_children_in_to_json
+    json = People.new.each.to_json only: [:address, :city]
+
+    assert_equal(%([{"address":{"city":"London"}},{"address":{"city":"Paris"}}]), json)
+  end
+
+  class CustomWithOptions
+    attr_accessor :foo, :bar
+
+    def as_json(options = {})
+      options[:only] = %w(foo bar)
+      super(options)
+    end
+  end
+
+  def test_hash_to_json_should_not_keep_options_around
+    f = CustomWithOptions.new
+    f.foo = "hello"
+    f.bar = "world"
+
+    hash = { "foo" => f, "other_hash" => { "foo" => "other_foo", "test" => "other_test" } }
+    assert_equal({ "foo" => { "foo" => "hello", "bar" => "world" },
+                  "other_hash" => { "foo" => "other_foo", "test" => "other_test" } }, ActiveSupport::JSON.decode(hash.to_json))
+  end
+
+  def test_array_to_json_should_not_keep_options_around
+    f = CustomWithOptions.new
+    f.foo = "hello"
+    f.bar = "world"
+
+    array = [f, { "foo" => "other_foo", "test" => "other_test" }]
+    assert_equal([{ "foo" => "hello", "bar" => "world" },
+                  { "foo" => "other_foo", "test" => "other_test" }], ActiveSupport::JSON.decode(array.to_json))
+  end
+
+  class OptionsTest
+    def as_json(options = :default)
+      options
+    end
+  end
+
+  def test_hash_as_json_without_options
+    json = { foo: OptionsTest.new }.as_json
+    assert_equal({ "foo" => :default }, json)
+  end
+
+  def test_array_as_json_without_options
+    json = [ OptionsTest.new ].as_json
+    assert_equal([:default], json)
+  end
+
+  def test_struct_encoding
+    Struct.new("UserNameAndEmail", :name, :email)
+    Struct.new("UserNameAndDate", :name, :date)
+    Struct.new("Custom", :name, :sub)
+    user_email = Struct::UserNameAndEmail.new "David", "sample@example.com"
+    user_birthday = Struct::UserNameAndDate.new "David", Date.new(2010, 01, 01)
+    custom = Struct::Custom.new "David", user_birthday
+
+    json_strings = ""
+    json_string_and_date = ""
+    json_custom = ""
+
+    assert_nothing_raised do
+      json_strings = user_email.to_json
+      json_string_and_date = user_birthday.to_json
+      json_custom = custom.to_json
+    end
+
+    assert_equal({ "name" => "David",
+                  "sub" => {
+                    "name" => "David",
+                    "date" => "2010-01-01" } }, ActiveSupport::JSON.decode(json_custom))
+
+    assert_equal({ "name" => "David", "email" => "sample@example.com" },
+                 ActiveSupport::JSON.decode(json_strings))
+
+    assert_equal({ "name" => "David", "date" => "2010-01-01" },
+                 ActiveSupport::JSON.decode(json_string_and_date))
+  end
+
+  def test_nil_true_and_false_represented_as_themselves
+    assert_nil nil.as_json
+    assert_equal true,  true.as_json
+    assert_equal false, false.as_json
+  end
+
+  class HashWithAsJson < Hash
+    attr_accessor :as_json_called
+
+    def initialize(*)
+      super
+    end
+
+    def as_json(options = {})
+      @as_json_called = true
+      super
+    end
+  end
+
+  def test_json_gem_dump_by_passing_active_support_encoder
+    h = HashWithAsJson.new
+    h[:foo] = "hello"
+    h[:bar] = "world"
+
+    assert_equal %({"foo":"hello","bar":"world"}), JSON.dump(h)
+    assert_nil h.as_json_called
+  end
+
+  def test_json_gem_generate_by_passing_active_support_encoder
+    h = HashWithAsJson.new
+    h[:foo] = "hello"
+    h[:bar] = "world"
+
+    assert_equal %({"foo":"hello","bar":"world"}), JSON.generate(h)
+    assert_nil h.as_json_called
+  end
+
+  def test_json_gem_pretty_generate_by_passing_active_support_encoder
+    h = HashWithAsJson.new
+    h[:foo] = "hello"
+    h[:bar] = "world"
+
+    assert_equal <<EXPECTED.chomp, JSON.pretty_generate(h)
+{
+  "foo": "hello",
+  "bar": "world"
+}
+EXPECTED
+    assert_nil h.as_json_called
+  end
+
+  def test_twz_to_json_with_use_standard_json_time_format_config_set_to_false
+    with_standard_json_time_format(false) do
+      zone = ActiveSupport::TimeZone["Eastern Time (US & Canada)"]
+      time = ActiveSupport::TimeWithZone.new(Time.utc(2000), zone)
+      assert_equal "\"1999/12/31 19:00:00 -0500\"", ActiveSupport::JSON.encode(time)
+    end
+  end
+
+  def test_twz_to_json_with_use_standard_json_time_format_config_set_to_true
+    with_standard_json_time_format(true) do
+      zone = ActiveSupport::TimeZone["Eastern Time (US & Canada)"]
+      time = ActiveSupport::TimeWithZone.new(Time.utc(2000), zone)
+      assert_equal "\"1999-12-31T19:00:00.000-05:00\"", ActiveSupport::JSON.encode(time)
+    end
+  end
+
+  def test_twz_to_json_with_custom_time_precision
+    with_standard_json_time_format(true) do
+      with_time_precision(0) do
+        zone = ActiveSupport::TimeZone["Eastern Time (US & Canada)"]
+        time = ActiveSupport::TimeWithZone.new(Time.utc(2000), zone)
+        assert_equal "\"1999-12-31T19:00:00-05:00\"", ActiveSupport::JSON.encode(time)
+      end
+    end
+  end
+
+  def test_time_to_json_with_custom_time_precision
+    with_standard_json_time_format(true) do
+      with_time_precision(0) do
+        assert_equal "\"2000-01-01T00:00:00Z\"", ActiveSupport::JSON.encode(Time.utc(2000))
+      end
+    end
+  end
+
+  def test_datetime_to_json_with_custom_time_precision
+    with_standard_json_time_format(true) do
+      with_time_precision(0) do
+        assert_equal "\"2000-01-01T00:00:00+00:00\"", ActiveSupport::JSON.encode(DateTime.new(2000))
+      end
+    end
+  end
+
+  def test_twz_to_json_when_wrapping_a_date_time
+    zone = ActiveSupport::TimeZone["Eastern Time (US & Canada)"]
+    time = ActiveSupport::TimeWithZone.new(DateTime.new(2000), zone)
+    assert_equal '"1999-12-31T19:00:00.000-05:00"', ActiveSupport::JSON.encode(time)
+  end
+
+  def test_exception_to_json
+    exception = Exception.new("foo")
+    assert_equal '"foo"', ActiveSupport::JSON.encode(exception)
+  end
+
+  class InfiniteNumber
+    def as_json(options = nil)
+      { "number" => Float::INFINITY }
+    end
+  end
+
+  def test_to_json_works_when_as_json_returns_infinite_number
+    assert_equal '{"number":null}', InfiniteNumber.new.to_json
+  end
+
+  class NaNNumber
+    def as_json(options = nil)
+      { "number" => Float::NAN }
+    end
+  end
+
+  def test_to_json_works_when_as_json_returns_NaN_number
+    assert_equal '{"number":null}', NaNNumber.new.to_json
+  end
+
+  def test_to_json_works_on_io_objects
+    assert_equal STDOUT.to_s.to_json, STDOUT.to_json
+  end
+
+  private
+
+    def object_keys(json_object)
+      json_object[1..-2].scan(/([^{}:,\s]+):/).flatten.sort
+    end
+
+    def with_standard_json_time_format(boolean = true)
+      old, ActiveSupport.use_standard_json_time_format = ActiveSupport.use_standard_json_time_format, boolean
+      yield
+    ensure
+      ActiveSupport.use_standard_json_time_format = old
+    end
+
+    def with_time_precision(value)
+      old_value = ActiveSupport::JSON::Encoding.time_precision
+      ActiveSupport::JSON::Encoding.time_precision = value
+      yield
+    ensure
+      ActiveSupport::JSON::Encoding.time_precision = old_value
+    end
+end

data/test/encoding_test_cases.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+require "bigdecimal"
+require "date"
+require "time"
+require "pathname"
+require "uri"
+
+module JSONTest
+  class Foo
+    def initialize(a, b)
+      @a, @b = a, b
+    end
+  end
+
+  class Hashlike
+    def to_hash
+      { foo: "hello", bar: "world" }
+    end
+  end
+
+  class Custom
+    def initialize(serialized)
+      @serialized = serialized
+    end
+
+    def as_json(options = nil)
+      @serialized
+    end
+  end
+
+  MyStruct = Struct.new(:name, :value) do
+    def initialize(*)
+      @unused = "unused instance variable"
+      super
+    end
+  end
+
+  module EncodingTestCases
+    TrueTests     = [[ true,  %(true)  ]]
+    FalseTests    = [[ false, %(false) ]]
+    NilTests      = [[ nil,   %(null)  ]]
+    NumericTests  = [[ 1,     %(1)     ],
+                     [ 2.5,   %(2.5)   ],
+                     [ 0.0 / 0.0,   %(null) ],
+                     [ 1.0 / 0.0,   %(null) ],
+                     [ -1.0 / 0.0,  %(null) ],
+                     [ BigDecimal("0.0") / BigDecimal("0.0"),  %(null) ],
+                     [ BigDecimal("2.5"), %("#{BigDecimal('2.5')}") ]]
+
+    StringTests   = [[ "this is the <string>",     %("this is the \\u003cstring\\u003e")],
+                     [ 'a "string" with quotes & an ampersand', %("a \\"string\\" with quotes \\u0026 an ampersand") ],
+                     [ "http://test.host/posts/1", %("http://test.host/posts/1")],
+                     [ "Control characters: \x00\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1a\x1b\x1c\x1d\x1e\x1f\u2028\u2029",
+                       %("Control characters: \\u0000\\u0001\\u0002\\u0003\\u0004\\u0005\\u0006\\u0007\\b\\t\\n\\u000b\\f\\r\\u000e\\u000f\\u0010\\u0011\\u0012\\u0013\\u0014\\u0015\\u0016\\u0017\\u0018\\u0019\\u001a\\u001b\\u001c\\u001d\\u001e\\u001f\\u2028\\u2029") ]]
+
+    ArrayTests    = [[ ["a", "b", "c"],          %([\"a\",\"b\",\"c\"])        ],
+                     [ [1, "a", :b, nil, false], %([1,\"a\",\"b\",null,false]) ]]
+
+    HashTests     = [[ { foo: "bar" }, %({\"foo\":\"bar\"}) ],
+                     [ { 1 => 1, 2 => "a", 3 => :b, 4 => nil, 5 => false }, %({\"1\":1,\"2\":\"a\",\"3\":\"b\",\"4\":null,\"5\":false}) ]]
+
+    RangeTests    = [[ 1..2,     %("1..2")],
+                     [ 1...2,    %("1...2")],
+                     [ 1.5..2.5, %("1.5..2.5")]]
+
+    SymbolTests   = [[ :a,     %("a")    ],
+                     [ :this,  %("this") ],
+                     [ :"a b", %("a b")  ]]
+
+    ObjectTests   = [[ Foo.new(1, 2), %({\"a\":1,\"b\":2}) ]]
+    HashlikeTests = [[ Hashlike.new, %({\"bar\":\"world\",\"foo\":\"hello\"}) ]]
+    StructTests   = [[ MyStruct.new(:foo, "bar"), %({\"name\":\"foo\",\"value\":\"bar\"}) ],
+                     [ MyStruct.new(nil, nil), %({\"name\":null,\"value\":null}) ]]
+    CustomTests   = [[ Custom.new("custom"), '"custom"' ],
+                     [ Custom.new(nil), "null" ],
+                     [ Custom.new(:a), '"a"' ],
+                     [ Custom.new([ :foo, "bar" ]), '["foo","bar"]' ],
+                     [ Custom.new(foo: "hello", bar: "world"), '{"bar":"world","foo":"hello"}' ],
+                     [ Custom.new(Hashlike.new), '{"bar":"world","foo":"hello"}' ],
+                     [ Custom.new(Custom.new(Custom.new(:a))), '"a"' ]]
+
+    RegexpTests   = [[ /^a/, '"(?-mix:^a)"' ], [/^\w{1,2}[a-z]+/ix, '"(?ix-m:^\\\\w{1,2}[a-z]+)"']]
+
+    URITests      = [[ URI.parse("http://example.com"), %("http://example.com") ]]
+
+    PathnameTests = [[ Pathname.new("lib/index.rb"), %("lib/index.rb") ]]
+
+    DateTests     = [[ Date.new(2005, 2, 1), %("2005/02/01") ]]
+    TimeTests     = [[ Time.utc(2005, 2, 1, 15, 15, 10), %("2005/02/01 15:15:10 +0000") ]]
+    DateTimeTests = [[ DateTime.civil(2005, 2, 1, 15, 15, 10), %("2005/02/01 15:15:10 +0000") ]]
+
+    StandardDateTests     = [[ Date.new(2005, 2, 1), %("2005-02-01") ]]
+    StandardTimeTests     = [[ Time.utc(2005, 2, 1, 15, 15, 10), %("2005-02-01T15:15:10.000Z") ]]
+    StandardDateTimeTests = [[ DateTime.civil(2005, 2, 1, 15, 15, 10), %("2005-02-01T15:15:10.000+00:00") ]]
+    StandardStringTests   = [[ "this is the <string>", %("this is the <string>")]]
+  end
+end

data/test/time_zone_test_helpers.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module TimeZoneTestHelpers
+  def with_tz_default(tz = nil)
+    old_tz = Time.zone
+    Time.zone = tz
+    yield
+  ensure
+    Time.zone = old_tz
+  end
+
+  def with_env_tz(new_tz = "US/Eastern")
+    old_tz, ENV["TZ"] = ENV["TZ"], new_tz
+    yield
+  ensure
+    old_tz ? ENV["TZ"] = old_tz : ENV.delete("TZ")
+  end
+
+  def with_preserve_timezone(value)
+    old_preserve_tz = ActiveSupport.to_time_preserves_timezone
+    ActiveSupport.to_time_preserves_timezone = value
+    yield
+  ensure
+    ActiveSupport.to_time_preserves_timezone = old_preserve_tz
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-patch-json-encode
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - lulalala
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-22 00:00:00.000000000 Z
+date: 2018-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -17,16 +17,58 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.16.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.16.0
 - !ruby/object:Gem::Dependency
   name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 12.3.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 12.3.0
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 5.1.4
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 5.1.4
+- !ruby/object:Gem::Dependency
+  name: yajl-ruby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -71,9 +113,14 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- benchmark/base_classes.rb
 - lib/rails/patch/json/encode.rb
 - lib/rails/patch/json/encode/version.rb
 - rails-patch-json-encode.gemspec
+- test/abstract_unit.rb
+- test/encoding_test.rb
+- test/encoding_test_cases.rb
+- test/time_zone_test_helpers.rb
 homepage: https://github.com/GoodLife/rails-patch-json-encode
 licenses:
 - MIT
@@ -94,8 +141,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: A monkey patch to speed up Rails' JSON generation time.
-test_files: []
+test_files:
+- test/abstract_unit.rb
+- test/encoding_test.rb
+- test/encoding_test_cases.rb
+- test/time_zone_test_helpers.rb