rails-observers 0.1.2 → 0.1.4

data/test/observing_test.rb

@@ -1,183 +0,0 @@
-require 'minitest/autorun'
-require 'active_model'
-require 'rails/observers/active_model/active_model'
-
-class ObservedModel
-  include ActiveModel::Observing
-
-  class Observer
-  end
-end
-
-class FooObserver < ActiveModel::Observer
-  class << self
-    public :new
-  end
-
-  attr_accessor :stub
-
-  def on_spec(record, *args)
-    stub.event_with(record, *args) if stub
-  end
-
-  def around_save(record)
-    yield :in_around_save
-  end
-end
-
-class Foo
-  include ActiveModel::Observing
-end
-
-class ObservingTest < ActiveModel::TestCase
-  def setup
-    ObservedModel.observers.clear
-  end
-
-  test "initializes model with no cached observers" do
-    assert ObservedModel.observers.empty?, "Not empty: #{ObservedModel.observers.inspect}"
-  end
-
-  test "stores cached observers in an array" do
-    ObservedModel.observers << :foo
-    assert ObservedModel.observers.include?(:foo), ":foo not in #{ObservedModel.observers.inspect}"
-  end
-
-  test "flattens array of assigned cached observers" do
-    ObservedModel.observers = [[:foo], :bar]
-    assert ObservedModel.observers.include?(:foo), ":foo not in #{ObservedModel.observers.inspect}"
-    assert ObservedModel.observers.include?(:bar), ":bar not in #{ObservedModel.observers.inspect}"
-  end
-
-  test "uses an ObserverArray so observers can be disabled" do
-    ObservedModel.observers = [:foo, :bar]
-    assert ObservedModel.observers.is_a?(ActiveModel::ObserverArray)
-  end
-
-  test "instantiates observer names passed as strings" do
-    ObservedModel.observers << 'foo_observer'
-    FooObserver.expects(:instance)
-    ObservedModel.instantiate_observers
-  end
-
-  test "instantiates observer names passed as symbols" do
-    ObservedModel.observers << :foo_observer
-    FooObserver.expects(:instance)
-    ObservedModel.instantiate_observers
-  end
-
-  test "instantiates observer classes" do
-    ObservedModel.observers << ObservedModel::Observer
-    ObservedModel::Observer.expects(:instance)
-    ObservedModel.instantiate_observers
-  end
-
-  test "raises an appropriate error when a developer accidentally adds the wrong class (i.e. Widget instead of WidgetObserver)" do
-    assert_raise ArgumentError do
-      ObservedModel.observers = ['string']
-      ObservedModel.instantiate_observers
-    end
-    assert_raise ArgumentError do
-      ObservedModel.observers = [:string]
-      ObservedModel.instantiate_observers
-    end
-    assert_raise ArgumentError do
-      ObservedModel.observers = [String]
-      ObservedModel.instantiate_observers
-    end
-  end
-
-  test "passes observers to subclasses" do
-    FooObserver.instance
-    bar = Class.new(Foo)
-    assert_equal Foo.observers_count, bar.observers_count
-  end
-end
-
-class ObserverTest < ActiveModel::TestCase
-  def setup
-    ObservedModel.observers = :foo_observer
-    FooObserver.singleton_class.instance_eval do
-      alias_method :original_observed_classes, :observed_classes
-    end
-  end
-
-  def teardown
-    FooObserver.singleton_class.instance_eval do
-      undef_method :observed_classes
-      alias_method :observed_classes, :original_observed_classes
-    end
-  end
-
-  test "guesses implicit observable model name" do
-    assert_equal Foo, FooObserver.observed_class
-  end
-
-  test "tracks implicit observable models" do
-    instance = FooObserver.new
-    assert_equal [Foo], instance.observed_classes
-  end
-
-  test "tracks explicit observed model class" do
-    FooObserver.observe ObservedModel
-    instance = FooObserver.new
-    assert_equal [ObservedModel], instance.observed_classes
-  end
-
-  test "tracks explicit observed model as string" do
-    FooObserver.observe 'observed_model'
-    instance = FooObserver.new
-    assert_equal [ObservedModel], instance.observed_classes
-  end
-
-  test "tracks explicit observed model as symbol" do
-    FooObserver.observe :observed_model
-    instance = FooObserver.new
-    assert_equal [ObservedModel], instance.observed_classes
-  end
-
-  test "calls existing observer event" do
-    foo = Foo.new
-    FooObserver.instance.stub = stub
-    FooObserver.instance.stub.expects(:event_with).with(foo)
-    Foo.notify_observers(:on_spec, foo)
-  end
-
-  test "calls existing observer event from the instance" do
-    foo = Foo.new
-    FooObserver.instance.stub = stub
-    FooObserver.instance.stub.expects(:event_with).with(foo)
-    foo.notify_observers(:on_spec)
-  end
-
-  test "passes extra arguments" do
-    foo = Foo.new
-    FooObserver.instance.stub = stub
-    FooObserver.instance.stub.expects(:event_with).with(foo, :bar)
-    Foo.send(:notify_observers, :on_spec, foo, :bar)
-  end
-
-  test "skips nonexistent observer event" do
-    foo = Foo.new
-    Foo.notify_observers(:whatever, foo)
-  end
-
-  test "update passes a block on to the observer" do
-    yielded_value = nil
-    FooObserver.instance.update(:around_save, Foo.new) do |val|
-      yielded_value = val
-    end
-    assert_equal :in_around_save, yielded_value
-  end
-
-  test "observe redefines observed_classes class method" do
-    class BarObserver < ActiveModel::Observer
-      observe :foo
-    end
-
-    assert_equal [Foo], BarObserver.observed_classes
-
-    BarObserver.observe(ObservedModel)
-    assert_equal [ObservedModel], BarObserver.observed_classes
-  end
-end

data/test/rake_test.rb

@@ -1,40 +0,0 @@
-require 'isolation/abstract_unit'
-require 'rails-observers'
-
-module ApplicationTests
-  class RakeTest < ActiveSupport::TestCase
-    include ActiveSupport::Testing::Isolation
-
-    def setup
-      build_app
-      boot_rails
-      FileUtils.rm_rf("#{app_path}/config/environments")
-    end
-
-    def teardown
-      teardown_app
-    end
-
-    def test_load_activerecord_base_when_we_use_observers
-      Dir.chdir(app_path) do
-        `bundle exec rails g model user;
-         bundle exec rake db:migrate;
-         bundle exec rails g observer user;`
-
-        add_to_config "config.active_record.observers = :user_observer"
-
-        assert_equal "0", `bundle exec rails r "puts User.count"`.strip
-
-        app_file "lib/tasks/count_user.rake", <<-RUBY
-          namespace :user do
-            task :count => :environment do
-              puts User.count
-            end
-          end
-        RUBY
-
-        assert_equal "0", `bundle exec rake user:count`.strip
-      end
-    end
-  end
-end

data/test/sweeper_test.rb

@@ -1,83 +0,0 @@
-require 'minitest/autorun'
-require 'action_controller'
-require 'active_record'
-require 'rails/observers/activerecord/active_record'
-require 'rails/observers/action_controller/caching'
-
-SharedTestRoutes = ActionDispatch::Routing::RouteSet.new
-
-class AppSweeper < ActionController::Caching::Sweeper; end
-
-class SweeperTestController < ActionController::Base
-  include SharedTestRoutes.url_helpers
-
-  cache_sweeper :app_sweeper
-
-  def show
-    render text: 'hello world'
-  end
-
-  def error
-    raise StandardError.new
-  end
-end
-
-class SweeperTest < ActionController::TestCase
-  def setup
-    @routes = SharedTestRoutes
-
-    @routes.draw do
-      get ':controller(/:action)'
-    end
-
-    super
-  end
-
-  def test_sweeper_should_not_ignore_no_method_error
-    sweeper = ActionController::Caching::Sweeper.send(:new)
-    assert_raise NoMethodError do
-      sweeper.send_not_defined
-    end
-  end
-
-  def test_sweeper_should_not_block_rendering
-    response = test_process(SweeperTestController)
-    assert_equal 'hello world', response.body
-  end
-
-  def test_sweeper_should_clean_up_if_exception_is_raised
-    assert_raise StandardError do
-      test_process(SweeperTestController, 'error')
-    end
-    assert_nil AppSweeper.instance.controller
-  end
-
-  def test_before_method_of_sweeper_should_always_return_true
-    sweeper = ActionController::Caching::Sweeper.send(:new)
-    assert sweeper.before(SweeperTestController.new)
-  end
-
-  def test_after_method_of_sweeper_should_always_return_nil
-    sweeper = ActionController::Caching::Sweeper.send(:new)
-    assert_nil sweeper.after(SweeperTestController.new)
-  end
-
-  def test_sweeper_should_not_ignore_unknown_method_calls
-    sweeper = ActionController::Caching::Sweeper.send(:new)
-    assert_raise NameError do
-      sweeper.instance_eval do
-        some_method_that_doesnt_exist
-      end
-    end
-  end
-
-  private
-
-  def test_process(controller, action = "show")
-    @controller = controller.is_a?(Class) ? controller.new : controller
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
-
-    process(action)
-  end
-end

data/test/transaction_callbacks_test.rb

@@ -1,246 +0,0 @@
-require "helper"
-
-class TransactionCallbacksTest < ActiveRecord::TestCase
-  self.use_transactional_fixtures = false
-  fixtures :topics
-
-  class TopicWithCallbacks < ActiveRecord::Base
-    self.table_name = :topics
-
-    after_commit{|record| record.send(:do_after_commit, nil)}
-    after_commit(:on => :create){|record| record.send(:do_after_commit, :create)}
-    after_commit(:on => :update){|record| record.send(:do_after_commit, :update)}
-    after_commit(:on => :destroy){|record| record.send(:do_after_commit, :destroy)}
-    after_rollback{|record| record.send(:do_after_rollback, nil)}
-    after_rollback(:on => :create){|record| record.send(:do_after_rollback, :create)}
-    after_rollback(:on => :update){|record| record.send(:do_after_rollback, :update)}
-    after_rollback(:on => :destroy){|record| record.send(:do_after_rollback, :destroy)}
-
-    def history
-      @history ||= []
-    end
-
-    def after_commit_block(on = nil, &block)
-      @after_commit ||= {}
-      @after_commit[on] ||= []
-      @after_commit[on] << block
-    end
-
-    def after_rollback_block(on = nil, &block)
-      @after_rollback ||= {}
-      @after_rollback[on] ||= []
-      @after_rollback[on] << block
-    end
-
-    def do_after_commit(on)
-      blocks = @after_commit[on] if defined?(@after_commit)
-      blocks.each{|b| b.call(self)} if blocks
-    end
-
-    def do_after_rollback(on)
-      blocks = @after_rollback[on] if defined?(@after_rollback)
-      blocks.each{|b| b.call(self)} if blocks
-    end
-  end
-
-  def setup
-    @first, @second = TopicWithCallbacks.find(1, 3).sort_by { |t| t.id }
-  end
-
-  def test_call_after_commit_after_transaction_commits
-    @first.after_commit_block{|r| r.history << :after_commit}
-    @first.after_rollback_block{|r| r.history << :after_rollback}
-
-    @first.save!
-    assert_equal [:after_commit], @first.history
-  end
-
-  def test_only_call_after_commit_on_update_after_transaction_commits_for_existing_record
-    @first.after_commit_block(:create){|r| r.history << :commit_on_create}
-    @first.after_commit_block(:update){|r| r.history << :commit_on_update}
-    @first.after_commit_block(:destroy){|r| r.history << :commit_on_destroy}
-    @first.after_rollback_block(:create){|r| r.history << :rollback_on_create}
-    @first.after_rollback_block(:update){|r| r.history << :rollback_on_update}
-    @first.after_rollback_block(:destroy){|r| r.history << :rollback_on_destroy}
-
-    @first.save!
-    assert_equal [:commit_on_update], @first.history
-  end
-
-  def test_only_call_after_commit_on_destroy_after_transaction_commits_for_destroyed_record
-    @first.after_commit_block(:create){|r| r.history << :commit_on_create}
-    @first.after_commit_block(:update){|r| r.history << :commit_on_update}
-    @first.after_commit_block(:destroy){|r| r.history << :commit_on_destroy}
-    @first.after_rollback_block(:create){|r| r.history << :rollback_on_create}
-    @first.after_rollback_block(:update){|r| r.history << :rollback_on_update}
-    @first.after_rollback_block(:destroy){|r| r.history << :rollback_on_destroy}
-
-    @first.destroy
-    assert_equal [:commit_on_destroy], @first.history
-  end
-
-  def test_only_call_after_commit_on_create_after_transaction_commits_for_new_record
-    @new_record = TopicWithCallbacks.new(:title => "New topic", :written_on => Date.today)
-    @new_record.after_commit_block(:create){|r| r.history << :commit_on_create}
-    @new_record.after_commit_block(:update){|r| r.history << :commit_on_update}
-    @new_record.after_commit_block(:destroy){|r| r.history << :commit_on_destroy}
-    @new_record.after_rollback_block(:create){|r| r.history << :rollback_on_create}
-    @new_record.after_rollback_block(:update){|r| r.history << :rollback_on_update}
-    @new_record.after_rollback_block(:destroy){|r| r.history << :rollback_on_destroy}
-
-    @new_record.save!
-    assert_equal [:commit_on_create], @new_record.history
-  end
-
-  def test_call_after_rollback_after_transaction_rollsback
-    @first.after_commit_block{|r| r.history << :after_commit}
-    @first.after_rollback_block{|r| r.history << :after_rollback}
-
-    Topic.transaction do
-      @first.save!
-      raise ActiveRecord::Rollback
-    end
-
-    assert_equal [:after_rollback], @first.history
-  end
-
-  def test_only_call_after_rollback_on_update_after_transaction_rollsback_for_existing_record
-    @first.after_commit_block(:create){|r| r.history << :commit_on_create}
-    @first.after_commit_block(:update){|r| r.history << :commit_on_update}
-    @first.after_commit_block(:destroy){|r| r.history << :commit_on_destroy}
-    @first.after_rollback_block(:create){|r| r.history << :rollback_on_create}
-    @first.after_rollback_block(:update){|r| r.history << :rollback_on_update}
-    @first.after_rollback_block(:destroy){|r| r.history << :rollback_on_destroy}
-
-    Topic.transaction do
-      @first.save!
-      raise ActiveRecord::Rollback
-    end
-
-    assert_equal [:rollback_on_update], @first.history
-  end
-
-  def test_only_call_after_rollback_on_destroy_after_transaction_rollsback_for_destroyed_record
-    @first.after_commit_block(:create){|r| r.history << :commit_on_create}
-    @first.after_commit_block(:update){|r| r.history << :commit_on_update}
-    @first.after_commit_block(:destroy){|r| r.history << :commit_on_update}
-    @first.after_rollback_block(:create){|r| r.history << :rollback_on_create}
-    @first.after_rollback_block(:update){|r| r.history << :rollback_on_update}
-    @first.after_rollback_block(:destroy){|r| r.history << :rollback_on_destroy}
-
-    Topic.transaction do
-      @first.destroy
-      raise ActiveRecord::Rollback
-    end
-
-    assert_equal [:rollback_on_destroy], @first.history
-  end
-
-  def test_only_call_after_rollback_on_create_after_transaction_rollsback_for_new_record
-    @new_record = TopicWithCallbacks.new(:title => "New topic", :written_on => Date.today)
-    @new_record.after_commit_block(:create){|r| r.history << :commit_on_create}
-    @new_record.after_commit_block(:update){|r| r.history << :commit_on_update}
-    @new_record.after_commit_block(:destroy){|r| r.history << :commit_on_destroy}
-    @new_record.after_rollback_block(:create){|r| r.history << :rollback_on_create}
-    @new_record.after_rollback_block(:update){|r| r.history << :rollback_on_update}
-    @new_record.after_rollback_block(:destroy){|r| r.history << :rollback_on_destroy}
-
-    Topic.transaction do
-      @new_record.save!
-      raise ActiveRecord::Rollback
-    end
-
-    assert_equal [:rollback_on_create], @new_record.history
-  end
-
-  def test_call_after_rollback_when_commit_fails
-    TopicWithCallbacks.connection.class.send(:alias_method, :real_method_commit_db_transaction, :commit_db_transaction)
-    begin
-      TopicWithCallbacks.connection.class.class_eval do
-        def commit_db_transaction; raise "boom!"; end
-      end
-
-      @first.after_commit_block{|r| r.history << :after_commit}
-      @first.after_rollback_block{|r| r.history << :after_rollback}
-
-      assert !@first.save rescue nil
-      assert_equal [:after_rollback], @first.history
-    ensure
-      TopicWithCallbacks.connection.class.send(:remove_method, :commit_db_transaction)
-      TopicWithCallbacks.connection.class.send(:alias_method, :commit_db_transaction, :real_method_commit_db_transaction)
-    end
-  end
-
-  def test_only_call_after_rollback_on_records_rolled_back_to_a_savepoint
-    def @first.rollbacks(i=0); @rollbacks ||= 0; @rollbacks += i if i; end
-    def @first.commits(i=0); @commits ||= 0; @commits += i if i; end
-    @first.after_rollback_block{|r| r.rollbacks(1)}
-    @first.after_commit_block{|r| r.commits(1)}
-
-    def @second.rollbacks(i=0); @rollbacks ||= 0; @rollbacks += i if i; end
-    def @second.commits(i=0); @commits ||= 0; @commits += i if i; end
-    @second.after_rollback_block{|r| r.rollbacks(1)}
-    @second.after_commit_block{|r| r.commits(1)}
-
-    Topic.transaction do
-      @first.save!
-      Topic.transaction(:requires_new => true) do
-        @second.save!
-        raise ActiveRecord::Rollback
-      end
-    end
-
-    assert_equal 1, @first.commits
-    assert_equal 0, @first.rollbacks
-    assert_equal 0, @second.commits
-    assert_equal 1, @second.rollbacks
-  end
-
-  def test_only_call_after_rollback_on_records_rolled_back_to_a_savepoint_when_release_savepoint_fails
-    def @first.rollbacks(i=0); @rollbacks ||= 0; @rollbacks += i if i; end
-    def @first.commits(i=0); @commits ||= 0; @commits += i if i; end
-
-    @first.after_rollback_block{|r| r.rollbacks(1)}
-    @first.after_commit_block{|r| r.commits(1)}
-
-    Topic.transaction do
-      @first.save
-      Topic.transaction(:requires_new => true) do
-        @first.save!
-        raise ActiveRecord::Rollback
-      end
-      Topic.transaction(:requires_new => true) do
-        @first.save!
-        raise ActiveRecord::Rollback
-      end
-    end
-
-    assert_equal 1, @first.commits
-    assert_equal 2, @first.rollbacks
-  end
-
-  def test_after_transaction_callbacks_should_prevent_callbacks_from_being_called
-    def @first.last_after_transaction_error=(e); @last_transaction_error = e; end
-    def @first.last_after_transaction_error; @last_transaction_error; end
-    @first.after_commit_block{|r| r.last_after_transaction_error = :commit; raise "fail!";}
-    @first.after_rollback_block{|r| r.last_after_transaction_error = :rollback; raise "fail!";}
-    @second.after_commit_block{|r| r.history << :after_commit}
-    @second.after_rollback_block{|r| r.history << :after_rollback}
-
-    Topic.transaction do
-      @first.save!
-      @second.save!
-    end
-    assert_equal :commit, @first.last_after_transaction_error
-    assert_equal [:after_commit], @second.history
-
-    @second.history.clear
-    Topic.transaction do
-      @first.save!
-      @second.save!
-      raise ActiveRecord::Rollback
-    end
-    assert_equal :rollback, @first.last_after_transaction_error
-    assert_equal [:after_rollback], @second.history
-  end
-end